RE: [PATCH v7 4/4] cryptodev: remove rte marker fields

From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Tyler Retzlaff" <roretzla@linux.microsoft.com>, <dev@dpdk.org>
Cc: "Ajit Khaparde" <ajit.khaparde@broadcom.com>,
	"Andrew Boyer" <andrew.boyer@amd.com>,
	"Andrew Rybchenko" <andrew.rybchenko@oktetlabs.ru>,
	"Bruce Richardson" <bruce.richardson@intel.com>,
	"Chenbo Xia" <chenbox@nvidia.com>,
	"Chengwen Feng" <fengchengwen@huawei.com>,
	"Dariusz Sosnowski" <dsosnowski@nvidia.com>,
	"David Christensen" <drc@linux.vnet.ibm.com>,
	"Hyong Youb Kim" <hyonkim@cisco.com>,
	"Jerin Jacob" <jerinj@marvell.com>,
	"Jie Hai" <haijie1@huawei.com>,
	"Jingjing Wu" <jingjing.wu@intel.com>,
	"John Daley" <johndale@cisco.com>,
	"Kevin Laatz" <kevin.laatz@intel.com>,
	"Kiran Kumar K" <kirankumark@marvell.com>,
	"Konstantin Ananyev" <konstantin.v.ananyev@yandex.ru>,
	"Maciej Czekaj" <mczekaj@marvell.com>,
	"Matan Azrad" <matan@nvidia.com>,
	"Maxime Coquelin" <maxime.coquelin@redhat.com>,
	"Nithin Dabilpuram" <ndabilpuram@marvell.com>,
	"Ori Kam" <orika@nvidia.com>,
	"Ruifeng Wang" <ruifeng.wang@arm.com>,
	"Satha Rao" <skoteshwar@marvell.com>,
	"Somnath Kotur" <somnath.kotur@broadcom.com>,
	"Suanming Mou" <suanmingm@nvidia.com>,
	"Sunil Kumar Kori" <skori@marvell.com>,
	"Viacheslav Ovsiienko" <viacheslavo@nvidia.com>,
	"Yisen Zhuang" <yisen.zhuang@huawei.com>,
	"Yuying Zhang" <Yuying.Zhang@intel.com>
Subject: RE: [PATCH v7 4/4] cryptodev: remove rte marker fields
Date: Tue, 26 Mar 2024 11:31:40 +0100	[thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9F334@smartserver.smartshare.dk> (raw)
In-Reply-To: <1710972098-2209-5-git-send-email-roretzla@linux.microsoft.com>

> From: Tyler Retzlaff [mailto:roretzla@linux.microsoft.com]
> Sent: Wednesday, 20 March 2024 23.02
> 
> RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Remove
> RTE_MARKER fields from rte_mbuf struct.
> 
> Maintain alignment of fields after removed cacheline1 marker by placing
> C11 alignas(RTE_CACHE_LINE_MIN_SIZE).
> 
> Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> ---
>  doc/guides/rel_notes/release_24_03.rst | 3 +++
>  lib/cryptodev/cryptodev_pmd.h          | 5 +++--
>  2 files changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/doc/guides/rel_notes/release_24_03.rst
> b/doc/guides/rel_notes/release_24_03.rst
> index 75d40d4..d3e5abe 100644
> --- a/doc/guides/rel_notes/release_24_03.rst
> +++ b/doc/guides/rel_notes/release_24_03.rst
> @@ -222,6 +222,9 @@ Removed Items
>  * security: ``RTE_MARKER`` fields ``cacheline0`` and ``cacheline1``
>    have been removed from ``struct rte_security_session``.
> 
> +* cryptodev: ``RTE_MARKER`` fields ``cacheline0`` and ``cacheline1``
> +  have been removed from ``struct cryptodev_driver``.
> +
>  API Changes
>  -----------
> 
> diff --git a/lib/cryptodev/cryptodev_pmd.h
> b/lib/cryptodev/cryptodev_pmd.h
> index d195b81..9daf129 100644
> --- a/lib/cryptodev/cryptodev_pmd.h
> +++ b/lib/cryptodev/cryptodev_pmd.h
> @@ -5,6 +5,8 @@
>  #ifndef _CRYPTODEV_PMD_H_
>  #define _CRYPTODEV_PMD_H_
> 
> +#include <stdalign.h>
> +
>  #ifdef __cplusplus
>  extern "C" {
>  #endif
> @@ -139,7 +141,6 @@ struct cryptodev_driver {
>   * has a fixed algo, key, op-type, digest_len etc.
>   */
>  struct rte_cryptodev_sym_session {
> -	RTE_MARKER cacheline0;
>  	uint64_t opaque_data;
>  	/**< Can be used for external metadata */
>  	uint32_t sess_data_sz;
> @@ -151,7 +152,7 @@ struct rte_cryptodev_sym_session {
>  	rte_iova_t driver_priv_data_iova;
>  	/**< Session driver data IOVA address */
> 
> -	alignas(RTE_CACHE_LINE_MIN_SIZE) RTE_MARKER cacheline1;
> +	alignas(RTE_CACHE_LINE_MIN_SIZE)
>  	/**< Second cache line - start of the driver session data */
>  	uint8_t driver_priv_data[];
>  	/**< Driver specific session data, variable size */
> --
> 1.8.3.1

Reviewed-by: Morten Brørup <mb@smartsharesystems.com>