From: Chris Lew <clew@codeaurora.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>,
Andy Gross <andy.gross@linaro.org>,
Ohad Ben-Cohen <ohad@wizery.com>
Cc: Arun Kumar Neelakantam <aneela@codeaurora.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-soc@vger.kernel.org, linux-remoteproc@vger.kernel.org
Subject: Re: [PATCH v3 2/5] soc: qcom: Introduce QMI helpers
Date: Fri, 17 Nov 2017 18:11:03 -0800 [thread overview]
Message-ID: <98a56116-d6f8-9084-d49e-c7669ddaa945@codeaurora.org> (raw)
In-Reply-To: <20171115201012.25892-3-bjorn.andersson@linaro.org>
On 11/15/2017 12:10 PM, Bjorn Andersson wrote:
[..]> +static void qmi_handle_message(struct qmi_handle *qmi,
> + struct sockaddr_qrtr *sq,
> + const void *buf, size_t len)
> +{
> + const struct qmi_header *hdr;
> + struct qmi_txn tmp_txn;
> + struct qmi_txn *txn = NULL;
> + int ret;
> +
> + if (len < sizeof(*hdr)) {
> + pr_err("ignoring short QMI packet\n");
> + return;
> + }
> +
> + hdr = buf;
> +
> + /* If this is a response, find the matching transaction handle */
> + if (hdr->type == QMI_RESPONSE) {
> + mutex_lock(&qmi->txn_lock);
> + txn = idr_find(&qmi->txns, hdr->txn_id);
> + if (txn)
> + mutex_lock(&txn->lock);
> + mutex_unlock(&qmi->txn_lock);
> + }
> +
> + if (txn && txn->dest && txn->ei) {
> + ret = qmi_decode_message(buf, len, txn->ei, txn->dest);
> + if (ret < 0)
> + pr_err("failed to decode incoming message\n");
> +
> + txn->result = ret;
> + complete(&txn->completion);
> +
> + mutex_unlock(&txn->lock);
> + } else if (txn) {
> + qmi_invoke_handler(qmi, sq, txn, buf, len);
> +
> + mutex_unlock(&txn->lock);
> + } else {
> + /* Create a txn based on the txn_id of the incoming message */
> + memset(&tmp_txn, 0, sizeof(tmp_txn));
> + tmp_txn.id = hdr->txn_id;
> +
> + qmi_invoke_handler(qmi, sq, &tmp_txn, buf, len);
I'm seeing an opportunity for user error with timed out transactions. If
txn_wait gets timed out the txn is removed from the txns list. Later if
we get the response, it comes down to this else with the tmp_txn. Some
handlers may try to do a complete(&txn->completion) like the
qmi_sample_client ping_pong_cb. This leads to a null pointer dereference
since the temp txn was never initialized.
Should clients not call complete and we can call the complete in the
else if(txn) condition?
Thanks,
Chris
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-11-18 2:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-15 20:10 [PATCH v3 0/5] In-kernel QMI helpers and sysmon Bjorn Andersson
2017-11-15 20:10 ` [PATCH v3 1/5] soc: qcom: Introduce QMI encoder/decoder Bjorn Andersson
2017-11-16 5:42 ` Bjorn Andersson
2017-11-16 18:57 ` Chris Lew
2017-11-16 12:10 ` Srinivas Kandagatla
2017-11-17 6:10 ` Bjorn Andersson
2017-11-15 20:10 ` [PATCH v3 2/5] soc: qcom: Introduce QMI helpers Bjorn Andersson
2017-11-16 12:11 ` Srinivas Kandagatla
2017-11-17 6:30 ` Bjorn Andersson
2017-11-18 2:11 ` Chris Lew [this message]
2017-11-21 22:42 ` Bjorn Andersson
2017-11-15 20:10 ` [PATCH v3 3/5] remoteproc: Pass type of shutdown to subdev remove Bjorn Andersson
2017-11-15 20:10 ` [PATCH v3 4/5] remoteproc: qcom: Introduce sysmon Bjorn Andersson
2017-11-16 20:05 ` Chris Lew
2017-11-17 5:58 ` Bjorn Andersson
2017-11-18 1:27 ` Chris Lew
2017-11-15 20:10 ` [PATCH v3 5/5] samples: Introduce Qualcomm QMI sample client Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98a56116-d6f8-9084-d49e-c7669ddaa945@codeaurora.org \
--to=clew@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=aneela@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.