From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A946C32771 for ; Mon, 26 Sep 2022 08:47:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234499AbiIZIrQ (ORCPT ); Mon, 26 Sep 2022 04:47:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234404AbiIZIrO (ORCPT ); Mon, 26 Sep 2022 04:47:14 -0400 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8BF5B23BF4 for ; Mon, 26 Sep 2022 01:47:05 -0700 (PDT) Received: by mail-lj1-x22d.google.com with SMTP id j24so6613635lja.4 for ; Mon, 26 Sep 2022 01:47:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=vrv065D+ctkztUjNUa3Jmz1/DXnw7DhEXSuZPsqfZUM=; b=J071zhv/iyvxBhhD3psGEI6Cg1DZGDrWbj/a2rzs1PQrBZVi1x4YFbVXd+qF8v1zeM L5LcIQmhQXg+djyOPZlWWjEH+2xODIqEOphDzDqNuV+U/0uYUKhy09ZIsGrBweC6pKJa ucZJ5Rvx0mqq7jjlw4fcxWPltrTPib8k3vLvTPGV/DukWFB+dhhjprSk5yGd/ggRY6TA skkp+RGujF6/85kzXHXolxPh0l4y9aTeTn2KdGvufQoCQOyBXW0M+gIWNpUqERTg++UJ iwtcvRRvx+9130yMOkp9pG77Ghe9H2+TJ3G5r3QhBWKXwAQxVZefiQptIznsD90ckZT7 ppSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=vrv065D+ctkztUjNUa3Jmz1/DXnw7DhEXSuZPsqfZUM=; b=rEEa8eHyAA+pRtS+h4a9GKUr28C29SHoMOCHTGtz9Vkp3a5fsJWefWTpQk60TbRHsx uP279laWVfwMOvvbtp3rcOKUbpDo9L9IbvEnBiQ8Gr6r1ylXJ4/T9rZ9mPAbUAr8ciGg 2jHfthvueV1kv7WFOABz20EqjXXYVk66dBmZmNl5ygrOfM8K9oquKvQU/F3Uph6Eh3MX x6EvR0h1yrCKBl7aNAcva+W1VK5Ik52Ohkc10x/LuY4xCT38iNSE4xOGZjb5n1bi6QxE jjVZB+xFpAzT7YFS8jbBDbYXTBDNvbAhhyJQIKZ4J6LelDI1TPPQMsNfqLhVAV7L1rnp 94UQ== X-Gm-Message-State: ACrzQf1bRCNRJgZswia+Us7n6qTM3qxJUaIS3tYFC0j2w0nHAguN96J5 RH5G9y7SDr2H+t6YjlBDzmCJ2w== X-Google-Smtp-Source: AMsMyM6LLIPv9bce/eO6Q1DzKsESf0rQUW8AIaaA5vkZLY+uRsnwWBGJc9Ve5Sr0LN9Vt9PSnwuvlQ== X-Received: by 2002:a2e:b74b:0:b0:26c:5cf3:cc87 with SMTP id k11-20020a2eb74b000000b0026c5cf3cc87mr7568481ljo.75.1664182023890; Mon, 26 Sep 2022 01:47:03 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id z17-20020a05651c11d100b0026c1cbbf464sm2289057ljo.112.2022.09.26.01.47.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Sep 2022 01:47:03 -0700 (PDT) Message-ID: <98adff9a-e55c-1b3a-4951-e569ff25499f@linaro.org> Date: Mon, 26 Sep 2022 10:47:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH 12/15] dt-bindings: pinctrl: qcom,sm8250: fix matching pin config Content-Language: en-US To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220925110608.145728-1-krzysztof.kozlowski@linaro.org> <20220925110608.145728-13-krzysztof.kozlowski@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20220925110608.145728-13-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 25/09/2022 13:06, Krzysztof Kozlowski wrote: > The TLMM pin controller follows generic pin-controller bindings, so > should have subnodes with '-state' and '-pins'. Otherwise the subnodes > (level one and two) are not properly matched. This method also unifies > the bindings with other Qualcomm TLMM and LPASS pinctrl bindings. > > The change causes indentation decrement, so the diff-hunk looks big, but > there are no functional changes in the subnode "properties" section. > The only difference there is removal of blank lines between common GPIO > pinconf properties. > > Signed-off-by: Krzysztof Kozlowski > --- > .../bindings/pinctrl/qcom,sm8250-pinctrl.yaml | 145 +++++++++--------- > 1 file changed, 75 insertions(+), 70 deletions(-) > (...) > + > + required: > + - pins > + > + allOf: > + - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" > + - if: > + properties: > + pins: > + pattern: "^gpio([0-9]|[1-9][0-9]|1[0-7][0-9])$" > + then: > + required: > + - function In my other patchset, I moved this if:then: to common schema, therefore this patch will be later rebased. All other patches in the patchset are free to go, so far. Best regards, Krzysztof