Re: [PATCH v4 8/8] MIPS: Unselect ARCH_MIGHT_HAVE_PC_SERIO if MIPS_GENERIC

From: Florian Fainelli <f.fainelli@gmail.com>
To: Miodrag Dinic <Miodrag.Dinic@imgtec.com>,
	Ralf Baechle <ralf@linux-mips.org>,
	Aleksandar Markovic <aleksandar.markovic@rt-rk.com>
Cc: "linux-mips@linux-mips.org" <linux-mips@linux-mips.org>,
	Goran Ferenc <Goran.Ferenc@imgtec.com>,
	Aleksandar Markovic <Aleksandar.Markovic@imgtec.com>,
	Bo Hu <bohu@google.com>, Douglas Leung <Douglas.Leung@imgtec.com>,
	James Hogan <James.Hogan@imgtec.com>,
	Jin Qian <jinqian@google.com>,
	Paul Burton <Paul.Burton@imgtec.com>,
	Petar Jovanovic <Petar.Jovanovic@imgtec.com>,
	Raghu Gandham <Raghu.Gandham@imgtec.com>
Subject: Re: [PATCH v4 8/8] MIPS: Unselect ARCH_MIGHT_HAVE_PC_SERIO if MIPS_GENERIC
Date: Mon, 28 Aug 2017 21:55:29 -0700	[thread overview]
Message-ID: <98b6a367-657d-d6a6-b3c2-7fbebd9241f7@gmail.com> (raw)
In-Reply-To: <232DDC0A2B605E4F9E85F6904417885F015D956D48@BADAG02.ba.imgtec.org>

On 08/28/2017 02:33 AM, Miodrag Dinic wrote:
> Hi Ralf,
> 
> Even though I agree with your approach in handling this issue is more appropriate,
> but the reason we isolated this option just for MIPS_GENERIC was because we
> are not quite sure which MIPS platforms were using this option (and effectively i8042 driver), except for Malta.
> So, we decided to go with a safer solution and deselect it only for platforms which we are most sure aren't going to use it.
> 
> If you prefer to have this option sprinkled across platforms which are using it, please indicate which those are.

FWIW, I had started something similar, see comments from Maciej:

https://patchwork.linux-mips.org/patch/16226/

> 
> Kind regards,
> Miodrag
> 
> ________________________________________
> From: Ralf Baechle [ralf@linux-mips.org]
> Sent: Saturday, August 26, 2017 12:52 PM
> To: Aleksandar Markovic
> Cc: linux-mips@linux-mips.org; Miodrag Dinic; Goran Ferenc; Aleksandar Markovic; Bo Hu; Douglas Leung; James Hogan; Jin Qian; Paul Burton; Petar Jovanovic; Raghu Gandham
> Subject: Re: [PATCH v4 8/8] MIPS: Unselect ARCH_MIGHT_HAVE_PC_SERIO if MIPS_GENERIC
> 
> On Fri, Aug 18, 2017 at 03:09:00PM +0200, Aleksandar Markovic wrote:
> 
>> From: Miodrag Dinic <miodrag.dinic@imgtec.com>
>>
>> This effectively disables i8042 driver for MIPS_GENERIC kernel platform.
>> Currently, only sead-3, boston and ranchu boards are supported by the
>> MIPS generic kernel and none of them require this driver.
>> More specifically, kernel would crash if it gets enabled, because
>> i8042 driver would try to read from an non-existent IO register.
> 
> And many more platforms would beneftig from disabling this option because
> let's face it, the i8042's heydays are over.  So rather than spreading
> random depenencies on MIPS_GENERIC or other platforms through Kconfig
> please push the select of ARCH_MIGHT_HAVE_PC_SERIO to the platforms.
> 
>   Ralf
> 

-- 
Florian