From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5B35C4332E for ; Wed, 6 Jan 2021 00:59:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A8A1D22EBD for ; Wed, 6 Jan 2021 00:59:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726497AbhAFA6f (ORCPT ); Tue, 5 Jan 2021 19:58:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42686 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726096AbhAFA6e (ORCPT ); Tue, 5 Jan 2021 19:58:34 -0500 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60640C061793; Tue, 5 Jan 2021 16:57:54 -0800 (PST) Received: by mail-wm1-x329.google.com with SMTP id e25so1231099wme.0; Tue, 05 Jan 2021 16:57:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=KXYCn82HDF++SErLqK8nsHG9ESramoIEaNfyckxwBPI=; b=SW5O3QRjqle9V5TgLatZv6eQGXERxBJrGoLURd0zTSbfWDVB7rAhiqoBIMhNHCmTdb Qgh9CKpzehPTXoEvq4A5mn7egguzLVii0l5PGZ9NnneosWxLzx77DnzDSTdF0RItUcD4 1dsl3PHJPQW360UxkvDwQ/VUjTItqJC2yr8OvZWBMRFEsizEGMgTDWsUTOTLu0NJGe5e HVmoTwwhtKVm+Bxr4DKx6w3apnBn5X3hQXPNwP5ThIauCYsqgXV7uxupjZFnbEXkNhlv R2vCDaHxr4PMwkG+EuewZp/fnE2lCrNg7PZbhnjHRqPjFnUjss1S5IvLwGtglgHD8gtd oywQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=KXYCn82HDF++SErLqK8nsHG9ESramoIEaNfyckxwBPI=; b=LPguTtAva+fVzVkWlIbHpxpMs5AmKFb9clLRENCyVg2Yz5+irLtaath+F8kXY5Vrqf 83jFT6WaEweupVcENs01IZDNxdZ8X+IRxSnbEHen+8HHmBtN6O4XbFMTM6G1RXX5vFo1 2wCdcTVCmNl55M0OD9kpSdxBwQPJNvdNu8s5IPs2AXDVerL4FylQZL5QPs0leqLQEoz4 DQt8F6/1rMJiyp+8aWdPfXovNLUKNll1rj+yARwyyblOCAp/wrTCu75PMaWgbxNFSqfW 6KtBCodzLXKQlkxkUdLR/4ZmG5LxLwRBpHsY50YXz9Eym494CMK9bH6H9pYzqpwv6Pyy OZBQ== X-Gm-Message-State: AOAM532QaMNEmg2H3nfoh90hsL/2ZM/EtRYjnhps2Ixj6kaibLyTNGgz aBIWdw7TAQCyp3UauRLFzCufUykig2A= X-Google-Smtp-Source: ABdhPJzwo+LWEvo/adaKIVydcUGt2CQ1KNHP13ImnpMofj5R7uq/XsdAN/rBGeAnspxRg7PXXOP0rg== X-Received: by 2002:a1c:9684:: with SMTP id y126mr1455713wmd.2.1609894672880; Tue, 05 Jan 2021 16:57:52 -0800 (PST) Received: from ?IPv6:2003:ea:8f06:5500:303d:91bf:ac5c:51a1? (p200300ea8f065500303d91bfac5c51a1.dip0.t-ipconnect.de. [2003:ea:8f06:5500:303d:91bf:ac5c:51a1]) by smtp.googlemail.com with ESMTPSA id v4sm1036267wrw.42.2021.01.05.16.57.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Jan 2021 16:57:52 -0800 (PST) Subject: Re: [PATCH 2/3] ARM: iop32x: improve N2100 PCI broken parity quirk To: Russell King - ARM Linux admin Cc: Bjorn Helgaas , Bjorn Helgaas , Realtek linux nic maintainers , David Miller , Jakub Kicinski , "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "netdev@vger.kernel.org" References: <20210106002833.GA1286114@bjorn-Precision-5520> <9d2d3d61-8866-f7d3-09e9-a43b05128689@gmail.com> <20210106005257.GH1551@shell.armlinux.org.uk> From: Heiner Kallweit Message-ID: <98b79572-4445-3e4f-062a-590a874943e9@gmail.com> Date: Wed, 6 Jan 2021 01:57:47 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210106005257.GH1551@shell.armlinux.org.uk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 06.01.2021 01:52, Russell King - ARM Linux admin wrote: > On Wed, Jan 06, 2021 at 01:44:03AM +0100, Heiner Kallweit wrote: >> The machine type check is there to protect from (theoretical) cases >> where the n2100 code (incl. the RTL8169 quirk) may be compiled in, >> but the kernel is used on another machine. > > That is far from a theoretical case. The ARM port has always supported > multiple machines in a single kernel. They just had to be "compatible" > in other words, the same SoC. All the platforms supported by > arch/arm/mach-iop32x can be built as a single kernel image and run on > any of those platforms. > Good to know, then we indeed need the machine check. IOW, based on what you state we could even now have the following situation: N2100 support is compiled in, and the kernel is used on another machine that by chance also has Realtek RTL8169 in PCI slots 1 or 2. Then the PCI quirk would be applied, even though the machine doesn't have the parity issue. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 072B7C433E0 for ; Wed, 6 Jan 2021 00:59:53 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AD44722838 for ; Wed, 6 Jan 2021 00:59:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AD44722838 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=a9Y4j8INbUTO7BAGdNGXqC/KXuCYZwe9swaIoF1C2Ik=; b=G0atmEBPCckeir6NhoEqH7aki Hnw+I3du1RVYzH7at3HrzeN3s8jPSLDnAK04dVRyc1OmoqMV/0YB3G1RfLFWuimTRHeRquKBul3dJ h7Rx9ahFowqlmDHjnYZ43V8hshovWV0NZZ3YjRPZLXP4WHS7ILnjhSamMCCOSkDmlvQkaDCDpql/1 VEaUCy1MYgqC9NIx6+w1AonHP0rBXcN+t1ZLG/+E1PNzV7A9uAqfkoZPgRdZvctUrqnvsgop615kk y6NZKAR/4TIMfvBgzTVylufyL9Ovb19LKj50D2hzhluE91z2QK4BQiaFbDLKKObQPBezaElqDo2aS 0GN+sM9uA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kwx9A-0007te-Tr; Wed, 06 Jan 2021 00:57:56 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kwx98-0007sx-3d for linux-arm-kernel@lists.infradead.org; Wed, 06 Jan 2021 00:57:54 +0000 Received: by mail-wm1-x32e.google.com with SMTP id c133so1115170wme.4 for ; Tue, 05 Jan 2021 16:57:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=KXYCn82HDF++SErLqK8nsHG9ESramoIEaNfyckxwBPI=; b=SW5O3QRjqle9V5TgLatZv6eQGXERxBJrGoLURd0zTSbfWDVB7rAhiqoBIMhNHCmTdb Qgh9CKpzehPTXoEvq4A5mn7egguzLVii0l5PGZ9NnneosWxLzx77DnzDSTdF0RItUcD4 1dsl3PHJPQW360UxkvDwQ/VUjTItqJC2yr8OvZWBMRFEsizEGMgTDWsUTOTLu0NJGe5e HVmoTwwhtKVm+Bxr4DKx6w3apnBn5X3hQXPNwP5ThIauCYsqgXV7uxupjZFnbEXkNhlv R2vCDaHxr4PMwkG+EuewZp/fnE2lCrNg7PZbhnjHRqPjFnUjss1S5IvLwGtglgHD8gtd oywQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=KXYCn82HDF++SErLqK8nsHG9ESramoIEaNfyckxwBPI=; b=iZ5p9Yg4K7YxvTQrjmjHxk/6/MH/D2Fl5m4vKxz2Pf2szVnBURhtUJP/159niyIRQH 6geE3Niej2vnSV8NyrmxRl6PeyYCwgYk8lDyrwQxbPfqueVmxr0DLdp8cIJJLkjSzmk9 CPc44FaPndVTICJWcwgoQ6LYhZnF1snmwwQfcfPUAd8gn+fkDPt7xG6EeUByA0D8hByf OvBgiyL2vk8vYCoczheX2CzOAxudFnt2q4gF9iAaik6GHKmuLG7drdhFGDEgFXcfpVJT E2hS0w7mdytZ5KcPG2ianCPn6S47/+X4AUGuq8g7IovA1vbdtOTFIcma0+Gga96SkyYx 9udQ== X-Gm-Message-State: AOAM532cWNtdrIffpkjR4fpRtQGtVtfRNbOGE8O53WEGcX2+PGsryC9A nqsyzIYhw+7LPDudaVjc7p4= X-Google-Smtp-Source: ABdhPJzwo+LWEvo/adaKIVydcUGt2CQ1KNHP13ImnpMofj5R7uq/XsdAN/rBGeAnspxRg7PXXOP0rg== X-Received: by 2002:a1c:9684:: with SMTP id y126mr1455713wmd.2.1609894672880; Tue, 05 Jan 2021 16:57:52 -0800 (PST) Received: from ?IPv6:2003:ea:8f06:5500:303d:91bf:ac5c:51a1? (p200300ea8f065500303d91bfac5c51a1.dip0.t-ipconnect.de. [2003:ea:8f06:5500:303d:91bf:ac5c:51a1]) by smtp.googlemail.com with ESMTPSA id v4sm1036267wrw.42.2021.01.05.16.57.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Jan 2021 16:57:52 -0800 (PST) Subject: Re: [PATCH 2/3] ARM: iop32x: improve N2100 PCI broken parity quirk To: Russell King - ARM Linux admin References: <20210106002833.GA1286114@bjorn-Precision-5520> <9d2d3d61-8866-f7d3-09e9-a43b05128689@gmail.com> <20210106005257.GH1551@shell.armlinux.org.uk> From: Heiner Kallweit Message-ID: <98b79572-4445-3e4f-062a-590a874943e9@gmail.com> Date: Wed, 6 Jan 2021 01:57:47 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210106005257.GH1551@shell.armlinux.org.uk> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210105_195754_223561_DE783230 X-CRM114-Status: GOOD ( 19.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Realtek linux nic maintainers , "linux-pci@vger.kernel.org" , Bjorn Helgaas , "netdev@vger.kernel.org" , Bjorn Helgaas , Jakub Kicinski , David Miller , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 06.01.2021 01:52, Russell King - ARM Linux admin wrote: > On Wed, Jan 06, 2021 at 01:44:03AM +0100, Heiner Kallweit wrote: >> The machine type check is there to protect from (theoretical) cases >> where the n2100 code (incl. the RTL8169 quirk) may be compiled in, >> but the kernel is used on another machine. > > That is far from a theoretical case. The ARM port has always supported > multiple machines in a single kernel. They just had to be "compatible" > in other words, the same SoC. All the platforms supported by > arch/arm/mach-iop32x can be built as a single kernel image and run on > any of those platforms. > Good to know, then we indeed need the machine check. IOW, based on what you state we could even now have the following situation: N2100 support is compiled in, and the kernel is used on another machine that by chance also has Realtek RTL8169 in PCI slots 1 or 2. Then the PCI quirk would be applied, even though the machine doesn't have the parity issue. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel