All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ray Kinsella <mdr@ashroe.eu>
To: Ophir Munk <ophirmu@mellanox.com>,
	dev@dpdk.org, David Marchand <david.marchand@redhat.com>
Cc: Matan Azrad <matan@mellanox.com>,
	Raslan Darawsheh <rasland@mellanox.com>,
	Thomas Monjalon <homas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH v2 1/2] common/mlx5: add rte internal tag and avoid comparison
Date: Thu, 7 May 2020 08:56:26 +0100	[thread overview]
Message-ID: <98cae429-6c47-49a7-49a4-eb9f9742b74b@ashroe.eu> (raw)
In-Reply-To: <20200507073702.4047-2-ophirmu@mellanox.com>



On 07/05/2020 08:37, Ophir Munk wrote:
> Move mlx5 symbols in the map file to the INTERNAL section and add
> __internal tags to their definitions.
> Those symbols were exported in 20.02 and now (20.05) they are removed.
> Avoid ABI comparison issues between 20.05/20.08 and 20.02 by adding the
> suppress_file directive to libabigail.abignore file. This directive will
> prevent loading mlx5 common symbols and no comparison will be performed.
> 
> Signed-off-by: Ophir Munk <ophirmu@mellanox.com>
> ---
>  devtools/libabigail.abignore                    |  7 +++++++
>  drivers/common/mlx5/mlx5_common.h               |  3 +++
>  drivers/common/mlx5/mlx5_devx_cmds.h            | 23 +++++++++++++++++++++++
>  drivers/common/mlx5/mlx5_nl.h                   | 18 +++++++++++++++++-
>  drivers/common/mlx5/rte_common_mlx5_version.map |  6 +++---
>  5 files changed, 53 insertions(+), 4 deletions(-)

Can you add a Fixes: section.
Referencing the original git commit that added the symbols we are ignoring?

Ray K

  parent reply	other threads:[~2020-05-07  7:56 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-05 11:20 [dpdk-dev] [PATCH v1 1/3] devtools: create internal ignore file for libabigail Ophir Munk
2020-05-05 11:20 ` [dpdk-dev] [PATCH v1 2/3] common/mlx5: add rte internal tag Ophir Munk
2020-05-05 11:46   ` Matan Azrad
2020-05-05 11:20 ` [dpdk-dev] [PATCH v1 3/3] common/mlx5: remove devx dependency on ibv and DV Ophir Munk
2020-05-05 11:45 ` [dpdk-dev] [PATCH v1 1/3] devtools: create internal ignore file for libabigail Matan Azrad
2020-05-05 14:53 ` David Marchand
2020-05-05 15:02   ` Ray Kinsella
2020-05-06 12:27   ` Thomas Monjalon
2020-05-06 12:42     ` David Marchand
2020-05-06 12:52       ` Thomas Monjalon
2020-05-06 14:15         ` Ray Kinsella
2020-05-06 14:22           ` Thomas Monjalon
2020-05-07  7:48             ` Ophir Munk
2020-05-07  7:37 ` [dpdk-dev] [PATCH v2 0/2] add INTERNAL tags and avoid comparison Ophir Munk
2020-05-07  7:37   ` [dpdk-dev] [PATCH v2 1/2] common/mlx5: add rte internal tag " Ophir Munk
2020-05-07  7:44     ` Matan Azrad
2020-05-07  7:56     ` Ray Kinsella [this message]
2020-05-07  9:03       ` Ophir Munk
2020-05-07  8:56     ` [dpdk-dev] [PATCH v3 " Ophir Munk
2020-05-07  8:56       ` [dpdk-dev] [PATCH v3 2/2] common/mlx5: remove devx dependency on ibv and DV Ophir Munk
2020-05-07 10:23       ` [dpdk-dev] [PATCH v3 1/2] common/mlx5: add rte internal tag and avoid comparison Thomas Monjalon
2020-05-07 11:41         ` Ophir Munk
2020-05-07 20:08           ` Thomas Monjalon
2020-05-10  8:14             ` Ophir Munk
2020-05-07 11:31       ` [dpdk-dev] [PATCH v4 " Ophir Munk
2020-05-07 11:31         ` [dpdk-dev] [PATCH v4 2/2] common/mlx5: remove devx dependency on ibv and DV Ophir Munk
2020-05-12 10:52         ` [dpdk-dev] [PATCH v4 1/2] common/mlx5: add rte internal tag and avoid comparison Raslan Darawsheh
2020-05-19  9:08         ` Thomas Monjalon
2020-05-07  7:37   ` [dpdk-dev] [PATCH v2 2/2] common/mlx5: remove devx dependency on ibv and DV Ophir Munk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=98cae429-6c47-49a7-49a4-eb9f9742b74b@ashroe.eu \
    --to=mdr@ashroe.eu \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=homas@monjalon.net \
    --cc=matan@mellanox.com \
    --cc=ophirmu@mellanox.com \
    --cc=rasland@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.