From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D126C7EE24 for ; Fri, 2 Jun 2023 09:22:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235156AbjFBJW5 (ORCPT ); Fri, 2 Jun 2023 05:22:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235120AbjFBJWX (ORCPT ); Fri, 2 Jun 2023 05:22:23 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D43E1E5C for ; Fri, 2 Jun 2023 02:20:35 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-4f50a8f6dd7so2431660e87.2 for ; Fri, 02 Jun 2023 02:20:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685697634; x=1688289634; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2iuUYh+jyUdoFLB4/Ohue7ftzcpCt5z7J6+fSnc6VTU=; b=TwjUwJM7U3biEp+bDOt6mi5g6rveW6zHrV3eIZABlm3sA0UeQXBiaeLEqXHVVlRS6V obf570bH69wo+oseHVf5WpQJfsMBi3yR16R5DU+qagUzj9NCOF+tjMVXMNjTjXO7yKwO IToW9xljrNJ/u73LaYYABCb74GkcJ4qV5SIrppNRoQhv7j5VmwBaYbAqOedwLHklXQoq odCMhRWiPZ5oFjyQmM7uNfMRTk/VS8QkN39m/vkaCtJYDZc12FUiiVjnbtdyeDKUvMRy rJiO8I0vWlyikMNhN9/sPXV1AolnW4arJUrOo9ulYJSmm4k5Y0q9RY6nzu0dc/YfF6vj M7gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685697634; x=1688289634; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2iuUYh+jyUdoFLB4/Ohue7ftzcpCt5z7J6+fSnc6VTU=; b=JnX+ULyVvWbZW6Hn31GaPEUByH9svgmlIkJpZSdWKwn//go4VGcdfeHl50HyXwZfcp cEtpkhcTN4qMEhDRkY6UB9GBFwKfL0/VrtnQaOpR8EIWeGnHdpMvnX+7U6vElDSHZYVw isOIk828hiQi3ErTqqMLXboXGrvlJtKKxFwGWrFQWJn5hR8srd7jF/ktYzMvWuaRsPHt FCPexyAnC9M6WBGzV1lOtStpvPBwUxL50IeIWu+NL/txhOG+sHxGj7U/Bja+BZrD16mU 6hreNbXO9Y0Ux/mjymxEncLMrgYPL2GTX44GZsRssyqs0AF8BX/3hMg+ZXA14KF4tlM7 PHgw== X-Gm-Message-State: AC+VfDzyCHGSfS1m/74loCOcNs+vtUr8CA/7DplF/+oaO+3SdznUGuVT E1IsTxdLKl5ecF9+GhhAYfq8mA== X-Google-Smtp-Source: ACHHUZ6LZI2uzZ/sScSiU09CzMvNNponFaH11Qgkqs/Cq4ZbxOfKxcSgHesxQk7yIvIgA2K8U6lj2A== X-Received: by 2002:ac2:5d28:0:b0:4f3:c7f8:d40c with SMTP id i8-20020ac25d28000000b004f3c7f8d40cmr1384339lfb.29.1685697634079; Fri, 02 Jun 2023 02:20:34 -0700 (PDT) Received: from [192.168.1.101] (abyj77.neoplus.adsl.tpnet.pl. [83.9.29.77]) by smtp.gmail.com with ESMTPSA id q27-20020ac2511b000000b004f387d97dafsm99110lfb.147.2023.06.02.02.20.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Jun 2023 02:20:33 -0700 (PDT) Message-ID: <98f092a2-56aa-fb27-d35b-0fae781ca846@linaro.org> Date: Fri, 2 Jun 2023 11:20:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH v2 3/6] arm64: dts: qcom: sm8250: Use 2 interconnect cells Content-Language: en-US To: Abel Vesa , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Linux Kernel Mailing List References: <20230602062016.1883171-1-abel.vesa@linaro.org> <20230602062016.1883171-3-abel.vesa@linaro.org> From: Konrad Dybcio In-Reply-To: <20230602062016.1883171-3-abel.vesa@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 2.06.2023 08:20, Abel Vesa wrote: > Use two interconnect cells in order to optionally support a path tag. > > Signed-off-by: Abel Vesa > --- Reviewed-by: Konrad Dybcio Konrad > > Changes since v1: > * This patch was not part of v1 > > arch/arm64/boot/dts/qcom/sm8250.dtsi | 72 ++++++++++++++-------------- > 1 file changed, 36 insertions(+), 36 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi > index e5c60a6e4074..c5787489b05c 100644 > --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi > @@ -106,8 +106,8 @@ CPU0: cpu@0 { > power-domain-names = "psci"; > qcom,freq-domain = <&cpufreq_hw 0>; > operating-points-v2 = <&cpu0_opp_table>; > - interconnects = <&gem_noc MASTER_AMPSS_M0 &mc_virt SLAVE_EBI_CH0>, > - <&epss_l3 MASTER_OSM_L3_APPS &epss_l3 SLAVE_OSM_L3>; > + interconnects = <&gem_noc MASTER_AMPSS_M0 0 &mc_virt SLAVE_EBI_CH0 0>, > + <&epss_l3 MASTER_OSM_L3_APPS 0 &epss_l3 SLAVE_OSM_L3 0>; > #cooling-cells = <2>; > L2_0: l2-cache { > compatible = "cache"; > @@ -137,8 +137,8 @@ CPU1: cpu@100 { > power-domain-names = "psci"; > qcom,freq-domain = <&cpufreq_hw 0>; > operating-points-v2 = <&cpu0_opp_table>; > - interconnects = <&gem_noc MASTER_AMPSS_M0 &mc_virt SLAVE_EBI_CH0>, > - <&epss_l3 MASTER_OSM_L3_APPS &epss_l3 SLAVE_OSM_L3>; > + interconnects = <&gem_noc MASTER_AMPSS_M0 0 &mc_virt SLAVE_EBI_CH0 0>, > + <&epss_l3 MASTER_OSM_L3_APPS 0 &epss_l3 SLAVE_OSM_L3 0>; > #cooling-cells = <2>; > L2_100: l2-cache { > compatible = "cache"; > @@ -162,8 +162,8 @@ CPU2: cpu@200 { > power-domain-names = "psci"; > qcom,freq-domain = <&cpufreq_hw 0>; > operating-points-v2 = <&cpu0_opp_table>; > - interconnects = <&gem_noc MASTER_AMPSS_M0 &mc_virt SLAVE_EBI_CH0>, > - <&epss_l3 MASTER_OSM_L3_APPS &epss_l3 SLAVE_OSM_L3>; > + interconnects = <&gem_noc MASTER_AMPSS_M0 0 &mc_virt SLAVE_EBI_CH0 0>, > + <&epss_l3 MASTER_OSM_L3_APPS 0 &epss_l3 SLAVE_OSM_L3 0>; > #cooling-cells = <2>; > L2_200: l2-cache { > compatible = "cache"; > @@ -187,8 +187,8 @@ CPU3: cpu@300 { > power-domain-names = "psci"; > qcom,freq-domain = <&cpufreq_hw 0>; > operating-points-v2 = <&cpu0_opp_table>; > - interconnects = <&gem_noc MASTER_AMPSS_M0 &mc_virt SLAVE_EBI_CH0>, > - <&epss_l3 MASTER_OSM_L3_APPS &epss_l3 SLAVE_OSM_L3>; > + interconnects = <&gem_noc MASTER_AMPSS_M0 0 &mc_virt SLAVE_EBI_CH0 0>, > + <&epss_l3 MASTER_OSM_L3_APPS 0 &epss_l3 SLAVE_OSM_L3 0>; > #cooling-cells = <2>; > L2_300: l2-cache { > compatible = "cache"; > @@ -212,8 +212,8 @@ CPU4: cpu@400 { > power-domain-names = "psci"; > qcom,freq-domain = <&cpufreq_hw 1>; > operating-points-v2 = <&cpu4_opp_table>; > - interconnects = <&gem_noc MASTER_AMPSS_M0 &mc_virt SLAVE_EBI_CH0>, > - <&epss_l3 MASTER_OSM_L3_APPS &epss_l3 SLAVE_OSM_L3>; > + interconnects = <&gem_noc MASTER_AMPSS_M0 0 &mc_virt SLAVE_EBI_CH0 0>, > + <&epss_l3 MASTER_OSM_L3_APPS 0 &epss_l3 SLAVE_OSM_L3 0>; > #cooling-cells = <2>; > L2_400: l2-cache { > compatible = "cache"; > @@ -237,8 +237,8 @@ CPU5: cpu@500 { > power-domain-names = "psci"; > qcom,freq-domain = <&cpufreq_hw 1>; > operating-points-v2 = <&cpu4_opp_table>; > - interconnects = <&gem_noc MASTER_AMPSS_M0 &mc_virt SLAVE_EBI_CH0>, > - <&epss_l3 MASTER_OSM_L3_APPS &epss_l3 SLAVE_OSM_L3>; > + interconnects = <&gem_noc MASTER_AMPSS_M0 0 &mc_virt SLAVE_EBI_CH0 0>, > + <&epss_l3 MASTER_OSM_L3_APPS 0 &epss_l3 SLAVE_OSM_L3 0>; > #cooling-cells = <2>; > L2_500: l2-cache { > compatible = "cache"; > @@ -262,8 +262,8 @@ CPU6: cpu@600 { > power-domain-names = "psci"; > qcom,freq-domain = <&cpufreq_hw 1>; > operating-points-v2 = <&cpu4_opp_table>; > - interconnects = <&gem_noc MASTER_AMPSS_M0 &mc_virt SLAVE_EBI_CH0>, > - <&epss_l3 MASTER_OSM_L3_APPS &epss_l3 SLAVE_OSM_L3>; > + interconnects = <&gem_noc MASTER_AMPSS_M0 0 &mc_virt SLAVE_EBI_CH0 0>, > + <&epss_l3 MASTER_OSM_L3_APPS 0 &epss_l3 SLAVE_OSM_L3 0>; > #cooling-cells = <2>; > L2_600: l2-cache { > compatible = "cache"; > @@ -287,8 +287,8 @@ CPU7: cpu@700 { > power-domain-names = "psci"; > qcom,freq-domain = <&cpufreq_hw 2>; > operating-points-v2 = <&cpu7_opp_table>; > - interconnects = <&gem_noc MASTER_AMPSS_M0 &mc_virt SLAVE_EBI_CH0>, > - <&epss_l3 MASTER_OSM_L3_APPS &epss_l3 SLAVE_OSM_L3>; > + interconnects = <&gem_noc MASTER_AMPSS_M0 0 &mc_virt SLAVE_EBI_CH0 0>, > + <&epss_l3 MASTER_OSM_L3_APPS 0 &epss_l3 SLAVE_OSM_L3 0>; > #cooling-cells = <2>; > L2_700: l2-cache { > compatible = "cache"; > @@ -1789,49 +1789,49 @@ spi13: spi@a94000 { > config_noc: interconnect@1500000 { > compatible = "qcom,sm8250-config-noc"; > reg = <0 0x01500000 0 0xa580>; > - #interconnect-cells = <1>; > + #interconnect-cells = <2>; > qcom,bcm-voters = <&apps_bcm_voter>; > }; > > system_noc: interconnect@1620000 { > compatible = "qcom,sm8250-system-noc"; > reg = <0 0x01620000 0 0x1c200>; > - #interconnect-cells = <1>; > + #interconnect-cells = <2>; > qcom,bcm-voters = <&apps_bcm_voter>; > }; > > mc_virt: interconnect@163d000 { > compatible = "qcom,sm8250-mc-virt"; > reg = <0 0x0163d000 0 0x1000>; > - #interconnect-cells = <1>; > + #interconnect-cells = <2>; > qcom,bcm-voters = <&apps_bcm_voter>; > }; > > aggre1_noc: interconnect@16e0000 { > compatible = "qcom,sm8250-aggre1-noc"; > reg = <0 0x016e0000 0 0x1f180>; > - #interconnect-cells = <1>; > + #interconnect-cells = <2>; > qcom,bcm-voters = <&apps_bcm_voter>; > }; > > aggre2_noc: interconnect@1700000 { > compatible = "qcom,sm8250-aggre2-noc"; > reg = <0 0x01700000 0 0x33000>; > - #interconnect-cells = <1>; > + #interconnect-cells = <2>; > qcom,bcm-voters = <&apps_bcm_voter>; > }; > > compute_noc: interconnect@1733000 { > compatible = "qcom,sm8250-compute-noc"; > reg = <0 0x01733000 0 0xa180>; > - #interconnect-cells = <1>; > + #interconnect-cells = <2>; > qcom,bcm-voters = <&apps_bcm_voter>; > }; > > mmss_noc: interconnect@1740000 { > compatible = "qcom,sm8250-mmss-noc"; > reg = <0 0x01740000 0 0x1f080>; > - #interconnect-cells = <1>; > + #interconnect-cells = <2>; > qcom,bcm-voters = <&apps_bcm_voter>; > }; > > @@ -2260,7 +2260,7 @@ crypto: crypto@1dfa000 { > <&apps_smmu 0x59f 0x0000>, > <&apps_smmu 0x586 0x0011>, > <&apps_smmu 0x596 0x0011>; > - interconnects = <&aggre2_noc MASTER_CRYPTO_CORE_0 &mc_virt SLAVE_EBI_CH0>; > + interconnects = <&aggre2_noc MASTER_CRYPTO_CORE_0 0 &mc_virt SLAVE_EBI_CH0 0>; > interconnect-names = "memory"; > }; > > @@ -3693,21 +3693,21 @@ opp-202000000 { > dc_noc: interconnect@90c0000 { > compatible = "qcom,sm8250-dc-noc"; > reg = <0 0x090c0000 0 0x4200>; > - #interconnect-cells = <1>; > + #interconnect-cells = <2>; > qcom,bcm-voters = <&apps_bcm_voter>; > }; > > gem_noc: interconnect@9100000 { > compatible = "qcom,sm8250-gem-noc"; > reg = <0 0x09100000 0 0xb4000>; > - #interconnect-cells = <1>; > + #interconnect-cells = <2>; > qcom,bcm-voters = <&apps_bcm_voter>; > }; > > npu_noc: interconnect@9990000 { > compatible = "qcom,sm8250-npu-noc"; > reg = <0 0x09990000 0 0x1600>; > - #interconnect-cells = <1>; > + #interconnect-cells = <2>; > qcom,bcm-voters = <&apps_bcm_voter>; > }; > > @@ -3837,8 +3837,8 @@ venus: video-codec@aa00000 { > <&videocc VIDEO_CC_MVS0_CLK>; > clock-names = "iface", "core", "vcodec0_core"; > > - interconnects = <&gem_noc MASTER_AMPSS_M0 &config_noc SLAVE_VENUS_CFG>, > - <&mmss_noc MASTER_VIDEO_P0 &mc_virt SLAVE_EBI_CH0>; > + interconnects = <&gem_noc MASTER_AMPSS_M0 0 &config_noc SLAVE_VENUS_CFG 0>, > + <&mmss_noc MASTER_VIDEO_P0 0 &mc_virt SLAVE_EBI_CH0 0>; > interconnect-names = "cpu-cfg", "video-mem"; > > iommus = <&apps_smmu 0x2100 0x0400>; > @@ -4122,10 +4122,10 @@ camss: camss@ac6a000 { > <&apps_smmu 0xc40 0x400>, > <&apps_smmu 0xc41 0x400>; > > - interconnects = <&gem_noc MASTER_AMPSS_M0 &config_noc SLAVE_CAMERA_CFG>, > - <&mmss_noc MASTER_CAMNOC_HF &mc_virt SLAVE_EBI_CH0>, > - <&mmss_noc MASTER_CAMNOC_SF &mc_virt SLAVE_EBI_CH0>, > - <&mmss_noc MASTER_CAMNOC_ICP &mc_virt SLAVE_EBI_CH0>; > + interconnects = <&gem_noc MASTER_AMPSS_M0 0 &config_noc SLAVE_CAMERA_CFG 0>, > + <&mmss_noc MASTER_CAMNOC_HF 0 &mc_virt SLAVE_EBI_CH0 0>, > + <&mmss_noc MASTER_CAMNOC_SF 0 &mc_virt SLAVE_EBI_CH0 0>, > + <&mmss_noc MASTER_CAMNOC_ICP 0 &mc_virt SLAVE_EBI_CH0 0>; > interconnect-names = "cam_ahb", > "cam_hf_0_mnoc", > "cam_sf_0_mnoc", > @@ -4182,8 +4182,8 @@ mdss: display-subsystem@ae00000 { > reg = <0 0x0ae00000 0 0x1000>; > reg-names = "mdss"; > > - interconnects = <&mmss_noc MASTER_MDP_PORT0 &mc_virt SLAVE_EBI_CH0>, > - <&mmss_noc MASTER_MDP_PORT1 &mc_virt SLAVE_EBI_CH0>; > + interconnects = <&mmss_noc MASTER_MDP_PORT0 0 &mc_virt SLAVE_EBI_CH0 0>, > + <&mmss_noc MASTER_MDP_PORT1 0 &mc_virt SLAVE_EBI_CH0 0>; > interconnect-names = "mdp0-mem", "mdp1-mem"; > > power-domains = <&dispcc MDSS_GDSC>; > @@ -5671,7 +5671,7 @@ epss_l3: interconnect@18590000 { > clocks = <&rpmhcc RPMH_CXO_CLK>, <&gcc GPLL0>; > clock-names = "xo", "alternate"; > > - #interconnect-cells = <1>; > + #interconnect-cells = <2>; > }; > > cpufreq_hw: cpufreq@18591000 {