From: Jonas Bonn <jonas@norrbonn.se>
To: Pravin Shelar <pravin.ovn@gmail.com>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
Pablo Neira Ayuso <pablo@netfilter.org>,
laforge@gnumonks.org
Subject: Re: [PATCH net-next v2 07/12] gtp: use ephemeral source port
Date: Sat, 12 Dec 2020 08:49:41 +0100 [thread overview]
Message-ID: <98f0ddde-e98f-67d5-7506-e197f69b281f@norrbonn.se> (raw)
In-Reply-To: <CAOrHB_CzXgf9mOr+LhSOKcJ1uzTQBqMmWiDCMkutCF7VRJ9Djg@mail.gmail.com>
On 12/12/2020 06:35, Pravin Shelar wrote:
> On Fri, Dec 11, 2020 at 4:29 AM Jonas Bonn <jonas@norrbonn.se> wrote:
>> /* Read the IP destination address and resolve the PDP context.
>> @@ -527,6 +527,10 @@ static int gtp_xmit_ip4(struct sk_buff *skb, struct net_device *dev)
>> return -EMSGSIZE;
>> }
>>
>> + sport = udp_flow_src_port(sock_net(pctx->sk), skb,
>> + 0, USHRT_MAX,
>> + true);
>> +
> why use_eth is true for this is L3 GTP devices, Am missing something?
No, you are right. Will fix.
/Jonas
next prev parent reply other threads:[~2020-12-12 10:12 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 12:26 [PATCH net-next v2 00/12] gtp: IPv6 support Jonas Bonn
2020-12-11 12:26 ` [PATCH net-next v2 01/12] gtp: set initial MTU Jonas Bonn
2020-12-12 9:38 ` Harald Welte
2020-12-11 12:26 ` [PATCH net-next v2 02/12] gtp: include role in link info Jonas Bonn
2020-12-12 9:40 ` Harald Welte
2020-12-11 12:26 ` [PATCH net-next v2 03/12] gtp: really check namespaces before xmit Jonas Bonn
2020-12-12 9:41 ` Harald Welte
2020-12-11 12:26 ` [PATCH net-next v2 04/12] gtp: drop unnecessary call to skb_dst_drop Jonas Bonn
2020-12-12 9:50 ` Harald Welte
2020-12-12 11:38 ` Jonas Bonn
2020-12-11 12:26 ` [PATCH net-next v2 05/12] gtp: set device type Jonas Bonn
2020-12-12 9:51 ` Harald Welte
2020-12-11 12:26 ` [PATCH net-next v2 06/12] gtp: rework IPv4 functionality Jonas Bonn
2020-12-11 12:26 ` [PATCH net-next v2 07/12] gtp: use ephemeral source port Jonas Bonn
2020-12-12 5:35 ` Pravin Shelar
2020-12-12 7:49 ` Jonas Bonn [this message]
2020-12-12 10:07 ` Harald Welte
2020-12-12 13:40 ` Jonas Bonn
2020-12-11 12:26 ` [PATCH net-next v2 08/12] gtp: set dev features to enable GSO Jonas Bonn
2020-12-12 5:31 ` Pravin Shelar
2020-12-12 7:50 ` Jonas Bonn
2020-12-13 18:25 ` Pravin Shelar
2020-12-11 12:26 ` [PATCH net-next v2 09/12] gtp: support GRO Jonas Bonn
2020-12-11 15:43 ` kernel test robot
2020-12-11 15:43 ` kernel test robot
2020-12-11 12:26 ` [PATCH net-next v2 10/12] gtp: add IPv6 support Jonas Bonn
2020-12-12 5:51 ` Pravin Shelar
2020-12-12 7:05 ` Jonas Bonn
2020-12-12 11:05 ` Harald Welte
2020-12-12 11:22 ` Harald Welte
2020-12-12 13:59 ` Jonas Bonn
2020-12-11 12:26 ` [PATCH net-next v2 11/12] gtp: netlink update for ipv6 Jonas Bonn
2020-12-12 11:25 ` Harald Welte
2020-12-11 12:26 ` [PATCH net-next v2 12/12] gtp: add dst_cache to tunnels Jonas Bonn
2020-12-11 17:25 ` kernel test robot
2020-12-11 17:25 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98f0ddde-e98f-67d5-7506-e197f69b281f@norrbonn.se \
--to=jonas@norrbonn.se \
--cc=laforge@gnumonks.org \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=pravin.ovn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.