From: Paolo Abeni <pabeni@redhat.com>
To: netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Alexander Lobakin <alexandr.lobakin@intel.com>,
Eric Dumazet <edumazet@google.com>,
Alexander H Duyck <alexander.duyck@gmail.com>
Subject: [PATCH net-next 1/2] net: gro: avoid re-computing truesize twice on recycle
Date: Fri, 4 Feb 2022 12:28:36 +0100 [thread overview]
Message-ID: <9903ebc67ba39368d7a1e93681c65305d868232c.1643972527.git.pabeni@redhat.com> (raw)
In-Reply-To: <cover.1643972527.git.pabeni@redhat.com>
After commit 5e10da5385d2 ("skbuff: allow 'slow_gro' for skb
carring sock reference") and commit af352460b465 ("net: fix GRO
skb truesize update") the truesize of the skb with stolen head is
properly updated by the GRO engine, we don't need anymore resetting
it at recycle time.
v1 -> v2:
- clarify the commit message (Alexander)
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
---
net/core/gro.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/core/gro.c b/net/core/gro.c
index a11b286d1495..d43d42215bdb 100644
--- a/net/core/gro.c
+++ b/net/core/gro.c
@@ -634,7 +634,6 @@ static void napi_reuse_skb(struct napi_struct *napi, struct sk_buff *skb)
skb->encapsulation = 0;
skb_shinfo(skb)->gso_type = 0;
- skb->truesize = SKB_TRUESIZE(skb_end_offset(skb));
if (unlikely(skb->slow_gro)) {
skb_orphan(skb);
skb_ext_reset(skb);
--
2.34.1
next prev parent reply other threads:[~2022-02-04 11:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-04 11:28 [PATCH net-next 0/2] gro: a couple of minor optimization Paolo Abeni
2022-02-04 11:28 ` Paolo Abeni [this message]
2022-02-04 16:34 ` [PATCH net-next 1/2] net: gro: avoid re-computing truesize twice on recycle Eric Dumazet
2022-02-04 11:28 ` [PATCH net-next 2/2] net: gro: minor optimization for dev_gro_receive() Paolo Abeni
2022-02-04 11:34 ` [PATCH net-next 0/2] gro: a couple of minor optimization Paolo Abeni
2022-02-05 9:51 ` David Miller
2022-02-04 12:16 ` Alexander Lobakin
2022-02-04 15:55 ` Alexander Duyck
2022-02-05 15:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9903ebc67ba39368d7a1e93681c65305d868232c.1643972527.git.pabeni@redhat.com \
--to=pabeni@redhat.com \
--cc=alexander.duyck@gmail.com \
--cc=alexandr.lobakin@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.