From: Eddie James <eajames@linux.ibm.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-fsi@lists.ozlabs.org, linux-hwmon@vger.kernel.org,
linux-kernel@vger.kernel.org, joel@jms.id.au, linux@roeck-us.net,
jdelvare@suse.com, alistair@popple.id.au, jk@ozlabs.org
Subject: Re: [PATCH 3/3] hwmon: (occ) Provide the SBEFIFO FFDC in binary sysfs
Date: Tue, 21 Sep 2021 10:57:07 -0500 [thread overview]
Message-ID: <990b5434-ed3e-7fe0-488f-f3ad55d48cee@linux.ibm.com> (raw)
In-Reply-To: <YUn8JcqBQVy2Nwd3@kroah.com>
On 9/21/21 10:37 AM, Greg KH wrote:
> On Tue, Sep 14, 2021 at 04:35:43PM -0500, Eddie James wrote:
>> Save any FFDC provided by the OCC driver, and provide it to userspace
>> through a binary sysfs entry. Do some basic state management to
>> ensure that userspace can always collect the data if there was an
>> error. Notify polling userspace when there is an error too.
>>
>> Signed-off-by: Eddie James <eajames@linux.ibm.com>
>> ---
>> drivers/hwmon/occ/p9_sbe.c | 98 +++++++++++++++++++++++++++++++++++++-
>> 1 file changed, 97 insertions(+), 1 deletion(-)
> You forgot a Documentation/ABI/ entry :(
>
> Binary sysfs files are for "pass through to the hardware" only, you
> should not be dumping kernel data to userspace through them. I can't
> really determine if this is the case here or not, as there's no
> documentation saying what you are trying to represent here...
Ok oops. I will add an entry, thanks.
I believe this qualifies for binary sysfs then, since the data is an
error response from the hardware directly.
Thanks,
Eddie
>
> thanks,
>
> greg k-h
prev parent reply other threads:[~2021-09-21 15:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 21:35 [PATCH 0/3] occ: fsi and hwmon: Extract and provide the SBEFIFO FFDC Eddie James
2021-09-14 21:35 ` [PATCH 1/3] fsi: occ: Use a large buffer for responses Eddie James
2021-09-14 21:35 ` [PATCH 2/3] fsi: occ: Store the SBEFIFO FFDC in the user response buffer Eddie James
2021-09-14 21:35 ` [PATCH 3/3] hwmon: (occ) Provide the SBEFIFO FFDC in binary sysfs Eddie James
2021-09-15 16:13 ` Guenter Roeck
2021-09-15 21:11 ` Eddie James
2021-09-16 7:27 ` Joel Stanley
2021-09-16 0:17 ` Jeremy Kerr
2021-09-17 18:44 ` Eddie James
2021-09-21 15:37 ` Greg KH
2021-09-21 15:57 ` Eddie James [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=990b5434-ed3e-7fe0-488f-f3ad55d48cee@linux.ibm.com \
--to=eajames@linux.ibm.com \
--cc=alistair@popple.id.au \
--cc=gregkh@linuxfoundation.org \
--cc=jdelvare@suse.com \
--cc=jk@ozlabs.org \
--cc=joel@jms.id.au \
--cc=linux-fsi@lists.ozlabs.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.