From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFE97C4321E for ; Fri, 18 Nov 2022 22:05:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231252AbiKRWF6 (ORCPT ); Fri, 18 Nov 2022 17:05:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32900 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229933AbiKRWFz (ORCPT ); Fri, 18 Nov 2022 17:05:55 -0500 Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9914082236; Fri, 18 Nov 2022 14:05:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=public-files.de; s=s31663417; t=1668809116; bh=hvzsqeW+pZ6aFflH2DeCG+N++nDpjK40B2TbayEPl3E=; h=X-UI-Sender-Class:Date:From:To:CC:Subject:Reply-to:In-Reply-To: References; b=fxKRAT+HRry568qEjuPyxuqxsmOxh4Ut89W+yMncF4mJNkKMr+YYWLSXrzs8Bhygb gtMmeD8NNRrBa2x/408mJhaEpcv+e7EncaHTSisARCpXGDGqE+Ua78jxcb7qs7fB7v FqSRREPLyy16mkf6slwzRamQdHq7B0MLmBiGY++cvRU/gct7xlgk5a0NONEk7mmiuJ bTMbyOw9Z1x1XJT2wd35t2bO5Tw2ixB0FK1bWOVI+rQL2b3gZ8aZsRWUeC2U9uSdNj MQ2ftGVApLk/FLynG7pklgr0+kBi4vdvKgs2JM71nOCdylNpgdyUN81YUkvaeBuzDK MZ1DqZv4XCJpg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [127.0.0.1] ([80.245.77.125]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N49hB-1p5SwP0bLt-0102e6; Fri, 18 Nov 2022 23:05:16 +0100 Date: Fri, 18 Nov 2022 23:05:11 +0100 From: Frank Wunderlich To: Rob Herring , Frank Wunderlich CC: linux-mediatek@lists.infradead.org, Ryder Lee , Jianjun Wang , Bjorn Helgaas , Krzysztof Kozlowski , Chunfeng Yun , Kishon Vijay Abraham I , Vinod Koul , Greg Kroah-Hartman , Matthias Brugger , Paolo Abeni , Lorenzo Bianconi , Bo Jiao , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v6 11/11] arm64: dts: mt7986: add BPI-R3 nand/nor overlays User-Agent: K-9 Mail for Android Reply-to: frank-w@public-files.de In-Reply-To: References: <20221118190126.100895-1-linux@fw-web.de> <20221118190126.100895-12-linux@fw-web.de> Message-ID: <99114D73-22EF-43CD-848E-88A37B29B953@public-files.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:ScE/GLdzMud5Wy9dhqxwyzhpkGMvwUQamRc0PAPEshdXTYQ917R W2WaOPx54U0oSso0ZvsU9Tfe7Ytz0Dz0NdoNaAZ3tSrgN3ci493eH4jyax8y3Q2AM8B22Zj jnYHxDKAcHQ5+gC+KekOMWdMimNh0IpbabDtg8O1/GJfsLrV/p3dyUaLAA//2lCcDzbtF90 067bPzcUPbKsFXpppCV2w== UI-OutboundReport: notjunk:1;M01:P0:jzrKweSzGSM=;rrPo469rUCAif9db3YD44H+IJFQ RP9TeEEcYoQ9Y15+4Qqqr36r4ytGk/qXf1ndgvE0mvRc9JcwFpicqvMIhnFQoMMj9kFiSVWCY qYOI9NWegO0sFWVYt+uDRy/Vg8oudtQfZqkV1hBdUkCaFtD/j/QUPyk/1ose2PdBVsOwLUVj3 dVfDKCq454TfNUe8uyD3UjBY07GTdDH2lpppsaj7Nm4ExwIoyNvI9s25LirIJOy1fkXNJ+oRH /+Su5ti6m1GrodB6ivViUBGMuiYKA39rVD2YA2SRKf5NT5dtxBaoqxeJhl/VtDHfqIjezjhsF MzPbGH+7lFMVCJcUp9O+pvhIU/DR2EXCRmw4YLNz0dfKf02XnNvorFa/Y3Yg7Rk8zYkyVKDMA esE6/FuupmZIj+33R/VDPJlsfzZYT1GVAEloc1gXg7SgA1z6l5YGez7T7O5/qY3WbLRWFQF8U UNvsPnDOSsBlenzsvz8kPyftCqdxm1azeq3S6ACDjTAmwwu0KKe0XAEHLo8nE+gowCCcY4jx/ dzXeOiFnVVQOsgNxJ8Ly4abKqimvAav0m2tEywHZBUuKb/H09Dna+GBcCmfkOPRUfOhKozxP+ Y5/IqectOej/avAT347nvrLm9Cl4IXPYjzzSj9e4QafM98y6hd1/wJh6orfb+Z1LfeQ18iDm1 XEA3kJVKu9rum8z0BDUk1jM7XY74zCuz3p1c5IhGH5WYxQdX0JnLkECXlyy8UIyvU1L/YoQwu iED6oE1g2tVYPQAW8KS0DsuEmrLTF3/B8AHrtZFZvJABhlG4LLOYmumZNrbNbBjb3zlIVK6GG HtrmluWV7dcXPXe1YH/AnUqR2kaZ2scpnDI1fyP8Xd1turb8JZUBcdN/vNqg0qiMRt/JfXzfZ 6YV1DFoB4zYXZxodKoC1hU6hE9xlGtaf3Nlhn6fJjGxSsrLTIwSOXtvQMD/b+msc+b3nhs8bq J2vMfA== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 18=2E November 2022 22:39:52 MEZ schrieb Rob Herring : >On Fri, Nov 18, 2022 at 1:01 PM Frank Wunderlich wrot= e: >> >> From: Frank Wunderlich >> >> Add devicetree overlays for using nand and nor on BPI-R3=2E > >Can you not tell at runtime which one you booted from? If not, how >does one choose which overlay to apply? If you can, why not populate >both nodes and enable the right one? IMO, if all h/w is present, it >should all be in the DT=2E Selecting what h/w to use is a separate >problem and overlays aren't a great solution for that=2E It is not the decision about bootdevice,more available devices=2E Only 1 spi device (nand OR nor) is available at boottime as they share same spi bus and chipselect is set via hw jumper=2E Both nodes have reg 0,which is imho not supported in linux=2E I choosed overlays to add the right spi device on the right mmc device where similar selection happens (see patch 10)=2E Either sd OR emmc can be used (1 mmc controller,first 4bits from bus switched by hardware jumper)=2EBut for mmc i use it as base fdt because i see mmc as primary device which holds rootfs too=2E Nand/nor is imho helping device for accessing emmc or like rescue system (only uboot)=2E I probe in uboot if emmc is available (mmc partconf) and choose emmc else sd=2E For spi i try with sf command to check for nor,if this does not work i apply nand overlay=2E >> Signed-off-by: Frank Wunderlich >> --- >> maybe rename to dtso? >> >> "kbuild: Allow DTB overlays to built from =2Edtso named source files" >> https://git=2Ekernel=2Eorg/pub/scm/linux/kernel/git/robh/linux=2Egit/co= mmit/?h=3Ddt/next&id=3D363547d2191cbc32ca954ba75d72908712398ff2 Should i do this? >> more comments about the dt overlay-support: >> >> https://patchwork=2Ekernel=2Eorg/comment/25092116/ >> https://patchwork=2Ekernel=2Eorg/comment/25085681/ Daniel suggest define sd/emmc as overlay too=2E=2E=2Ewith way you mention = below we could create 4 full fdt without applying overlays in uboot=2E >> --- a/arch/arm64/boot/dts/mediatek/Makefile >> +++ b/arch/arm64/boot/dts/mediatek/Makefile >> @@ -8,6 +8,8 @@ dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt6797-x20-dev=2Edtb >> dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt7622-rfb1=2Edtb >> dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt7622-bananapi-bpi-r64=2Edtb >> dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt7986a-bananapi-bpi-r3-emmc=2Edtb >> +dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt7986a-bananapi-bpi-r3-nand=2Edtbo >> +dtb-$(CONFIG_ARCH_MEDIATEK) +=3D mt7986a-bananapi-bpi-r3-nor=2Edtbo > >These need rules to apply them to the base dtb(s)=2E You just need: > >full=2Edtb :=3D base=2Edtb overlay=2Edtb >dtb-y +=3D full=2Edtb I would prefer to do this in bootloader to allow all 4 possible configurat= ions: Sd+nand Sd+nor Emmc+nand Emmc+nor >Rob Hi, regards Frank From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E1010C43217 for ; Fri, 18 Nov 2022 22:06:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Reply-To:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID: References:In-Reply-To:Subject:CC:To:From:Date:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VWQYluALbSDnUf0x/kvoPjLGb4+PaN/z1jKJJIBOI9A=; b=jw85aQSxUq3gV7 qE0MaOuQkFb6upPO4WQDJUKeWhxgB36JcCbluenMRqOgExYaHskDFfpRY2QXxkHZEQHhOHJGxhV5X J7GUfs4ZJRWMLLUGrf/mjCITCoZJPEftRNoJVGWdit7w+vFq4MNoM4MGU7w99E4itzN0A3BDLk4M+ 0SLkqRfCrJotwexxpwh4V+lIupGxTWP6gZEy63RaiMCwFHCzgkdxoVKbeu1Xo1G8dQNp6uSruJ87o AxCtJqDyJyWl7Ild9Ktzpc8fbBm5z/+4n3amtQU9bGT6EGXt7XgXzmrrBe2UtQJ2euz1kmxFd4WOG nPlKwkzwsc+yL4/X6QAA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ow9Un-008iMK-8B; Fri, 18 Nov 2022 22:06:01 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ow9Ub-008iJH-Tt; Fri, 18 Nov 2022 22:05:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:Message-ID:References:In-Reply-To:Reply-to:Subject:CC:To:From: Date:Sender:Content-ID:Content-Description; bh=Cy/UMrRY23kBrD2ecL5l9ho8KZiKHiy2L0b7WpzlhX4=; b=CTxWbp2sZqYzHQZPHf0ks6NLXx lO2uqO61AQZSyinA2vpcX0pUQ9tOpDIwdXTbktgm5Gs9As0AfoY3YLP37mdbSndYqXMhNSO2/phqR n5k0Hg4uV28Fvup1Z6PQUhjHmU7tKnl2jOllo55oAjZY7i1g7CVu/M/uBVSvN7BEzckNm4arCf7uf v7FqRlVrtrbjEjvkpsD8EGwQP9smJ6BOGFQgr/8XuMBjHGM6ve77VIpDihklZakSLSXclDkgKELE/ 5OD7WBxjxBSZhfKXYd5jYqGiLimTC8T8qGQvjNMwsLk9p6/mlsGhtIBSoMcio1UbTHzU08mv1pwrX DzvbQsiQ==; Received: from mout.gmx.net ([212.227.17.20]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ow9UW-0027gC-JJ; Fri, 18 Nov 2022 22:05:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=public-files.de; s=s31663417; t=1668809116; bh=hvzsqeW+pZ6aFflH2DeCG+N++nDpjK40B2TbayEPl3E=; h=X-UI-Sender-Class:Date:From:To:CC:Subject:Reply-to:In-Reply-To: References; b=fxKRAT+HRry568qEjuPyxuqxsmOxh4Ut89W+yMncF4mJNkKMr+YYWLSXrzs8Bhygb gtMmeD8NNRrBa2x/408mJhaEpcv+e7EncaHTSisARCpXGDGqE+Ua78jxcb7qs7fB7v FqSRREPLyy16mkf6slwzRamQdHq7B0MLmBiGY++cvRU/gct7xlgk5a0NONEk7mmiuJ bTMbyOw9Z1x1XJT2wd35t2bO5Tw2ixB0FK1bWOVI+rQL2b3gZ8aZsRWUeC2U9uSdNj MQ2ftGVApLk/FLynG7pklgr0+kBi4vdvKgs2JM71nOCdylNpgdyUN81YUkvaeBuzDK MZ1DqZv4XCJpg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [127.0.0.1] ([80.245.77.125]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N49hB-1p5SwP0bLt-0102e6; Fri, 18 Nov 2022 23:05:16 +0100 Date: Fri, 18 Nov 2022 23:05:11 +0100 From: Frank Wunderlich To: Rob Herring , Frank Wunderlich CC: linux-mediatek@lists.infradead.org, Ryder Lee , Jianjun Wang , Bjorn Helgaas , Krzysztof Kozlowski , Chunfeng Yun , Kishon Vijay Abraham I , Vinod Koul , Greg Kroah-Hartman , Matthias Brugger , Paolo Abeni , Lorenzo Bianconi , Bo Jiao , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v6 11/11] arm64: dts: mt7986: add BPI-R3 nand/nor overlays User-Agent: K-9 Mail for Android In-Reply-To: References: <20221118190126.100895-1-linux@fw-web.de> <20221118190126.100895-12-linux@fw-web.de> Message-ID: <99114D73-22EF-43CD-848E-88A37B29B953@public-files.de> MIME-Version: 1.0 X-Provags-ID: V03:K1:ScE/GLdzMud5Wy9dhqxwyzhpkGMvwUQamRc0PAPEshdXTYQ917R W2WaOPx54U0oSso0ZvsU9Tfe7Ytz0Dz0NdoNaAZ3tSrgN3ci493eH4jyax8y3Q2AM8B22Zj jnYHxDKAcHQ5+gC+KekOMWdMimNh0IpbabDtg8O1/GJfsLrV/p3dyUaLAA//2lCcDzbtF90 067bPzcUPbKsFXpppCV2w== UI-OutboundReport: notjunk:1;M01:P0:jzrKweSzGSM=;rrPo469rUCAif9db3YD44H+IJFQ RP9TeEEcYoQ9Y15+4Qqqr36r4ytGk/qXf1ndgvE0mvRc9JcwFpicqvMIhnFQoMMj9kFiSVWCY qYOI9NWegO0sFWVYt+uDRy/Vg8oudtQfZqkV1hBdUkCaFtD/j/QUPyk/1ose2PdBVsOwLUVj3 dVfDKCq454TfNUe8uyD3UjBY07GTdDH2lpppsaj7Nm4ExwIoyNvI9s25LirIJOy1fkXNJ+oRH /+Su5ti6m1GrodB6ivViUBGMuiYKA39rVD2YA2SRKf5NT5dtxBaoqxeJhl/VtDHfqIjezjhsF MzPbGH+7lFMVCJcUp9O+pvhIU/DR2EXCRmw4YLNz0dfKf02XnNvorFa/Y3Yg7Rk8zYkyVKDMA esE6/FuupmZIj+33R/VDPJlsfzZYT1GVAEloc1gXg7SgA1z6l5YGez7T7O5/qY3WbLRWFQF8U UNvsPnDOSsBlenzsvz8kPyftCqdxm1azeq3S6ACDjTAmwwu0KKe0XAEHLo8nE+gowCCcY4jx/ dzXeOiFnVVQOsgNxJ8Ly4abKqimvAav0m2tEywHZBUuKb/H09Dna+GBcCmfkOPRUfOhKozxP+ Y5/IqectOej/avAT347nvrLm9Cl4IXPYjzzSj9e4QafM98y6hd1/wJh6orfb+Z1LfeQ18iDm1 XEA3kJVKu9rum8z0BDUk1jM7XY74zCuz3p1c5IhGH5WYxQdX0JnLkECXlyy8UIyvU1L/YoQwu iED6oE1g2tVYPQAW8KS0DsuEmrLTF3/B8AHrtZFZvJABhlG4LLOYmumZNrbNbBjb3zlIVK6GG HtrmluWV7dcXPXe1YH/AnUqR2kaZ2scpnDI1fyP8Xd1turb8JZUBcdN/vNqg0qiMRt/JfXzfZ 6YV1DFoB4zYXZxodKoC1hU6hE9xlGtaf3Nlhn6fJjGxSsrLTIwSOXtvQMD/b+msc+b3nhs8bq J2vMfA== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221118_220544_851483_EEE0D8CF X-CRM114-Status: GOOD ( 14.46 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: frank-w@public-files.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Am 18. November 2022 22:39:52 MEZ schrieb Rob Herring : >On Fri, Nov 18, 2022 at 1:01 PM Frank Wunderlich wrote: >> >> From: Frank Wunderlich >> >> Add devicetree overlays for using nand and nor on BPI-R3. > >Can you not tell at runtime which one you booted from? If not, how >does one choose which overlay to apply? If you can, why not populate >both nodes and enable the right one? IMO, if all h/w is present, it >should all be in the DT. Selecting what h/w to use is a separate >problem and overlays aren't a great solution for that. It is not the decision about bootdevice,more available devices. Only 1 spi device (nand OR nor) is available at boottime as they share same spi bus and chipselect is set via hw jumper. Both nodes have reg 0,which is imho not supported in linux. I choosed overlays to add the right spi device on the right mmc device where similar selection happens (see patch 10). Either sd OR emmc can be used (1 mmc controller,first 4bits from bus switched by hardware jumper).But for mmc i use it as base fdt because i see mmc as primary device which holds rootfs too. Nand/nor is imho helping device for accessing emmc or like rescue system (only uboot). I probe in uboot if emmc is available (mmc partconf) and choose emmc else sd. For spi i try with sf command to check for nor,if this does not work i apply nand overlay. >> Signed-off-by: Frank Wunderlich >> --- >> maybe rename to dtso? >> >> "kbuild: Allow DTB overlays to built from .dtso named source files" >> https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git/commit/?h=dt/next&id=363547d2191cbc32ca954ba75d72908712398ff2 Should i do this? >> more comments about the dt overlay-support: >> >> https://patchwork.kernel.org/comment/25092116/ >> https://patchwork.kernel.org/comment/25085681/ Daniel suggest define sd/emmc as overlay too...with way you mention below we could create 4 full fdt without applying overlays in uboot. >> --- a/arch/arm64/boot/dts/mediatek/Makefile >> +++ b/arch/arm64/boot/dts/mediatek/Makefile >> @@ -8,6 +8,8 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt6797-x20-dev.dtb >> dtb-$(CONFIG_ARCH_MEDIATEK) += mt7622-rfb1.dtb >> dtb-$(CONFIG_ARCH_MEDIATEK) += mt7622-bananapi-bpi-r64.dtb >> dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc.dtb >> +dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nand.dtbo >> +dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nor.dtbo > >These need rules to apply them to the base dtb(s). You just need: > >full.dtb := base.dtb overlay.dtb >dtb-y += full.dtb I would prefer to do this in bootloader to allow all 4 possible configurations: Sd+nand Sd+nor Emmc+nand Emmc+nor >Rob Hi, regards Frank -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F563C433FE for ; Fri, 18 Nov 2022 22:06:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Reply-To:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID: References:In-Reply-To:Subject:CC:To:From:Date:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Hq4TrALHAYzapV9SkSF5T5goYgmaDd+6Iwy+YZ++KkE=; b=tfuM2tIHHklgZZ 3Xo4R3Q16SAb+INDBHp1IO+4owNl5Vo8lgjeGJLD0sKa5G2lVCxl1YGDVIUzGboOTxTf70KXrBKzw YZ/38mUsBLzaYNzUiqvp6eC7bHk2SZVV29Cd4rp7w5M9lQRbUIGdCP231B6KF1yryLL6vG629wMHM XN2JrgJgn0C8LrmLjycBjyqvgbOaC+c2yKHlR7vURULdpHiGXU6dF9G9dFy3ndNxZjNHI6d4Sbt7X AOES1dQ8pA3dnoWCiRjtsUktWwxMl5Q4/zUXxzWXIMtkRaqHxicyx9uQb8VvXuMgbkHO8efPG3qv3 lARdqWHTBjUN14EoU7yA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ow9Ud-008iK1-Ux; Fri, 18 Nov 2022 22:05:52 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ow9Ub-008iJH-Tt; Fri, 18 Nov 2022 22:05:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:Message-ID:References:In-Reply-To:Reply-to:Subject:CC:To:From: Date:Sender:Content-ID:Content-Description; bh=Cy/UMrRY23kBrD2ecL5l9ho8KZiKHiy2L0b7WpzlhX4=; b=CTxWbp2sZqYzHQZPHf0ks6NLXx lO2uqO61AQZSyinA2vpcX0pUQ9tOpDIwdXTbktgm5Gs9As0AfoY3YLP37mdbSndYqXMhNSO2/phqR n5k0Hg4uV28Fvup1Z6PQUhjHmU7tKnl2jOllo55oAjZY7i1g7CVu/M/uBVSvN7BEzckNm4arCf7uf v7FqRlVrtrbjEjvkpsD8EGwQP9smJ6BOGFQgr/8XuMBjHGM6ve77VIpDihklZakSLSXclDkgKELE/ 5OD7WBxjxBSZhfKXYd5jYqGiLimTC8T8qGQvjNMwsLk9p6/mlsGhtIBSoMcio1UbTHzU08mv1pwrX DzvbQsiQ==; Received: from mout.gmx.net ([212.227.17.20]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ow9UW-0027gC-JJ; Fri, 18 Nov 2022 22:05:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=public-files.de; s=s31663417; t=1668809116; bh=hvzsqeW+pZ6aFflH2DeCG+N++nDpjK40B2TbayEPl3E=; h=X-UI-Sender-Class:Date:From:To:CC:Subject:Reply-to:In-Reply-To: References; b=fxKRAT+HRry568qEjuPyxuqxsmOxh4Ut89W+yMncF4mJNkKMr+YYWLSXrzs8Bhygb gtMmeD8NNRrBa2x/408mJhaEpcv+e7EncaHTSisARCpXGDGqE+Ua78jxcb7qs7fB7v FqSRREPLyy16mkf6slwzRamQdHq7B0MLmBiGY++cvRU/gct7xlgk5a0NONEk7mmiuJ bTMbyOw9Z1x1XJT2wd35t2bO5Tw2ixB0FK1bWOVI+rQL2b3gZ8aZsRWUeC2U9uSdNj MQ2ftGVApLk/FLynG7pklgr0+kBi4vdvKgs2JM71nOCdylNpgdyUN81YUkvaeBuzDK MZ1DqZv4XCJpg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [127.0.0.1] ([80.245.77.125]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N49hB-1p5SwP0bLt-0102e6; Fri, 18 Nov 2022 23:05:16 +0100 Date: Fri, 18 Nov 2022 23:05:11 +0100 From: Frank Wunderlich To: Rob Herring , Frank Wunderlich CC: linux-mediatek@lists.infradead.org, Ryder Lee , Jianjun Wang , Bjorn Helgaas , Krzysztof Kozlowski , Chunfeng Yun , Kishon Vijay Abraham I , Vinod Koul , Greg Kroah-Hartman , Matthias Brugger , Paolo Abeni , Lorenzo Bianconi , Bo Jiao , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v6 11/11] arm64: dts: mt7986: add BPI-R3 nand/nor overlays User-Agent: K-9 Mail for Android In-Reply-To: References: <20221118190126.100895-1-linux@fw-web.de> <20221118190126.100895-12-linux@fw-web.de> Message-ID: <99114D73-22EF-43CD-848E-88A37B29B953@public-files.de> MIME-Version: 1.0 X-Provags-ID: V03:K1:ScE/GLdzMud5Wy9dhqxwyzhpkGMvwUQamRc0PAPEshdXTYQ917R W2WaOPx54U0oSso0ZvsU9Tfe7Ytz0Dz0NdoNaAZ3tSrgN3ci493eH4jyax8y3Q2AM8B22Zj jnYHxDKAcHQ5+gC+KekOMWdMimNh0IpbabDtg8O1/GJfsLrV/p3dyUaLAA//2lCcDzbtF90 067bPzcUPbKsFXpppCV2w== UI-OutboundReport: notjunk:1;M01:P0:jzrKweSzGSM=;rrPo469rUCAif9db3YD44H+IJFQ RP9TeEEcYoQ9Y15+4Qqqr36r4ytGk/qXf1ndgvE0mvRc9JcwFpicqvMIhnFQoMMj9kFiSVWCY qYOI9NWegO0sFWVYt+uDRy/Vg8oudtQfZqkV1hBdUkCaFtD/j/QUPyk/1ose2PdBVsOwLUVj3 dVfDKCq454TfNUe8uyD3UjBY07GTdDH2lpppsaj7Nm4ExwIoyNvI9s25LirIJOy1fkXNJ+oRH /+Su5ti6m1GrodB6ivViUBGMuiYKA39rVD2YA2SRKf5NT5dtxBaoqxeJhl/VtDHfqIjezjhsF MzPbGH+7lFMVCJcUp9O+pvhIU/DR2EXCRmw4YLNz0dfKf02XnNvorFa/Y3Yg7Rk8zYkyVKDMA esE6/FuupmZIj+33R/VDPJlsfzZYT1GVAEloc1gXg7SgA1z6l5YGez7T7O5/qY3WbLRWFQF8U UNvsPnDOSsBlenzsvz8kPyftCqdxm1azeq3S6ACDjTAmwwu0KKe0XAEHLo8nE+gowCCcY4jx/ dzXeOiFnVVQOsgNxJ8Ly4abKqimvAav0m2tEywHZBUuKb/H09Dna+GBcCmfkOPRUfOhKozxP+ Y5/IqectOej/avAT347nvrLm9Cl4IXPYjzzSj9e4QafM98y6hd1/wJh6orfb+Z1LfeQ18iDm1 XEA3kJVKu9rum8z0BDUk1jM7XY74zCuz3p1c5IhGH5WYxQdX0JnLkECXlyy8UIyvU1L/YoQwu iED6oE1g2tVYPQAW8KS0DsuEmrLTF3/B8AHrtZFZvJABhlG4LLOYmumZNrbNbBjb3zlIVK6GG HtrmluWV7dcXPXe1YH/AnUqR2kaZ2scpnDI1fyP8Xd1turb8JZUBcdN/vNqg0qiMRt/JfXzfZ 6YV1DFoB4zYXZxodKoC1hU6hE9xlGtaf3Nlhn6fJjGxSsrLTIwSOXtvQMD/b+msc+b3nhs8bq J2vMfA== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221118_220544_851483_EEE0D8CF X-CRM114-Status: GOOD ( 14.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: frank-w@public-files.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am 18. November 2022 22:39:52 MEZ schrieb Rob Herring : >On Fri, Nov 18, 2022 at 1:01 PM Frank Wunderlich wrote: >> >> From: Frank Wunderlich >> >> Add devicetree overlays for using nand and nor on BPI-R3. > >Can you not tell at runtime which one you booted from? If not, how >does one choose which overlay to apply? If you can, why not populate >both nodes and enable the right one? IMO, if all h/w is present, it >should all be in the DT. Selecting what h/w to use is a separate >problem and overlays aren't a great solution for that. It is not the decision about bootdevice,more available devices. Only 1 spi device (nand OR nor) is available at boottime as they share same spi bus and chipselect is set via hw jumper. Both nodes have reg 0,which is imho not supported in linux. I choosed overlays to add the right spi device on the right mmc device where similar selection happens (see patch 10). Either sd OR emmc can be used (1 mmc controller,first 4bits from bus switched by hardware jumper).But for mmc i use it as base fdt because i see mmc as primary device which holds rootfs too. Nand/nor is imho helping device for accessing emmc or like rescue system (only uboot). I probe in uboot if emmc is available (mmc partconf) and choose emmc else sd. For spi i try with sf command to check for nor,if this does not work i apply nand overlay. >> Signed-off-by: Frank Wunderlich >> --- >> maybe rename to dtso? >> >> "kbuild: Allow DTB overlays to built from .dtso named source files" >> https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git/commit/?h=dt/next&id=363547d2191cbc32ca954ba75d72908712398ff2 Should i do this? >> more comments about the dt overlay-support: >> >> https://patchwork.kernel.org/comment/25092116/ >> https://patchwork.kernel.org/comment/25085681/ Daniel suggest define sd/emmc as overlay too...with way you mention below we could create 4 full fdt without applying overlays in uboot. >> --- a/arch/arm64/boot/dts/mediatek/Makefile >> +++ b/arch/arm64/boot/dts/mediatek/Makefile >> @@ -8,6 +8,8 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt6797-x20-dev.dtb >> dtb-$(CONFIG_ARCH_MEDIATEK) += mt7622-rfb1.dtb >> dtb-$(CONFIG_ARCH_MEDIATEK) += mt7622-bananapi-bpi-r64.dtb >> dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc.dtb >> +dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nand.dtbo >> +dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nor.dtbo > >These need rules to apply them to the base dtb(s). You just need: > >full.dtb := base.dtb overlay.dtb >dtb-y += full.dtb I would prefer to do this in bootloader to allow all 4 possible configurations: Sd+nand Sd+nor Emmc+nand Emmc+nor >Rob Hi, regards Frank _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel