From: Paolo Bonzini <pbonzini@redhat.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>,
Stephen Zhang <stephenzhangzsd@gmail.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
seanjc@google.com, wanpengli@tencent.com, jmattson@google.com,
joro@8bytes.org, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, x86@kernel.org, hpa@zytor.com
Subject: Re: [PATCH] KVM: x86/mmu: improve robustness of some functions
Date: Mon, 25 Jan 2021 10:58:43 +0100 [thread overview]
Message-ID: <99258705-ff9e-aa0c-ba58-da87df760655@redhat.com> (raw)
In-Reply-To: <87a6sx4a0l.fsf@vitty.brq.redhat.com>
On 25/01/21 10:54, Vitaly Kuznetsov wrote:
>
> What if we do something like (completely untested):
>
> diff --git a/arch/x86/kvm/mmu/mmu_internal.h b/arch/x86/kvm/mmu/mmu_internal.h
> index bfc6389edc28..5ec15e4160b1 100644
> --- a/arch/x86/kvm/mmu/mmu_internal.h
> +++ b/arch/x86/kvm/mmu/mmu_internal.h
> @@ -12,7 +12,7 @@
> extern bool dbg;
>
> #define pgprintk(x...) do { if (dbg) printk(x); } while (0)
> -#define rmap_printk(x...) do { if (dbg) printk(x); } while (0)
> +#define rmap_printk(fmt, args...) do { if (dbg) printk("%s: " fmt, __func__, ## args); } while (0)
> #define MMU_WARN_ON(x) WARN_ON(x)
> #else
> #define pgprintk(x...) do { } while (0)
>
> and eliminate the need to pass '__func__,' explicitly? We can probably
> do the same to pgprintk().
Nice indeed. Though I wonder if anybody has ever used these. For those
that I actually needed in the past I created tracepoints instead.
Paolo
next prev parent reply other threads:[~2021-01-25 10:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 11:18 [PATCH] KVM: x86/mmu: improve robustness of some functions Stephen Zhang
2021-01-25 9:54 ` Vitaly Kuznetsov
2021-01-25 9:58 ` Paolo Bonzini [this message]
2021-01-25 16:54 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99258705-ff9e-aa0c-ba58-da87df760655@redhat.com \
--to=pbonzini@redhat.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=seanjc@google.com \
--cc=stephenzhangzsd@gmail.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.