From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: David Miller <davem@davemloft.net>
Cc: ajones@riverbed.com, e1000-devel@lists.sourceforge.net,
netdev@vger.kernel.org, shemminger@vyatta.com,
alexander.h.duyck@intel.com
Subject: Re: [net-next PATCH] e1000e: allow tx of pre-formatted vlan tagged packets
Date: Wed, 18 Mar 2009 23:55:31 -0700 [thread overview]
Message-ID: <9929d2390903182355s458a9675mdbbe65e3d548eddd@mail.gmail.com> (raw)
In-Reply-To: <20090318.234102.202869351.davem@davemloft.net>
On Wed, Mar 18, 2009 at 11:41 PM, David Miller <davem@davemloft.net> wrote:
> From: Arthur Jones <ajones@riverbed.com>
> Date: Tue, 17 Mar 2009 12:59:05 -0700
>
>> As with igb, when the e1000e driver is fed 802.1q
>> packets with hardware checksum on, it chokes with an
>> error of the form:
>>
>> checksum_partial proto=81!
>>
>> As the logic there was not smart enough to look into
>> the vlan header to pick out the encapsulated protocol.
>>
>> There are times when we'd like to send these packets
>> out without having to configure a vlan on the interface.
>> Here we check for the vlan tag and allow the packet to
>> go out with the correct hardware checksum.
>>
>> Thanks to Kand Ly <kand@riverbed.com> for discovering the
>> issue and the coming up with a solution. This patch is
>> based upon his work.
>>
>> Fixups from Stephen Hemminger <shemminger@vyatta.com> and
>> Alexander Duyck <alexander.h.duyck@intel.com>.
>>
>> Signed-off-by: Arthur Jones <ajones@riverbed.com>
>
> Jeff K., you got this one too?
> --
Yes. I have both. The are both in my queue, and I should have
something for you Dave later tonight/tomorrow morning.
--
Cheers,
Jeff
prev parent reply other threads:[~2009-03-19 6:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-17 19:59 [net-next PATCH] e1000e: allow tx of pre-formatted vlan tagged packets Arthur Jones
2009-03-19 6:41 ` David Miller
2009-03-19 6:55 ` Jeff Kirsher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9929d2390903182355s458a9675mdbbe65e3d548eddd@mail.gmail.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=ajones@riverbed.com \
--cc=alexander.h.duyck@intel.com \
--cc=davem@davemloft.net \
--cc=e1000-devel@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.