From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3323EC3815B for ; Wed, 15 Apr 2020 08:30:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0D3B520768 for ; Wed, 15 Apr 2020 08:30:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Yb7p1K7s" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2408065AbgDOIab (ORCPT ); Wed, 15 Apr 2020 04:30:31 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:33062 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2408046AbgDOIaQ (ORCPT ); Wed, 15 Apr 2020 04:30:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586939414; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bLmrOkcXJQ/8f3TsPjBB59Qp6PFUF6WHach7rOTidPU=; b=Yb7p1K7sVA3olaCuHiBBjK9yqILcoVdKBSzQpmJF0kxrIzL6C2Mt/pQE1wdX4bML6D9hNY G3y5HkTMxQs3vdnCBV6/wkBL2Z63GMx+P1UdlLMy9rrM7ejSgqNg9i8cr4HtgFYl/j3P/6 i3SeRFqf+ifkLFnwcXaQBl2OzzMFbzc= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-259-t2O1iRReO8yDzyEE8oEDug-1; Wed, 15 Apr 2020 04:30:10 -0400 X-MC-Unique: t2O1iRReO8yDzyEE8oEDug-1 Received: by mail-wr1-f70.google.com with SMTP id s11so5338132wru.6 for ; Wed, 15 Apr 2020 01:30:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bLmrOkcXJQ/8f3TsPjBB59Qp6PFUF6WHach7rOTidPU=; b=CYE6Dx/BI891NtrLAfvtdi6gbEz7vzmtU3lO3nM8A3Va3ZEt9/RQc1HuUNnh61tjjo yq6fYbWO2oPBlLCGoYyfPFg0TI9/LF4/yrjb8sP8Xxr0zBkmqThGAxTCp1r75izaF5A1 PAVkllbD3Xgxz1kvuqmUl6H9mpmFvsvVxqOT/oZNHwO2GLiu+NdnxV3S1rM+HBAfcaoN mVAIvMTt5wGsYXx7KQLrjrZprAy5hSsgJktwjUK6vtaoaNFAHdy4mgf3W390EKGxwnG0 Bv15HVImmckmsITnrS7qiB2DBZBoXSH8q++BFZfIFnr18C52jtr988G6ny6oymwLv4Sp qd7g== X-Gm-Message-State: AGi0PuY8Wj2YeMJrFlm86zdggJjuVDJmfsuLHMOgg2bByoMwq/9IYGEn OZJ4hMLZ2w/IqCv3TaZAwSZdfDLhK3Sy/LooG+hEvRxnzwrZCFeJxTYwkk4GDgfvWYS323GMc0r zOiUiOY3Qqbu1PRGggEA72e6x X-Received: by 2002:a1c:b445:: with SMTP id d66mr4126790wmf.187.1586939409338; Wed, 15 Apr 2020 01:30:09 -0700 (PDT) X-Google-Smtp-Source: APiQypI1/GFDfyQOLK5J6+00PCnZPj8fmTN9rFZPV07c4zGKdQlKsQOx+NrwNSeq7rAzMZDiU7ufeQ== X-Received: by 2002:a1c:b445:: with SMTP id d66mr4126760wmf.187.1586939409106; Wed, 15 Apr 2020 01:30:09 -0700 (PDT) Received: from localhost.localdomain ([194.230.155.238]) by smtp.gmail.com with ESMTPSA id g25sm8724053wmh.24.2020.04.15.01.30.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Apr 2020 01:30:08 -0700 (PDT) Subject: Re: [PATCH v2] kvm_host: unify VM_STAT and VCPU_STAT definitions in a single place To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , kvm@vger.kernel.org Cc: Marc Zyngier , James Morse , Julien Thierry , Suzuki K Poulose , Paul Mackerras , Christian Borntraeger , Janosch Frank , David Hildenbrand , Cornelia Huck , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-s390@vger.kernel.org References: <20200414155625.20559-1-eesposit@redhat.com> From: Emanuele Giuseppe Esposito Message-ID: <992ede27-3eae-f2da-ad38-1d3498853ad2@redhat.com> Date: Wed, 15 Apr 2020 10:30:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/15/20 8:36 AM, Philippe Mathieu-Daudé wrote: > On 4/14/20 5:56 PM, Emanuele Giuseppe Esposito wrote: >> The macros VM_STAT and VCPU_STAT are redundantly implemented in multiple >> files, each used by a different architecure to initialize the debugfs >> entries for statistics. Since they all have the same purpose, they can be >> unified in a single common definition in include/linux/kvm_host.h >> >> Signed-off-by: Emanuele Giuseppe Esposito >> --- >> arch/arm64/kvm/guest.c | 23 ++--- >> arch/mips/kvm/mips.c | 61 ++++++------ >> arch/powerpc/kvm/book3s.c | 61 ++++++------ >> arch/powerpc/kvm/booke.c | 41 ++++---- >> arch/s390/kvm/kvm-s390.c | 203 +++++++++++++++++++------------------- >> arch/x86/kvm/x86.c | 80 +++++++-------- >> include/linux/kvm_host.h | 5 + >> 7 files changed, 231 insertions(+), 243 deletions(-) >> >> diff --git a/arch/arm64/kvm/guest.c b/arch/arm64/kvm/guest.c >> index 23ebe51410f0..8417b200bec9 100644 >> --- a/arch/arm64/kvm/guest.c >> +++ b/arch/arm64/kvm/guest.c >> @@ -29,20 +29,17 @@ >> >> #include "trace.h" >> >> -#define VM_STAT(x) { #x, offsetof(struct kvm, stat.x), KVM_STAT_VM } >> -#define VCPU_STAT(x) { #x, offsetof(struct kvm_vcpu, stat.x), KVM_STAT_VCPU } >> - >> struct kvm_stats_debugfs_item debugfs_entries[] = { >> - VCPU_STAT(halt_successful_poll), >> - VCPU_STAT(halt_attempted_poll), >> - VCPU_STAT(halt_poll_invalid), >> - VCPU_STAT(halt_wakeup), >> - VCPU_STAT(hvc_exit_stat), >> - VCPU_STAT(wfe_exit_stat), >> - VCPU_STAT(wfi_exit_stat), >> - VCPU_STAT(mmio_exit_user), >> - VCPU_STAT(mmio_exit_kernel), >> - VCPU_STAT(exits), >> + VCPU_STAT("halt_successful_poll", halt_successful_poll), >> + VCPU_STAT("halt_attempted_poll", halt_attempted_poll), >> + VCPU_STAT("halt_poll_invalid", halt_poll_invalid), >> + VCPU_STAT("halt_wakeup", halt_wakeup), >> + VCPU_STAT("hvc_exit_stat", hvc_exit_stat), >> + VCPU_STAT("wfe_exit_stat", wfe_exit_stat), >> + VCPU_STAT("wfi_exit_stat", wfi_exit_stat), >> + VCPU_STAT("mmio_exit_user", mmio_exit_user), >> + VCPU_STAT("mmio_exit_kernel", mmio_exit_kernel), >> + VCPU_STAT("exits", exits), >> { NULL } >> }; > > Patch easily reviewed with --word-diff. > > [...] >> diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h >> index 6d58beb65454..2e6ead872957 100644 >> --- a/include/linux/kvm_host.h >> +++ b/include/linux/kvm_host.h >> @@ -1130,6 +1130,11 @@ struct kvm_stats_debugfs_item { >> #define KVM_DBGFS_GET_MODE(dbgfs_item) \ >> ((dbgfs_item)->mode ? (dbgfs_item)->mode : 0644) >> >> +#define VM_STAT(n, x, ...) \ >> + { n, offsetof(struct kvm, stat.x), KVM_STAT_VM, ## __VA_ARGS__ } >> +#define VCPU_STAT(n, x, ...) \ > > Not sure while you use so many whitespaces here... (maybe Paolo can > strip some when applying?). I honestly am not sure why it added few more spaces than I wanted, but the idea was to follow the KVM_DBGFS_GET_MODE macro above and put the backslash at the end of the line (80th char). > > Otherwise it looks nicer that v1, thanks. > > Reviewed-by: Philippe Mathieu-Daudé > >> + { n, offsetof(struct kvm_vcpu, stat.x), KVM_STAT_VCPU, ## __VA_ARGS__ } >> + >> extern struct kvm_stats_debugfs_item debugfs_entries[]; >> extern struct dentry *kvm_debugfs_dir; >> >> > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EA8EC2BB85 for ; Wed, 15 Apr 2020 09:23:52 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id DAD5120775 for ; Wed, 15 Apr 2020 09:23:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="RiCeefqe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DAD5120775 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 9259E4B241; Wed, 15 Apr 2020 05:23:51 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@redhat.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oLszwmyJhrmc; Wed, 15 Apr 2020 05:23:50 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 630984B228; Wed, 15 Apr 2020 05:23:48 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id C58CC4B17F for ; Wed, 15 Apr 2020 04:30:13 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tDVSHi6e6WnQ for ; Wed, 15 Apr 2020 04:30:12 -0400 (EDT) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mm01.cs.columbia.edu (Postfix) with ESMTP id BC52B4B176 for ; Wed, 15 Apr 2020 04:30:12 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586939412; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JM3vltnSQeQHbyK1dZxQXkvEx4sl9ZGuP7RHLsjmkZo=; b=RiCeefqeN0xM0QLxOuea3ScEkNkiZAu1zEUteu0DXZiRRKYUjhjjEkpvxqe0cp3yTJOphM tr5F//BC+9UCetg5/1c53fD3whPU9uhvV4qT7MnLEIRcNVnLNP9kQoGh0USgRHFkhmEkbc uGH99DSgrYqPnwLi+X7qnbvSqjeMJNs= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-222-ycu5H-vdOeyEa6RrTjZ5DA-1; Wed, 15 Apr 2020 04:30:10 -0400 X-MC-Unique: ycu5H-vdOeyEa6RrTjZ5DA-1 Received: by mail-wm1-f69.google.com with SMTP id c196so2751291wmd.3 for ; Wed, 15 Apr 2020 01:30:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bLmrOkcXJQ/8f3TsPjBB59Qp6PFUF6WHach7rOTidPU=; b=r6uRrFXRdicpOfXX579P90sbcOnPIwoZHTipFNMQmTDr+XD44HaQaBBk8u9fX6kna6 kSHk/02qXd0nR8rmnX2m6Wv39PsJLSfNfN60lefU2jimfzFqqwmusNSG2xqLfctoKx8P vK0yx7y5IXcl05XGNZwZkP3OsI/5lhNwjU7WkP0SAv1GMB/OkqBiteeHZm5ZWeZqKJLq zDFEk4lRujhHxsUEOs+MA5+dugEEfe33Ive2VVaB55sITl1z9T6r9ol+Bcpr7xr7Mu8c 089rQ8DVutMBTqA+8OhMyowKO1nCPV7OIh556mPYOsw/KwOrnpHWJg5aUE5unLLr7VVu +n1g== X-Gm-Message-State: AGi0PubYHIaXukau1Ive+ID4hENzA63d3Tmi/QqzJvvTJHeUNs3Ww880 QjrMl7fbb360O7UE6i1R1ecY6VrERsY+yXEH8SPLtIrx4R7slGv5XjZh7KGYAmzEZ/75y7KfoBR kYBgyYIRUNJylsoQBjbvC2sQQ X-Received: by 2002:a1c:b445:: with SMTP id d66mr4126798wmf.187.1586939409340; Wed, 15 Apr 2020 01:30:09 -0700 (PDT) X-Google-Smtp-Source: APiQypI1/GFDfyQOLK5J6+00PCnZPj8fmTN9rFZPV07c4zGKdQlKsQOx+NrwNSeq7rAzMZDiU7ufeQ== X-Received: by 2002:a1c:b445:: with SMTP id d66mr4126760wmf.187.1586939409106; Wed, 15 Apr 2020 01:30:09 -0700 (PDT) Received: from localhost.localdomain ([194.230.155.238]) by smtp.gmail.com with ESMTPSA id g25sm8724053wmh.24.2020.04.15.01.30.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Apr 2020 01:30:08 -0700 (PDT) Subject: Re: [PATCH v2] kvm_host: unify VM_STAT and VCPU_STAT definitions in a single place To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , kvm@vger.kernel.org References: <20200414155625.20559-1-eesposit@redhat.com> From: Emanuele Giuseppe Esposito Message-ID: <992ede27-3eae-f2da-ad38-1d3498853ad2@redhat.com> Date: Wed, 15 Apr 2020 10:30:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Mailman-Approved-At: Wed, 15 Apr 2020 05:23:47 -0400 Cc: kvm-ppc@vger.kernel.org, linux-s390@vger.kernel.org, Cornelia Huck , Wanpeng Li , Janosch Frank , Marc Zyngier , Joerg Roedel , David Hildenbrand , linux-kernel@vger.kernel.org, Sean Christopherson , linux-mips@vger.kernel.org, Paul Mackerras , Christian Borntraeger , linux-arm-kernel@lists.infradead.org, Paolo Bonzini , Vitaly Kuznetsov , kvmarm@lists.cs.columbia.edu, Jim Mattson X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu CgpPbiA0LzE1LzIwIDg6MzYgQU0sIFBoaWxpcHBlIE1hdGhpZXUtRGF1ZMOpIHdyb3RlOgo+IE9u IDQvMTQvMjAgNTo1NiBQTSwgRW1hbnVlbGUgR2l1c2VwcGUgRXNwb3NpdG8gd3JvdGU6Cj4+IFRo ZSBtYWNyb3MgVk1fU1RBVCBhbmQgVkNQVV9TVEFUIGFyZSByZWR1bmRhbnRseSBpbXBsZW1lbnRl ZCBpbiBtdWx0aXBsZQo+PiBmaWxlcywgZWFjaCB1c2VkIGJ5IGEgZGlmZmVyZW50IGFyY2hpdGVj dXJlIHRvIGluaXRpYWxpemUgdGhlIGRlYnVnZnMKPj4gZW50cmllcyBmb3Igc3RhdGlzdGljcy4g U2luY2UgdGhleSBhbGwgaGF2ZSB0aGUgc2FtZSBwdXJwb3NlLCB0aGV5IGNhbiBiZQo+PiB1bmlm aWVkIGluIGEgc2luZ2xlIGNvbW1vbiBkZWZpbml0aW9uIGluIGluY2x1ZGUvbGludXgva3ZtX2hv c3QuaAo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBFbWFudWVsZSBHaXVzZXBwZSBFc3Bvc2l0byA8ZWVz cG9zaXRAcmVkaGF0LmNvbT4KPj4gLS0tCj4+ICAgYXJjaC9hcm02NC9rdm0vZ3Vlc3QuYyAgICB8 ICAyMyArKy0tLQo+PiAgIGFyY2gvbWlwcy9rdm0vbWlwcy5jICAgICAgfCAgNjEgKysrKysrLS0t LS0tCj4+ICAgYXJjaC9wb3dlcnBjL2t2bS9ib29rM3MuYyB8ICA2MSArKysrKystLS0tLS0KPj4g ICBhcmNoL3Bvd2VycGMva3ZtL2Jvb2tlLmMgIHwgIDQxICsrKystLS0tCj4+ICAgYXJjaC9zMzkw L2t2bS9rdm0tczM5MC5jICB8IDIwMyArKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0t LS0tLQo+PiAgIGFyY2gveDg2L2t2bS94ODYuYyAgICAgICAgfCAgODAgKysrKysrKy0tLS0tLS0t Cj4+ICAgaW5jbHVkZS9saW51eC9rdm1faG9zdC5oICB8ICAgNSArCj4+ICAgNyBmaWxlcyBjaGFu Z2VkLCAyMzEgaW5zZXJ0aW9ucygrKSwgMjQzIGRlbGV0aW9ucygtKQo+Pgo+PiBkaWZmIC0tZ2l0 IGEvYXJjaC9hcm02NC9rdm0vZ3Vlc3QuYyBiL2FyY2gvYXJtNjQva3ZtL2d1ZXN0LmMKPj4gaW5k ZXggMjNlYmU1MTQxMGYwLi44NDE3YjIwMGJlYzkgMTAwNjQ0Cj4+IC0tLSBhL2FyY2gvYXJtNjQv a3ZtL2d1ZXN0LmMKPj4gKysrIGIvYXJjaC9hcm02NC9rdm0vZ3Vlc3QuYwo+PiBAQCAtMjksMjAg KzI5LDE3IEBACj4+ICAgCj4+ICAgI2luY2x1ZGUgInRyYWNlLmgiCj4+ICAgCj4+IC0jZGVmaW5l IFZNX1NUQVQoeCkgeyAjeCwgb2Zmc2V0b2Yoc3RydWN0IGt2bSwgc3RhdC54KSwgS1ZNX1NUQVRf Vk0gfQo+PiAtI2RlZmluZSBWQ1BVX1NUQVQoeCkgeyAjeCwgb2Zmc2V0b2Yoc3RydWN0IGt2bV92 Y3B1LCBzdGF0LngpLCBLVk1fU1RBVF9WQ1BVIH0KPj4gLQo+PiAgIHN0cnVjdCBrdm1fc3RhdHNf ZGVidWdmc19pdGVtIGRlYnVnZnNfZW50cmllc1tdID0gewo+PiAtCVZDUFVfU1RBVChoYWx0X3N1 Y2Nlc3NmdWxfcG9sbCksCj4+IC0JVkNQVV9TVEFUKGhhbHRfYXR0ZW1wdGVkX3BvbGwpLAo+PiAt CVZDUFVfU1RBVChoYWx0X3BvbGxfaW52YWxpZCksCj4+IC0JVkNQVV9TVEFUKGhhbHRfd2FrZXVw KSwKPj4gLQlWQ1BVX1NUQVQoaHZjX2V4aXRfc3RhdCksCj4+IC0JVkNQVV9TVEFUKHdmZV9leGl0 X3N0YXQpLAo+PiAtCVZDUFVfU1RBVCh3ZmlfZXhpdF9zdGF0KSwKPj4gLQlWQ1BVX1NUQVQobW1p b19leGl0X3VzZXIpLAo+PiAtCVZDUFVfU1RBVChtbWlvX2V4aXRfa2VybmVsKSwKPj4gLQlWQ1BV X1NUQVQoZXhpdHMpLAo+PiArCVZDUFVfU1RBVCgiaGFsdF9zdWNjZXNzZnVsX3BvbGwiLCBoYWx0 X3N1Y2Nlc3NmdWxfcG9sbCksCj4+ICsJVkNQVV9TVEFUKCJoYWx0X2F0dGVtcHRlZF9wb2xsIiwg aGFsdF9hdHRlbXB0ZWRfcG9sbCksCj4+ICsJVkNQVV9TVEFUKCJoYWx0X3BvbGxfaW52YWxpZCIs IGhhbHRfcG9sbF9pbnZhbGlkKSwKPj4gKwlWQ1BVX1NUQVQoImhhbHRfd2FrZXVwIiwgaGFsdF93 YWtldXApLAo+PiArCVZDUFVfU1RBVCgiaHZjX2V4aXRfc3RhdCIsIGh2Y19leGl0X3N0YXQpLAo+ PiArCVZDUFVfU1RBVCgid2ZlX2V4aXRfc3RhdCIsIHdmZV9leGl0X3N0YXQpLAo+PiArCVZDUFVf U1RBVCgid2ZpX2V4aXRfc3RhdCIsIHdmaV9leGl0X3N0YXQpLAo+PiArCVZDUFVfU1RBVCgibW1p b19leGl0X3VzZXIiLCBtbWlvX2V4aXRfdXNlciksCj4+ICsJVkNQVV9TVEFUKCJtbWlvX2V4aXRf a2VybmVsIiwgbW1pb19leGl0X2tlcm5lbCksCj4+ICsJVkNQVV9TVEFUKCJleGl0cyIsIGV4aXRz KSwKPj4gICAJeyBOVUxMIH0KPj4gICB9Owo+IAo+IFBhdGNoIGVhc2lseSByZXZpZXdlZCB3aXRo IC0td29yZC1kaWZmLgo+IAo+IFsuLi5dCj4+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2xpbnV4L2t2 bV9ob3N0LmggYi9pbmNsdWRlL2xpbnV4L2t2bV9ob3N0LmgKPj4gaW5kZXggNmQ1OGJlYjY1NDU0 Li4yZTZlYWQ4NzI5NTcgMTAwNjQ0Cj4+IC0tLSBhL2luY2x1ZGUvbGludXgva3ZtX2hvc3QuaAo+ PiArKysgYi9pbmNsdWRlL2xpbnV4L2t2bV9ob3N0LmgKPj4gQEAgLTExMzAsNiArMTEzMCwxMSBA QCBzdHJ1Y3Qga3ZtX3N0YXRzX2RlYnVnZnNfaXRlbSB7Cj4+ICAgI2RlZmluZSBLVk1fREJHRlNf R0VUX01PREUoZGJnZnNfaXRlbSkgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIFwKPj4gICAJKChkYmdmc19pdGVtKS0+bW9kZSA/IChkYmdmc19pdGVtKS0+bW9kZSA6IDA2 NDQpCj4+ICAgCj4+ICsjZGVmaW5lIFZNX1NUQVQobiwgeCwgLi4uKSAJCQkJCQkJCQkJCQkJICAg XAo+PiArCXsgbiwgb2Zmc2V0b2Yoc3RydWN0IGt2bSwgc3RhdC54KSwgS1ZNX1NUQVRfVk0sICMj IF9fVkFfQVJHU19fIH0KPj4gKyNkZWZpbmUgVkNQVV9TVEFUKG4sIHgsIC4uLikJCQkJCQkJCQkJ CQkgICBcCj4gCj4gTm90IHN1cmUgd2hpbGUgeW91IHVzZSBzbyBtYW55IHdoaXRlc3BhY2VzIGhl cmUuLi4gKG1heWJlIFBhb2xvIGNhbgo+IHN0cmlwIHNvbWUgd2hlbiBhcHBseWluZz8pLgoKSSBo b25lc3RseSBhbSBub3Qgc3VyZSB3aHkgaXQgYWRkZWQgZmV3IG1vcmUgc3BhY2VzIHRoYW4gSSB3 YW50ZWQsIGJ1dCAKdGhlIGlkZWEgd2FzIHRvIGZvbGxvdyB0aGUgS1ZNX0RCR0ZTX0dFVF9NT0RF IG1hY3JvIGFib3ZlIGFuZCBwdXQgdGhlIApiYWNrc2xhc2ggYXQgdGhlIGVuZCBvZiB0aGUgbGlu ZSAoODB0aCBjaGFyKS4KCj4gCj4gT3RoZXJ3aXNlIGl0IGxvb2tzIG5pY2VyIHRoYXQgdjEsIHRo YW5rcy4KPiAKPiBSZXZpZXdlZC1ieTogUGhpbGlwcGUgTWF0aGlldS1EYXVkw6kgPGY0YnVnQGFt c2F0Lm9yZz4KPiAKPj4gKwl7IG4sIG9mZnNldG9mKHN0cnVjdCBrdm1fdmNwdSwgc3RhdC54KSwg S1ZNX1NUQVRfVkNQVSwgIyMgX19WQV9BUkdTX18gfQo+PiArCj4+ICAgZXh0ZXJuIHN0cnVjdCBr dm1fc3RhdHNfZGVidWdmc19pdGVtIGRlYnVnZnNfZW50cmllc1tdOwo+PiAgIGV4dGVybiBzdHJ1 Y3QgZGVudHJ5ICprdm1fZGVidWdmc19kaXI7Cj4+ICAgCj4+Cj4gCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwprdm1hcm0gbWFpbGluZyBsaXN0Cmt2bWFy bUBsaXN0cy5jcy5jb2x1bWJpYS5lZHUKaHR0cHM6Ly9saXN0cy5jcy5jb2x1bWJpYS5lZHUvbWFp bG1hbi9saXN0aW5mby9rdm1hcm0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B1CFC3815B for ; Wed, 15 Apr 2020 08:30:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D476D20784 for ; Wed, 15 Apr 2020 08:30:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BOEJV+/L"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Gy1JelUi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D476D20784 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jC9VjcAqcD7UTE8LRfCdlfG1pkI4KpsERv1K6YlYPlA=; b=BOEJV+/LjBlO/d8f0jJ4xpRlo gJWPhIN3YAniuYNQ1dMftkbrWupSabhozyNaKHJRju/H5xKkCNleO8rc39cRnNdUDQDkaOxhjYa6Y 7a+yjAip02uGcTP8FQxGbuZhhKO6J5JZSrOvUDiZv0BD+uEhe0/riHTTsjJMqsi9xRMFVaZlP8ShL Egb7YisOpYPsrDemfVwN7AMejVkIT0KopNBJLDnmzcA8KDoLG+LHsmSmB7ZUK01cNGq1vVNHnlV9Z 9ot8EO+2paFCtWj5S+KDc6xuPPys+NafSoXWzl4PHozVK2kjvaH966tHEgZpkuKbXhCunUuoVHp3s n9NazPbXw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOdR7-0003fB-NP; Wed, 15 Apr 2020 08:30:21 +0000 Received: from us-smtp-1.mimecast.com ([207.211.31.81] helo=us-smtp-delivery-1.mimecast.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOdR3-0003eZ-Pw for linux-arm-kernel@lists.infradead.org; Wed, 15 Apr 2020 08:30:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586939413; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JM3vltnSQeQHbyK1dZxQXkvEx4sl9ZGuP7RHLsjmkZo=; b=Gy1JelUiEW62GcknI2F4U1MY9rXun7NaXtGlAoeqnRpj73td6V1k84YGZ2TC4dSDVhiYTW AvzKi/l22s/pO2cSbijUL0XOVOkwVcwMsyuNn4NvGquSz2TACISolkppTfesR/te00fPtT t03cTy68SdKnYszM+Y+FTojMYOJ72Kw= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-295-GwvFOVedNsGaGpc3YZ7qDg-1; Wed, 15 Apr 2020 04:30:10 -0400 X-MC-Unique: GwvFOVedNsGaGpc3YZ7qDg-1 Received: by mail-wm1-f70.google.com with SMTP id b203so4664378wmd.6 for ; Wed, 15 Apr 2020 01:30:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bLmrOkcXJQ/8f3TsPjBB59Qp6PFUF6WHach7rOTidPU=; b=qG5FdkHfkXvpY6kftSmHHylorNDEVHknR9kdFCYPsOHl1jXkezsNzJb/YNQTlirUFn /FZP+oMtvC+CaBVJn+b1Ys0F/KIkiBP3o9YBSW0ed4gX8kDSqm1KA5wftMiylUdWIa/F O8ywG+70dYlkQJMV7vdgxEHR9AZR1pF8ruhvTknTzpKzVWz0JwHi6yivUK7eONAxFL+j phi4srcI2kPw/xzbHXJBf1pm5wjAyF/IpnZhNlqWgHSK+2+0uBxg2eXLy/60UxZ7tBww Nvqc31o5Y3pQAp7nzGjaR+BztCKlZ1T6UniZGOG8kLvh0u8yDgv7zGpWVOKYm07KBkXJ ubcQ== X-Gm-Message-State: AGi0PuYyCzWs9Kud/sC2VJaXlYHXHVieKEnljk38a4/dAIoLWjJUbGBO ivLYVKfK0LIHC2b+0ikmWEQKcAk0zvWNuqivuOfnhHUNdKjprXSBIZf5OVpq8ZplTyhZTLl4oCq kepzDhEs+17ROUvRVndzwqOCC1UTLGjJExoA= X-Received: by 2002:a1c:b445:: with SMTP id d66mr4126792wmf.187.1586939409338; Wed, 15 Apr 2020 01:30:09 -0700 (PDT) X-Google-Smtp-Source: APiQypI1/GFDfyQOLK5J6+00PCnZPj8fmTN9rFZPV07c4zGKdQlKsQOx+NrwNSeq7rAzMZDiU7ufeQ== X-Received: by 2002:a1c:b445:: with SMTP id d66mr4126760wmf.187.1586939409106; Wed, 15 Apr 2020 01:30:09 -0700 (PDT) Received: from localhost.localdomain ([194.230.155.238]) by smtp.gmail.com with ESMTPSA id g25sm8724053wmh.24.2020.04.15.01.30.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Apr 2020 01:30:08 -0700 (PDT) Subject: Re: [PATCH v2] kvm_host: unify VM_STAT and VCPU_STAT definitions in a single place To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , kvm@vger.kernel.org References: <20200414155625.20559-1-eesposit@redhat.com> From: Emanuele Giuseppe Esposito Message-ID: <992ede27-3eae-f2da-ad38-1d3498853ad2@redhat.com> Date: Wed, 15 Apr 2020 10:30:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200415_013017_931952_33306607 X-CRM114-Status: GOOD ( 18.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kvm-ppc@vger.kernel.org, linux-s390@vger.kernel.org, Cornelia Huck , Wanpeng Li , Janosch Frank , Suzuki K Poulose , Marc Zyngier , Joerg Roedel , David Hildenbrand , linux-kernel@vger.kernel.org, Sean Christopherson , linux-mips@vger.kernel.org, Paul Mackerras , Christian Borntraeger , James Morse , linux-arm-kernel@lists.infradead.org, Paolo Bonzini , Vitaly Kuznetsov , kvmarm@lists.cs.columbia.edu, Julien Thierry , Jim Mattson Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiA0LzE1LzIwIDg6MzYgQU0sIFBoaWxpcHBlIE1hdGhpZXUtRGF1ZMOpIHdyb3RlOgo+IE9u IDQvMTQvMjAgNTo1NiBQTSwgRW1hbnVlbGUgR2l1c2VwcGUgRXNwb3NpdG8gd3JvdGU6Cj4+IFRo ZSBtYWNyb3MgVk1fU1RBVCBhbmQgVkNQVV9TVEFUIGFyZSByZWR1bmRhbnRseSBpbXBsZW1lbnRl ZCBpbiBtdWx0aXBsZQo+PiBmaWxlcywgZWFjaCB1c2VkIGJ5IGEgZGlmZmVyZW50IGFyY2hpdGVj dXJlIHRvIGluaXRpYWxpemUgdGhlIGRlYnVnZnMKPj4gZW50cmllcyBmb3Igc3RhdGlzdGljcy4g U2luY2UgdGhleSBhbGwgaGF2ZSB0aGUgc2FtZSBwdXJwb3NlLCB0aGV5IGNhbiBiZQo+PiB1bmlm aWVkIGluIGEgc2luZ2xlIGNvbW1vbiBkZWZpbml0aW9uIGluIGluY2x1ZGUvbGludXgva3ZtX2hv c3QuaAo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBFbWFudWVsZSBHaXVzZXBwZSBFc3Bvc2l0byA8ZWVz cG9zaXRAcmVkaGF0LmNvbT4KPj4gLS0tCj4+ICAgYXJjaC9hcm02NC9rdm0vZ3Vlc3QuYyAgICB8 ICAyMyArKy0tLQo+PiAgIGFyY2gvbWlwcy9rdm0vbWlwcy5jICAgICAgfCAgNjEgKysrKysrLS0t LS0tCj4+ICAgYXJjaC9wb3dlcnBjL2t2bS9ib29rM3MuYyB8ICA2MSArKysrKystLS0tLS0KPj4g ICBhcmNoL3Bvd2VycGMva3ZtL2Jvb2tlLmMgIHwgIDQxICsrKystLS0tCj4+ICAgYXJjaC9zMzkw L2t2bS9rdm0tczM5MC5jICB8IDIwMyArKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0t LS0tLQo+PiAgIGFyY2gveDg2L2t2bS94ODYuYyAgICAgICAgfCAgODAgKysrKysrKy0tLS0tLS0t Cj4+ICAgaW5jbHVkZS9saW51eC9rdm1faG9zdC5oICB8ICAgNSArCj4+ICAgNyBmaWxlcyBjaGFu Z2VkLCAyMzEgaW5zZXJ0aW9ucygrKSwgMjQzIGRlbGV0aW9ucygtKQo+Pgo+PiBkaWZmIC0tZ2l0 IGEvYXJjaC9hcm02NC9rdm0vZ3Vlc3QuYyBiL2FyY2gvYXJtNjQva3ZtL2d1ZXN0LmMKPj4gaW5k ZXggMjNlYmU1MTQxMGYwLi44NDE3YjIwMGJlYzkgMTAwNjQ0Cj4+IC0tLSBhL2FyY2gvYXJtNjQv a3ZtL2d1ZXN0LmMKPj4gKysrIGIvYXJjaC9hcm02NC9rdm0vZ3Vlc3QuYwo+PiBAQCAtMjksMjAg KzI5LDE3IEBACj4+ICAgCj4+ICAgI2luY2x1ZGUgInRyYWNlLmgiCj4+ICAgCj4+IC0jZGVmaW5l IFZNX1NUQVQoeCkgeyAjeCwgb2Zmc2V0b2Yoc3RydWN0IGt2bSwgc3RhdC54KSwgS1ZNX1NUQVRf Vk0gfQo+PiAtI2RlZmluZSBWQ1BVX1NUQVQoeCkgeyAjeCwgb2Zmc2V0b2Yoc3RydWN0IGt2bV92 Y3B1LCBzdGF0LngpLCBLVk1fU1RBVF9WQ1BVIH0KPj4gLQo+PiAgIHN0cnVjdCBrdm1fc3RhdHNf ZGVidWdmc19pdGVtIGRlYnVnZnNfZW50cmllc1tdID0gewo+PiAtCVZDUFVfU1RBVChoYWx0X3N1 Y2Nlc3NmdWxfcG9sbCksCj4+IC0JVkNQVV9TVEFUKGhhbHRfYXR0ZW1wdGVkX3BvbGwpLAo+PiAt CVZDUFVfU1RBVChoYWx0X3BvbGxfaW52YWxpZCksCj4+IC0JVkNQVV9TVEFUKGhhbHRfd2FrZXVw KSwKPj4gLQlWQ1BVX1NUQVQoaHZjX2V4aXRfc3RhdCksCj4+IC0JVkNQVV9TVEFUKHdmZV9leGl0 X3N0YXQpLAo+PiAtCVZDUFVfU1RBVCh3ZmlfZXhpdF9zdGF0KSwKPj4gLQlWQ1BVX1NUQVQobW1p b19leGl0X3VzZXIpLAo+PiAtCVZDUFVfU1RBVChtbWlvX2V4aXRfa2VybmVsKSwKPj4gLQlWQ1BV X1NUQVQoZXhpdHMpLAo+PiArCVZDUFVfU1RBVCgiaGFsdF9zdWNjZXNzZnVsX3BvbGwiLCBoYWx0 X3N1Y2Nlc3NmdWxfcG9sbCksCj4+ICsJVkNQVV9TVEFUKCJoYWx0X2F0dGVtcHRlZF9wb2xsIiwg aGFsdF9hdHRlbXB0ZWRfcG9sbCksCj4+ICsJVkNQVV9TVEFUKCJoYWx0X3BvbGxfaW52YWxpZCIs IGhhbHRfcG9sbF9pbnZhbGlkKSwKPj4gKwlWQ1BVX1NUQVQoImhhbHRfd2FrZXVwIiwgaGFsdF93 YWtldXApLAo+PiArCVZDUFVfU1RBVCgiaHZjX2V4aXRfc3RhdCIsIGh2Y19leGl0X3N0YXQpLAo+ PiArCVZDUFVfU1RBVCgid2ZlX2V4aXRfc3RhdCIsIHdmZV9leGl0X3N0YXQpLAo+PiArCVZDUFVf U1RBVCgid2ZpX2V4aXRfc3RhdCIsIHdmaV9leGl0X3N0YXQpLAo+PiArCVZDUFVfU1RBVCgibW1p b19leGl0X3VzZXIiLCBtbWlvX2V4aXRfdXNlciksCj4+ICsJVkNQVV9TVEFUKCJtbWlvX2V4aXRf a2VybmVsIiwgbW1pb19leGl0X2tlcm5lbCksCj4+ICsJVkNQVV9TVEFUKCJleGl0cyIsIGV4aXRz KSwKPj4gICAJeyBOVUxMIH0KPj4gICB9Owo+IAo+IFBhdGNoIGVhc2lseSByZXZpZXdlZCB3aXRo IC0td29yZC1kaWZmLgo+IAo+IFsuLi5dCj4+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2xpbnV4L2t2 bV9ob3N0LmggYi9pbmNsdWRlL2xpbnV4L2t2bV9ob3N0LmgKPj4gaW5kZXggNmQ1OGJlYjY1NDU0 Li4yZTZlYWQ4NzI5NTcgMTAwNjQ0Cj4+IC0tLSBhL2luY2x1ZGUvbGludXgva3ZtX2hvc3QuaAo+ PiArKysgYi9pbmNsdWRlL2xpbnV4L2t2bV9ob3N0LmgKPj4gQEAgLTExMzAsNiArMTEzMCwxMSBA QCBzdHJ1Y3Qga3ZtX3N0YXRzX2RlYnVnZnNfaXRlbSB7Cj4+ICAgI2RlZmluZSBLVk1fREJHRlNf R0VUX01PREUoZGJnZnNfaXRlbSkgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIFwKPj4gICAJKChkYmdmc19pdGVtKS0+bW9kZSA/IChkYmdmc19pdGVtKS0+bW9kZSA6IDA2 NDQpCj4+ICAgCj4+ICsjZGVmaW5lIFZNX1NUQVQobiwgeCwgLi4uKSAJCQkJCQkJCQkJCQkJICAg XAo+PiArCXsgbiwgb2Zmc2V0b2Yoc3RydWN0IGt2bSwgc3RhdC54KSwgS1ZNX1NUQVRfVk0sICMj IF9fVkFfQVJHU19fIH0KPj4gKyNkZWZpbmUgVkNQVV9TVEFUKG4sIHgsIC4uLikJCQkJCQkJCQkJ CQkgICBcCj4gCj4gTm90IHN1cmUgd2hpbGUgeW91IHVzZSBzbyBtYW55IHdoaXRlc3BhY2VzIGhl cmUuLi4gKG1heWJlIFBhb2xvIGNhbgo+IHN0cmlwIHNvbWUgd2hlbiBhcHBseWluZz8pLgoKSSBo b25lc3RseSBhbSBub3Qgc3VyZSB3aHkgaXQgYWRkZWQgZmV3IG1vcmUgc3BhY2VzIHRoYW4gSSB3 YW50ZWQsIGJ1dCAKdGhlIGlkZWEgd2FzIHRvIGZvbGxvdyB0aGUgS1ZNX0RCR0ZTX0dFVF9NT0RF IG1hY3JvIGFib3ZlIGFuZCBwdXQgdGhlIApiYWNrc2xhc2ggYXQgdGhlIGVuZCBvZiB0aGUgbGlu ZSAoODB0aCBjaGFyKS4KCj4gCj4gT3RoZXJ3aXNlIGl0IGxvb2tzIG5pY2VyIHRoYXQgdjEsIHRo YW5rcy4KPiAKPiBSZXZpZXdlZC1ieTogUGhpbGlwcGUgTWF0aGlldS1EYXVkw6kgPGY0YnVnQGFt c2F0Lm9yZz4KPiAKPj4gKwl7IG4sIG9mZnNldG9mKHN0cnVjdCBrdm1fdmNwdSwgc3RhdC54KSwg S1ZNX1NUQVRfVkNQVSwgIyMgX19WQV9BUkdTX18gfQo+PiArCj4+ICAgZXh0ZXJuIHN0cnVjdCBr dm1fc3RhdHNfZGVidWdmc19pdGVtIGRlYnVnZnNfZW50cmllc1tdOwo+PiAgIGV4dGVybiBzdHJ1 Y3QgZGVudHJ5ICprdm1fZGVidWdmc19kaXI7Cj4+ICAgCj4+Cj4gCgoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5n IGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Emanuele Giuseppe Esposito Date: Wed, 15 Apr 2020 08:30:06 +0000 Subject: Re: [PATCH v2] kvm_host: unify VM_STAT and VCPU_STAT definitions in a single place Message-Id: <992ede27-3eae-f2da-ad38-1d3498853ad2@redhat.com> List-Id: References: <20200414155625.20559-1-eesposit@redhat.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , kvm@vger.kernel.org Cc: Marc Zyngier , James Morse , Julien Thierry , Suzuki K Poulose , Paul Mackerras , Christian Borntraeger , Janosch Frank , David Hildenbrand , Cornelia Huck , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-s390@vger.kernel.org On 4/15/20 8:36 AM, Philippe Mathieu-Daudé wrote: > On 4/14/20 5:56 PM, Emanuele Giuseppe Esposito wrote: >> The macros VM_STAT and VCPU_STAT are redundantly implemented in multiple >> files, each used by a different architecure to initialize the debugfs >> entries for statistics. Since they all have the same purpose, they can be >> unified in a single common definition in include/linux/kvm_host.h >> >> Signed-off-by: Emanuele Giuseppe Esposito >> --- >> arch/arm64/kvm/guest.c | 23 ++--- >> arch/mips/kvm/mips.c | 61 ++++++------ >> arch/powerpc/kvm/book3s.c | 61 ++++++------ >> arch/powerpc/kvm/booke.c | 41 ++++---- >> arch/s390/kvm/kvm-s390.c | 203 +++++++++++++++++++------------------- >> arch/x86/kvm/x86.c | 80 +++++++-------- >> include/linux/kvm_host.h | 5 + >> 7 files changed, 231 insertions(+), 243 deletions(-) >> >> diff --git a/arch/arm64/kvm/guest.c b/arch/arm64/kvm/guest.c >> index 23ebe51410f0..8417b200bec9 100644 >> --- a/arch/arm64/kvm/guest.c >> +++ b/arch/arm64/kvm/guest.c >> @@ -29,20 +29,17 @@ >> >> #include "trace.h" >> >> -#define VM_STAT(x) { #x, offsetof(struct kvm, stat.x), KVM_STAT_VM } >> -#define VCPU_STAT(x) { #x, offsetof(struct kvm_vcpu, stat.x), KVM_STAT_VCPU } >> - >> struct kvm_stats_debugfs_item debugfs_entries[] = { >> - VCPU_STAT(halt_successful_poll), >> - VCPU_STAT(halt_attempted_poll), >> - VCPU_STAT(halt_poll_invalid), >> - VCPU_STAT(halt_wakeup), >> - VCPU_STAT(hvc_exit_stat), >> - VCPU_STAT(wfe_exit_stat), >> - VCPU_STAT(wfi_exit_stat), >> - VCPU_STAT(mmio_exit_user), >> - VCPU_STAT(mmio_exit_kernel), >> - VCPU_STAT(exits), >> + VCPU_STAT("halt_successful_poll", halt_successful_poll), >> + VCPU_STAT("halt_attempted_poll", halt_attempted_poll), >> + VCPU_STAT("halt_poll_invalid", halt_poll_invalid), >> + VCPU_STAT("halt_wakeup", halt_wakeup), >> + VCPU_STAT("hvc_exit_stat", hvc_exit_stat), >> + VCPU_STAT("wfe_exit_stat", wfe_exit_stat), >> + VCPU_STAT("wfi_exit_stat", wfi_exit_stat), >> + VCPU_STAT("mmio_exit_user", mmio_exit_user), >> + VCPU_STAT("mmio_exit_kernel", mmio_exit_kernel), >> + VCPU_STAT("exits", exits), >> { NULL } >> }; > > Patch easily reviewed with --word-diff. > > [...] >> diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h >> index 6d58beb65454..2e6ead872957 100644 >> --- a/include/linux/kvm_host.h >> +++ b/include/linux/kvm_host.h >> @@ -1130,6 +1130,11 @@ struct kvm_stats_debugfs_item { >> #define KVM_DBGFS_GET_MODE(dbgfs_item) \ >> ((dbgfs_item)->mode ? (dbgfs_item)->mode : 0644) >> >> +#define VM_STAT(n, x, ...) \ >> + { n, offsetof(struct kvm, stat.x), KVM_STAT_VM, ## __VA_ARGS__ } >> +#define VCPU_STAT(n, x, ...) \ > > Not sure while you use so many whitespaces here... (maybe Paolo can > strip some when applying?). I honestly am not sure why it added few more spaces than I wanted, but the idea was to follow the KVM_DBGFS_GET_MODE macro above and put the backslash at the end of the line (80th char). > > Otherwise it looks nicer that v1, thanks. > > Reviewed-by: Philippe Mathieu-Daudé > >> + { n, offsetof(struct kvm_vcpu, stat.x), KVM_STAT_VCPU, ## __VA_ARGS__ } >> + >> extern struct kvm_stats_debugfs_item debugfs_entries[]; >> extern struct dentry *kvm_debugfs_dir; >> >> >