From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A085BC07E95 for ; Tue, 20 Jul 2021 07:24:59 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0B5AD6113A for ; Tue, 20 Jul 2021 07:24:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0B5AD6113A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=siemens.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2AAEA82C60; Tue, 20 Jul 2021 09:24:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=siemens.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id DE99082C63; Tue, 20 Jul 2021 09:24:54 +0200 (CEST) Received: from goliath.siemens.de (goliath.siemens.de [192.35.17.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2CF0B82C54 for ; Tue, 20 Jul 2021 09:24:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=siemens.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jan.kiszka@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id 16K7OokP000733 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 20 Jul 2021 09:24:50 +0200 Received: from [139.22.32.146] ([139.22.32.146]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 16K7OnGR032766; Tue, 20 Jul 2021 09:24:49 +0200 Subject: Re: [PATCH v3 0/5] Add SIMATIC IOT2050 board support To: Lokesh Vutla , U-Boot Mailing List Cc: Le Jin , Bao Cheng Su , Nian Gao , Chao Zeng References: <5d99f5f4-0ce3-feaa-0b42-564fe067cbde@ti.com> From: Jan Kiszka Message-ID: <99324792-4bad-5f2f-cfdc-49b6f3cb1140@siemens.com> Date: Tue, 20 Jul 2021 09:24:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <5d99f5f4-0ce3-feaa-0b42-564fe067cbde@ti.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 15.07.21 08:35, Lokesh Vutla wrote: > Hi Jan, > > On 14/07/21 3:09 pm, Jan Kiszka wrote: >> On 14.07.21 11:29, Lokesh Vutla wrote: >>> Hi Jan, >>> >>> On 12/06/21 1:12 am, Jan Kiszka wrote: >>>> This is the baseline support for the SIMATIC IOT2050 devices. >>>> >>>> Changes in v3: >>>> - rebased >>>> - addressed several checkpatch warnings >>>> - a few #ifdef -> IS_ENABLED conversions >>>> - comment marker for SPDK identifier in .S file >>>> - trailing whitespaces >>>> - factored out rti_wdt_load_fw (less #ifdef) >>> >>> I see that there is no conclusion yet for the Watchdog firmware support. But >>> that can be split out from this series IMO. Can you repost with basic support so >>> that I can merge the series. Watchdog support can be dealt separately. >> >> I will eventually look again into that loading topic, but I would also >> consider that non-critical to merge it this way first and cleanup later >> if it actually turns out to be solvable in an equivalent way (result is >> part of u-boot proper image) via binman. Even the configuration >> interface may stay the same. >> >> If you still have concerns, skip patch 4 and 5 - though that would >> affect an increasing demand of our users for this important feature. > > First 3 patches of the series throws a build error for me: > https://source.denx.de/u-boot/custodians/u-boot-ti/-/jobs/292183 > > Can you take a look? > Thanks, found and fixed - but now I'm facing a boot regression over current master. Will have to bisect this, if this is related to some config switch we are missing now or rather a real issue in the current tree. Jan -- Siemens AG, T RDA IOT Corporate Competence Center Embedded Linux