All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] irqchip/exynos-combiner: remove unnecessary oom message
@ 2021-06-09 14:03 ` Zhen Lei
  0 siblings, 0 replies; 5+ messages in thread
From: Zhen Lei @ 2021-06-09 14:03 UTC (permalink / raw)
  To: Thomas Gleixner, Marc Zyngier, Krzysztof Kozlowski,
	linux-arm-kernel, linux-samsung-soc, linux-kernel
  Cc: Zhen Lei

Fixes scripts/checkpatch.pl warning:
WARNING: Possible unnecessary 'out of memory' message

Remove it can help us save a bit of memory.

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
 drivers/irqchip/exynos-combiner.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/irqchip/exynos-combiner.c b/drivers/irqchip/exynos-combiner.c
index 14106126cbf3262..552aa04ff063123 100644
--- a/drivers/irqchip/exynos-combiner.c
+++ b/drivers/irqchip/exynos-combiner.c
@@ -177,10 +177,8 @@ static void __init combiner_init(void __iomem *combiner_base,
 	nr_irq = max_nr * IRQ_IN_COMBINER;
 
 	combiner_data = kcalloc(max_nr, sizeof (*combiner_data), GFP_KERNEL);
-	if (!combiner_data) {
-		pr_warn("%s: could not allocate combiner data\n", __func__);
+	if (!combiner_data)
 		return;
-	}
 
 	combiner_irq_domain = irq_domain_add_linear(np, nr_irq,
 				&combiner_irq_domain_ops, combiner_data);
-- 
2.26.0.106.g9fadedd



^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH 1/1] irqchip/exynos-combiner: remove unnecessary oom message
@ 2021-06-09 14:03 ` Zhen Lei
  0 siblings, 0 replies; 5+ messages in thread
From: Zhen Lei @ 2021-06-09 14:03 UTC (permalink / raw)
  To: Thomas Gleixner, Marc Zyngier, Krzysztof Kozlowski,
	linux-arm-kernel, linux-samsung-soc, linux-kernel
  Cc: Zhen Lei

Fixes scripts/checkpatch.pl warning:
WARNING: Possible unnecessary 'out of memory' message

Remove it can help us save a bit of memory.

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
 drivers/irqchip/exynos-combiner.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/irqchip/exynos-combiner.c b/drivers/irqchip/exynos-combiner.c
index 14106126cbf3262..552aa04ff063123 100644
--- a/drivers/irqchip/exynos-combiner.c
+++ b/drivers/irqchip/exynos-combiner.c
@@ -177,10 +177,8 @@ static void __init combiner_init(void __iomem *combiner_base,
 	nr_irq = max_nr * IRQ_IN_COMBINER;
 
 	combiner_data = kcalloc(max_nr, sizeof (*combiner_data), GFP_KERNEL);
-	if (!combiner_data) {
-		pr_warn("%s: could not allocate combiner data\n", __func__);
+	if (!combiner_data)
 		return;
-	}
 
 	combiner_irq_domain = irq_domain_add_linear(np, nr_irq,
 				&combiner_irq_domain_ops, combiner_data);
-- 
2.26.0.106.g9fadedd



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] irqchip/exynos-combiner: remove unnecessary oom message
  2021-06-09 14:03 ` Zhen Lei
@ 2021-06-10  6:44   ` Krzysztof Kozlowski
  -1 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2021-06-10  6:44 UTC (permalink / raw)
  To: Zhen Lei, Thomas Gleixner, Marc Zyngier, linux-arm-kernel,
	linux-samsung-soc, linux-kernel

On 09/06/2021 16:03, Zhen Lei wrote:
> Fixes scripts/checkpatch.pl warning:
> WARNING: Possible unnecessary 'out of memory' message
> 
> Remove it can help us save a bit of memory.
> 
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
>  drivers/irqchip/exynos-combiner.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/irqchip/exynos-combiner.c b/drivers/irqchip/exynos-combiner.c
> index 14106126cbf3262..552aa04ff063123 100644
> --- a/drivers/irqchip/exynos-combiner.c
> +++ b/drivers/irqchip/exynos-combiner.c
> @@ -177,10 +177,8 @@ static void __init combiner_init(void __iomem *combiner_base,
>  	nr_irq = max_nr * IRQ_IN_COMBINER;
>  
>  	combiner_data = kcalloc(max_nr, sizeof (*combiner_data), GFP_KERNEL);
> -	if (!combiner_data) {
> -		pr_warn("%s: could not allocate combiner data\n", __func__);
> +	if (!combiner_data)
>  		return;
> -	}
>  
>  	combiner_irq_domain = irq_domain_add_linear(np, nr_irq,
>  				&combiner_irq_domain_ops, combiner_data);
> 

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] irqchip/exynos-combiner: remove unnecessary oom message
@ 2021-06-10  6:44   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2021-06-10  6:44 UTC (permalink / raw)
  To: Zhen Lei, Thomas Gleixner, Marc Zyngier, linux-arm-kernel,
	linux-samsung-soc, linux-kernel

On 09/06/2021 16:03, Zhen Lei wrote:
> Fixes scripts/checkpatch.pl warning:
> WARNING: Possible unnecessary 'out of memory' message
> 
> Remove it can help us save a bit of memory.
> 
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
>  drivers/irqchip/exynos-combiner.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/irqchip/exynos-combiner.c b/drivers/irqchip/exynos-combiner.c
> index 14106126cbf3262..552aa04ff063123 100644
> --- a/drivers/irqchip/exynos-combiner.c
> +++ b/drivers/irqchip/exynos-combiner.c
> @@ -177,10 +177,8 @@ static void __init combiner_init(void __iomem *combiner_base,
>  	nr_irq = max_nr * IRQ_IN_COMBINER;
>  
>  	combiner_data = kcalloc(max_nr, sizeof (*combiner_data), GFP_KERNEL);
> -	if (!combiner_data) {
> -		pr_warn("%s: could not allocate combiner data\n", __func__);
> +	if (!combiner_data)
>  		return;
> -	}
>  
>  	combiner_irq_domain = irq_domain_add_linear(np, nr_irq,
>  				&combiner_irq_domain_ops, combiner_data);
> 

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [irqchip: irq/irqchip-next] irqchip/exynos-combiner: Remove unnecessary oom message
  2021-06-09 14:03 ` Zhen Lei
  (?)
  (?)
@ 2021-06-11 13:54 ` irqchip-bot for Zhen Lei
  -1 siblings, 0 replies; 5+ messages in thread
From: irqchip-bot for Zhen Lei @ 2021-06-11 13:54 UTC (permalink / raw)
  To: linux-kernel; +Cc: Zhen Lei, Krzysztof Kozlowski, Marc Zyngier, tglx

The following commit has been merged into the irq/irqchip-next branch of irqchip:

Commit-ID:     da30e6688dd64fabc3746e00e4a9b6f926efd5ca
Gitweb:        https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/da30e6688dd64fabc3746e00e4a9b6f926efd5ca
Author:        Zhen Lei <thunder.leizhen@huawei.com>
AuthorDate:    Wed, 09 Jun 2021 22:03:35 +08:00
Committer:     Marc Zyngier <maz@kernel.org>
CommitterDate: Fri, 11 Jun 2021 14:19:27 +01:00

irqchip/exynos-combiner: Remove unnecessary oom message

Fixes scripts/checkpatch.pl warning:
WARNING: Possible unnecessary 'out of memory' message

Remove it can help us save a bit of memory.

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20210609140335.14425-1-thunder.leizhen@huawei.com
---
 drivers/irqchip/exynos-combiner.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/irqchip/exynos-combiner.c b/drivers/irqchip/exynos-combiner.c
index 0b85d9a..256ed73 100644
--- a/drivers/irqchip/exynos-combiner.c
+++ b/drivers/irqchip/exynos-combiner.c
@@ -179,10 +179,8 @@ static void __init combiner_init(void __iomem *combiner_base,
 	nr_irq = max_nr * IRQ_IN_COMBINER;
 
 	combiner_data = kcalloc(max_nr, sizeof (*combiner_data), GFP_KERNEL);
-	if (!combiner_data) {
-		pr_warn("%s: could not allocate combiner data\n", __func__);
+	if (!combiner_data)
 		return;
-	}
 
 	combiner_irq_domain = irq_domain_add_linear(np, nr_irq,
 				&combiner_irq_domain_ops, combiner_data);

^ permalink raw reply related	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-06-11 13:54 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-09 14:03 [PATCH 1/1] irqchip/exynos-combiner: remove unnecessary oom message Zhen Lei
2021-06-09 14:03 ` Zhen Lei
2021-06-10  6:44 ` Krzysztof Kozlowski
2021-06-10  6:44   ` Krzysztof Kozlowski
2021-06-11 13:54 ` [irqchip: irq/irqchip-next] irqchip/exynos-combiner: Remove " irqchip-bot for Zhen Lei

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.