From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 307CBC4332F for ; Tue, 31 May 2022 13:17:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231594AbiEaNR5 (ORCPT ); Tue, 31 May 2022 09:17:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237966AbiEaNR4 (ORCPT ); Tue, 31 May 2022 09:17:56 -0400 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E7734F458 for ; Tue, 31 May 2022 06:17:55 -0700 (PDT) Received: by mail-ej1-x632.google.com with SMTP id n10so26604668ejk.5 for ; Tue, 31 May 2022 06:17:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=tpA42Tx44I0fnuuCprNTajRej43QyVodYuy8RXRmj7I=; b=tcsodHGz8IqIORGd0a2SWG5S+EnDeWCOTSoO1dfwXffZDM4sjNpNzUr8Jhv6fFtg2X a9eoEWUyQ4L2gsw+3vlwdu8/A58jYl80KdSs1icT9wQ1FI0VMw8x/7NfPTHk/0azGwlt fmOs1UUcFmuHnVu5/v7Z5MY1NNvrdwifxw6u1Mt/IpgcMCUBzZHy0V1QiyebL4b8RZIf hvd8gbtaYqYQcxp4Izw4u9R5eGgUPBFUMywr+nyAx2I6PcanxO4n1uMmxlq44TYivFzv haogT6bNlUA/XiY0EFY4mH6jWdPyjl4o5z/ar7CK8yM67kzYcXb3p3u9fs/Rsv83k+U6 lIbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=tpA42Tx44I0fnuuCprNTajRej43QyVodYuy8RXRmj7I=; b=IXRI8Y2CLjKsq/HqHbyT/Spt817daY9mg56exwxiCXtF2TAsL0Ri1iG/7FNUN9wcTt iBmvVunCqErwaUANNmVx9fpYLDYb1Yl1fzitrgFLo+QsHufwwz2vVNAzDQ8KAF9Mr4bd DnCZ3hsT9Y0Y4m2SyxDEKD05TYTHY4cP3WzYIdOn8vm6+6jKoKuGsvqGPGIIF0IGstZZ ZPAQgzmAAcytm+Bhw7IKTuH+E3LRRZGOwJKrRTQuPogKiogJM64fYrWUTo6RxvYrDoY8 t5FLkAkzfiFXZx2/hyScSWCVpvTOfD3q1XjRC9DbdeLtV8AQOSjt0HVBG+4qUa5Q9Aya rEHQ== X-Gm-Message-State: AOAM530xInZb+9c8rV3/jb/GwEAKxNMInhzhgoXcV5qGN+IayD/mPa7Z GUgTMu8wLSUDdXvOMarCz8CNxA== X-Google-Smtp-Source: ABdhPJxa6B5W86EzUoyr39/9kYuoZNb7bEBcDDiKZI03K64YBYD7w3EMgBY04Zh/hLOqXrEZl9XIGA== X-Received: by 2002:a17:906:c155:b0:6ff:25f9:b9b5 with SMTP id dp21-20020a170906c15500b006ff25f9b9b5mr22268410ejc.288.1654003074168; Tue, 31 May 2022 06:17:54 -0700 (PDT) Received: from [192.168.0.179] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id a25-20020a509b59000000b0042dd3bf1403sm2872641edj.54.2022.05.31.06.17.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 May 2022 06:17:53 -0700 (PDT) Message-ID: <9947e5b7-8843-1952-be93-abe67723127f@linaro.org> Date: Tue, 31 May 2022 15:17:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 1/4] dt-bindings: phy: samsung,ufs-phy: make pmu-syscon as phandle-array Content-Language: en-US To: Chanho Park , Kishon Vijay Abraham I , Vinod Koul , Alim Akhtar , Rob Herring , Krzysztof Kozlowski Cc: devicetree@vger.kernel.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org References: <20220531121913.48722-1-chanho61.park@samsung.com> <20220531121913.48722-2-chanho61.park@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <20220531121913.48722-2-chanho61.park@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 31/05/2022 14:19, Chanho Park wrote: > To support secondary ufs phy devices, we need to get an offset value > from pmu-syscon. > > Signed-off-by: Chanho Park > --- > .../devicetree/bindings/phy/samsung,ufs-phy.yaml | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml > index f6ed1a005e7a..80c3ec14375a 100644 > --- a/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml > @@ -40,9 +40,14 @@ properties: > - const: tx0_symbol_clk > > samsung,pmu-syscon: > - $ref: '/schemas/types.yaml#/definitions/phandle' > - description: phandle for PMU system controller interface, used to > - control pmu registers bits for ufs m-phy > + $ref: '/schemas/types.yaml#/definitions/phandle-array' > + items: > + - items: > + - description: phandle for PMU system controller interface, used to > + control pmu registers bits for ufs m-phy Wrong indentation. > + - description: offset of pmu control register for ufs m-phy > + description: > + can be phandle/offset pair. The offset can be optional. You made offset required, not optional. You need minItems:1 on the level of second "items". > > required: > - "#phy-cells" > @@ -63,7 +68,7 @@ examples: > compatible = "samsung,exynos7-ufs-phy"; > reg = <0x15571800 0x240>; > reg-names = "phy-pma"; > - samsung,pmu-syscon = <&pmu_system_controller>; > + samsung,pmu-syscon = <&pmu_system_controller 0x720>; > #phy-cells = <0>; > clocks = <&clock_fsys1 SCLK_COMBO_PHY_EMBEDDED_26M>, > <&clock_fsys1 PHYCLK_UFS20_RX1_SYMBOL_USER>, Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B937EC433F5 for ; Tue, 31 May 2022 13:18:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6KYTkYedb0Z4NLWCrkf3xBmKnpdTSSfRk7jNtjgmaTU=; b=J72rTpuqVW7kkE yunJz3wn4glTPAAcnVzPeeNi1twKNgOOPlc4XazMn3Q5r88TfS+WqeQdzhxgeKa1+i3xw30XXFSV7 UwUazOeuRoU+rvEIYwmB+e7JOq3Mte95qZsuikTHK8eheRFOZxen4r4zHqPnGivVmtW79dVDz8u9b DnNcKoKjkVQ/ejnZpu9jIA5rrAc04biycPPGZaYT7OEEtc4/JQuL5gYQFDesHuHuvOd9CNFYVbJcj Zp6AdASkp3nr53XccbooyEzgpeo01YOdy1Hs2Xh81VjenJlPS+nZEFsnmSagngf4xB0/HsuNmR1Sl E3zTm7OLfj3dQZjKFh3g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nw1l4-00B1Q1-3u; Tue, 31 May 2022 13:18:02 +0000 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nw1l1-00B1Mx-Ve for linux-phy@lists.infradead.org; Tue, 31 May 2022 13:18:01 +0000 Received: by mail-ej1-x62c.google.com with SMTP id gh17so26598704ejc.6 for ; Tue, 31 May 2022 06:17:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=tpA42Tx44I0fnuuCprNTajRej43QyVodYuy8RXRmj7I=; b=tcsodHGz8IqIORGd0a2SWG5S+EnDeWCOTSoO1dfwXffZDM4sjNpNzUr8Jhv6fFtg2X a9eoEWUyQ4L2gsw+3vlwdu8/A58jYl80KdSs1icT9wQ1FI0VMw8x/7NfPTHk/0azGwlt fmOs1UUcFmuHnVu5/v7Z5MY1NNvrdwifxw6u1Mt/IpgcMCUBzZHy0V1QiyebL4b8RZIf hvd8gbtaYqYQcxp4Izw4u9R5eGgUPBFUMywr+nyAx2I6PcanxO4n1uMmxlq44TYivFzv haogT6bNlUA/XiY0EFY4mH6jWdPyjl4o5z/ar7CK8yM67kzYcXb3p3u9fs/Rsv83k+U6 lIbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=tpA42Tx44I0fnuuCprNTajRej43QyVodYuy8RXRmj7I=; b=8A4eLXmyHwZLFoA6bk1IkAXjPbmHNiZcdpfFRkvxEML5lBQeKRx726ZHNAeOZZA2UI +OMbW7NVgWwwc4dBBUtYdzeXAV4uWJMbJNiFHO5KYCn9DAJ27Vu1cc9Ed6lcHEcjJysp 0qVY7vn40t5GZokMZR5/eTOQ4TI8f/byb5z51+mKdTom61xpiw+Ox7B4FShFCMNVbYR/ 4wofv9giLwU/MnTkxoMYkcKKkMPLNDUQnwpY2FJMttHNrx3c7DPklKSKfmFyOIEHW8ia QwRY+j/h4ET3DgHMs7jUsVYZtZ9yoEvyX8NAPIqvZY40/abWHl93uL5dC6oPLO4YGn1p hgeQ== X-Gm-Message-State: AOAM532YPL/O+ycz8h18srVbYKe26lfYBYQxWgHlKTrOxN8FZ804eQHB pXLfVMdK4NnI1Tdeca4MaG3giA== X-Google-Smtp-Source: ABdhPJxa6B5W86EzUoyr39/9kYuoZNb7bEBcDDiKZI03K64YBYD7w3EMgBY04Zh/hLOqXrEZl9XIGA== X-Received: by 2002:a17:906:c155:b0:6ff:25f9:b9b5 with SMTP id dp21-20020a170906c15500b006ff25f9b9b5mr22268410ejc.288.1654003074168; Tue, 31 May 2022 06:17:54 -0700 (PDT) Received: from [192.168.0.179] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id a25-20020a509b59000000b0042dd3bf1403sm2872641edj.54.2022.05.31.06.17.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 May 2022 06:17:53 -0700 (PDT) Message-ID: <9947e5b7-8843-1952-be93-abe67723127f@linaro.org> Date: Tue, 31 May 2022 15:17:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 1/4] dt-bindings: phy: samsung,ufs-phy: make pmu-syscon as phandle-array Content-Language: en-US To: Chanho Park , Kishon Vijay Abraham I , Vinod Koul , Alim Akhtar , Rob Herring , Krzysztof Kozlowski Cc: devicetree@vger.kernel.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org References: <20220531121913.48722-1-chanho61.park@samsung.com> <20220531121913.48722-2-chanho61.park@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <20220531121913.48722-2-chanho61.park@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220531_061800_143904_E224B08D X-CRM114-Status: GOOD ( 14.46 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On 31/05/2022 14:19, Chanho Park wrote: > To support secondary ufs phy devices, we need to get an offset value > from pmu-syscon. > > Signed-off-by: Chanho Park > --- > .../devicetree/bindings/phy/samsung,ufs-phy.yaml | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml > index f6ed1a005e7a..80c3ec14375a 100644 > --- a/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml > @@ -40,9 +40,14 @@ properties: > - const: tx0_symbol_clk > > samsung,pmu-syscon: > - $ref: '/schemas/types.yaml#/definitions/phandle' > - description: phandle for PMU system controller interface, used to > - control pmu registers bits for ufs m-phy > + $ref: '/schemas/types.yaml#/definitions/phandle-array' > + items: > + - items: > + - description: phandle for PMU system controller interface, used to > + control pmu registers bits for ufs m-phy Wrong indentation. > + - description: offset of pmu control register for ufs m-phy > + description: > + can be phandle/offset pair. The offset can be optional. You made offset required, not optional. You need minItems:1 on the level of second "items". > > required: > - "#phy-cells" > @@ -63,7 +68,7 @@ examples: > compatible = "samsung,exynos7-ufs-phy"; > reg = <0x15571800 0x240>; > reg-names = "phy-pma"; > - samsung,pmu-syscon = <&pmu_system_controller>; > + samsung,pmu-syscon = <&pmu_system_controller 0x720>; > #phy-cells = <0>; > clocks = <&clock_fsys1 SCLK_COMBO_PHY_EMBEDDED_26M>, > <&clock_fsys1 PHYCLK_UFS20_RX1_SYMBOL_USER>, Best regards, Krzysztof -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94D1BC433EF for ; Tue, 31 May 2022 13:19:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JL4ozW5Gf4noPO6WpL7lnreCupZUt5llDssb6EvQiVA=; b=eDvFiFXeTP5Y23 VSMX/N1fIFK7MLj7FQYpPLLXd/pgfLhlfPTWyxh+tLCk0cx/YM/xb1pkpdFum9fqgI9XbwV3X9GbS rpfNQKq0Z+OevFmclzfl2kb0G4ynZ2dpCRRYK9cIQKlM4gmb7o8DFyMQ9EUgsMun09E+psWxh1yBT bUV5QJ7bh+VdG5lCaKE08xhnrsNmt7eYOo26wg8pBftM6zf1d7h0YXsXaFUFAQ3hyUPieqDuoxu2T AM/1Go99ThiXhoyLOK8C5kjWnOfeiyEo0URrdBWriZRa2CLUmTt9FahEnp/RKDWoFBZwodVi5ZwOi jPjGRX2u+5tRDaE93NKg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nw1l4-00B1QA-PV; Tue, 31 May 2022 13:18:02 +0000 Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nw1l1-00B1Mu-Vf for linux-arm-kernel@lists.infradead.org; Tue, 31 May 2022 13:18:01 +0000 Received: by mail-ej1-x62e.google.com with SMTP id u12so905453eja.8 for ; Tue, 31 May 2022 06:17:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=tpA42Tx44I0fnuuCprNTajRej43QyVodYuy8RXRmj7I=; b=tcsodHGz8IqIORGd0a2SWG5S+EnDeWCOTSoO1dfwXffZDM4sjNpNzUr8Jhv6fFtg2X a9eoEWUyQ4L2gsw+3vlwdu8/A58jYl80KdSs1icT9wQ1FI0VMw8x/7NfPTHk/0azGwlt fmOs1UUcFmuHnVu5/v7Z5MY1NNvrdwifxw6u1Mt/IpgcMCUBzZHy0V1QiyebL4b8RZIf hvd8gbtaYqYQcxp4Izw4u9R5eGgUPBFUMywr+nyAx2I6PcanxO4n1uMmxlq44TYivFzv haogT6bNlUA/XiY0EFY4mH6jWdPyjl4o5z/ar7CK8yM67kzYcXb3p3u9fs/Rsv83k+U6 lIbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=tpA42Tx44I0fnuuCprNTajRej43QyVodYuy8RXRmj7I=; b=pLKgh3/AEy7liECaS9RwpKZ3c3mIhjtTm7elJwXh9kucFcaNC01gf9w4ckBhaIxOGU eJ7tJZqT878O7Eo+fa07ugYxbYOjW6jkzZW+7nq6OC6iszlyeRJCAz7/W0LHXsg2pmqq ZASAuY52sUbfQii2nZKrH6isELI26psGmOq9q7ZO0YH2i4iw2p64YVvK6k2nL3208Zjm 6wcTVL3D6BMvciFghkJUVKRG2dVk8KWKxu9r+XqEX+6I6DFA7TONEXa5Td4Mo6/jTKUR TETuEwJSRv+IDyO/kmAV4cpVzy5DJNiANFJ45IeE9z6nSK6hxAjPBLwo+KOZmwHnfPiD RPOQ== X-Gm-Message-State: AOAM530WodeAOKP39VDHmG4VApVkzqYsy2J/LHSQyM8p9kwe5fZgRPZJ yPszew0vXz3JW1gI3wLy7qrgaQ== X-Google-Smtp-Source: ABdhPJxa6B5W86EzUoyr39/9kYuoZNb7bEBcDDiKZI03K64YBYD7w3EMgBY04Zh/hLOqXrEZl9XIGA== X-Received: by 2002:a17:906:c155:b0:6ff:25f9:b9b5 with SMTP id dp21-20020a170906c15500b006ff25f9b9b5mr22268410ejc.288.1654003074168; Tue, 31 May 2022 06:17:54 -0700 (PDT) Received: from [192.168.0.179] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id a25-20020a509b59000000b0042dd3bf1403sm2872641edj.54.2022.05.31.06.17.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 May 2022 06:17:53 -0700 (PDT) Message-ID: <9947e5b7-8843-1952-be93-abe67723127f@linaro.org> Date: Tue, 31 May 2022 15:17:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 1/4] dt-bindings: phy: samsung,ufs-phy: make pmu-syscon as phandle-array Content-Language: en-US To: Chanho Park , Kishon Vijay Abraham I , Vinod Koul , Alim Akhtar , Rob Herring , Krzysztof Kozlowski Cc: devicetree@vger.kernel.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org References: <20220531121913.48722-1-chanho61.park@samsung.com> <20220531121913.48722-2-chanho61.park@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <20220531121913.48722-2-chanho61.park@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220531_061800_140626_9292AB6A X-CRM114-Status: GOOD ( 15.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 31/05/2022 14:19, Chanho Park wrote: > To support secondary ufs phy devices, we need to get an offset value > from pmu-syscon. > > Signed-off-by: Chanho Park > --- > .../devicetree/bindings/phy/samsung,ufs-phy.yaml | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml > index f6ed1a005e7a..80c3ec14375a 100644 > --- a/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml > @@ -40,9 +40,14 @@ properties: > - const: tx0_symbol_clk > > samsung,pmu-syscon: > - $ref: '/schemas/types.yaml#/definitions/phandle' > - description: phandle for PMU system controller interface, used to > - control pmu registers bits for ufs m-phy > + $ref: '/schemas/types.yaml#/definitions/phandle-array' > + items: > + - items: > + - description: phandle for PMU system controller interface, used to > + control pmu registers bits for ufs m-phy Wrong indentation. > + - description: offset of pmu control register for ufs m-phy > + description: > + can be phandle/offset pair. The offset can be optional. You made offset required, not optional. You need minItems:1 on the level of second "items". > > required: > - "#phy-cells" > @@ -63,7 +68,7 @@ examples: > compatible = "samsung,exynos7-ufs-phy"; > reg = <0x15571800 0x240>; > reg-names = "phy-pma"; > - samsung,pmu-syscon = <&pmu_system_controller>; > + samsung,pmu-syscon = <&pmu_system_controller 0x720>; > #phy-cells = <0>; > clocks = <&clock_fsys1 SCLK_COMBO_PHY_EMBEDDED_26M>, > <&clock_fsys1 PHYCLK_UFS20_RX1_SYMBOL_USER>, Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel