From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8F4BC64E75 for ; Mon, 16 Nov 2020 14:35:27 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 593A420706 for ; Mon, 16 Nov 2020 14:35:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dfQNvyNh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 593A420706 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46980 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kefbK-00057U-8j for qemu-devel@archiver.kernel.org; Mon, 16 Nov 2020 09:35:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59664) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kefZw-0004X0-1A for qemu-devel@nongnu.org; Mon, 16 Nov 2020 09:34:00 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:30489) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kefZt-0007g7-D1 for qemu-devel@nongnu.org; Mon, 16 Nov 2020 09:33:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605537236; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZMjHWkaUogV8kmId/9AtqVBdQ3z2mMu/a555HUu6U40=; b=dfQNvyNhd3HW3x/SUfPc9oU7q8Aq3mqvghFWPATAPFjtF2/Yw9g+U2ov7ygtiMXJmOVv+0 UwyAlLv29sSppY1g774vMsxYpi8GRbhNbtvCOW3OBrAT8BajPavRJlzinqxhblxvXBO0lD yWLR8QlFnDsziXmwBvut5ImX91/iEPE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-204-pSE7KwDhMu2u8wzbdejdZw-1; Mon, 16 Nov 2020 09:33:52 -0500 X-MC-Unique: pSE7KwDhMu2u8wzbdejdZw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DF609801FDA; Mon, 16 Nov 2020 14:33:50 +0000 (UTC) Received: from thuth.remote.csb (ovpn-113-126.ams2.redhat.com [10.36.113.126]) by smtp.corp.redhat.com (Postfix) with ESMTP id BDFCC1002D59; Mon, 16 Nov 2020 14:33:43 +0000 (UTC) Subject: Re: [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category To: Peter Maydell , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= References: <20201115184903.1292715-1-ganqixin@huawei.com> <20201115184903.1292715-14-ganqixin@huawei.com> From: Thomas Huth Message-ID: <9958130f-b6cd-ca91-f0af-9e3a916bfc8b@redhat.com> Date: Mon, 16 Nov 2020 15:33:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/16 04:46:27 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Trivial , "Chenqun \(kuhn\)" , QEMU Developers , Gan Qixin , zhanghailiang Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 16/11/2020 14.31, Peter Maydell wrote: > On Mon, 16 Nov 2020 at 13:28, Philippe Mathieu-Daudé wrote: >> Well, this is not an usable device but a part of a bigger device, >> so here we want the opposite: not list this device in any category. >> >> Maybe we could add a DEVICE_CATEGORY_COMPOSITE for all such QOM >> types so management apps can filter them out? (And so we are sure >> all QOM is classified). >> >> Thomas, you already dealt with categorizing devices in the past, >> what do you think about this? Who else could help? Maybe add >> someone from libvirt in the thread? > > If we could get to the point where we can assert() that > dc->categories is non-zero in class init, we would be able > to avoid further "forgot to categorize device" bugs getting > into the tree in future, which seems like an argument for > having some way of marking "really just an implementation > detail" devices I guess? IMHO we need: assert(dc->user_creatable == false || categories != 0) then we don't need something like DEVICE_CATEGORY_COMPOSITE. Thomas