From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35742) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c6Z5L-0006Vw-Il for qemu-devel@nongnu.org; Tue, 15 Nov 2016 03:27:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c6Z5I-0000oL-El for qemu-devel@nongnu.org; Tue, 15 Nov 2016 03:27:19 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:51020) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c6Z5I-0000oE-6T for qemu-devel@nongnu.org; Tue, 15 Nov 2016 03:27:16 -0500 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id uAF8Q96u046970 for ; Tue, 15 Nov 2016 03:27:14 -0500 Received: from e06smtp06.uk.ibm.com (e06smtp06.uk.ibm.com [195.75.94.102]) by mx0a-001b2d01.pphosted.com with ESMTP id 26qxr4g9na-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 15 Nov 2016 03:27:14 -0500 Received: from localhost by e06smtp06.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 15 Nov 2016 08:27:12 -0000 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 67AAB17D805A for ; Tue, 15 Nov 2016 08:29:34 +0000 (GMT) Received: from d06av03.portsmouth.uk.ibm.com (d06av03.portsmouth.uk.ibm.com [9.149.37.213]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id uAF8RAua43253824 for ; Tue, 15 Nov 2016 08:27:10 GMT Received: from d06av03.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av03.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id uAF8R9Iv007348 for ; Tue, 15 Nov 2016 01:27:10 -0700 References: <1477850917-1214-1-git-send-email-mst@redhat.com> <1477850917-1214-13-git-send-email-mst@redhat.com> <925e80d1-f936-4519-9490-9c40d129392e@de.ibm.com> <75f9936a-443a-79ee-8e44-ff4b93ab66bc@redhat.com> From: Christian Borntraeger Date: Tue, 15 Nov 2016 09:27:08 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Message-Id: <995f9b5c-abc0-927c-f164-c815a1f8b038@de.ibm.com> Subject: Re: [Qemu-devel] [PULL 12/47] virtio: remove ioeventfd_disabled altogether List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , "Michael S. Tsirkin" , qemu-devel@nongnu.org Cc: Cornelia Huck , Peter Maydell , Farhan Ali On 11/10/2016 03:48 PM, Christian Borntraeger wrote: > On 11/10/2016 03:38 PM, Paolo Bonzini wrote: >> >> >> On 10/11/2016 15:35, Christian Borntraeger wrote: >>> On 10/30/2016 10:23 PM, Michael S. Tsirkin wrote: >>>> From: Paolo Bonzini >>>> >>>> Now that there is not anymore a switch from the generic ioeventfd handler >>>> to the dataplane handler, virtio_bus_set_host_notifier(assign=true) is >>>> always called with !bus->ioeventfd_started, hence virtio_bus_stop_ioeventfd >>>> does nothing in this case. Move the invocation to vhost.c, which is the >>>> only place that needs it. >>>> >>>> Reviewed-by: Cornelia Huck >>>> Signed-off-by: Paolo Bonzini >>>> Reviewed-by: Michael S. Tsirkin >>>> Signed-off-by: Michael S. Tsirkin >>>> --- >>>> include/hw/virtio/virtio-bus.h | 6 ------ >>>> hw/virtio/vhost.c | 3 +++ >>>> hw/virtio/virtio-bus.c | 23 ++++++++--------------- >>>> 3 files changed, 11 insertions(+), 21 deletions(-) >>> >>> This breaks vhost-net for s390/kvm after rebooting the guest. (ping fails and >>> ifconfig shows no packets is TXed) >>> >>> Any idea? >> >> Patch from Felipe: >> [PATCH v2] vhost: Update 'ioeventfd_started' with host notifiers >> >> Paolo > > Yes, that fixes the issue > hmm, not quite. This patch on top of commit 6bbcb76301a72dc80c8d29af13d40bb9a759c9c6 MAINTAINERS: Remove obsolete stable branches still triggers qemu-system-s390x: hw/s390x/virtio-ccw.c:1076: virtio_ccw_remove_irqfd: Assertion `ret == 0' failed. for some cases according to Farhan. There are too many patches floating around, what is the latest assumed to be final patch set? We can then test that. Thanks Christian