From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Hakan Jansson <hakan.jansson@infineon.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: net: broadcom-bluetooth: Add property for autobaud mode
Date: Sun, 22 May 2022 10:14:02 +0200 [thread overview]
Message-ID: <996ac5f2-3cf3-e67a-144b-4fdac9bbc20d@linaro.org> (raw)
In-Reply-To: <cb20a6f49c91521d54c847ee4dc14451b0ee91dd.1653057480.git.hakan.jansson@infineon.com>
On 20/05/2022 17:07, Hakan Jansson wrote:
> Some devices (e.g. CYW5557x) require autobaud mode to enable FW loading.
Which devices support this? You probably need allOf:if:then.
> Autobaud mode can also be required on some boards where the controller
> device is using a non-standard baud rate when first powered on.
>
> This patch adds a property, "brcm,uses-autobaud-mode", to enable autobaud
> mode selection.
Don't use "This patch":
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
>
> Signed-off-by: Hakan Jansson <hakan.jansson@infineon.com>
> ---
> V1 -> V2: Modify property description
>
> .../devicetree/bindings/net/broadcom-bluetooth.yaml | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml b/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml
> index 5aac094fd217..a29f059c21cc 100644
> --- a/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml
> +++ b/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml
> @@ -92,6 +92,15 @@ properties:
> pcm-sync-mode: slave, master
> pcm-clock-mode: slave, master
>
> + brcm,uses-autobaud-mode:
Based on description, I understand the host triggers using autobaud.
However here you word it as "uses", so it is independent of host, it
looks like property of a device. The commit msg describes it even
different - "require autobaud".
This leads to second issue - it looks like there is some hardware
property (requiring to use autobaud) which should be described by
bindings. But instead you describe desired operational feature.
> + type: boolean
> + description: >
No need for '>'.
> + Setting this property will make the host (driver) assert the controller
> + chip's BT_UART_CTS_N prior to asserting BT_REG_ON. This will make the
> + controller start up in autobaud mode. The controller will then detect the
> + baud rate of the first incoming (HCI Reset) command from the host and
> + subsequently use that baud rate.
> +
> interrupts:
> items:
> - description: Handle to the line HOST_WAKE used to wake
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-05-22 8:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 15:07 [PATCH v2 0/2] Bluetooth: hci_bcm: Autobaud mode support Hakan Jansson
2022-05-20 15:07 ` [PATCH v2 1/2] dt-bindings: net: broadcom-bluetooth: Add property for autobaud mode Hakan Jansson
2022-05-20 16:09 ` Bluetooth: hci_bcm: Autobaud mode support bluez.test.bot
2022-05-22 8:14 ` Krzysztof Kozlowski [this message]
2022-05-23 9:21 ` [PATCH v2 1/2] dt-bindings: net: broadcom-bluetooth: Add property for autobaud mode Hakan Jansson
2022-05-30 7:44 ` Krzysztof Kozlowski
2022-05-20 15:07 ` [PATCH v2 2/2] Bluetooth: hci_bcm: Add support for FW loading in " Hakan Jansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=996ac5f2-3cf3-e67a-144b-4fdac9bbc20d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=hakan.jansson@infineon.com \
--cc=johan.hedberg@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.