From: Amit Salecha <amit.salecha@qlogic.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Ameen Rahman <ameen.rahman@qlogic.com>,
Anirban Chakraborty <anirban.chakraborty@qlogic.com>,
David Miller <davem@davemloft.net>
Subject: RE: [PATCH] qlcnic: dont assume NET_IP_ALIGN is 2
Date: Mon, 20 Sep 2010 06:16:31 -0500 [thread overview]
Message-ID: <99737F4847ED0A48AECC9F4A1974A4B80F86F8018D@MNEXMB2.qlogic.org> (raw)
In-Reply-To: <1284717448.3391.75.camel@edumazet-laptop>
> -----Original Message-----
> From: Eric Dumazet [mailto:eric.dumazet@gmail.com]
> Sent: Friday, September 17, 2010 3:27 PM
> To: Amit Salecha
> Cc: netdev@vger.kernel.org; Ameen Rahman; Anirban Chakraborty; David
> Miller
> Subject: [PATCH] qlcnic: dont assume NET_IP_ALIGN is 2
>
> Amit, I noticed following bug in qlnic driver.
>
> Also, skb->truesize should not be changed by drivers, unless dealing
> with fragments.
>
> When you have :
> skb->truesize = skb->len + sizeof(struct sk_buff);
>
> you are lying to stack that can queue many "small" UDP packets,
> accouting for small packets in socket rcvbuf, while the truesize was
> really 1532 + sizeof(struct sk_buff)
>
> Could you take a look ?
>
>
This can be cleaned up.
Though I have one doubt. We are allocating larger packets than the actual data used.
Doesn't it will break accounting ?
-Amit
next prev parent reply other threads:[~2010-09-20 11:16 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-17 5:14 [PATCHv2 NEXT 0/5]qlcnic: vlan rx accleration support Amit Kumar Salecha
2010-09-17 5:14 ` [PATCHv2 NEXT 1/5] qlcnic: support vlan rx accleration Amit Kumar Salecha
2010-09-17 5:29 ` Eric Dumazet
2010-09-17 9:57 ` [PATCH] qlcnic: dont assume NET_IP_ALIGN is 2 Eric Dumazet
2010-09-17 10:53 ` Amit Salecha
2010-09-18 5:58 ` David Miller
2010-09-20 11:16 ` Amit Salecha [this message]
2010-09-20 12:18 ` Eric Dumazet
2010-09-20 12:28 ` [PATCH net-next-2.6] qlnic: dont set skb->truesize Eric Dumazet
2010-09-20 17:09 ` David Miller
2010-09-20 15:58 ` [PATCH] qlcnic: dont assume NET_IP_ALIGN is 2 David Miller
2010-09-21 8:19 ` Amit Salecha
2010-09-21 8:34 ` Eric Dumazet
2010-09-21 8:41 ` Amit Salecha
2010-09-21 9:23 ` Eric Dumazet
2010-09-21 19:33 ` David Miller
2010-09-21 19:55 ` [PATCH] netxen: dont set skb->truesize Eric Dumazet
2010-09-21 20:04 ` David Miller
2010-09-17 5:14 ` [PATCHv2 NEXT 2/5] qlcnic: vlan gro support Amit Kumar Salecha
2010-09-17 18:24 ` David Miller
2010-09-17 18:25 ` David Miller
2010-09-17 5:14 ` [PATCHv2 NEXT 3/5] qlcnic: vlan lro support Amit Kumar Salecha
2010-09-17 5:14 ` [PATCHv2 NEXT 4/5] qlcnic: remove fw version check Amit Kumar Salecha
2010-09-17 5:14 ` [PATCHv2 NEXT 5/5] qlcnic: update version 5.0.10 Amit Kumar Salecha
2010-09-17 18:31 ` [PATCHv2 NEXT 0/5]qlcnic: vlan rx accleration support David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99737F4847ED0A48AECC9F4A1974A4B80F86F8018D@MNEXMB2.qlogic.org \
--to=amit.salecha@qlogic.com \
--cc=ameen.rahman@qlogic.com \
--cc=anirban.chakraborty@qlogic.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.