From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B95AC4332F for ; Mon, 3 Jan 2022 06:27:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231868AbiACG1i (ORCPT ); Mon, 3 Jan 2022 01:27:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229505AbiACG1h (ORCPT ); Mon, 3 Jan 2022 01:27:37 -0500 Received: from mail.marcansoft.com (marcansoft.com [IPv6:2a01:298:fe:f::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2FBB9C061761; Sun, 2 Jan 2022 22:27:37 -0800 (PST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: marcan@marcan.st) by mail.marcansoft.com (Postfix) with ESMTPSA id 6FC5D42528; Mon, 3 Jan 2022 06:27:27 +0000 (UTC) Message-ID: <9974e68b-f591-81ec-d91f-1b9b14c09edd@marcan.st> Date: Mon, 3 Jan 2022 15:27:25 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [RFC PATCH 00/34] brcmfmac: Support Apple T2 and M1 platforms Content-Language: en-US To: Linus Walleij Cc: Kalle Valo , "David S. Miller" , Jakub Kicinski , Rob Herring , "Rafael J. Wysocki" , Len Brown , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-hsien Lin , Wright Feng , Sven Peter , Alyssa Rosenzweig , Mark Kettenis , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Pieter-Paul Giesberts , Hans de Goede , "John W. Linville" , "brian m. carlson" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com References: <20211226153624.162281-1-marcan@marcan.st> From: Hector Martin In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2022/01/02 15:25, Linus Walleij wrote: > On Sun, Dec 26, 2021 at 4:36 PM Hector Martin wrote: > >> Merry Christmas! This year Santa brings us a 34-patch series to add >> proper support for the Broadcom FullMAC chips used on Apple T2 and M1 >> platforms: > > I tried to review as best I could, when I think I know what I'm doing I state > Reviewed-by and when I think it just LooksGoodToMe(TM) I replied > Acked-by. If I missed some patch you can assume Acked-by from me > on these as well. > > Thanks for doing this, some really old bugs and code improvements long > overdue is in the series, much appreciated. > > Yours, > Linus Walleij > Thanks for the comprehensive review! I'm glad this all makes some sense and I'm not crazy about the approach :) I'll wait a bit for any other feedback that might come in and then submit a v2 with the fixes/changes mentioned so far. Cheers, -- Hector Martin (marcan@marcan.st) Public Key: https://mrcn.st/pub