From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from perceval.ideasonboard.com ([213.167.242.64]:37772 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759305AbeD0VrM (ORCPT ); Fri, 27 Apr 2018 17:47:12 -0400 From: Laurent Pinchart To: Kieran Bingham Cc: Laurent Pinchart , linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH v2 1/8] v4l: vsp1: Use SPDX license headers Date: Sat, 28 Apr 2018 00:47:25 +0300 Message-ID: <9975058.6n0K4TYcZK@avalon> In-Reply-To: <45a7f1d7-9802-9b3b-c964-2f37c113cc8e@ideasonboard.com> References: <20180422223430.16407-1-laurent.pinchart+renesas@ideasonboard.com> <20180422223430.16407-2-laurent.pinchart+renesas@ideasonboard.com> <45a7f1d7-9802-9b3b-c964-2f37c113cc8e@ideasonboard.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Sender: linux-media-owner@vger.kernel.org List-ID: Hi Kieran, On Saturday, 28 April 2018 00:25:51 EEST Kieran Bingham wrote: > Hi Laurent, >=20 > Thank you for the patch, and going through the whole driver for this upda= te. > On 22/04/18 23:34, Laurent Pinchart wrote: > > Adopt the SPDX license identifier headers to ease license compliance > > management. All files in the driver are licensed under the GPLv2+ except > > for the vsp1_regs.h file which is licensed under the GPLv2. This is > > likely an oversight, but fixing this requires contacting the copyright > > owners and is out of scope for this patch. >=20 > I agree that's out of scope for this patch, but it's not too exhaustive a > list to correct at a later date: >=20 > git shortlog -e -n -s -- ./drivers/media/platform/vsp1/vsp1_regs.h > 19 Laurent Pinchart > 5 Nobuhiro Iwamatsu > 3 Kieran Bingham > 2 Geert Uytterhoeven > 2 Sergei Shtylyov > 1 Linus Torvalds > 1 Niklas S=F6derlund > 1 Wolfram Sang >=20 > (Both Geert and Linus are merge commits there) I agree with you, I've sent a separate patch. > > While at it fix the file descriptions to match file names where copy and > > paste error occurred. > >=20 > > Signed-off-by: Laurent Pinchart > > >=20 > It's crazy that we have two types of comment style for the SPDX identifie= r - > but that's not a fault in this patch, so: >=20 > Reviewed-by: Kieran Bingham >=20 > > --- > >=20 > > drivers/media/platform/vsp1/vsp1.h | 6 +----- > > drivers/media/platform/vsp1/vsp1_brx.c | 6 +----- > > drivers/media/platform/vsp1/vsp1_brx.h | 6 +----- > > drivers/media/platform/vsp1/vsp1_clu.c | 6 +----- > > drivers/media/platform/vsp1/vsp1_clu.h | 6 +----- > > drivers/media/platform/vsp1/vsp1_dl.c | 8 ++------ > > drivers/media/platform/vsp1/vsp1_dl.h | 6 +----- > > drivers/media/platform/vsp1/vsp1_drm.c | 8 ++------ > > drivers/media/platform/vsp1/vsp1_drm.h | 6 +----- > > drivers/media/platform/vsp1/vsp1_drv.c | 6 +----- > > drivers/media/platform/vsp1/vsp1_entity.c | 6 +----- > > drivers/media/platform/vsp1/vsp1_entity.h | 6 +----- > > drivers/media/platform/vsp1/vsp1_hgo.c | 6 +----- > > drivers/media/platform/vsp1/vsp1_hgo.h | 6 +----- > > drivers/media/platform/vsp1/vsp1_hgt.c | 6 +----- > > drivers/media/platform/vsp1/vsp1_hgt.h | 6 +----- > > drivers/media/platform/vsp1/vsp1_histo.c | 6 +----- > > drivers/media/platform/vsp1/vsp1_histo.h | 6 +----- > > drivers/media/platform/vsp1/vsp1_hsit.c | 6 +----- > > drivers/media/platform/vsp1/vsp1_hsit.h | 6 +----- > > drivers/media/platform/vsp1/vsp1_lif.c | 6 +----- > > drivers/media/platform/vsp1/vsp1_lif.h | 6 +----- > > drivers/media/platform/vsp1/vsp1_lut.c | 6 +----- > > drivers/media/platform/vsp1/vsp1_lut.h | 6 +----- > > drivers/media/platform/vsp1/vsp1_pipe.c | 6 +----- > > drivers/media/platform/vsp1/vsp1_pipe.h | 6 +----- > > drivers/media/platform/vsp1/vsp1_regs.h | 5 +---- > > drivers/media/platform/vsp1/vsp1_rpf.c | 6 +----- > > drivers/media/platform/vsp1/vsp1_rwpf.c | 6 +----- > > drivers/media/platform/vsp1/vsp1_rwpf.h | 6 +----- > > drivers/media/platform/vsp1/vsp1_sru.c | 6 +----- > > drivers/media/platform/vsp1/vsp1_sru.h | 6 +----- > > drivers/media/platform/vsp1/vsp1_uds.c | 6 +----- > > drivers/media/platform/vsp1/vsp1_uds.h | 6 +----- > > drivers/media/platform/vsp1/vsp1_video.c | 6 +----- > > drivers/media/platform/vsp1/vsp1_video.h | 6 +----- > > drivers/media/platform/vsp1/vsp1_wpf.c | 6 +----- > > 37 files changed, 39 insertions(+), 186 deletions(-) =2D-=20 Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v2 1/8] v4l: vsp1: Use SPDX license headers Date: Sat, 28 Apr 2018 00:47:25 +0300 Message-ID: <9975058.6n0K4TYcZK@avalon> References: <20180422223430.16407-1-laurent.pinchart+renesas@ideasonboard.com> <20180422223430.16407-2-laurent.pinchart+renesas@ideasonboard.com> <45a7f1d7-9802-9b3b-c964-2f37c113cc8e@ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id 403346EAEF for ; Fri, 27 Apr 2018 21:47:12 +0000 (UTC) In-Reply-To: <45a7f1d7-9802-9b3b-c964-2f37c113cc8e@ideasonboard.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Kieran Bingham Cc: linux-renesas-soc@vger.kernel.org, Laurent Pinchart , dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org SGkgS2llcmFuLAoKT24gU2F0dXJkYXksIDI4IEFwcmlsIDIwMTggMDA6MjU6NTEgRUVTVCBLaWVy YW4gQmluZ2hhbSB3cm90ZToKPiBIaSBMYXVyZW50LAo+IAo+IFRoYW5rIHlvdSBmb3IgdGhlIHBh dGNoLCBhbmQgZ29pbmcgdGhyb3VnaCB0aGUgd2hvbGUgZHJpdmVyIGZvciB0aGlzIHVwZGF0ZS4K PiBPbiAyMi8wNC8xOCAyMzozNCwgTGF1cmVudCBQaW5jaGFydCB3cm90ZToKPiA+IEFkb3B0IHRo ZSBTUERYIGxpY2Vuc2UgaWRlbnRpZmllciBoZWFkZXJzIHRvIGVhc2UgbGljZW5zZSBjb21wbGlh bmNlCj4gPiBtYW5hZ2VtZW50LiBBbGwgZmlsZXMgaW4gdGhlIGRyaXZlciBhcmUgbGljZW5zZWQg dW5kZXIgdGhlIEdQTHYyKyBleGNlcHQKPiA+IGZvciB0aGUgdnNwMV9yZWdzLmggZmlsZSB3aGlj aCBpcyBsaWNlbnNlZCB1bmRlciB0aGUgR1BMdjIuIFRoaXMgaXMKPiA+IGxpa2VseSBhbiBvdmVy c2lnaHQsIGJ1dCBmaXhpbmcgdGhpcyByZXF1aXJlcyBjb250YWN0aW5nIHRoZSBjb3B5cmlnaHQK PiA+IG93bmVycyBhbmQgaXMgb3V0IG9mIHNjb3BlIGZvciB0aGlzIHBhdGNoLgo+IAo+IEkgYWdy ZWUgdGhhdCdzIG91dCBvZiBzY29wZSBmb3IgdGhpcyBwYXRjaCwgYnV0IGl0J3Mgbm90IHRvbyBl eGhhdXN0aXZlIGEKPiBsaXN0IHRvIGNvcnJlY3QgYXQgYSBsYXRlciBkYXRlOgo+IAo+IGdpdCBz aG9ydGxvZyAtZSAtbiAtcyAtLSAuL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vdnNwMS92c3AxX3Jl Z3MuaAo+ICAgICAxOSAgTGF1cmVudCBQaW5jaGFydCA8bGF1cmVudC5waW5jaGFydCtyZW5lc2Fz QGlkZWFzb25ib2FyZC5jb20+Cj4gICAgICA1ICBOb2J1aGlybyBJd2FtYXRzdSA8bm9idWhpcm8u aXdhbWF0c3UueWpAcmVuZXNhcy5jb20+Cj4gICAgICAzICBLaWVyYW4gQmluZ2hhbSA8a2llcmFu LmJpbmdoYW0rcmVuZXNhc0BpZGVhc29uYm9hcmQuY29tPgo+ICAgICAgMiAgR2VlcnQgVXl0dGVy aG9ldmVuIDxnZWVydCtyZW5lc2FzQGdsaWRlci5iZT4KPiAgICAgIDIgIFNlcmdlaSBTaHR5bHlv diA8c2VyZ2VpLnNodHlseW92QGNvZ2VudGVtYmVkZGVkLmNvbT4KPiAgICAgIDEgIExpbnVzIFRv cnZhbGRzIDx0b3J2YWxkc0BsaW51eC1mb3VuZGF0aW9uLm9yZz4KPiAgICAgIDEgIE5pa2xhcyBT w7ZkZXJsdW5kIDxuaWtsYXMuc29kZXJsdW5kK3JlbmVzYXNAcmFnbmF0ZWNoLnNlPgo+ICAgICAg MSAgV29sZnJhbSBTYW5nIDx3c2ErcmVuZXNhc0BzYW5nLWVuZ2luZWVyaW5nLmNvbT4KPiAKPiAo Qm90aCBHZWVydCBhbmQgTGludXMgYXJlIG1lcmdlIGNvbW1pdHMgdGhlcmUpCgpJIGFncmVlIHdp dGggeW91LCBJJ3ZlIHNlbnQgYSBzZXBhcmF0ZSBwYXRjaC4KCj4gPiBXaGlsZSBhdCBpdCBmaXgg dGhlIGZpbGUgZGVzY3JpcHRpb25zIHRvIG1hdGNoIGZpbGUgbmFtZXMgd2hlcmUgY29weSBhbmQK PiA+IHBhc3RlIGVycm9yIG9jY3VycmVkLgo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBMYXVyZW50 IFBpbmNoYXJ0Cj4gPiA8bGF1cmVudC5waW5jaGFydCtyZW5lc2FzQGlkZWFzb25ib2FyZC5jb20+ Cj4gCj4gSXQncyBjcmF6eSB0aGF0IHdlIGhhdmUgdHdvIHR5cGVzIG9mIGNvbW1lbnQgc3R5bGUg Zm9yIHRoZSBTUERYIGlkZW50aWZpZXIgLQo+IGJ1dCB0aGF0J3Mgbm90IGEgZmF1bHQgaW4gdGhp cyBwYXRjaCwgc286Cj4gCj4gUmV2aWV3ZWQtYnk6IEtpZXJhbiBCaW5naGFtIDxraWVyYW4uYmlu Z2hhbStyZW5lc2FzQGlkZWFzb25ib2FyZC5jb20+Cj4gCj4gPiAtLS0KPiA+IAo+ID4gIGRyaXZl cnMvbWVkaWEvcGxhdGZvcm0vdnNwMS92c3AxLmggICAgICAgIHwgNiArLS0tLS0KPiA+ICBkcml2 ZXJzL21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNwMV9icnguYyAgICB8IDYgKy0tLS0tCj4gPiAgZHJp dmVycy9tZWRpYS9wbGF0Zm9ybS92c3AxL3ZzcDFfYnJ4LmggICAgfCA2ICstLS0tLQo+ID4gIGRy aXZlcnMvbWVkaWEvcGxhdGZvcm0vdnNwMS92c3AxX2NsdS5jICAgIHwgNiArLS0tLS0KPiA+ICBk cml2ZXJzL21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNwMV9jbHUuaCAgICB8IDYgKy0tLS0tCj4gPiAg ZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92c3AxL3ZzcDFfZGwuYyAgICAgfCA4ICsrLS0tLS0tCj4g PiAgZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92c3AxL3ZzcDFfZGwuaCAgICAgfCA2ICstLS0tLQo+ ID4gIGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vdnNwMS92c3AxX2RybS5jICAgIHwgOCArKy0tLS0t LQo+ID4gIGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vdnNwMS92c3AxX2RybS5oICAgIHwgNiArLS0t LS0KPiA+ICBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNwMV9kcnYuYyAgICB8IDYgKy0t LS0tCj4gPiAgZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92c3AxL3ZzcDFfZW50aXR5LmMgfCA2ICst LS0tLQo+ID4gIGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vdnNwMS92c3AxX2VudGl0eS5oIHwgNiAr LS0tLS0KPiA+ICBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNwMV9oZ28uYyAgICB8IDYg Ky0tLS0tCj4gPiAgZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92c3AxL3ZzcDFfaGdvLmggICAgfCA2 ICstLS0tLQo+ID4gIGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vdnNwMS92c3AxX2hndC5jICAgIHwg NiArLS0tLS0KPiA+ICBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNwMV9oZ3QuaCAgICB8 IDYgKy0tLS0tCj4gPiAgZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92c3AxL3ZzcDFfaGlzdG8uYyAg fCA2ICstLS0tLQo+ID4gIGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vdnNwMS92c3AxX2hpc3RvLmgg IHwgNiArLS0tLS0KPiA+ICBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNwMV9oc2l0LmMg ICB8IDYgKy0tLS0tCj4gPiAgZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92c3AxL3ZzcDFfaHNpdC5o ICAgfCA2ICstLS0tLQo+ID4gIGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vdnNwMS92c3AxX2xpZi5j ICAgIHwgNiArLS0tLS0KPiA+ICBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNwMV9saWYu aCAgICB8IDYgKy0tLS0tCj4gPiAgZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92c3AxL3ZzcDFfbHV0 LmMgICAgfCA2ICstLS0tLQo+ID4gIGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vdnNwMS92c3AxX2x1 dC5oICAgIHwgNiArLS0tLS0KPiA+ICBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNwMV9w aXBlLmMgICB8IDYgKy0tLS0tCj4gPiAgZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92c3AxL3ZzcDFf cGlwZS5oICAgfCA2ICstLS0tLQo+ID4gIGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vdnNwMS92c3Ax X3JlZ3MuaCAgIHwgNSArLS0tLQo+ID4gIGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vdnNwMS92c3Ax X3JwZi5jICAgIHwgNiArLS0tLS0KPiA+ICBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNw MV9yd3BmLmMgICB8IDYgKy0tLS0tCj4gPiAgZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92c3AxL3Zz cDFfcndwZi5oICAgfCA2ICstLS0tLQo+ID4gIGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vdnNwMS92 c3AxX3NydS5jICAgIHwgNiArLS0tLS0KPiA+ICBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL3ZzcDEv dnNwMV9zcnUuaCAgICB8IDYgKy0tLS0tCj4gPiAgZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92c3Ax L3ZzcDFfdWRzLmMgICAgfCA2ICstLS0tLQo+ID4gIGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vdnNw MS92c3AxX3Vkcy5oICAgIHwgNiArLS0tLS0KPiA+ICBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL3Zz cDEvdnNwMV92aWRlby5jICB8IDYgKy0tLS0tCj4gPiAgZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92 c3AxL3ZzcDFfdmlkZW8uaCAgfCA2ICstLS0tLQo+ID4gIGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0v dnNwMS92c3AxX3dwZi5jICAgIHwgNiArLS0tLS0KPiA+ICAzNyBmaWxlcyBjaGFuZ2VkLCAzOSBp bnNlcnRpb25zKCspLCAxODYgZGVsZXRpb25zKC0pCgotLSAKUmVnYXJkcywKCkxhdXJlbnQgUGlu Y2hhcnQKCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K ZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==