All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Michael Straube <straube.linux@gmail.com>,
	Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	devel@driverdev.osuosl.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH v3 3/4] staging: rtl8723bs: use ether_addr_copy() in rtw_macaddr_cfg()
Date: Tue, 26 Jun 2018 14:36:00 -0700	[thread overview]
Message-ID: <997ac97e1dcfcaf4d0b1fa7003d4611dd7821f5d.camel@perches.com> (raw)
In-Reply-To: <2a49e8e7-15ef-af4f-1039-b15ae60df11b@gmail.com>

On Tue, 2018-06-26 at 22:32 +0200, Michael Straube wrote:
> On 06/26/18 22:17, Joe Perches wrote:
> > On Tue, 2018-06-26 at 21:44 +0200, Michael Straube wrote:
> > > On 06/26/18 19:32, Andy Shevchenko wrote:
> > > > On Tue, Jun 26, 2018 at 11:14 AM, Michael Straube
> > > > <straube.linux@gmail.com> wrote:
> > > > > Use ether_addr_copy() instead of memcpy() to copy the mac address.
[]
> > > > Btw, ensure that the source and destination buffers are aligned to u16
> > > > as required by API.
> > > To be honest I'm not sure how to do that excactly.
> > > Use __align(2) in the array declarations? e.g.:
> > >           u8 mac[ETH_ALEN] __align(2);
> > All initial function automatics are naturally aligned.
> So there is nothing to change? Now I'm confused.

There's nothing to change.  You could add __aligned(2)
if you wanted to, but it's already aligned.


  reply	other threads:[~2018-06-26 21:36 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-26  8:14 [PATCH v3 1/4] staging: rtl8723bs: fix comparsion to NULL - coding style Michael Straube
2018-06-26  8:14 ` [PATCH v3 2/4] staging: rtl8723bs: refactor rtw_macaddr_cfg() Michael Straube
2018-06-26 17:29   ` Andy Shevchenko
2018-06-26 19:19     ` Michael Straube
2018-06-26  8:14 ` [PATCH v3 3/4] staging: rtl8723bs: use ether_addr_copy() in rtw_macaddr_cfg() Michael Straube
2018-06-26 17:32   ` Andy Shevchenko
2018-06-26 19:44     ` Michael Straube
2018-06-26 20:17       ` Joe Perches
2018-06-26 20:32         ` Michael Straube
2018-06-26 21:36           ` Joe Perches [this message]
2018-06-27  8:33           ` Dan Carpenter
2018-06-27 12:56             ` Michael Straube
2018-06-27 13:11               ` Dan Carpenter
2018-06-27 16:14                 ` Andy Shevchenko
2018-06-27 16:42                   ` Joe Perches
2018-06-27 18:35                     ` Dan Carpenter
2018-06-26  8:14 ` [PATCH v3 4/4] staging: rtl8723bs: use mac_pton() " Michael Straube
2018-06-26 17:34   ` Andy Shevchenko
2018-06-26 20:48     ` Michael Straube

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=997ac97e1dcfcaf4d0b1fa7003d4611dd7821f5d.camel@perches.com \
    --to=joe@perches.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=straube.linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.