From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF7BDC433FE for ; Mon, 28 Nov 2022 09:05:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230175AbiK1JFE (ORCPT ); Mon, 28 Nov 2022 04:05:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230004AbiK1JFC (ORCPT ); Mon, 28 Nov 2022 04:05:02 -0500 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3FD171789F for ; Mon, 28 Nov 2022 01:05:01 -0800 (PST) Received: by mail-lf1-x130.google.com with SMTP id g7so16311944lfv.5 for ; Mon, 28 Nov 2022 01:05:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=A55aTUx9um1awxaJwrSFbAQ2B0+UBrA3NMiv8IfADq0=; b=S72uyT2NmmapvIzFBlVuuVu0Rj7I4DWGK7uN5lPNwFlu0h/1xHqfc0w1ekc4I5t3Uc EN1EyLvMqacGCEyoAVBLE2K5WwWW7b3QhzeHSt96fjPRHdsIcBipIoipMdiiwv2KLMKF 4jRN/hMdKFY1tCOyS2B1azQZzCvJ4VqiGQ1gKE4FLqK3KOY/tB4uwWsoppviePTHGj0I xVFArXGbIddcVz/WKsB70I0stTDLANjS0MD/cELNNmuhiNaxpmNVJ0t77XYWD8eX6Ptt DPn9UqhkeYxwgnaF/NCocPrBYXR5aGK3rgOKaYtBrYcmlo9DtCVRy2H/GR/W6qgBGkuG 2Pew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=A55aTUx9um1awxaJwrSFbAQ2B0+UBrA3NMiv8IfADq0=; b=56q+nvhv2rEdNwQ4YGmKsvP8H+ovSZc2joo7pZtg3XNbGnDjHqvBaOUSzjcqjugmkF 4oTq80J+w/IQySaugPCexdSbaY7dNezPotqgjqyJQHNcYMw3zCI7R9pI1YpDNL1web59 Ih7cQCs7E37e79e9X6KAVlCwDO381PGcWSMlT0+xEssSCYlyuUA50c4uFGdM39rppc1K /LODPvCgpgBBikyvVP6EJlVCgydGCZzbs+OwEwzeptFXbIVnDH1pKx5b6aAJulng86HO mVu8HswJg0D/Z7ajXinpSoNgz0Rq05ey2zi7RejIeBAyXZccZtryFJGXv/tXJfZzSdYN skBg== X-Gm-Message-State: ANoB5plE5/raCOIbVS50cwI/XUQ2fY4FO+88MzxOkHTA1WAJUV7lk5Cb 38jTxCq6/Z+MeT1kjvQ1239lpjifCdMh46/5 X-Google-Smtp-Source: AA0mqf690hCzqZNxg+ZuHnfgQ+jA8Im/PCMuhGme2XTYv6jky84sgnUWOjjTeaDuaJus+Yq5DlEr3A== X-Received: by 2002:a05:6512:2987:b0:4b1:61a6:fc45 with SMTP id du7-20020a056512298700b004b161a6fc45mr11308428lfb.224.1669626299613; Mon, 28 Nov 2022 01:04:59 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id r30-20020ac25c1e000000b004ac088fdfd2sm1645536lfp.85.2022.11.28.01.04.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Nov 2022 01:04:59 -0800 (PST) Message-ID: <9985d44e-977e-d7ea-0932-4879a3ccd14d@linaro.org> Date: Mon, 28 Nov 2022 10:04:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 7/9] dt-bindings: spi: mtk-snfi: add two timing delay property Content-Language: en-US To: Xiangsheng Hou , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Mark Brown , Chuanhong Guo Cc: linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, benliang.zhao@mediatek.com, bin.zhang@mediatek.com References: <20221128020613.14821-1-xiangsheng.hou@mediatek.com> <20221128020613.14821-8-xiangsheng.hou@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: <20221128020613.14821-8-xiangsheng.hou@mediatek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/11/2022 03:06, Xiangsheng Hou wrote: > add rx-sample-delay and rx-latch-latency property. Start sentences with capital letter. Here and in commit subject: property->properties > > Signed-off-by: Xiangsheng Hou > --- > .../bindings/spi/mediatek,spi-mtk-snfi.yaml | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.yaml b/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.yaml > index ee20075cd0e7..367862688e92 100644 > --- a/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.yaml > +++ b/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.yaml > @@ -55,6 +55,22 @@ properties: > description: device-tree node of the accompanying ECC engine. > $ref: /schemas/types.yaml#/definitions/phandle > > + rx-sample-delay: No, use existing property, don't invent your own stuff - missing unit suffix. See spi-peripheral-props.yaml. > + description: Rx delay to sample data with this value, the valid > + values are from 0 to 47. The delay is smaller than > + the rx-latch-latency. > + $ref: /schemas/types.yaml#/definitions/uint32 Drop $ref. > + minItems: 0 > + maxItems: 47 > + default: 0 > + > + rx-latch-latency: Same problems. Did you check spi-peripheral-props.yaml or other SPI controller schemas for such property? > + description: Rx delay to sample data with this value, the value > + unit is clock cycle. I think the unit should be rather time (e.g. us). > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [0, 1, 2, 3] > + default: 0 > + > required: > - compatible > - reg Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5B639C4332F for ; Mon, 28 Nov 2022 09:05:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=R2WV3yVTnyK3zwyzyC8GaAMEtw82gRT4Scf67F+okRE=; b=4Oy2rt8O58sFAM xqzUtIDW1rcqNihxLWHTD51qGEm2UNz4+81Rbam4BIIyU+ReLDK4o8nyzmnEzVQDBqsiXDEhUCHtT ijOtJoML3iJoz1/4HqdPE4AdTAJwxyiZ4Ibq0js+ZJKB8tvnoMW+pLLGTxN/siXGWLGGC0K/uDroc to7OKq1HJHmWgRjSYj/1c5E6s+v58trLVADdXWQwz4IWAWwJtiWkmmrqmQ2U6b6mCUmLyKA0Ux8m0 K3W7GqiKC/aEUlzlM+jdiK+e68k3Kqwtw78osWNtmXx5LGTXsgmRkYocO51Zk3949rd/Z/1Un8k1i TnLBtmooFDfTlE3Y/laQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oza4V-000U6H-Uo; Mon, 28 Nov 2022 09:05:04 +0000 Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oza4T-000U2r-9L for linux-mtd@lists.infradead.org; Mon, 28 Nov 2022 09:05:02 +0000 Received: by mail-lf1-x12d.google.com with SMTP id u27so5295992lfc.9 for ; Mon, 28 Nov 2022 01:05:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=A55aTUx9um1awxaJwrSFbAQ2B0+UBrA3NMiv8IfADq0=; b=S72uyT2NmmapvIzFBlVuuVu0Rj7I4DWGK7uN5lPNwFlu0h/1xHqfc0w1ekc4I5t3Uc EN1EyLvMqacGCEyoAVBLE2K5WwWW7b3QhzeHSt96fjPRHdsIcBipIoipMdiiwv2KLMKF 4jRN/hMdKFY1tCOyS2B1azQZzCvJ4VqiGQ1gKE4FLqK3KOY/tB4uwWsoppviePTHGj0I xVFArXGbIddcVz/WKsB70I0stTDLANjS0MD/cELNNmuhiNaxpmNVJ0t77XYWD8eX6Ptt DPn9UqhkeYxwgnaF/NCocPrBYXR5aGK3rgOKaYtBrYcmlo9DtCVRy2H/GR/W6qgBGkuG 2Pew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=A55aTUx9um1awxaJwrSFbAQ2B0+UBrA3NMiv8IfADq0=; b=1fQrAbb/ZMeTg7P5IWa3GqUTdaizoutVal/JbPO+nvkCRkdASWloQKuvn/i7E4w0/6 0bZFhph+xO+mSFV6Clx8JJQ2oAg1PCz932zzf7jGtClU7m7hMREpL/UDmaHwszmj5i6v KQvi/mEAlvTOzU2miUa28ylwmhIWI7HBC/BrkBCrB4V4W1xf+Nv3rrq4N6qMRg6pTr74 rBaTQDX+goJ4qLQAHpbogaQd8waryDmMxMHgL13zHtUPUk0709GYo4FyIYmM/4lDf2St DEK1faI1y3SNN5EDYTR451NdHmlYM0zkwFeVpomQpPubpMTMVWqe5ZbclrkY4BlU1fxx nR/w== X-Gm-Message-State: ANoB5pnAFryaX1PbQwzscwhhPi3TOP2BkrwXzZZ/weaxA+P5qFxk4Zbz omXY8MRCFJu/edAicLdtKLL23A== X-Google-Smtp-Source: AA0mqf690hCzqZNxg+ZuHnfgQ+jA8Im/PCMuhGme2XTYv6jky84sgnUWOjjTeaDuaJus+Yq5DlEr3A== X-Received: by 2002:a05:6512:2987:b0:4b1:61a6:fc45 with SMTP id du7-20020a056512298700b004b161a6fc45mr11308428lfb.224.1669626299613; Mon, 28 Nov 2022 01:04:59 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id r30-20020ac25c1e000000b004ac088fdfd2sm1645536lfp.85.2022.11.28.01.04.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Nov 2022 01:04:59 -0800 (PST) Message-ID: <9985d44e-977e-d7ea-0932-4879a3ccd14d@linaro.org> Date: Mon, 28 Nov 2022 10:04:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 7/9] dt-bindings: spi: mtk-snfi: add two timing delay property Content-Language: en-US To: Xiangsheng Hou , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Mark Brown , Chuanhong Guo Cc: linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, benliang.zhao@mediatek.com, bin.zhang@mediatek.com References: <20221128020613.14821-1-xiangsheng.hou@mediatek.com> <20221128020613.14821-8-xiangsheng.hou@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: <20221128020613.14821-8-xiangsheng.hou@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221128_010501_370964_694BDC16 X-CRM114-Status: GOOD ( 15.88 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On 28/11/2022 03:06, Xiangsheng Hou wrote: > add rx-sample-delay and rx-latch-latency property. Start sentences with capital letter. Here and in commit subject: property->properties > > Signed-off-by: Xiangsheng Hou > --- > .../bindings/spi/mediatek,spi-mtk-snfi.yaml | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.yaml b/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.yaml > index ee20075cd0e7..367862688e92 100644 > --- a/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.yaml > +++ b/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.yaml > @@ -55,6 +55,22 @@ properties: > description: device-tree node of the accompanying ECC engine. > $ref: /schemas/types.yaml#/definitions/phandle > > + rx-sample-delay: No, use existing property, don't invent your own stuff - missing unit suffix. See spi-peripheral-props.yaml. > + description: Rx delay to sample data with this value, the valid > + values are from 0 to 47. The delay is smaller than > + the rx-latch-latency. > + $ref: /schemas/types.yaml#/definitions/uint32 Drop $ref. > + minItems: 0 > + maxItems: 47 > + default: 0 > + > + rx-latch-latency: Same problems. Did you check spi-peripheral-props.yaml or other SPI controller schemas for such property? > + description: Rx delay to sample data with this value, the value > + unit is clock cycle. I think the unit should be rather time (e.g. us). > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [0, 1, 2, 3] > + default: 0 > + > required: > - compatible > - reg Best regards, Krzysztof ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D5658C4332F for ; Mon, 28 Nov 2022 09:06:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oi+8COMTPJl5Rp4bIzuvM4grGMrIdLS0EpQAAzGZiIo=; b=xDGHIjcuur8zqn lTsmz4jmprK08BlrqX4aPNaGcqJsNJHtTmyoIjJ+kC6NAwZ9YQpeqEEhlawa9euApoLSwx7Uqoqsq vEsSO4wi60jESfABzGIJoPaBE85DARs+jlfAuigZqAWRnvPGvt2DzT06J1J4uo+wXW5tvGRKobunb h4ZWQOQRzezPljostenLoUzUTOAM1xwt2DxzsRJO4Tt6i+PFrXJ7UEWp6TRlFnbcA7+/RgUbbvzrc Q438cAGBmLSrHdU7pijEYaL6NNqYnJZraZvehYQDrI/lYDTmGELa+VMo8MZMhOth04kE+mArLLPsx vymiHi4L44tYOpUECztA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oza4Z-000U8M-Bg; Mon, 28 Nov 2022 09:05:07 +0000 Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oza4U-000U2s-Ru for linux-arm-kernel@lists.infradead.org; Mon, 28 Nov 2022 09:05:04 +0000 Received: by mail-lf1-x135.google.com with SMTP id bp15so16250355lfb.13 for ; Mon, 28 Nov 2022 01:05:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=A55aTUx9um1awxaJwrSFbAQ2B0+UBrA3NMiv8IfADq0=; b=S72uyT2NmmapvIzFBlVuuVu0Rj7I4DWGK7uN5lPNwFlu0h/1xHqfc0w1ekc4I5t3Uc EN1EyLvMqacGCEyoAVBLE2K5WwWW7b3QhzeHSt96fjPRHdsIcBipIoipMdiiwv2KLMKF 4jRN/hMdKFY1tCOyS2B1azQZzCvJ4VqiGQ1gKE4FLqK3KOY/tB4uwWsoppviePTHGj0I xVFArXGbIddcVz/WKsB70I0stTDLANjS0MD/cELNNmuhiNaxpmNVJ0t77XYWD8eX6Ptt DPn9UqhkeYxwgnaF/NCocPrBYXR5aGK3rgOKaYtBrYcmlo9DtCVRy2H/GR/W6qgBGkuG 2Pew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=A55aTUx9um1awxaJwrSFbAQ2B0+UBrA3NMiv8IfADq0=; b=LH5/674X4B6S58crN5qUynVFiNPkRv0CHDHN3LBzF6giYHenYxxMXrtcrZHJvnfJ+4 NorF20zQn4gNLbx2sfF44cUkhDjTfQ3qH77K+2IRs/s6JU1N0LC6M3qFXYduJDPfQia6 WjywSWH+43B6CcsYHESzcalGZOMEdOvk8GD7wLcuZYe/aS4pd3G1+9GF6Xg2VVyrl1O4 PfpO8NAn/gxwSIoDj0S5LYbTS+Bdutr2jVpo9MzwMdBlXw1UhdwJShPXoycYWpcVtLiY i8AS5z4Y/y43ozoJg8t40IoJVj4k1djU007rZ1Vd9N2wshHNh0WdOlBU7agK2HkCsixP G8Fw== X-Gm-Message-State: ANoB5pkTgs8p19mHOng0fZPBKPeQ04hrLS8vDuN0lCTwYN+DQYsljNq/ pBAIqCRGqeD+QMuklSh44AIvaA== X-Google-Smtp-Source: AA0mqf690hCzqZNxg+ZuHnfgQ+jA8Im/PCMuhGme2XTYv6jky84sgnUWOjjTeaDuaJus+Yq5DlEr3A== X-Received: by 2002:a05:6512:2987:b0:4b1:61a6:fc45 with SMTP id du7-20020a056512298700b004b161a6fc45mr11308428lfb.224.1669626299613; Mon, 28 Nov 2022 01:04:59 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id r30-20020ac25c1e000000b004ac088fdfd2sm1645536lfp.85.2022.11.28.01.04.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Nov 2022 01:04:59 -0800 (PST) Message-ID: <9985d44e-977e-d7ea-0932-4879a3ccd14d@linaro.org> Date: Mon, 28 Nov 2022 10:04:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 7/9] dt-bindings: spi: mtk-snfi: add two timing delay property Content-Language: en-US To: Xiangsheng Hou , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Mark Brown , Chuanhong Guo Cc: linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, benliang.zhao@mediatek.com, bin.zhang@mediatek.com References: <20221128020613.14821-1-xiangsheng.hou@mediatek.com> <20221128020613.14821-8-xiangsheng.hou@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: <20221128020613.14821-8-xiangsheng.hou@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221128_010502_924348_169D57B8 X-CRM114-Status: GOOD ( 16.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 28/11/2022 03:06, Xiangsheng Hou wrote: > add rx-sample-delay and rx-latch-latency property. Start sentences with capital letter. Here and in commit subject: property->properties > > Signed-off-by: Xiangsheng Hou > --- > .../bindings/spi/mediatek,spi-mtk-snfi.yaml | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.yaml b/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.yaml > index ee20075cd0e7..367862688e92 100644 > --- a/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.yaml > +++ b/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.yaml > @@ -55,6 +55,22 @@ properties: > description: device-tree node of the accompanying ECC engine. > $ref: /schemas/types.yaml#/definitions/phandle > > + rx-sample-delay: No, use existing property, don't invent your own stuff - missing unit suffix. See spi-peripheral-props.yaml. > + description: Rx delay to sample data with this value, the valid > + values are from 0 to 47. The delay is smaller than > + the rx-latch-latency. > + $ref: /schemas/types.yaml#/definitions/uint32 Drop $ref. > + minItems: 0 > + maxItems: 47 > + default: 0 > + > + rx-latch-latency: Same problems. Did you check spi-peripheral-props.yaml or other SPI controller schemas for such property? > + description: Rx delay to sample data with this value, the value > + unit is clock cycle. I think the unit should be rather time (e.g. us). > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [0, 1, 2, 3] > + default: 0 > + > required: > - compatible > - reg Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel