From: Peter Lieven <pl@kamp.de>
To: Ilya Dryomov <idryomov@gmail.com>
Cc: kwolf@redhat.com, berrange@redhat.com, qemu-block@nongnu.org,
qemu-devel@nongnu.org, ct@flyingcircus.io,
Paolo Bonzini <pbonzini@redhat.com>,
mreitz@redhat.com
Subject: Re: [PATCH V3 5/6] block/rbd: add write zeroes support
Date: Fri, 18 Jun 2021 11:00:38 +0200 [thread overview]
Message-ID: <99aaf586-5555-8c45-08c8-e50e3b5919de@kamp.de> (raw)
In-Reply-To: <CAOi1vP8AFWaS7Qwu8DVQP0EGZh48CcsrYnTfCWU2J6ZctGA2EQ@mail.gmail.com>
Am 16.06.21 um 14:34 schrieb Ilya Dryomov:
> On Wed, May 19, 2021 at 4:28 PM Peter Lieven <pl@kamp.de> wrote:
>> Signed-off-by: Peter Lieven <pl@kamp.de>
>> ---
>> block/rbd.c | 37 ++++++++++++++++++++++++++++++++++++-
>> 1 file changed, 36 insertions(+), 1 deletion(-)
>>
>> diff --git a/block/rbd.c b/block/rbd.c
>> index 0d8612a988..ee13f08a74 100644
>> --- a/block/rbd.c
>> +++ b/block/rbd.c
>> @@ -63,7 +63,8 @@ typedef enum {
>> RBD_AIO_READ,
>> RBD_AIO_WRITE,
>> RBD_AIO_DISCARD,
>> - RBD_AIO_FLUSH
>> + RBD_AIO_FLUSH,
>> + RBD_AIO_WRITE_ZEROES
>> } RBDAIOCmd;
>>
>> typedef struct BDRVRBDState {
>> @@ -705,6 +706,10 @@ static int qemu_rbd_open(BlockDriverState *bs, QDict *options, int flags,
>> }
>> }
>>
>> +#ifdef LIBRBD_SUPPORTS_WRITE_ZEROES
>> + bs->supported_zero_flags = BDRV_REQ_MAY_UNMAP;
> I wonder if we should also set BDRV_REQ_NO_FALLBACK here since librbd
> does not really have a notion of non-efficient explicit zeroing.
This is only true if thick provisioning is supported which is in Octopus onwards, right?
So it would only be correct to set this if thick provisioning is supported otherwise we could
fail with ENOTSUP and then qemu emulates the zeroing with plain writes.
Peter
next prev parent reply other threads:[~2021-06-18 9:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 14:23 [PATCH V3 0/6] block/rbd: migrate to coroutines and add write zeroes support Peter Lieven
2021-05-19 14:23 ` [PATCH V3 1/6] block/rbd: bump librbd requirement to luminous release Peter Lieven
2021-06-16 12:26 ` Ilya Dryomov
2021-06-18 8:58 ` Peter Lieven
2021-06-18 10:21 ` Ilya Dryomov
2021-05-19 14:23 ` [PATCH V3 2/6] block/rbd: store object_size in BDRVRBDState Peter Lieven
2021-06-19 20:02 ` Ilya Dryomov
2021-05-19 14:23 ` [PATCH V3 3/6] block/rbd: update s->image_size in qemu_rbd_getlength Peter Lieven
2021-06-19 19:57 ` Ilya Dryomov
2021-05-19 14:23 ` [PATCH V3 4/6] block/rbd: migrate from aio to coroutines Peter Lieven
2021-06-17 14:43 ` Ilya Dryomov
2021-06-18 9:07 ` Peter Lieven
2021-06-18 11:26 ` Ilya Dryomov
2021-05-19 14:23 ` [PATCH V3 5/6] block/rbd: add write zeroes support Peter Lieven
2021-06-16 12:34 ` Ilya Dryomov
2021-06-18 9:00 ` Peter Lieven [this message]
2021-06-18 10:34 ` Ilya Dryomov
2021-06-21 8:49 ` Peter Lieven
2021-06-26 15:56 ` Ilya Dryomov
2021-06-27 19:29 ` Peter Lieven
2021-05-19 14:23 ` [PATCH V3 6/6] block/rbd: drop qemu_rbd_refresh_limits Peter Lieven
2021-06-19 20:10 ` Ilya Dryomov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99aaf586-5555-8c45-08c8-e50e3b5919de@kamp.de \
--to=pl@kamp.de \
--cc=berrange@redhat.com \
--cc=ct@flyingcircus.io \
--cc=idryomov@gmail.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.