From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D033C433E9 for ; Thu, 3 Sep 2020 14:01:16 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 43D99206A5 for ; Thu, 3 Sep 2020 14:01:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JQ2wDOaL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 43D99206A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45618 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kDpnf-0002np-7M for qemu-devel@archiver.kernel.org; Thu, 03 Sep 2020 10:01:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51652) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kDpmk-00028l-9R for qemu-devel@nongnu.org; Thu, 03 Sep 2020 10:00:18 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:32823) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kDpmh-0003T5-Jr for qemu-devel@nongnu.org; Thu, 03 Sep 2020 10:00:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599141614; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Im5eAk6wPSmNcodCRioKcx0J21zZyaBr1f5cb3hIzUY=; b=JQ2wDOaLCr+DZhHxRHTAyGdiq4FL9AMA74XRbt6bcwa8YJglcFfYoIhd33Q6Y4I2PnW/NM wG6s/QzgMjH1tf+swMnUk6We8TdY/iAz/RLH7xKVazg/FtUENeFb2MvTYgC6vFGj6QByih aOTNXEQ5hB8XO9M0mrc1leDEs/brP1g= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-482-jsPrDkeBM7apWFbfXf8p7w-1; Thu, 03 Sep 2020 10:00:12 -0400 X-MC-Unique: jsPrDkeBM7apWFbfXf8p7w-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6E6601DE13; Thu, 3 Sep 2020 14:00:11 +0000 (UTC) Received: from thuth.remote.csb (ovpn-114-10.ams2.redhat.com [10.36.114.10]) by smtp.corp.redhat.com (Postfix) with ESMTP id DF4E41002D58; Thu, 3 Sep 2020 14:00:00 +0000 (UTC) Subject: Re: [PATCH 1/2] hw/timer/hpet: Remove dead code To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20200903134506.440082-1-philmd@redhat.com> <20200903134506.440082-2-philmd@redhat.com> From: Thomas Huth Message-ID: <99ac9ba8-9a6d-dea6-c7eb-387723fe5fcf@redhat.com> Date: Thu, 3 Sep 2020 15:59:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200903134506.440082-2-philmd@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US Received-SPF: pass client-ip=63.128.21.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/03 04:23:54 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -44 X-Spam_score: -4.5 X-Spam_bar: ---- X-Spam_report: (-4.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-2.403, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Paolo Bonzini , Michael Tokarev , Laurent Vivier , "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 03/09/2020 15.45, Philippe Mathieu-Daudé wrote: > This code was never compiled/used, remove it. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/timer/hpet.c | 14 -------------- > 1 file changed, 14 deletions(-) > > diff --git a/hw/timer/hpet.c b/hw/timer/hpet.c > index 380acfa7c8a..b683f64f1d3 100644 > --- a/hw/timer/hpet.c > +++ b/hw/timer/hpet.c > @@ -416,20 +416,6 @@ static void hpet_del_timer(HPETTimer *t) > update_irq(t, 0); > } > > -#ifdef HPET_DEBUG > -static uint32_t hpet_ram_readb(void *opaque, hwaddr addr) > -{ > - printf("qemu: hpet_read b at %" PRIx64 "\n", addr); > - return 0; > -} > - > -static uint32_t hpet_ram_readw(void *opaque, hwaddr addr) > -{ > - printf("qemu: hpet_read w at %" PRIx64 "\n", addr); > - return 0; > -} > -#endif > - > static uint64_t hpet_ram_read(void *opaque, hwaddr addr, > unsigned size) > { > Reviewed-by: Thomas Huth