From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB8CEC43461 for ; Mon, 10 May 2021 12:50:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C162B61108 for ; Mon, 10 May 2021 12:50:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241526AbhEJMuj (ORCPT ); Mon, 10 May 2021 08:50:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57500 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244233AbhEJL6m (ORCPT ); Mon, 10 May 2021 07:58:42 -0400 Received: from ssl.serverraum.org (ssl.serverraum.org [IPv6:2a01:4f8:151:8464::1:2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8D0DC07E5FF for ; Mon, 10 May 2021 04:52:25 -0700 (PDT) Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 5675322239; Mon, 10 May 2021 13:52:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1620647543; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yO4AK8WNlzpOysSwYhMdNTxh6p0zS+xaRzCx4D02VTA=; b=aJ87l8l+za7++bQhHM8uOwBLK2wipB1v1+sZx34XkEkmjZHOv75oGC1IDaKjYhbCW71sEx pumTU78vNkCc0/3mJpbDWKIuAN9pKWtEZKYHgp+s552bdDH5W9F4pN9yl3O7xwd2dNhHPZ Xt/zqwgvO0o4O2tu8faj/8U4oUrSDKI= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 10 May 2021 13:52:22 +0200 From: Michael Walle To: Kuninori Morimoto Cc: Mark Brown , Guillaume Tucker , kernelci-results@groups.io, Heiko Thiery , alsa-devel@alsa-project.org, Jaroslav Kysela , Liam Girdwood , Takashi Iwai , Stephan Gerhold , Thierry Reding , Jon Hunter , linux-kernel@vger.kernel.org Subject: Re: broonie-sound/for-next bisection: baseline.bootrr.asoc-simple-card-probed on kontron-sl28-var3-ads2 In-Reply-To: <87o8djcxas.wl-kuninori.morimoto.gx@renesas.com> References: <6080e82c.1c69fb81.cd60c.2a13@mx.google.com> <3ca62063-41b4-c25b-a7bc-8a8160e7b684@collabora.com> <877dkp5141.wl-kuninori.morimoto.gx@renesas.com> <20210426144242.GF4590@sirena.org.uk> <8735vc4r59.wl-kuninori.morimoto.gx@renesas.com> <20210427101926.GA4605@sirena.org.uk> <20210427135703.GH4605@sirena.org.uk> <1aa3a8716d2416f0cc127737dcff092a@walle.cc> <87o8djcxas.wl-kuninori.morimoto.gx@renesas.com> User-Agent: Roundcube Webmail/1.4.11 Message-ID: <99b3cd8db134d9682c16784f75f40bae@walle.cc> X-Sender: michael@walle.cc Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Am 2021-05-10 01:16, schrieb Kuninori Morimoto: > I'm sorry for my late response. Japan was holiday > >> _But_ later >> asoc_simple_canonicalize_cpu() will reset the dai_name pointer to >> NULL in simple_parse_node() if "single" is 1 and then we end up >> having two links with the same name. > > Ahh, OK thanks. > I think understand that why my posted patch > (= 59c35c44a9cf89a83a9 "ASoC: simple-card: add simple_parse_node()") > breaks your board. > > I will try to fixup the issue. > > Thank you for your help !! I've just tested your new patches. Unfortunately, it was very successful. I've also traced the is_single_links and it is still 1 for this board. Is this correct? Still these two questions are open: >> Which begs the two questions: >> (1) What is "single" actually and when should it be 1? >> (2) If single is 1, then the sysfs file will be named >> "(null)-codec-name". >> Do we want that? -michael From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A974C433B4 for ; Mon, 10 May 2021 11:53:20 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 528C360E09 for ; Mon, 10 May 2021 11:53:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 528C360E09 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id CF49916A4; Mon, 10 May 2021 13:52:27 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz CF49916A4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1620647597; bh=OGnNYM5nsoTkN/9Vy/5lWlNGUdYVVDyGMH4Q4kFLpFE=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=D1l6xqSFsUspvplrR+sgkT63RjEdDDTUNSr3ipgLlkJYx3zEkiFU80Up1tQ/cD9fi +Xzbef4ut9oPQ8B2jeilHTQL1SZ5CdVwDkMi7vTp0ltnzw5iPOFa5+cunq3nPgNF9I mwhZY/8pliSTecxHzdqyJa1kvlcbAsk7TUGkMYOo= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 52C60F8020C; Mon, 10 May 2021 13:52:27 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 62C8BF80240; Mon, 10 May 2021 13:52:26 +0200 (CEST) Received: from ssl.serverraum.org (ssl.serverraum.org [176.9.125.105]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 10474F800E9 for ; Mon, 10 May 2021 13:52:23 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 10474F800E9 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=walle.cc header.i=@walle.cc header.b="aJ87l8l+" Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 5675322239; Mon, 10 May 2021 13:52:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1620647543; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yO4AK8WNlzpOysSwYhMdNTxh6p0zS+xaRzCx4D02VTA=; b=aJ87l8l+za7++bQhHM8uOwBLK2wipB1v1+sZx34XkEkmjZHOv75oGC1IDaKjYhbCW71sEx pumTU78vNkCc0/3mJpbDWKIuAN9pKWtEZKYHgp+s552bdDH5W9F4pN9yl3O7xwd2dNhHPZ Xt/zqwgvO0o4O2tu8faj/8U4oUrSDKI= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 10 May 2021 13:52:22 +0200 From: Michael Walle To: Kuninori Morimoto Subject: Re: broonie-sound/for-next bisection: baseline.bootrr.asoc-simple-card-probed on kontron-sl28-var3-ads2 In-Reply-To: <87o8djcxas.wl-kuninori.morimoto.gx@renesas.com> References: <6080e82c.1c69fb81.cd60c.2a13@mx.google.com> <3ca62063-41b4-c25b-a7bc-8a8160e7b684@collabora.com> <877dkp5141.wl-kuninori.morimoto.gx@renesas.com> <20210426144242.GF4590@sirena.org.uk> <8735vc4r59.wl-kuninori.morimoto.gx@renesas.com> <20210427101926.GA4605@sirena.org.uk> <20210427135703.GH4605@sirena.org.uk> <1aa3a8716d2416f0cc127737dcff092a@walle.cc> <87o8djcxas.wl-kuninori.morimoto.gx@renesas.com> User-Agent: Roundcube Webmail/1.4.11 Message-ID: <99b3cd8db134d9682c16784f75f40bae@walle.cc> X-Sender: michael@walle.cc Cc: Jon Hunter , alsa-devel@alsa-project.org, Stephan Gerhold , kernelci-results@groups.io, Guillaume Tucker , Takashi Iwai , Liam Girdwood , Mark Brown , Heiko Thiery , Thierry Reding , linux-kernel@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi, Am 2021-05-10 01:16, schrieb Kuninori Morimoto: > I'm sorry for my late response. Japan was holiday > >> _But_ later >> asoc_simple_canonicalize_cpu() will reset the dai_name pointer to >> NULL in simple_parse_node() if "single" is 1 and then we end up >> having two links with the same name. > > Ahh, OK thanks. > I think understand that why my posted patch > (= 59c35c44a9cf89a83a9 "ASoC: simple-card: add simple_parse_node()") > breaks your board. > > I will try to fixup the issue. > > Thank you for your help !! I've just tested your new patches. Unfortunately, it was very successful. I've also traced the is_single_links and it is still 1 for this board. Is this correct? Still these two questions are open: >> Which begs the two questions: >> (1) What is "single" actually and when should it be 1? >> (2) If single is 1, then the sysfs file will be named >> "(null)-codec-name". >> Do we want that? -michael