From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751379AbdLJC1N (ORCPT ); Sat, 9 Dec 2017 21:27:13 -0500 Received: from mail-ot0-f195.google.com ([74.125.82.195]:39820 "EHLO mail-ot0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751331AbdLJC1L (ORCPT ); Sat, 9 Dec 2017 21:27:11 -0500 X-Google-Smtp-Source: AGs4zMZomRPpJGXD6Bv/nRPH7qTU9P/vytZ22EOvyb/g85XD94e1fob1e6W54EhvX52ZdxOvqrdy3g== Subject: Re: [PATCH v2 1/2] staging: rtl8712: Cleanup checkpatch issue WARNING:LONG_LINE To: Neil Singh , Florian Schilhabel , Greg Kroah-Hartman Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, driverdev-devel@linuxdriverproject.org References: <1512817868-4233-1-git-send-email-neil2468@gmail.com> <1512817868-4233-2-git-send-email-neil2468@gmail.com> From: Larry Finger Message-ID: <99b7f8b6-d6b5-b9cc-278c-19ffcad98081@lwfinger.net> Date: Sat, 9 Dec 2017 20:27:09 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1512817868-4233-2-git-send-email-neil2468@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/09/2017 05:11 AM, Neil Singh wrote: > Cleanup below checkpatch issue: > > WARNING:LONG_LINE: line over 80 characters > 1000: FILE: rtl871x_security.c:1000: > +static void construct_ctr_preload(u8 *ctr_preload, sint a4_exists, sint qc_exists, > > Signed-off-by: Neil Singh > --- > drivers/staging/rtl8712/rtl871x_security.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8712/rtl871x_security.c b/drivers/staging/rtl8712/rtl871x_security.c > index 56d36f6..77a5f5d 100644 > --- a/drivers/staging/rtl8712/rtl871x_security.c > +++ b/drivers/staging/rtl8712/rtl871x_security.c > @@ -997,7 +997,8 @@ static void construct_mic_header2(u8 *mic_header2, u8 *mpdu, sint a4_exists, > /* Builds the last MIC header block from */ > /* header fields. */ > /************************************************/ > -static void construct_ctr_preload(u8 *ctr_preload, sint a4_exists, sint qc_exists, > +static void construct_ctr_preload(u8 *ctr_preload, > + sint a4_exists, sint qc_exists, > u8 *mpdu, u8 *pn_vector, sint c) > { > sint i; > Did you run checkpatch on these patches? My system reports the following: ------- patch_1 ------- WARNING: A patch subject line should describe the change not the tool that found it #95: Subject: [PATCH v2 1/2] staging: rtl8712: Cleanup checkpatch issue WARNING:LONG_LINE CHECK: Alignment should match open parenthesis #125: FILE: drivers/staging/rtl8712/rtl871x_security.c:1001: +static void construct_ctr_preload(u8 *ctr_preload, + sint a4_exists, sint qc_exists, ------- patch_2 ------- WARNING: A patch subject line should describe the change not the tool that found it #95: Subject: [PATCH v2 2/2] staging: rtl8712: Cleanup checkpatch issues CODE_INDENT and LEADING_SPACE Larry From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH v2 1/2] staging: rtl8712: Cleanup checkpatch issue WARNING:LONG_LINE References: <1512817868-4233-1-git-send-email-neil2468@gmail.com> <1512817868-4233-2-git-send-email-neil2468@gmail.com> From: Larry Finger Message-ID: <99b7f8b6-d6b5-b9cc-278c-19ffcad98081@lwfinger.net> Date: Sat, 9 Dec 2017 20:27:09 -0600 MIME-Version: 1.0 In-Reply-To: <1512817868-4233-2-git-send-email-neil2468@gmail.com> Content-Language: en-US List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Neil Singh , Florian Schilhabel , Greg Kroah-Hartman Cc: devel@driverdev.osuosl.org, driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org On 12/09/2017 05:11 AM, Neil Singh wrote: > Cleanup below checkpatch issue: > > WARNING:LONG_LINE: line over 80 characters > 1000: FILE: rtl871x_security.c:1000: > +static void construct_ctr_preload(u8 *ctr_preload, sint a4_exists, sint qc_exists, > > Signed-off-by: Neil Singh > --- > drivers/staging/rtl8712/rtl871x_security.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8712/rtl871x_security.c b/drivers/staging/rtl8712/rtl871x_security.c > index 56d36f6..77a5f5d 100644 > --- a/drivers/staging/rtl8712/rtl871x_security.c > +++ b/drivers/staging/rtl8712/rtl871x_security.c > @@ -997,7 +997,8 @@ static void construct_mic_header2(u8 *mic_header2, u8 *mpdu, sint a4_exists, > /* Builds the last MIC header block from */ > /* header fields. */ > /************************************************/ > -static void construct_ctr_preload(u8 *ctr_preload, sint a4_exists, sint qc_exists, > +static void construct_ctr_preload(u8 *ctr_preload, > + sint a4_exists, sint qc_exists, > u8 *mpdu, u8 *pn_vector, sint c) > { > sint i; > Did you run checkpatch on these patches? My system reports the following: ------- patch_1 ------- WARNING: A patch subject line should describe the change not the tool that found it #95: Subject: [PATCH v2 1/2] staging: rtl8712: Cleanup checkpatch issue WARNING:LONG_LINE CHECK: Alignment should match open parenthesis #125: FILE: drivers/staging/rtl8712/rtl871x_security.c:1001: +static void construct_ctr_preload(u8 *ctr_preload, + sint a4_exists, sint qc_exists, ------- patch_2 ------- WARNING: A patch subject line should describe the change not the tool that found it #95: Subject: [PATCH v2 2/2] staging: rtl8712: Cleanup checkpatch issues CODE_INDENT and LEADING_SPACE Larry _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel