From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0CC4BC433EF for ; Tue, 26 Apr 2022 19:01:11 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 59A1283D60; Tue, 26 Apr 2022 21:01:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1650999669; bh=8A/e3acvRrXFa8uWtlVhaxmQgPergcfIv0syJg13EF4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=blf4XNZdSfV72Zp3YWPdl++kdcCZfLBu0JZIygq6DihHeaQ/qfG/4A3kttZQcgxYS /CV0DGpxgXzZ2VKppcWhqL2dqOge4kSjBCv306p5R22zW4wnd1tTVIzO4cVy2N0hR1 Xh3OnhGnxFJxOlW8x4p9qwuEta7XjfyjNhLKZoO05TEBQuSdZ9gmrupVIsv4pR2Jjp lfmaRhtf6tyZnXSRHvAjziGHwRBcPE6kgtYQxtAxtAiEsl2e2BOSe4P9OpnRv1Djcu ymaCZPHsDsge8Bl6LgtLZvdxVxHXlQ2hqXySyWiG94SX6NXoX/HXBJoBWtZAQgR7i2 B3xkwbQJWYhOA== Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 58F0181B5B; Tue, 26 Apr 2022 21:01:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1650999667; bh=8A/e3acvRrXFa8uWtlVhaxmQgPergcfIv0syJg13EF4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=UeCJOsCYpUkVFsrXY/s3ti0VpiLFZ4wBf5BdeZiIVG2I4ClEluKLStsjJY9H41Dkq Awj2GybzKaxJbR+ZyQfPiBnFSN3wXxV0gsba8PN1dKBs57YH6en/9oY+XRMjYNhL0M 8Vg4dSaM8qNLTqTdHtloikt6MPRfwpJUKE4UTOqBnwjdEdFYCLAum4cVgW+RJMEeDD KbOWG7OKP/G+sx13tQWgKrvBagqExeMznoqgDBr1Fc9D0JA+1xF/THEdXidZmMvGfY 5lXYRbm8oFYsYq3nFLdX8EXGviswOpKO//tyQiCSJSKRnx6t2SMe90Kzqo/eMkfi/h cQUo7S5LizAwQ== Message-ID: <99b8a289-74f4-cbf3-60ce-d8a4f8320e39@denx.de> Date: Tue, 26 Apr 2022 21:01:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH] power: domain: apple: Restore reset ops that return 0 Content-Language: en-US To: Mark Kettenis Cc: kettenis@openbsd.org, u-boot@lists.denx.de, patrick.delaunay@foss.st.com, sjg@chromium.org References: <20220426171409.58716-1-kettenis@openbsd.org> <6cd5d5c8-a61e-a5e3-b9e1-85213333466e@denx.de> From: Marek Vasut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 4/26/22 20:21, Mark Kettenis wrote: >> Date: Tue, 26 Apr 2022 20:04:19 +0200 >> From: Marek Vasut >> >> On 4/26/22 19:14, Mark Kettenis wrote: >>> These were removed inadvertently in commit 20874a60722b. >>> Fixes a crash on Apple M1 systems. >> >> The drivers/power/domain/power-domain-uclass.c should handle empty >> implementation of request/rfree callback in exactly the commit you >> reference above. > > Yes, but drivers/reset/reset-uclass.c doesn't and you also removed the > request/rfree callbacks for that part of the apple_pmgr driver. Ah, sigh. Would it rather make sense to change the reset uclass ? It would reduce the amount of empty callbacks.