From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Sripada, Radhakrishna" Subject: Re: [PATCH v4] drm/i915/icl: Fix clockgating issue when using scalers Date: Fri, 29 Mar 2019 23:20:37 +0000 Message-ID: <99c00cb7e5472d8aa341a6cdd28b5b9874fcf368.camel@intel.com> References: <20190315221838.22444-1-radhakrishna.sripada@intel.com> <20190328173519.1856-1-radhakrishna.sripada@intel.com> <20190329183907.GH3888@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7B18C6E567 for ; Fri, 29 Mar 2019 23:20:39 +0000 (UTC) In-Reply-To: <20190329183907.GH3888@intel.com> Content-Language: en-US Content-ID: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "ville.syrjala@linux.intel.com" Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCAyMDE5LTAzLTI5IGF0IDIwOjM5ICswMjAwLCBWaWxsZSBTeXJqw6Rsw6Qgd3JvdGU6 DQo+IE9uIFRodSwgTWFyIDI4LCAyMDE5IGF0IDEwOjM1OjE5QU0gLTA3MDAsIFJhZGhha3Jpc2hu YSBTcmlwYWRhIHdyb3RlOg0KPiA+IEZpeGVzIHRoZSBjbG9jay1nYXRpbmcgaXNzdWUgd2hlbiBw aXBlIHNjYWxpbmcgaXMgZW5hYmxlZC4NCj4gPiAoTGluZWFnZSAjMjAwNjYwNDMxMikNCj4gPiAN Cj4gPiBWMjogRml4IHR5cG8gaW4gaGVhZGxpbmUoQ2hyaXMpDQo+ID4gICAgIEhhbmRsZSB0aGUg bm9uIGRvdWJsZSBidWZmZXJlZCBuYXR1cmUgb2YgdGhlIHJlZ2lzdGVyKFZpbGxlKQ0KPiA+IFYz OiBGaXggY2hlY2twYXRjaCB3YXJuaW5nLiBCQVQgZmFpbHVyZSBmb3IgVjIgb24gZ2VuMyBsb29r cw0KPiA+IHVucmVsYXRlZC4NCj4gPiBWNDogU3BsaXQgdGhlIGljbCBhbmQgc2tsIHdhJ3MoVmls bGUpDQo+ID4gDQo+ID4gQ2M6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVr Pg0KPiA+IENjOiBWaWxsZSBTeXJqYWxhIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4N Cj4gPiBDYzogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPg0KPiA+IENjOiBB ZGl0eWEgU3dhcnVwIDxhZGl0eWEuc3dhcnVwQGludGVsLmNvbT4NCj4gPiBTaWduZWQtb2ZmLWJ5 OiBSYWRoYWtyaXNobmEgU3JpcGFkYSA8cmFkaGFrcmlzaG5hLnNyaXBhZGFAaW50ZWwuY29tDQo+ ID4gPg0KPiA+IC0tLQ0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMg fCA0OCArKysrKysrKysrKysrKysrKysrKy0tDQo+ID4gLS0tLS0tDQo+ID4gIDEgZmlsZSBjaGFu Z2VkLCAzNCBpbnNlcnRpb25zKCspLCAxNCBkZWxldGlvbnMoLSkNCj4gPiANCj4gPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jDQo+ID4gYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMNCj4gPiBpbmRleCA4NTc2YTdmNzk5ZjIuLmMz Y2E5Y2ZkMzZmZSAxMDA2NDQNCj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k aXNwbGF5LmMNCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMN Cj4gPiBAQCAtNDY2LDYgKzQ2Niw3IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgaW50ZWxfbGltaXQN Cj4gPiBpbnRlbF9saW1pdHNfYnh0ID0gew0KPiA+ICAJLnAyID0geyAucDJfc2xvdyA9IDEsIC5w Ml9mYXN0ID0gMjAgfSwNCj4gPiAgfTsNCj4gPiAgDQo+ID4gKy8qIFdBIERpc3BsYXkgIzA4Mjc6 IEdlbjk6YWxsICovDQo+ID4gIHN0YXRpYyB2b2lkDQo+ID4gIHNrbF93YV9jbGtnYXRlKHN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwgaW50IHBpcGUsIGJvb2wNCj4gPiBlbmFibGUp DQo+ID4gIHsNCj4gPiBAQCAtNDc4LDYgKzQ3OSwxNyBAQCBza2xfd2FfY2xrZ2F0ZShzdHJ1Y3Qg ZHJtX2k5MTVfcHJpdmF0ZQ0KPiA+ICpkZXZfcHJpdiwgaW50IHBpcGUsIGJvb2wgZW5hYmxlKQ0K PiA+ICAJCQkgICB+KERVUFMxX0dBVElOR19ESVMgfCBEVVBTMl9HQVRJTkdfRElTKSk7DQo+ID4g IH0NCj4gPiAgDQo+ID4gKy8qIFdhXzIwMDY2MDQzMTI6aWNsICovDQo+ID4gK3N0YXRpYyB2b2lk DQo+ID4gK2ljbF93YV9jbGtnYXRlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwg aW50IHBpcGUsIGJvb2wNCj4gPiBlbmFibGUpDQo+IA0KPiBUaGVzZSBmdW5jdGlvbnMgbmFtZXMg KGluY2x1ZGluZyB0aGUgc2tsIG9uZSkgYXJlIHJhdGhlciB0b28gZ2VuZXJpYw0KPiBhbmQgZG9u J3QgZGVzY3JpYmUgd2hpY2ggY2xvY2sgZ2F0aW5nIHdlJ3JlIGRpc2FibGluZy4gQnV0IGZpeGlu Zw0KPiB0aGF0IGlzIHByb2JhYmx5IG1hdGVyaWFsIGZvciBhbm90aGVyIHBhdGNoLg0KU3VyZSBs ZXQgbWUgc3BpbiBvdXQgYW5vdGhlciBwYXRjaCBmb3IgdGhpcy4NCj4gDQo+ID4gK3sNCj4gPiAr CWlmIChlbmFibGUpDQo+ID4gKwkJSTkxNV9XUklURShDTEtHQVRFX0RJU19QU0wocGlwZSksIERQ RlJfR0FUSU5HX0RJUyk7DQo+ID4gKwllbHNlDQo+ID4gKwkJSTkxNV9XUklURShDTEtHQVRFX0RJ U19QU0wocGlwZSksDQo+ID4gKwkJCSAgIEk5MTVfUkVBRChDTEtHQVRFX0RJU19QU0wocGlwZSkp ICYNCj4gPiB+RFBGUl9HQVRJTkdfRElTKTsNCj4gDQo+IE5vIFJNVyBmb3IgZW5hYmxlIGJ1dCBS TVcgZm9yIGRpc2FibGU/IFNlZW1zIHJhdGhlciBpbmNvbnNpc3RlbnQuDQpTdXJlIGxvb2tzIGlu Y29uc2lzdGVudC4gTGV0IG1lIGZpeCBpdCBuZXh0IHJldi4NCj4gDQo+ID4gK30NCj4gPiArDQo+ ID4gIHN0YXRpYyBib29sDQo+ID4gIG5lZWRzX21vZGVzZXQoY29uc3Qgc3RydWN0IGRybV9jcnRj X3N0YXRlICpzdGF0ZSkNCj4gPiAgew0KPiA+IEBAIC01NDgxLDE0ICs1NDkzLDE4IEBAIHN0YXRp YyBib29sDQo+ID4gaHN3X3Bvc3RfdXBkYXRlX2VuYWJsZV9pcHMoY29uc3Qgc3RydWN0IGludGVs X2NydGNfc3RhdGUNCj4gPiAqb2xkX2NydGNfcw0KPiA+ICAJcmV0dXJuICFvbGRfY3J0Y19zdGF0 ZS0+aXBzX2VuYWJsZWQ7DQo+ID4gIH0NCj4gPiAgDQo+ID4gLXN0YXRpYyBib29sIG5lZWRzX252 MTJfd2Eoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LA0KPiA+IC0JCQkgIGNvbnN0 IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlKQ0KPiA+ICtzdGF0aWMgYm9vbCBz a2xfbmVlZHNfY2xrX3dhKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwNCj4gPiAr CQkJICAgICBjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSkNCj4gDQo+ IFN0aWxsIG1peGluZyBvdXIgd29ya2Fyb3VuZHMgbW9yZSB0aGFuIEknZCBsaWtlLiBJIHN1Z2dl c3Qga2VlcGluZw0KPiB0aGUgdHdvIGVudGlyZWx5IHNlcGFyYXRlLg0KU3VyZSBsZXQgbWUgc2Vw YXJhdGUgaXQgY29tcGxldGVseS4gQXZvaWRzIGR1cGxpY2F0aW5nIGNoZWNrcyBhcyB3ZWxsLg0K DQpUaGFua3MsDQpSYWRoYWtyaXNobmEoUkspIFNyaXBhZGENCj4gDQo+ID4gIHsNCj4gPiAtCWlm ICghY3J0Y19zdGF0ZS0+bnYxMl9wbGFuZXMpDQo+ID4gLQkJcmV0dXJuIGZhbHNlOw0KPiA+IC0N Cj4gPiAgCS8qIFdBIERpc3BsYXkgIzA4Mjc6IEdlbjk6YWxsICovDQo+ID4gLQlpZiAoSVNfR0VO KGRldl9wcml2LCA5KSAmJiAhSVNfR0VNSU5JTEFLRShkZXZfcHJpdikpDQo+ID4gKwlpZiAoISFj cnRjX3N0YXRlLT5udjEyX3BsYW5lcyAmJiBJU19HRU4oZGV2X3ByaXYsIDkpICYmDQo+ID4gKwkg ICAgIUlTX0dFTUlOSUxBS0UoZGV2X3ByaXYpKQ0KPiA+ICsJCXJldHVybiB0cnVlOw0KPiA+ICsN Cj4gPiArCS8qDQo+ID4gKwkgKiBXYV8yMDA2NjA0MzEyOmljbA0KPiA+ICsJICovDQo+ID4gKwlp ZiAoSVNfSUNFTEFLRShkZXZfcHJpdikgJiYgY3J0Y19zdGF0ZS0+cGNoX3BmaXQuZW5hYmxlZCkN Cj4gPiAgCQlyZXR1cm4gdHJ1ZTsNCj4gPiAgDQo+ID4gIAlyZXR1cm4gZmFsc2U7DQo+ID4gQEAg LTU1MjcsMTAgKzU1NDMsMTIgQEAgc3RhdGljIHZvaWQgaW50ZWxfcG9zdF9wbGFuZV91cGRhdGUo c3RydWN0DQo+ID4gaW50ZWxfY3J0Y19zdGF0ZSAqb2xkX2NydGNfc3RhdGUpDQo+ID4gIAkJCWlu dGVsX3Bvc3RfZW5hYmxlX3ByaW1hcnkoJmNydGMtPmJhc2UsDQo+ID4gcGlwZV9jb25maWcpOw0K PiA+ICAJfQ0KPiA+ICANCj4gPiAtCS8qIERpc3BsYXkgV0EgODI3ICovDQo+ID4gLQlpZiAobmVl ZHNfbnYxMl93YShkZXZfcHJpdiwgb2xkX2NydGNfc3RhdGUpICYmDQo+ID4gLQkgICAgIW5lZWRz X252MTJfd2EoZGV2X3ByaXYsIHBpcGVfY29uZmlnKSkgew0KPiA+IC0JCXNrbF93YV9jbGtnYXRl KGRldl9wcml2LCBjcnRjLT5waXBlLCBmYWxzZSk7DQo+ID4gKwlpZiAoc2tsX25lZWRzX2Nsa193 YShkZXZfcHJpdiwgb2xkX2NydGNfc3RhdGUpICYmDQo+ID4gKwkgICAgIXNrbF9uZWVkc19jbGtf d2EoZGV2X3ByaXYsIHBpcGVfY29uZmlnKSkgew0KPiA+ICsJCWlmIChJU19JQ0VMQUtFKGRldl9w cml2KSkNCj4gPiArCQkJaWNsX3dhX2Nsa2dhdGUoZGV2X3ByaXYsIGNydGMtPnBpcGUsIGZhbHNl KTsNCj4gPiArCQllbHNlDQo+ID4gKwkJCXNrbF93YV9jbGtnYXRlKGRldl9wcml2LCBjcnRjLT5w aXBlLCBmYWxzZSk7DQo+ID4gIAl9DQo+ID4gIH0NCj4gPiAgDQo+ID4gQEAgLTU1NjYsMTAgKzU1 ODQsMTIgQEAgc3RhdGljIHZvaWQgaW50ZWxfcHJlX3BsYW5lX3VwZGF0ZShzdHJ1Y3QNCj4gPiBp bnRlbF9jcnRjX3N0YXRlICpvbGRfY3J0Y19zdGF0ZSwNCj4gPiAgCQkJaW50ZWxfc2V0X2NwdV9m aWZvX3VuZGVycnVuX3JlcG9ydGluZyhkZXZfcHJpdiwNCj4gPiBjcnRjLT5waXBlLCBmYWxzZSk7 DQo+ID4gIAl9DQo+ID4gIA0KPiA+IC0JLyogRGlzcGxheSBXQSA4MjcgKi8NCj4gPiAtCWlmICgh bmVlZHNfbnYxMl93YShkZXZfcHJpdiwgb2xkX2NydGNfc3RhdGUpICYmDQo+ID4gLQkgICAgbmVl ZHNfbnYxMl93YShkZXZfcHJpdiwgcGlwZV9jb25maWcpKSB7DQo+ID4gLQkJc2tsX3dhX2Nsa2dh dGUoZGV2X3ByaXYsIGNydGMtPnBpcGUsIHRydWUpOw0KPiA+ICsJaWYgKCFza2xfbmVlZHNfY2xr X3dhKGRldl9wcml2LCBvbGRfY3J0Y19zdGF0ZSkgJiYNCj4gPiArCSAgICBza2xfbmVlZHNfY2xr X3dhKGRldl9wcml2LCBwaXBlX2NvbmZpZykpIHsNCj4gPiArCQlpZiAoSVNfSUNFTEFLRShkZXZf cHJpdikpDQo+ID4gKwkJCWljbF93YV9jbGtnYXRlKGRldl9wcml2LCBjcnRjLT5waXBlLCB0cnVl KTsNCj4gPiArCQllbHNlDQo+ID4gKwkJCXNrbF93YV9jbGtnYXRlKGRldl9wcml2LCBjcnRjLT5w aXBlLCB0cnVlKTsNCj4gPiAgCX0NCj4gPiAgDQo+ID4gIAkvKg0KPiA+IC0tIA0KPiA+IDIuMjAu MC5yYzIuNy5nOTY1Nzk4ZDFmMjk5DQo+IA0KPiANCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2ludGVsLWdmeA==