From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A37B1C55191 for ; Sun, 26 Apr 2020 11:50:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8BB8C206CD for ; Sun, 26 Apr 2020 11:50:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726296AbgDZLu2 (ORCPT ); Sun, 26 Apr 2020 07:50:28 -0400 Received: from mx2.suse.de ([195.135.220.15]:34706 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726131AbgDZLu1 (ORCPT ); Sun, 26 Apr 2020 07:50:27 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 000ABAB64; Sun, 26 Apr 2020 11:50:24 +0000 (UTC) Subject: Re: [PATCH v3 2/3] dt-bindings: arm: actions: Document Caninos Loucos Labrador To: Matheus Castello Cc: manivannan.sadhasivam@linaro.org, mark.rutland@arm.com, robh+dt@kernel.org, edgar.righi@lsitec.org.br, igor.lima@lsitec.org.br, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-actions@lists.infradead.org References: <20200229104358.GB19610@mani> <20200320035104.26139-1-matheus@castello.eng.br> <20200320035104.26139-3-matheus@castello.eng.br> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Organization: SUSE Software Solutions Germany GmbH Message-ID: <99c5fa14-cc2d-3692-fc6e-8e3fa77c5ab0@suse.de> Date: Sun, 26 Apr 2020 13:50:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200320035104.26139-3-matheus@castello.eng.br> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org + linux-actions Am 20.03.20 um 04:51 schrieb Matheus Castello: > Update the documentation to add the Caninos Loucos Labrador. Labrador > project consists of a computer on module based on the Actions Semi S500 > processor and the Labrador base board. > > Signed-off-by: Matheus Castello > --- > Documentation/devicetree/bindings/arm/actions.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/actions.yaml b/Documentation/devicetree/bindings/arm/actions.yaml > index ace3fdaa8396..1b131ceb884a 100644 > --- a/Documentation/devicetree/bindings/arm/actions.yaml > +++ b/Documentation/devicetree/bindings/arm/actions.yaml > @@ -24,6 +24,11 @@ properties: > - lemaker,guitar-bb-rev-b # LeMaker Guitar Base Board rev. B > - const: lemaker,guitar > - const: actions,s500 > + - items: > + - enum: > + - caninos,labrador-bb # Caninos Loucos Labrador Base Board > + - const: caninos,labrador > + - const: actions,s500 > > # The Actions Semi S700 is a quad-core ARM Cortex-A53 SoC. > - items: Now that you chose to stick with caninos rather than lsi prefix, the sort order compared to lemaker remains wrong. Looking at https://caninosloucos.org/en/labrador-en/ there's a "CORE BOARD V2.0" and a "BASE BOARD M V1.0". Assuming the v2 is not software-relevant, shouldn't the M be reflected in the compatible string? For example, "caninos,labrador-core" and "caninos,labrador-m"? You're free to use -bb-m of course, but no need to copy LeMaker -bb naming for your board. What does your PCB say? Also note that other recent bindings have been using a description attribute - not sure whether we can apply that a) to the SoM and b) to the base board here. Please compare other in-tree bindings. Regards, Andreas -- SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer HRB 36809 (AG Nürnberg) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B232CC55191 for ; Sun, 26 Apr 2020 11:50:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 87B91206CD for ; Sun, 26 Apr 2020 11:50:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XBNX+Dk7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 87B91206CD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Bl5AM6j3Z9mS4FFf5TVsyVP0o7f6dRq+X9N6gKeYHAg=; b=XBNX+Dk7KvykoMJz3rh265Qtx P9PmsJWjZMWrakrmJVeq0sJdy+N7toJ2eEHanKGPijeM5ZBQg6QQ4DAVchz5i1uLQ8k6IV0aSmk4S 8AQNsAupHHUQkPbLMBoq86oLwNks85Z6g/azNUxOY/su2oPjn2lSp6ziH7aQapZBIJfL+dtwUT9M9 O2BQkqpXZDlS1SuqnpIsQH1B5zG2y8NGITED3G6pky7lpJDeRPyd8aKOX881tPgkVWvuzeW38AeBq iUgArnnu/MajNTRXaC5m5pFaSKYrEplRjDCSIQQveOE2einxCvEQZ9kemzCk3oEwmMVkVsrayUJbl oNfvs935Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jSfnq-00028E-QZ; Sun, 26 Apr 2020 11:50:30 +0000 Received: from mx2.suse.de ([195.135.220.15]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jSfnn-00027H-PA; Sun, 26 Apr 2020 11:50:29 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 000ABAB64; Sun, 26 Apr 2020 11:50:24 +0000 (UTC) Subject: Re: [PATCH v3 2/3] dt-bindings: arm: actions: Document Caninos Loucos Labrador To: Matheus Castello References: <20200229104358.GB19610@mani> <20200320035104.26139-1-matheus@castello.eng.br> <20200320035104.26139-3-matheus@castello.eng.br> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Organization: SUSE Software Solutions Germany GmbH Message-ID: <99c5fa14-cc2d-3692-fc6e-8e3fa77c5ab0@suse.de> Date: Sun, 26 Apr 2020 13:50:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200320035104.26139-3-matheus@castello.eng.br> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200426_045027_966891_B253E102 X-CRM114-Status: GOOD ( 17.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, manivannan.sadhasivam@linaro.org, igor.lima@lsitec.org.br, edgar.righi@lsitec.org.br, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org KyBsaW51eC1hY3Rpb25zCgpBbSAyMC4wMy4yMCB1bSAwNDo1MSBzY2hyaWViIE1hdGhldXMgQ2Fz dGVsbG86Cj4gVXBkYXRlIHRoZSBkb2N1bWVudGF0aW9uIHRvIGFkZCB0aGUgQ2FuaW5vcyBMb3Vj b3MgTGFicmFkb3IuIExhYnJhZG9yCj4gcHJvamVjdCBjb25zaXN0cyBvZiBhIGNvbXB1dGVyIG9u IG1vZHVsZSBiYXNlZCBvbiB0aGUgQWN0aW9ucyBTZW1pIFM1MDAKPiBwcm9jZXNzb3IgYW5kIHRo ZSBMYWJyYWRvciBiYXNlIGJvYXJkLgo+IAo+IFNpZ25lZC1vZmYtYnk6IE1hdGhldXMgQ2FzdGVs bG8gPG1hdGhldXNAY2FzdGVsbG8uZW5nLmJyPgo+IC0tLQo+ICAgRG9jdW1lbnRhdGlvbi9kZXZp Y2V0cmVlL2JpbmRpbmdzL2FybS9hY3Rpb25zLnlhbWwgfCA1ICsrKysrCj4gICAxIGZpbGUgY2hh bmdlZCwgNSBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRpb24vZGV2 aWNldHJlZS9iaW5kaW5ncy9hcm0vYWN0aW9ucy55YW1sIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0 cmVlL2JpbmRpbmdzL2FybS9hY3Rpb25zLnlhbWwKPiBpbmRleCBhY2UzZmRhYTgzOTYuLjFiMTMx Y2ViODg0YSAxMDA2NDQKPiAtLS0gYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3Mv YXJtL2FjdGlvbnMueWFtbAo+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5n cy9hcm0vYWN0aW9ucy55YW1sCj4gQEAgLTI0LDYgKzI0LDExIEBAIHByb3BlcnRpZXM6Cj4gICAg ICAgICAgICAgICAgIC0gbGVtYWtlcixndWl0YXItYmItcmV2LWIgIyBMZU1ha2VyIEd1aXRhciBC YXNlIEJvYXJkIHJldi4gQgo+ICAgICAgICAgICAgIC0gY29uc3Q6IGxlbWFrZXIsZ3VpdGFyCj4g ICAgICAgICAgICAgLSBjb25zdDogYWN0aW9ucyxzNTAwCj4gKyAgICAgIC0gaXRlbXM6Cj4gKyAg ICAgICAgICAtIGVudW06Cj4gKyAgICAgICAgICAgICAgLSBjYW5pbm9zLGxhYnJhZG9yLWJiICMg Q2FuaW5vcyBMb3Vjb3MgTGFicmFkb3IgQmFzZSBCb2FyZAo+ICsgICAgICAgICAgLSBjb25zdDog Y2FuaW5vcyxsYWJyYWRvcgo+ICsgICAgICAgICAgLSBjb25zdDogYWN0aW9ucyxzNTAwCj4gCj4g ICAgICAgICAjIFRoZSBBY3Rpb25zIFNlbWkgUzcwMCBpcyBhIHF1YWQtY29yZSBBUk0gQ29ydGV4 LUE1MyBTb0MuCj4gICAgICAgICAtIGl0ZW1zOgoKTm93IHRoYXQgeW91IGNob3NlIHRvIHN0aWNr IHdpdGggY2FuaW5vcyByYXRoZXIgdGhhbiBsc2kgcHJlZml4LCB0aGUgCnNvcnQgb3JkZXIgY29t cGFyZWQgdG8gbGVtYWtlciByZW1haW5zIHdyb25nLgoKTG9va2luZyBhdCBodHRwczovL2Nhbmlu b3Nsb3Vjb3Mub3JnL2VuL2xhYnJhZG9yLWVuLyB0aGVyZSdzIGEgIkNPUkUgCkJPQVJEIFYyLjAi IGFuZCBhICJCQVNFIEJPQVJEIE0gVjEuMCIuCgpBc3N1bWluZyB0aGUgdjIgaXMgbm90IHNvZnR3 YXJlLXJlbGV2YW50LCBzaG91bGRuJ3QgdGhlIE0gYmUgcmVmbGVjdGVkIAppbiB0aGUgY29tcGF0 aWJsZSBzdHJpbmc/IEZvciBleGFtcGxlLCAiY2FuaW5vcyxsYWJyYWRvci1jb3JlIiBhbmQgCiJj YW5pbm9zLGxhYnJhZG9yLW0iPyBZb3UncmUgZnJlZSB0byB1c2UgLWJiLW0gb2YgY291cnNlLCBi dXQgbm8gbmVlZCB0byAKY29weSBMZU1ha2VyIC1iYiBuYW1pbmcgZm9yIHlvdXIgYm9hcmQuIFdo YXQgZG9lcyB5b3VyIFBDQiBzYXk/CgpBbHNvIG5vdGUgdGhhdCBvdGhlciByZWNlbnQgYmluZGlu Z3MgaGF2ZSBiZWVuIHVzaW5nIGEgZGVzY3JpcHRpb24gCmF0dHJpYnV0ZSAtIG5vdCBzdXJlIHdo ZXRoZXIgd2UgY2FuIGFwcGx5IHRoYXQgYSkgdG8gdGhlIFNvTSBhbmQgYikgdG8gCnRoZSBiYXNl IGJvYXJkIGhlcmUuIFBsZWFzZSBjb21wYXJlIG90aGVyIGluLXRyZWUgYmluZGluZ3MuCgpSZWdh cmRzLApBbmRyZWFzCgotLSAKU1VTRSBTb2Z0d2FyZSBTb2x1dGlvbnMgR2VybWFueSBHbWJICk1h eGZlbGRzdHIuIDUsIDkwNDA5IE7DvHJuYmVyZywgR2VybWFueQpHRjogRmVsaXggSW1lbmTDtnJm ZmVyCkhSQiAzNjgwOSAoQUcgTsO8cm5iZXJnKQoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgt YXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3Jn L21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=