Re: [RFC/PATCH v2 11/22] s390/mm: Remove superfluous parameter

[Janosch Frank <frankja@linux.vnet.ibm.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1500 bytes --]

On 21.12.2017 10:22, Janosch Frank wrote:
> On 13.12.2017 13:53, Janosch Frank wrote:
>> It seems it hasn't even been used before the last cleanup and was
>> overlooked.
> 
> This one is an independent cleanup.
> 
> Can we move this out of this series and schedule it for earlier
> inclusion into mainline?

Polite ping
pte has never been used, not even when it was introduced by Martin.

> 
>>
>> Signed-off-by: Janosch Frank <frankja@linux.vnet.ibm.com>
>> ---
>>  arch/s390/mm/gmap.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/s390/mm/gmap.c b/arch/s390/mm/gmap.c
>> index ffc11d8..d396da8 100644
>> --- a/arch/s390/mm/gmap.c
>> +++ b/arch/s390/mm/gmap.c
>> @@ -2237,7 +2237,7 @@ EXPORT_SYMBOL_GPL(gmap_shadow_page);
>>   * Called with sg->parent->shadow_lock.
>>   */
>>  static void gmap_shadow_notify(struct gmap *sg, unsigned long vmaddr,
>> -			       unsigned long gaddr, pte_t *pte)
>> +			       unsigned long gaddr)
>>  {
>>  	struct gmap_rmap *rmap, *rnext, *head;
>>  	unsigned long start, end, bits, raddr;
>> @@ -2322,7 +2322,7 @@ void ptep_notify(struct mm_struct *mm, unsigned long vmaddr,
>>  			spin_lock(&gmap->shadow_lock);
>>  			list_for_each_entry_safe(sg, next,
>>  						 &gmap->children, list)
>> -				gmap_shadow_notify(sg, vmaddr, gaddr, pte);
>> +				gmap_shadow_notify(sg, vmaddr, gaddr);
>>  			spin_unlock(&gmap->shadow_lock);
>>  		}
>>  		if (bits & PGSTE_IN_BIT)
>>
> 
> 



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]