From mboxrd@z Thu Jan 1 00:00:00 1970 From: Remy Horton Subject: Re: xstats performance Date: Fri, 1 Jul 2016 10:15:27 +0100 Message-ID: <99e03d76-b896-2146-274c-2f3d83eee899@intel.com> References: <5773EB79.1090509@6wind.com> <8870166.MVVViF2IlQ@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, Olivier MATZ To: Thomas Monjalon Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id D30AB1DB1 for ; Fri, 1 Jul 2016 11:15:30 +0200 (CEST) In-Reply-To: <8870166.MVVViF2IlQ@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 29/06/2016 17:40, Thomas Monjalon wrote: [..] > I don't think it is possible to standardize stats ids, for two reasons: > - it is hard to maintain and avoid conflicts between drivers > - the drivers would have to lookup the names which degrades performance I designed it that way to keep flexibility down the line rather than specifically for the above use-case. > I think the idea of Olivier would improve the performance of stats retrieval, > which was the idea of this rework :) > Unfortunately we need someone available to fix it quickly for RC2. For all the current drivers xstats_names[idx].id==idx so it would just involve removing the references to the id field and updating the documentation. Complication is coordinating with QLogic for the bnx2x & qede xstats patches. ..Remy