All of lore.kernel.org
 help / color / mirror / Atom feed
From: anton.wuerfel@fau.de
To: "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org,
	linux-kernel@i4.cs.fau.de, anton.wuerfel@fau.de,
	phillip.raffeck@fau.de
Subject: Re: [PATCH 08/11] tty: serial: 8250: Add parentheses to macro
Date: Fri, 18 Dec 2015 12:36:36 +0100	[thread overview]
Message-ID: <99efe3549ef3d0b399b78b2f8f66947c.squirrel@faumail.uni-erlangen.de> (raw)
In-Reply-To: <1450365401.30729.142.camel@linux.intel.com>

Hello Andy,

> What about the rest of the drivers under drivers/tty/serial?
>
> What do you propose to do with, for example, the following
>
> drivers/tty/serial/cpm_uart/cpm_uart_core.c:1392:#define
> CPM_UART_CONSOLE=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0&cpm_scc_ua=
rt_console
> drivers/tty/serial/cpm_uart/cpm_uart_core.c:1394:#define
> CPM_UART_CONSOLE=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0NULL
>
>> =C2=A0#else
>> =C2=A0#define SERIAL8250_CONSOLE	NULL
>> =C2=A0#endif
>

thanks for your reply. Phillip and me are newcomers to kernel developme=
nt,
so we tried to touch as few files as possible and gain some experience =
in
creating patches and communication on LKML. We will consider sending
further patches in the future.

Regards,
Phillip Raffeck
Anton Wuerfel

> --
> Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Intel Finland Oy
>
>


--
To unsubscribe from this list: send the line "unsubscribe linux-parisc"=
 in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: anton.wuerfel@fau.de
To: "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org,
	linux-kernel@i4.cs.fau.de, anton.wuerfel@fau.de,
	phillip.raffeck@fau.de
Subject: Re: [PATCH 08/11] tty: serial: 8250: Add parentheses to macro
Date: Fri, 18 Dec 2015 12:36:36 +0100	[thread overview]
Message-ID: <99efe3549ef3d0b399b78b2f8f66947c.squirrel@faumail.uni-erlangen.de> (raw)
In-Reply-To: <1450365401.30729.142.camel@linux.intel.com>

Hello Andy,

> What about the rest of the drivers under drivers/tty/serial?
>
> What do you propose to do with, for example, the following
>
> drivers/tty/serial/cpm_uart/cpm_uart_core.c:1392:#define
> CPM_UART_CONSOLE       &cpm_scc_uart_console
> drivers/tty/serial/cpm_uart/cpm_uart_core.c:1394:#define
> CPM_UART_CONSOLE       NULL
>
>>  #else
>>  #define SERIAL8250_CONSOLE	NULL
>>  #endif
>

thanks for your reply. Phillip and me are newcomers to kernel development,
so we tried to touch as few files as possible and gain some experience in
creating patches and communication on LKML. We will consider sending
further patches in the future.

Regards,
Phillip Raffeck
Anton Wuerfel

> --
> Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Intel Finland Oy
>
>



  reply	other threads:[~2015-12-18 11:36 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-16 15:36 [PATCH 00/11] tty: serial: 8250: Fix checkpatch warnings Anton Wuerfel
2015-12-16 15:36 ` Anton Wuerfel
2015-12-16 15:36 ` Anton Wuerfel
2015-12-16 15:36 ` [PATCH 01/11] tty: serial: 8250: Fix whitespace errors Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 16:43   ` Peter Hurley
2015-12-16 16:43     ` Peter Hurley
2015-12-16 16:43     ` Peter Hurley
2015-12-16 15:36 ` [PATCH 02/11] tty: serial: 8250: Fix indentation warnings Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 16:49   ` Peter Hurley
2015-12-16 16:49     ` Peter Hurley
2015-12-16 16:49     ` Peter Hurley
2015-12-16 15:36 ` [PATCH 03/11] tty: serial: 8250: Fix braces after struct Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36 ` [PATCH 04/11] tty: serial: 8250: Fix multiline comment style Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 16:52   ` Peter Hurley
2015-12-16 16:52     ` Peter Hurley
2015-12-16 16:52     ` Peter Hurley
2015-12-16 15:36 ` [PATCH 05/11] tty: serial: 8250: Remove else after return Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36 ` [PATCH 06/11] tty: serial: 8250: Move EXPORT_SYMBOL to function Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 17:06   ` Peter Hurley
2015-12-16 17:06     ` Peter Hurley
2015-12-16 17:06     ` Peter Hurley
2015-12-16 15:36 ` [PATCH 07/11] tty: serial: 8250: Fix line continuation warning Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36 ` [PATCH 08/11] tty: serial: 8250: Add parentheses to macro Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-17 15:16   ` Andy Shevchenko
2015-12-17 15:16     ` Andy Shevchenko
2015-12-18 11:36     ` anton.wuerfel [this message]
2015-12-18 11:36       ` anton.wuerfel
2015-12-18 12:35       ` Andy Shevchenko
2015-12-18 12:35         ` Andy Shevchenko
2015-12-16 15:36 ` [PATCH 09/11] tty: serial: 8250: Fix multi-line strings Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36 ` [PATCH 10/11] tty: serial: 8250: Replace printk by pr_* Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 17:00   ` Peter Hurley
2015-12-16 17:00     ` Peter Hurley
2015-12-16 17:00     ` Peter Hurley
2015-12-16 15:36 ` [PATCH 11/11] tty: serial: 8250: Delete commented code Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 15:36   ` Anton Wuerfel
2015-12-16 17:05   ` Peter Hurley
2015-12-16 17:05     ` Peter Hurley
2015-12-16 17:05     ` Peter Hurley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=99efe3549ef3d0b399b78b2f8f66947c.squirrel@faumail.uni-erlangen.de \
    --to=anton.wuerfel@fau.de \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=linux-kernel@i4.cs.fau.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=phillip.raffeck@fau.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.