From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Philippe Brucker Subject: Re: [PATCH v7 0/7] Add virtio-iommu driver Date: Tue, 28 May 2019 10:18:21 +0100 Message-ID: <99ff5494-bfdf-f4ef-b2d2-c177add385c6__22632.5298471906$1559035219$gmane$org@arm.com> References: <20190115121959.23763-1-jean-philippe.brucker@arm.com> <20190512123022-mutt-send-email-mst@kernel.org> <20190527092604.GB21613@8bytes.org> <20190527111345-mutt-send-email-mst@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190527111345-mutt-send-email-mst@kernel.org> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: "Michael S. Tsirkin" , Joerg Roedel Cc: Mark Rutland , "virtio-dev@lists.oasis-open.org" , Lorenzo Pieralisi , "tnowicki@caviumnetworks.com" , "devicetree@vger.kernel.org" , Marc Zyngier , "linux-pci@vger.kernel.org" , Will Deacon , Robin Murphy , "virtualization@lists.linux-foundation.org" , "eric.auger@redhat.com" , "iommu@lists.linux-foundation.org" , "robh+dt@kernel.org" , "bhelgaas@google.com" , "kvmarm@lists.cs.columbia.edu" List-Id: virtualization@lists.linuxfoundation.org On 27/05/2019 16:15, Michael S. Tsirkin wrote: > On Mon, May 27, 2019 at 11:26:04AM +0200, Joerg Roedel wrote: >> On Sun, May 12, 2019 at 12:31:59PM -0400, Michael S. Tsirkin wrote: >>> OK this has been in next for a while. >>> >>> Last time IOMMU maintainers objected. Are objections >>> still in force? >>> >>> If not could we get acks please? >> >> No objections against the code, I only hesitated because the Spec was >> not yet official. >> >> So for the code: >> >> Acked-by: Joerg Roedel > > Last spec patch had a bunch of comments not yet addressed. > But I do not remember whether comments are just about wording > or about the host/guest interface as well. > Jean-Philippe could you remind me please? It's mostly wording, but there is a small change in the config space layout and two new feature bits. I'll send a new version of the driver when possible. Thanks, Jean