From: Christian Zigotzky <chzigotzky@xenosoft.de>
To: Christophe Leroy <christophe.leroy@c-s.fr>,
linuxppc-dev@lists.ozlabs.org,
Michael Ellerman <mpe@ellerman.id.au>
Subject: VLC doesn't play videos anymore since the PowerPC fixes 5.1-3
Date: Thu, 4 Apr 2019 10:44:13 +0200 [thread overview]
Message-ID: <99ff68a4-3aef-47ad-99f8-433b181afe3f@xenosoft.de> (raw)
In-Reply-To: <5726a634-25ca-d267-17fd-af88436edf1f@c-s.fr>
On 04 April 2019 at 06:00AM, Christophe Leroy wrote:
>
>
> Le 04/04/2019 à 02:58, Christian Zigotzky a écrit :
>> On 03 April 2019 at 07:05AM, Christophe Leroy wrote:
>>> Le 03/04/2019 à 05:52, Christian Zigotzky a écrit :
>>>> Please test VLC with the RC3 of kernel 5.1.
>>>>
>>>> The removing of the PowerPC fixes 5.1-3 has solved the VLC issue.
>>>> Another user has already confirmed that [1]. This isn’t an April
>>>> Fool‘s. ;-)
>>>
>>> Could you bisect to identify the guilty commit ?
>>>
>>> Thanks
>>> Christophe
>>>
>>>>
>>>> Thanks
>>>>
>>>> [1]
>>>> http://forum.hyperion-entertainment.com/viewtopic.php?f=58&t=4256&start=20#p47561
>>>>
>>>>
>>>
>> Hello Christophe,
>>
>> I have found the problematic patch. The following patch from the
>> PowerPC fixes 5.1-3 is responsible for the VLC issue.
>
> That change is part of the following commit:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.1-rc2&id=b5b4453e7912f056da1ca7572574cada32ecb60c
>
>
> Just changing back the type of wtom_clock_sec to 32 bits without
> changing back the loading instruction is likely to give unexpected
> results on PPC64.
>
> Are you using 32 bits or 64 bits powerpc ?
>
> Christophe
64-bit kernel + 32-bit userland for example:
- ubuntu MATE 16.04.6 LTS 32-bit PowerPC with a 64-bit kernel
- Fienix (Debian Sid) 32-bit PowerPC with a 64-bit kernel
- MATE PowerPC Remix (ubuntu MATE 17.04) 32-bit PowerPC with a 64-bit kernel
-- Christian
>
>
>>
>> diff --git a/arch/powerpc/include/asm/vdso_datapage.h
>> b/arch/powerpc/include/asm/vdso_datapage.h
>> index 1afe90ade595..bbc06bd72b1f 100644
>> --- a/arch/powerpc/include/asm/vdso_datapage.h
>> +++ b/arch/powerpc/include/asm/vdso_datapage.h
>> @@ -82,10 +82,10 @@ struct vdso_data {
>> __u32 icache_block_size; /* L1 i-cache block size */
>> __u32 dcache_log_block_size; /* L1 d-cache log block size */
>> __u32 icache_log_block_size; /* L1 i-cache log block size */
>> - __s32 wtom_clock_sec; /* Wall to monotonic clock */
>> - __s32 wtom_clock_nsec;
>> - struct timespec stamp_xtime; /* xtime as at tb_orig_stamp */
>> - __u32 stamp_sec_fraction; /* fractional seconds of stamp_xtime */
>> + __u32 stamp_sec_fraction; /* fractional seconds of
>> stamp_xtime */
>> + __s32 wtom_clock_nsec; /* Wall to monotonic clock nsec */
>> + __s64 wtom_clock_sec; /* Wall to monotonic clock sec */
>> + struct timespec stamp_xtime; /* xtime as at tb_orig_stamp */
>> __u32 syscall_map_64[SYSCALL_MAP_SIZE]; /* map of syscalls */
>> __u32 syscall_map_32[SYSCALL_MAP_SIZE]; /* map of syscalls */
>> };
>>
>> -----
>>
>> Link:
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/diff/arch/powerpc/include/asm/vdso_datapage.h?h=v5.1-rc2&id=a5ed1e96cafde5ba48638f486bfca0685dc6ddc9
>>
>>
>> I created a patch for solving the VLC issue today.
>>
>> vdso_datapage_vlc.patch:
>>
>> diff -rupN a/arch/powerpc/include/asm/vdso_datapage.h
>> b/arch/powerpc/include/asm/vdso_datapage.h
>> --- a/arch/powerpc/include/asm/vdso_datapage.h 2019-04-03
>> 22:56:44.560645936 +0200
>> +++ b/arch/powerpc/include/asm/vdso_datapage.h 2019-04-04
>> 02:20:09.479361827 +0200
>> @@ -82,10 +82,10 @@ struct vdso_data {
>> __u32 icache_block_size; /* L1 i-cache block
>> size */
>> __u32 dcache_log_block_size; /* L1 d-cache log
>> block size */
>> __u32 icache_log_block_size; /* L1 i-cache log
>> block size */
>> - __u32 stamp_sec_fraction; /* fractional seconds
>> of stamp_xtime */
>> - __s32 wtom_clock_nsec; /* Wall to monotonic
>> clock nsec */
>> - __s64 wtom_clock_sec; /* Wall to monotonic
>> clock sec */
>> - struct timespec stamp_xtime; /* xtime as at
>> tb_orig_stamp */
>> + __s32 wtom_clock_sec; /* Wall to monotonic
>> clock */
>> + __s32 wtom_clock_nsec;
>> + struct timespec stamp_xtime; /* xtime as at tb_orig_stamp */
>> + __u32 stamp_sec_fraction; /* fractional seconds of
>> stamp_xtime */
>> __u32 syscall_map_64[SYSCALL_MAP_SIZE]; /* map of syscalls */
>> __u32 syscall_map_32[SYSCALL_MAP_SIZE]; /* map of syscalls */
>> };
>>
>> -----
>>
>> Cheers,
>> Christian
>
next prev parent reply other threads:[~2019-04-04 8:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 3:52 VLC doesn't play videos anymore since the PowerPC fixes 5.1-3 Christian Zigotzky
2019-04-03 5:05 ` Christophe Leroy
2019-04-04 0:58 ` Christian Zigotzky
2019-04-04 4:00 ` Christophe Leroy
2019-04-04 8:44 ` Christian Zigotzky [this message]
2019-04-04 9:07 ` Christophe Leroy
2019-04-04 11:23 ` Christian Zigotzky
2019-04-04 12:48 ` Christian Zigotzky
-- strict thread matches above, loose matches on Subject: below --
2019-04-02 13:37 Christian Zigotzky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99ff68a4-3aef-47ad-99f8-433b181afe3f@xenosoft.de \
--to=chzigotzky@xenosoft.de \
--cc=christophe.leroy@c-s.fr \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.