From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paul Durrant <Paul.Durrant@citrix.com>
Subject: Re: [PATCH v4 11/17] x86/hvm: only call hvm_io_assist()
 from hvm_wait_for_io()
Date: Wed, 24 Jun 2015 15:50:53 +0000
Message-ID: <9AAE0902D5BC7E449B7C8E4E778ABCD02596D0C2@AMSPEX01CL02.citrite.net>
References: <1435145089-21999-1-git-send-email-paul.durrant@citrix.com>
	<1435145089-21999-12-git-send-email-paul.durrant@citrix.com>
	<558AEAA002000078000890AC@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=6108bc5fa=Paul.Durrant@citrix.com>)
	id 1Z7mwy-0003ru-5I
	for xen-devel@lists.xenproject.org; Wed, 24 Jun 2015 15:50:56 +0000
In-Reply-To: <558AEAA002000078000890AC@mail.emea.novell.com>
Content-Language: en-US
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Andrew Cooper <Andrew.Cooper3@citrix.com>, "Keir (Xen.org)" <keir@xen.org>, "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
List-Id: xen-devel@lists.xenproject.org

> -----Original Message-----
> From: xen-devel-bounces@lists.xen.org [mailto:xen-devel-
> bounces@lists.xen.org] On Behalf Of Jan Beulich
> Sent: 24 June 2015 16:37
> To: Paul Durrant
> Cc: Andrew Cooper; Keir (Xen.org); xen-devel@lists.xenproject.org
> Subject: Re: [Xen-devel] [PATCH v4 11/17] x86/hvm: only call hvm_io_assist()
> from hvm_wait_for_io()
> 
> >>> On 24.06.15 at 13:24, <paul.durrant@citrix.com> wrote:
> > By removing the calls in hvmemul_do_io() (which is replaced by a single
> > assignment) and hvm_complete_assist_request() (which is replaced by a
> > call to process_portio_intercept() with a suitable set of ops) then
> 
> With this saying hvm_process_io_intercept() ...
> 

Ah, good spot :-)

> > hvm_io_assist() can be moved into hvm.c and made static (and hence be a
> > candidate for inlining).
> >
> > This patch also fixes the I/O state test at the end of hvm_io_assist()
> > to check the correct value. Since the ioreq server patch series was
> > integrated the current ioreq state is no longer an indicator of in-flight
> > I/O state, since an I/O sheduled by re-emulation may be targetted at a
> > different ioreq server.
> >
> > Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
> 
> Acked-by: Jan Beulich <jbeulich@suse.com>
> 

Thanks.

  Paul

> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel