From: Paul Durrant <Paul.Durrant@citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>,
Ian Jackson <Ian.Jackson@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Stefano Stabellini <Stefano.Stabellini@citrix.com>,
Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH v2 1/3] libxl: re-name libxl__xs_write() to libxl__xs_printf()...
Date: Wed, 25 Nov 2015 11:27:33 +0000 [thread overview]
Message-ID: <9AAE0902D5BC7E449B7C8E4E778ABCD02F69743E@AMSPEX01CL01.citrite.net> (raw)
In-Reply-To: <1448382161.26412.53.camel@citrix.com>
> -----Original Message-----
> From: Ian Campbell [mailto:ian.campbell@citrix.com]
> Sent: 24 November 2015 16:23
> To: Ian Jackson; Paul Durrant
> Cc: xen-devel@lists.xenproject.org; Stefano Stabellini; Wei Liu
> Subject: Re: [PATCH v2 1/3] libxl: re-name libxl__xs_write() to
> libxl__xs_printf()...
>
> On Mon, 2015-11-16 at 17:15 +0000, Ian Jackson wrote:
> > Paul Durrant writes ("[PATCH v2 1/3] libxl: re-name libxl__xs_write() to
> > libxl__xs_printf()..."):
> > > ...to denote what it actually does.
> > >
> > > The name libxl__xs_write() suggests something taking a buffer and
> > > length,
> > > akin to write(2), whereas the semantics of the function are actually
> > > more
> > > akin to printf(3).
> > >
> > > This patch is a textual substitution of libxl__xs_write with
> > > libxl__xs_printf with some associated formatting fixes.
> >
> > Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
>
> Did you have opinions on the other two patches and/or shall I just apply
> this one in the meantime?
>
Given the discussion (on IRC) about using 'ok' for boolean returns, I'll re-work this patch.
Paul
> Ian.
next prev parent reply other threads:[~2015-11-25 11:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 14:00 [PATCH v2 0/3] libxl: xenstore related cleanup Paul Durrant
2015-11-16 14:00 ` [PATCH v2 1/3] libxl: re-name libxl__xs_write() to libxl__xs_printf() Paul Durrant
2015-11-16 17:15 ` Ian Jackson
2015-11-24 16:22 ` Ian Campbell
2015-11-25 11:27 ` Paul Durrant [this message]
2015-11-16 14:00 ` [PATCH v2 2/3] libxl: check for underlying xenstore operation failure Paul Durrant
2015-11-24 16:48 ` Ian Jackson
2015-11-24 17:24 ` Paul Durrant
2015-11-16 14:00 ` [PATCH v2 3/3] libxl: stop using libxl__xs_mkdir() for ~/control/shutdown Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9AAE0902D5BC7E449B7C8E4E778ABCD02F69743E@AMSPEX01CL01.citrite.net \
--to=paul.durrant@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@citrix.com \
--cc=Stefano.Stabellini@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.