From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============5533815686554596648==" MIME-Version: 1.0 From: Alex Kogan To: kbuild-all@lists.01.org Subject: Re: [PATCH v10 3/5] locking/qspinlock: Introduce CNA into the slow path of qspinlock Date: Tue, 07 Apr 2020 17:57:08 -0400 Message-ID: <9AC3B764-C979-4393-BAA7-5D0EC412539C@oracle.com> In-Reply-To: <202004050749.uDEAXWHu%lkp@intel.com> List-Id: --===============5533815686554596648== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Thank you for the report. The cna_configure_spin_lock_slowpath() function is declared in , but I think that header file is not included for ARCH=3Di386. The attached patch takes care of that. I will fix this issue in the next re= vision of the series. Best regards, =E2=80=94 Alex > On Apr 4, 2020, at 7:25 PM, kbuild test robot wrote: > = > Hi Alex, > = > Thank you for the patch! Yet something to improve: > = > [auto build test ERROR on tip/locking/core] > [also build test ERROR on arm/for-next linus/master tip/x86/core v5.6 nex= t-20200404] > [if your patch is applied to the wrong git tree, please drop us a note to= help > improve the system. BTW, we also suggest to use '--base' option to specif= y the > base tree in git format-patch, please see https://urldefense.com/v3/__htt= ps://stackoverflow.com/a/37406982__;!!GqivPVa7Brio!Lqc3AwNlFOKA7cagALf2nrTI= W1vs51gNE0IpUwdbGXHSNkBrdGd3foFN0-mVET_7$ ] > = > url: https://urldefense.com/v3/__https://github.com/0day-ci/linux/comm= its/Alex-Kogan/Add-NUMA-awareness-to-qspinlock/20200405-045543__;!!GqivPVa7= Brio!Lqc3AwNlFOKA7cagALf2nrTIW1vs51gNE0IpUwdbGXHSNkBrdGd3foFN0-8wHcpi$ = > base: https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/= kernel/git/tip/tip.git__;!!GqivPVa7Brio!Lqc3AwNlFOKA7cagALf2nrTIW1vs51gNE0I= pUwdbGXHSNkBrdGd3foFN0zsCtG8K$ f1e67e355c2aafeddf1eac31335709236996d2fe > config: i386-alldefconfig (attached as .config) > compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0 > reproduce: > # save the attached .config to linux build tree > make ARCH=3Di386 = > = > If you fix the issue, kindly add following tag as appropriate > Reported-by: kbuild test robot > = > All errors (new ones prefixed by >>): > = > arch/x86/kernel/alternative.c: In function 'alternative_instructions': >>> arch/x86/kernel/alternative.c:742:2: error: implicit declaration of fun= ction 'cna_configure_spin_lock_slowpath' [-Werror=3Dimplicit-function-decla= ration] > cna_configure_spin_lock_slowpath(); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > cc1: some warnings being treated as errors > = > vim +/cna_configure_spin_lock_slowpath +742 arch/x86/kernel/alternative.c > = > 741 = >> 742 cna_configure_spin_lock_slowpath(); > 743 = > 744 apply_paravirt(__parainstructions, __parainstructions_end); > 745 = > 746 restart_nmi(); > 747 alternatives_patched =3D 1; > 748 } > 749 = > = > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://urldefense.com/v3/__https://lists.01.org/hyperkitty/list/kbuild-a= ll(a)lists.01.org__;!!GqivPVa7Brio!Lqc3AwNlFOKA7cagALf2nrTIW1vs51gNE0IpUwdb= GXHSNkBrdGd3foFN01EKECWp$ = > <.config.gz> --===============5533815686554596648== Content-Type: application/octet-stream MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-locking-qspinlock-Fix-compilation-error-on-ARCH-i386.patch" RnJvbSA2ZGQ3YjUwMTgzZmZiZGVkMDBkNjc0NDBhYmJlNTdjMDFmMWY2MjBiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGV4IEtvZ2FuIDxhbGV4LmtvZ2FuQG9yYWNsZS5jb20+CkRh dGU6IFR1ZSwgNyBBcHIgMjAyMCAxNzoyMTowMCAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIGxvY2tp bmcvcXNwaW5sb2NrOiBGaXggY29tcGlsYXRpb24gZXJyb3Igb24gQVJDSD1pMzg2CgpTaWduZWQt b2ZmLWJ5OiBBbGV4IEtvZ2FuIDxhbGV4LmtvZ2FuQG9yYWNsZS5jb20+ClJlcG9ydGVkLWJ5OiBr YnVpbGQgdGVzdCByb2JvdCA8bGtwQGludGVsLmNvbT4KLS0tCiBhcmNoL3g4Ni9pbmNsdWRlL2Fz bS9xc3BpbmxvY2suaCB8IDIgLS0KIGFyY2gveDg2L2tlcm5lbC9hbHRlcm5hdGl2ZS5jICAgIHwg MiArKwogMiBmaWxlcyBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpk aWZmIC0tZ2l0IGEvYXJjaC94ODYvaW5jbHVkZS9hc20vcXNwaW5sb2NrLmggYi9hcmNoL3g4Ni9p bmNsdWRlL2FzbS9xc3BpbmxvY2suaAppbmRleCA1YTMwMjdkOGVhMjcuLmZlNDg4NGI2ZjFiNCAx MDA2NDQKLS0tIGEvYXJjaC94ODYvaW5jbHVkZS9hc20vcXNwaW5sb2NrLmgKKysrIGIvYXJjaC94 ODYvaW5jbHVkZS9hc20vcXNwaW5sb2NrLmgKQEAgLTI5LDggKzI5LDYgQEAgc3RhdGljIF9fYWx3 YXlzX2lubGluZSB1MzIgcXVldWVkX2ZldGNoX3NldF9wZW5kaW5nX2FjcXVpcmUoc3RydWN0IHFz cGlubG9jayAqbG8KIAogI2lmZGVmIENPTkZJR19OVU1BX0FXQVJFX1NQSU5MT0NLUwogZXh0ZXJu IHZvaWQgY25hX2NvbmZpZ3VyZV9zcGluX2xvY2tfc2xvd3BhdGgodm9pZCk7Ci0jZWxzZQotc3Rh dGljIGlubGluZSB2b2lkIGNuYV9jb25maWd1cmVfc3Bpbl9sb2NrX3Nsb3dwYXRoKHZvaWQpIHsg fQogI2VuZGlmCiAKICNpZmRlZiBDT05GSUdfUEFSQVZJUlRfU1BJTkxPQ0tTCmRpZmYgLS1naXQg YS9hcmNoL3g4Ni9rZXJuZWwvYWx0ZXJuYXRpdmUuYyBiL2FyY2gveDg2L2tlcm5lbC9hbHRlcm5h dGl2ZS5jCmluZGV4IDUwZjc5YThhYTJhOS4uOTJlMDc1ZjA5MjAxIDEwMDY0NAotLS0gYS9hcmNo L3g4Ni9rZXJuZWwvYWx0ZXJuYXRpdmUuYworKysgYi9hcmNoL3g4Ni9rZXJuZWwvYWx0ZXJuYXRp dmUuYwpAQCAtNzM5LDcgKzczOSw5IEBAIHZvaWQgX19pbml0IGFsdGVybmF0aXZlX2luc3RydWN0 aW9ucyh2b2lkKQogCX0KICNlbmRpZgogCisjaWYgZGVmaW5lZChDT05GSUdfTlVNQV9BV0FSRV9T UElOTE9DS1MpCiAJY25hX2NvbmZpZ3VyZV9zcGluX2xvY2tfc2xvd3BhdGgoKTsKKyNlbmRpZgog CiAJYXBwbHlfcGFyYXZpcnQoX19wYXJhaW5zdHJ1Y3Rpb25zLCBfX3BhcmFpbnN0cnVjdGlvbnNf ZW5kKTsKIAotLSAKMi4yMS4xIChBcHBsZSBHaXQtMTIyLjMpCgo= --===============5533815686554596648==--