From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752107AbcFTFdW (ORCPT ); Mon, 20 Jun 2016 01:33:22 -0400 Received: from mga11.intel.com ([192.55.52.93]:40955 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751628AbcFTFdM convert rfc822-to-8bit (ORCPT ); Mon, 20 Jun 2016 01:33:12 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,496,1459839600"; d="scan'208";a="991134948" From: "Rosen, Rami" To: Netanel Belgazal , "netdev@vger.kernel.org" , "davm@davemeloft.net" , "linux-kernel@vger.kernel.org" CC: "zorik@annapurnalabs.com" , "saeed@annapurnalabs.com" , "alex@annapurnalabs.com" , "msw@amazon.com" , "aligouri@amazon.com" , "antoine.tenart@free-electrons.com" , "Rosen, Rami" Subject: RE: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA) Thread-Topic: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA) Thread-Index: AQHRxVDGpT6kAtlSG0KHtgv6iqr3PJ/x2Fvg Date: Mon, 20 Jun 2016 05:20:55 +0000 Message-ID: <9B0331B6EBBD0E4684FBFAEDA55776F92CD6858D@HASMSX110.ger.corp.intel.com> References: <1465807573-11293-1-git-send-email-netanel@annapurnalabs.com> In-Reply-To: <1465807573-11293-1-git-send-email-netanel@annapurnalabs.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTE2YTQxZjQtOTQwNy00MDk3LWI1ZjAtNDRiMDZkNmI4MDJhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InVTUEd2ajZGNEFtYXQxcXVBRU5NcWRCNllqTG5xVHhcL29uRlwvakh5QVltTT0ifQ== x-ctpclassification: CTP_IC x-originating-ip: [10.184.70.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi all, A very limited review below. + + /* get capabilities of particular feature */ + ENA_ADMIN_GET_FEATURE = 8, Instead /* get capabilities SHOULD BE: /* set capabilities ..... + + /* get capabilities of particular feature */ + ENA_ADMIN_SET_FEATURE = 9, + .. +int ena_com_set_hash_ctrl(struct ena_com_dev *ena_dev) +{ + struct ena_com_admin_queue *admin_queue = &ena_dev->admin_queue; ... You set ret=-EINVAL, but you do not use this ret as you immediately return 0 in the next line, which is the end of the method. Either return ret or return -EINVAL. + if (unlikely(ret)) { + ena_trc_err("Failed to set hash input. error: %d\n", ret); + ret = -EINVAL; + } + + return 0; +} + + +/* ena_com_set_mmio_read_mode - Enable/disable the mmio reg read mechanism + * @ena_dev: ENA communication layer struct Instead realess_supported: SHOULD BE: readless_supported + * @realess_supported: readless mode (enable/disable) + */ +void ena_com_set_mmio_read_mode(struct ena_com_dev *ena_dev, + bool readless_supported); + + +/* ena_com_create_io_queue - Create io queue. + * @ena_dev: ENA communication layer struct Instead ena_com_create_io_ctx SHOULD BE: @ena_com_create_io_ctx + * ena_com_create_io_ctx - create context structure + * + * Create the submission and the completion queues. + * + * @return - 0 on success, negative value on failure. + */ +int ena_com_create_io_queue(struct ena_com_dev *ena_dev, + struct ena_com_create_io_ctx *ctx); + +/* ena_com_admin_destroy - Destroy IO queue with the queue id - qid. + * @ena_dev: ENA communication layer struct Missing: @qid + */ +void ena_com_destroy_io_queue(struct ena_com_dev *ena_dev, u16 qid); + Regards, Rami Rosen Intel Corporation From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rosen, Rami" Subject: RE: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA) Date: Mon, 20 Jun 2016 05:20:55 +0000 Message-ID: <9B0331B6EBBD0E4684FBFAEDA55776F92CD6858D@HASMSX110.ger.corp.intel.com> References: <1465807573-11293-1-git-send-email-netanel@annapurnalabs.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Cc: "zorik@annapurnalabs.com" , "saeed@annapurnalabs.com" , "alex@annapurnalabs.com" , "msw@amazon.com" , "aligouri@amazon.com" , "antoine.tenart@free-electrons.com" , "Rosen, Rami" To: Netanel Belgazal , "netdev@vger.kernel.org" , "davm@davemeloft.net" , "linux-kernel@vger.kernel.org" Return-path: Received: from mga11.intel.com ([192.55.52.93]:40955 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751628AbcFTFdM convert rfc822-to-8bit (ORCPT ); Mon, 20 Jun 2016 01:33:12 -0400 In-Reply-To: <1465807573-11293-1-git-send-email-netanel@annapurnalabs.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: Hi all, A very limited review below. + + /* get capabilities of particular feature */ + ENA_ADMIN_GET_FEATURE = 8, Instead /* get capabilities SHOULD BE: /* set capabilities ..... + + /* get capabilities of particular feature */ + ENA_ADMIN_SET_FEATURE = 9, + .. +int ena_com_set_hash_ctrl(struct ena_com_dev *ena_dev) +{ + struct ena_com_admin_queue *admin_queue = &ena_dev->admin_queue; ... You set ret=-EINVAL, but you do not use this ret as you immediately return 0 in the next line, which is the end of the method. Either return ret or return -EINVAL. + if (unlikely(ret)) { + ena_trc_err("Failed to set hash input. error: %d\n", ret); + ret = -EINVAL; + } + + return 0; +} + + +/* ena_com_set_mmio_read_mode - Enable/disable the mmio reg read mechanism + * @ena_dev: ENA communication layer struct Instead realess_supported: SHOULD BE: readless_supported + * @realess_supported: readless mode (enable/disable) + */ +void ena_com_set_mmio_read_mode(struct ena_com_dev *ena_dev, + bool readless_supported); + + +/* ena_com_create_io_queue - Create io queue. + * @ena_dev: ENA communication layer struct Instead ena_com_create_io_ctx SHOULD BE: @ena_com_create_io_ctx + * ena_com_create_io_ctx - create context structure + * + * Create the submission and the completion queues. + * + * @return - 0 on success, negative value on failure. + */ +int ena_com_create_io_queue(struct ena_com_dev *ena_dev, + struct ena_com_create_io_ctx *ctx); + +/* ena_com_admin_destroy - Destroy IO queue with the queue id - qid. + * @ena_dev: ENA communication layer struct Missing: @qid + */ +void ena_com_destroy_io_queue(struct ena_com_dev *ena_dev, u16 qid); + Regards, Rami Rosen Intel Corporation