* [PATCH] arm64: dts: allwinner: a64: Add lradc node @ 2019-05-18 17:09 ` Luca Weiss 0 siblings, 0 replies; 45+ messages in thread From: Luca Weiss @ 2019-05-18 17:09 UTC (permalink / raw) Cc: Luca Weiss, Maxime Ripard, Chen-Yu Tsai, Rob Herring, Mark Rutland, moderated list:ARM/Allwinner sunXi SoC support, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list Add a node describing the KEYADC on the A64. Signed-off-by: Luca Weiss <luca@z3ntu.xyz> --- arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi index 7734f70e1057..dc1bf8c1afb5 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi @@ -704,6 +704,13 @@ status = "disabled"; }; + lradc: lradc@1c21800 { + compatible = "allwinner,sun4i-a10-lradc-keys"; + reg = <0x01c21800 0x100>; + interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; + status = "disabled"; + }; + i2s0: i2s@1c22000 { #sound-dai-cells = <0>; compatible = "allwinner,sun50i-a64-i2s", -- 2.21.0 ^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PATCH] arm64: dts: allwinner: a64: Add lradc node @ 2019-05-18 17:09 ` Luca Weiss 0 siblings, 0 replies; 45+ messages in thread From: Luca Weiss @ 2019-05-18 17:09 UTC (permalink / raw) Cc: Mark Rutland, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, Maxime Ripard, open list, Luca Weiss, Chen-Yu Tsai, Rob Herring, moderated list:ARM/Allwinner sunXi SoC support Add a node describing the KEYADC on the A64. Signed-off-by: Luca Weiss <luca@z3ntu.xyz> --- arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi index 7734f70e1057..dc1bf8c1afb5 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi @@ -704,6 +704,13 @@ status = "disabled"; }; + lradc: lradc@1c21800 { + compatible = "allwinner,sun4i-a10-lradc-keys"; + reg = <0x01c21800 0x100>; + interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; + status = "disabled"; + }; + i2s0: i2s@1c22000 { #sound-dai-cells = <0>; compatible = "allwinner,sun50i-a64-i2s", -- 2.21.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PATCH] arm64: dts: allwinner: a64: Add lradc node @ 2019-05-18 17:09 ` Luca Weiss 0 siblings, 0 replies; 45+ messages in thread From: Luca Weiss @ 2019-05-18 17:09 UTC (permalink / raw) Cc: Luca Weiss, Maxime Ripard, Chen-Yu Tsai, Rob Herring, Mark Rutland, moderated list:ARM/Allwinner sunXi SoC support, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list Add a node describing the KEYADC on the A64. Signed-off-by: Luca Weiss <luca@z3ntu.xyz> --- arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi index 7734f70e1057..dc1bf8c1afb5 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi @@ -704,6 +704,13 @@ status = "disabled"; }; + lradc: lradc@1c21800 { + compatible = "allwinner,sun4i-a10-lradc-keys"; + reg = <0x01c21800 0x100>; + interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; + status = "disabled"; + }; + i2s0: i2s@1c22000 { #sound-dai-cells = <0>; compatible = "allwinner,sun50i-a64-i2s", -- 2.21.0 ^ permalink raw reply related [flat|nested] 45+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node 2019-05-18 17:09 ` Luca Weiss (?) @ 2019-05-20 11:07 ` Maxime Ripard -1 siblings, 0 replies; 45+ messages in thread From: Maxime Ripard @ 2019-05-20 11:07 UTC (permalink / raw) To: Luca Weiss Cc: Chen-Yu Tsai, Rob Herring, Mark Rutland, moderated list:ARM/Allwinner sunXi SoC support, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list [-- Attachment #1: Type: text/plain, Size: 1097 bytes --] Hi! On Sat, May 18, 2019 at 07:09:30PM +0200, Luca Weiss wrote: > Add a node describing the KEYADC on the A64. > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > --- > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > index 7734f70e1057..dc1bf8c1afb5 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > @@ -704,6 +704,13 @@ > status = "disabled"; > }; > > + lradc: lradc@1c21800 { > + compatible = "allwinner,sun4i-a10-lradc-keys"; > + reg = <0x01c21800 0x100>; > + interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; > + status = "disabled"; > + }; > + The controller is pretty different on the A64 compared to the A10. The A10 has two channels for example, while the A64 has only one. It looks like the one in the A83t though, so you can use that compatible instead. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node @ 2019-05-20 11:07 ` Maxime Ripard 0 siblings, 0 replies; 45+ messages in thread From: Maxime Ripard @ 2019-05-20 11:07 UTC (permalink / raw) To: Luca Weiss Cc: Mark Rutland, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list, Chen-Yu Tsai, Rob Herring, moderated list:ARM/Allwinner sunXi SoC support [-- Attachment #1.1: Type: text/plain, Size: 1097 bytes --] Hi! On Sat, May 18, 2019 at 07:09:30PM +0200, Luca Weiss wrote: > Add a node describing the KEYADC on the A64. > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > --- > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > index 7734f70e1057..dc1bf8c1afb5 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > @@ -704,6 +704,13 @@ > status = "disabled"; > }; > > + lradc: lradc@1c21800 { > + compatible = "allwinner,sun4i-a10-lradc-keys"; > + reg = <0x01c21800 0x100>; > + interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; > + status = "disabled"; > + }; > + The controller is pretty different on the A64 compared to the A10. The A10 has two channels for example, while the A64 has only one. It looks like the one in the A83t though, so you can use that compatible instead. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node @ 2019-05-20 11:07 ` Maxime Ripard 0 siblings, 0 replies; 45+ messages in thread From: Maxime Ripard @ 2019-05-20 11:07 UTC (permalink / raw) To: Luca Weiss Cc: Chen-Yu Tsai, Rob Herring, Mark Rutland, moderated list:ARM/Allwinner sunXi SoC support, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list [-- Attachment #1: Type: text/plain, Size: 1097 bytes --] Hi! On Sat, May 18, 2019 at 07:09:30PM +0200, Luca Weiss wrote: > Add a node describing the KEYADC on the A64. > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > --- > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > index 7734f70e1057..dc1bf8c1afb5 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > @@ -704,6 +704,13 @@ > status = "disabled"; > }; > > + lradc: lradc@1c21800 { > + compatible = "allwinner,sun4i-a10-lradc-keys"; > + reg = <0x01c21800 0x100>; > + interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; > + status = "disabled"; > + }; > + The controller is pretty different on the A64 compared to the A10. The A10 has two channels for example, while the A64 has only one. It looks like the one in the A83t though, so you can use that compatible instead. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node 2019-05-20 11:07 ` Maxime Ripard (?) @ 2019-05-21 6:43 ` luca -1 siblings, 0 replies; 45+ messages in thread From: luca @ 2019-05-21 6:43 UTC (permalink / raw) To: Maxime Ripard Cc: Chen-Yu Tsai, Rob Herring, Mark Rutland, moderated list:ARM/Allwinner sunXi SoC support, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list On May 20, 2019 1:07:42 PM GMT+02:00, Maxime Ripard <maxime.ripard@bootlin.com> wrote: >Hi! > >On Sat, May 18, 2019 at 07:09:30PM +0200, Luca Weiss wrote: >> Add a node describing the KEYADC on the A64. >> >> Signed-off-by: Luca Weiss <luca@z3ntu.xyz> >> --- >> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >> index 7734f70e1057..dc1bf8c1afb5 100644 >> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >> @@ -704,6 +704,13 @@ >> status = "disabled"; >> }; >> >> + lradc: lradc@1c21800 { >> + compatible = "allwinner,sun4i-a10-lradc-keys"; >> + reg = <0x01c21800 0x100>; >> + interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; >> + status = "disabled"; >> + }; >> + > >The controller is pretty different on the A64 compared to the A10. The >A10 has two channels for example, while the A64 has only one. > >It looks like the one in the A83t though, so you can use that >compatible instead. > >Maxime > >-- >Maxime Ripard, Bootlin >Embedded Linux and Kernel engineering >https://bootlin.com Hi, Looking at the patch for the A83t, the only difference is that it uses a 3/4 instead of a 2/3 voltage divider, nothing is changed with the channels. But I'm also not sure which one (or a different one) is used from looking at the "A64 User Manual". Thanks, Luca ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node @ 2019-05-21 6:43 ` luca 0 siblings, 0 replies; 45+ messages in thread From: luca @ 2019-05-21 6:43 UTC (permalink / raw) To: Maxime Ripard Cc: Mark Rutland, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list, Chen-Yu Tsai, Rob Herring, moderated list:ARM/Allwinner sunXi SoC support On May 20, 2019 1:07:42 PM GMT+02:00, Maxime Ripard <maxime.ripard@bootlin.com> wrote: >Hi! > >On Sat, May 18, 2019 at 07:09:30PM +0200, Luca Weiss wrote: >> Add a node describing the KEYADC on the A64. >> >> Signed-off-by: Luca Weiss <luca@z3ntu.xyz> >> --- >> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >> index 7734f70e1057..dc1bf8c1afb5 100644 >> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >> @@ -704,6 +704,13 @@ >> status = "disabled"; >> }; >> >> + lradc: lradc@1c21800 { >> + compatible = "allwinner,sun4i-a10-lradc-keys"; >> + reg = <0x01c21800 0x100>; >> + interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; >> + status = "disabled"; >> + }; >> + > >The controller is pretty different on the A64 compared to the A10. The >A10 has two channels for example, while the A64 has only one. > >It looks like the one in the A83t though, so you can use that >compatible instead. > >Maxime > >-- >Maxime Ripard, Bootlin >Embedded Linux and Kernel engineering >https://bootlin.com Hi, Looking at the patch for the A83t, the only difference is that it uses a 3/4 instead of a 2/3 voltage divider, nothing is changed with the channels. But I'm also not sure which one (or a different one) is used from looking at the "A64 User Manual". Thanks, Luca _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node @ 2019-05-21 6:43 ` luca 0 siblings, 0 replies; 45+ messages in thread From: luca @ 2019-05-21 6:43 UTC (permalink / raw) To: Maxime Ripard Cc: Chen-Yu Tsai, Rob Herring, Mark Rutland, moderated list:ARM/Allwinner sunXi SoC support, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list On May 20, 2019 1:07:42 PM GMT+02:00, Maxime Ripard <maxime.ripard@bootlin.com> wrote: >Hi! > >On Sat, May 18, 2019 at 07:09:30PM +0200, Luca Weiss wrote: >> Add a node describing the KEYADC on the A64. >> >> Signed-off-by: Luca Weiss <luca@z3ntu.xyz> >> --- >> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >> index 7734f70e1057..dc1bf8c1afb5 100644 >> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >> @@ -704,6 +704,13 @@ >> status = "disabled"; >> }; >> >> + lradc: lradc@1c21800 { >> + compatible = "allwinner,sun4i-a10-lradc-keys"; >> + reg = <0x01c21800 0x100>; >> + interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; >> + status = "disabled"; >> + }; >> + > >The controller is pretty different on the A64 compared to the A10. The >A10 has two channels for example, while the A64 has only one. > >It looks like the one in the A83t though, so you can use that >compatible instead. > >Maxime > >-- >Maxime Ripard, Bootlin >Embedded Linux and Kernel engineering >https://bootlin.com Hi, Looking at the patch for the A83t, the only difference is that it uses a 3/4 instead of a 2/3 voltage divider, nothing is changed with the channels. But I'm also not sure which one (or a different one) is used from looking at the "A64 User Manual". Thanks, Luca ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node 2019-05-21 6:43 ` luca (?) @ 2019-05-21 13:09 ` Maxime Ripard -1 siblings, 0 replies; 45+ messages in thread From: Maxime Ripard @ 2019-05-21 13:09 UTC (permalink / raw) To: luca Cc: Chen-Yu Tsai, Rob Herring, Mark Rutland, moderated list:ARM/Allwinner sunXi SoC support, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list [-- Attachment #1: Type: text/plain, Size: 1787 bytes --] On Tue, May 21, 2019 at 08:43:45AM +0200, luca@z3ntu.xyz wrote: > On May 20, 2019 1:07:42 PM GMT+02:00, Maxime Ripard <maxime.ripard@bootlin.com> wrote: > >On Sat, May 18, 2019 at 07:09:30PM +0200, Luca Weiss wrote: > >> Add a node describing the KEYADC on the A64. > >> > >> Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > >> --- > >> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 7 +++++++ > >> 1 file changed, 7 insertions(+) > >> > >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > >b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > >> index 7734f70e1057..dc1bf8c1afb5 100644 > >> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > >> @@ -704,6 +704,13 @@ > >> status = "disabled"; > >> }; > >> > >> + lradc: lradc@1c21800 { > >> + compatible = "allwinner,sun4i-a10-lradc-keys"; > >> + reg = <0x01c21800 0x100>; > >> + interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; > >> + status = "disabled"; > >> + }; > >> + > > > >The controller is pretty different on the A64 compared to the A10. The > >A10 has two channels for example, while the A64 has only one. > > > >It looks like the one in the A83t though, so you can use that > >compatible instead. > > Looking at the patch for the A83t, the only difference is that it > uses a 3/4 instead of a 2/3 voltage divider, nothing is changed with > the channels. I guess you can reuse the A83t compatible here then, and a more specific a64 compatible in case we ever need to fix this. > But I'm also not sure which one (or a different one) > is used from looking at the "A64 User Manual". I'm sorry, what are you referring to with "one" in that sentence? Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node @ 2019-05-21 13:09 ` Maxime Ripard 0 siblings, 0 replies; 45+ messages in thread From: Maxime Ripard @ 2019-05-21 13:09 UTC (permalink / raw) To: luca Cc: Mark Rutland, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list, Chen-Yu Tsai, Rob Herring, moderated list:ARM/Allwinner sunXi SoC support [-- Attachment #1.1: Type: text/plain, Size: 1787 bytes --] On Tue, May 21, 2019 at 08:43:45AM +0200, luca@z3ntu.xyz wrote: > On May 20, 2019 1:07:42 PM GMT+02:00, Maxime Ripard <maxime.ripard@bootlin.com> wrote: > >On Sat, May 18, 2019 at 07:09:30PM +0200, Luca Weiss wrote: > >> Add a node describing the KEYADC on the A64. > >> > >> Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > >> --- > >> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 7 +++++++ > >> 1 file changed, 7 insertions(+) > >> > >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > >b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > >> index 7734f70e1057..dc1bf8c1afb5 100644 > >> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > >> @@ -704,6 +704,13 @@ > >> status = "disabled"; > >> }; > >> > >> + lradc: lradc@1c21800 { > >> + compatible = "allwinner,sun4i-a10-lradc-keys"; > >> + reg = <0x01c21800 0x100>; > >> + interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; > >> + status = "disabled"; > >> + }; > >> + > > > >The controller is pretty different on the A64 compared to the A10. The > >A10 has two channels for example, while the A64 has only one. > > > >It looks like the one in the A83t though, so you can use that > >compatible instead. > > Looking at the patch for the A83t, the only difference is that it > uses a 3/4 instead of a 2/3 voltage divider, nothing is changed with > the channels. I guess you can reuse the A83t compatible here then, and a more specific a64 compatible in case we ever need to fix this. > But I'm also not sure which one (or a different one) > is used from looking at the "A64 User Manual". I'm sorry, what are you referring to with "one" in that sentence? Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node @ 2019-05-21 13:09 ` Maxime Ripard 0 siblings, 0 replies; 45+ messages in thread From: Maxime Ripard @ 2019-05-21 13:09 UTC (permalink / raw) To: luca Cc: Chen-Yu Tsai, Rob Herring, Mark Rutland, moderated list:ARM/Allwinner sunXi SoC support, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list [-- Attachment #1: Type: text/plain, Size: 1787 bytes --] On Tue, May 21, 2019 at 08:43:45AM +0200, luca@z3ntu.xyz wrote: > On May 20, 2019 1:07:42 PM GMT+02:00, Maxime Ripard <maxime.ripard@bootlin.com> wrote: > >On Sat, May 18, 2019 at 07:09:30PM +0200, Luca Weiss wrote: > >> Add a node describing the KEYADC on the A64. > >> > >> Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > >> --- > >> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 7 +++++++ > >> 1 file changed, 7 insertions(+) > >> > >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > >b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > >> index 7734f70e1057..dc1bf8c1afb5 100644 > >> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > >> @@ -704,6 +704,13 @@ > >> status = "disabled"; > >> }; > >> > >> + lradc: lradc@1c21800 { > >> + compatible = "allwinner,sun4i-a10-lradc-keys"; > >> + reg = <0x01c21800 0x100>; > >> + interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; > >> + status = "disabled"; > >> + }; > >> + > > > >The controller is pretty different on the A64 compared to the A10. The > >A10 has two channels for example, while the A64 has only one. > > > >It looks like the one in the A83t though, so you can use that > >compatible instead. > > Looking at the patch for the A83t, the only difference is that it > uses a 3/4 instead of a 2/3 voltage divider, nothing is changed with > the channels. I guess you can reuse the A83t compatible here then, and a more specific a64 compatible in case we ever need to fix this. > But I'm also not sure which one (or a different one) > is used from looking at the "A64 User Manual". I'm sorry, what are you referring to with "one" in that sentence? Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node 2019-05-21 13:09 ` Maxime Ripard (?) @ 2019-05-21 13:52 ` luca -1 siblings, 0 replies; 45+ messages in thread From: luca @ 2019-05-21 13:52 UTC (permalink / raw) To: Maxime Ripard Cc: Chen-Yu Tsai, Rob Herring, Mark Rutland, moderated list:ARM/Allwinner sunXi SoC support, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list On May 21, 2019 3:09:55 PM GMT+02:00, Maxime Ripard <maxime.ripard@bootlin.com> wrote: >On Tue, May 21, 2019 at 08:43:45AM +0200, luca@z3ntu.xyz wrote: >> On May 20, 2019 1:07:42 PM GMT+02:00, Maxime Ripard ><maxime.ripard@bootlin.com> wrote: >> >On Sat, May 18, 2019 at 07:09:30PM +0200, Luca Weiss wrote: >> >> Add a node describing the KEYADC on the A64. >> >> >> >> Signed-off-by: Luca Weiss <luca@z3ntu.xyz> >> >> --- >> >> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 7 +++++++ >> >> 1 file changed, 7 insertions(+) >> >> >> >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >> >b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >> >> index 7734f70e1057..dc1bf8c1afb5 100644 >> >> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >> >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >> >> @@ -704,6 +704,13 @@ >> >> status = "disabled"; >> >> }; >> >> >> >> + lradc: lradc@1c21800 { >> >> + compatible = "allwinner,sun4i-a10-lradc-keys"; >> >> + reg = <0x01c21800 0x100>; >> >> + interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; >> >> + status = "disabled"; >> >> + }; >> >> + >> > >> >The controller is pretty different on the A64 compared to the A10. >The >> >A10 has two channels for example, while the A64 has only one. >> > >> >It looks like the one in the A83t though, so you can use that >> >compatible instead. >> >> Looking at the patch for the A83t, the only difference is that it >> uses a 3/4 instead of a 2/3 voltage divider, nothing is changed with >> the channels. > >I guess you can reuse the A83t compatible here then, and a more >specific a64 compatible in case we ever need to fix this. > >> But I'm also not sure which one (or a different one) >> is used from looking at the "A64 User Manual". > >I'm sorry, what are you referring to with "one" in that sentence? > >Maxime > >-- >Maxime Ripard, Bootlin >Embedded Linux and Kernel engineering >https://bootlin.com Hi, Sorry, I meant I didn't find anything in the A64 user manual whether a 3/4 or a 2/3 voltage divider (or one with different values) is used on the A64. Luca ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node @ 2019-05-21 13:52 ` luca 0 siblings, 0 replies; 45+ messages in thread From: luca @ 2019-05-21 13:52 UTC (permalink / raw) To: Maxime Ripard Cc: Mark Rutland, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list, Chen-Yu Tsai, Rob Herring, moderated list:ARM/Allwinner sunXi SoC support On May 21, 2019 3:09:55 PM GMT+02:00, Maxime Ripard <maxime.ripard@bootlin.com> wrote: >On Tue, May 21, 2019 at 08:43:45AM +0200, luca@z3ntu.xyz wrote: >> On May 20, 2019 1:07:42 PM GMT+02:00, Maxime Ripard ><maxime.ripard@bootlin.com> wrote: >> >On Sat, May 18, 2019 at 07:09:30PM +0200, Luca Weiss wrote: >> >> Add a node describing the KEYADC on the A64. >> >> >> >> Signed-off-by: Luca Weiss <luca@z3ntu.xyz> >> >> --- >> >> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 7 +++++++ >> >> 1 file changed, 7 insertions(+) >> >> >> >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >> >b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >> >> index 7734f70e1057..dc1bf8c1afb5 100644 >> >> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >> >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >> >> @@ -704,6 +704,13 @@ >> >> status = "disabled"; >> >> }; >> >> >> >> + lradc: lradc@1c21800 { >> >> + compatible = "allwinner,sun4i-a10-lradc-keys"; >> >> + reg = <0x01c21800 0x100>; >> >> + interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; >> >> + status = "disabled"; >> >> + }; >> >> + >> > >> >The controller is pretty different on the A64 compared to the A10. >The >> >A10 has two channels for example, while the A64 has only one. >> > >> >It looks like the one in the A83t though, so you can use that >> >compatible instead. >> >> Looking at the patch for the A83t, the only difference is that it >> uses a 3/4 instead of a 2/3 voltage divider, nothing is changed with >> the channels. > >I guess you can reuse the A83t compatible here then, and a more >specific a64 compatible in case we ever need to fix this. > >> But I'm also not sure which one (or a different one) >> is used from looking at the "A64 User Manual". > >I'm sorry, what are you referring to with "one" in that sentence? > >Maxime > >-- >Maxime Ripard, Bootlin >Embedded Linux and Kernel engineering >https://bootlin.com Hi, Sorry, I meant I didn't find anything in the A64 user manual whether a 3/4 or a 2/3 voltage divider (or one with different values) is used on the A64. Luca _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node @ 2019-05-21 13:52 ` luca 0 siblings, 0 replies; 45+ messages in thread From: luca @ 2019-05-21 13:52 UTC (permalink / raw) To: Maxime Ripard Cc: Chen-Yu Tsai, Rob Herring, Mark Rutland, moderated list:ARM/Allwinner sunXi SoC support, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list On May 21, 2019 3:09:55 PM GMT+02:00, Maxime Ripard <maxime.ripard@bootlin.com> wrote: >On Tue, May 21, 2019 at 08:43:45AM +0200, luca@z3ntu.xyz wrote: >> On May 20, 2019 1:07:42 PM GMT+02:00, Maxime Ripard ><maxime.ripard@bootlin.com> wrote: >> >On Sat, May 18, 2019 at 07:09:30PM +0200, Luca Weiss wrote: >> >> Add a node describing the KEYADC on the A64. >> >> >> >> Signed-off-by: Luca Weiss <luca@z3ntu.xyz> >> >> --- >> >> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 7 +++++++ >> >> 1 file changed, 7 insertions(+) >> >> >> >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >> >b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >> >> index 7734f70e1057..dc1bf8c1afb5 100644 >> >> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >> >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >> >> @@ -704,6 +704,13 @@ >> >> status = "disabled"; >> >> }; >> >> >> >> + lradc: lradc@1c21800 { >> >> + compatible = "allwinner,sun4i-a10-lradc-keys"; >> >> + reg = <0x01c21800 0x100>; >> >> + interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; >> >> + status = "disabled"; >> >> + }; >> >> + >> > >> >The controller is pretty different on the A64 compared to the A10. >The >> >A10 has two channels for example, while the A64 has only one. >> > >> >It looks like the one in the A83t though, so you can use that >> >compatible instead. >> >> Looking at the patch for the A83t, the only difference is that it >> uses a 3/4 instead of a 2/3 voltage divider, nothing is changed with >> the channels. > >I guess you can reuse the A83t compatible here then, and a more >specific a64 compatible in case we ever need to fix this. > >> But I'm also not sure which one (or a different one) >> is used from looking at the "A64 User Manual". > >I'm sorry, what are you referring to with "one" in that sentence? > >Maxime > >-- >Maxime Ripard, Bootlin >Embedded Linux and Kernel engineering >https://bootlin.com Hi, Sorry, I meant I didn't find anything in the A64 user manual whether a 3/4 or a 2/3 voltage divider (or one with different values) is used on the A64. Luca ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node 2019-05-21 13:52 ` luca (?) @ 2019-05-21 14:25 ` Maxime Ripard -1 siblings, 0 replies; 45+ messages in thread From: Maxime Ripard @ 2019-05-21 14:25 UTC (permalink / raw) To: luca Cc: Chen-Yu Tsai, Rob Herring, Mark Rutland, moderated list:ARM/Allwinner sunXi SoC support, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list [-- Attachment #1: Type: text/plain, Size: 2323 bytes --] On Tue, May 21, 2019 at 03:52:47PM +0200, luca@z3ntu.xyz wrote: > On May 21, 2019 3:09:55 PM GMT+02:00, Maxime Ripard <maxime.ripard@bootlin.com> wrote: > >On Tue, May 21, 2019 at 08:43:45AM +0200, luca@z3ntu.xyz wrote: > >> On May 20, 2019 1:07:42 PM GMT+02:00, Maxime Ripard > ><maxime.ripard@bootlin.com> wrote: > >> >On Sat, May 18, 2019 at 07:09:30PM +0200, Luca Weiss wrote: > >> >> Add a node describing the KEYADC on the A64. > >> >> > >> >> Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > >> >> --- > >> >> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 7 +++++++ > >> >> 1 file changed, 7 insertions(+) > >> >> > >> >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > >> >b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > >> >> index 7734f70e1057..dc1bf8c1afb5 100644 > >> >> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > >> >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > >> >> @@ -704,6 +704,13 @@ > >> >> status = "disabled"; > >> >> }; > >> >> > >> >> + lradc: lradc@1c21800 { > >> >> + compatible = "allwinner,sun4i-a10-lradc-keys"; > >> >> + reg = <0x01c21800 0x100>; > >> >> + interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; > >> >> + status = "disabled"; > >> >> + }; > >> >> + > >> > > >> >The controller is pretty different on the A64 compared to the A10. > >The > >> >A10 has two channels for example, while the A64 has only one. > >> > > >> >It looks like the one in the A83t though, so you can use that > >> >compatible instead. > >> > >> Looking at the patch for the A83t, the only difference is that it > >> uses a 3/4 instead of a 2/3 voltage divider, nothing is changed with > >> the channels. > > > >I guess you can reuse the A83t compatible here then, and a more > >specific a64 compatible in case we ever need to fix this. > > > >> But I'm also not sure which one (or a different one) > >> is used from looking at the "A64 User Manual". > > > >I'm sorry, what are you referring to with "one" in that sentence? > > Sorry, I meant I didn't find anything in the A64 user manual whether > a 3/4 or a 2/3 voltage divider (or one with different values) is > used on the A64. Ok :) I guess you can just reuse the A83t compatible then, together with the A64's. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node @ 2019-05-21 14:25 ` Maxime Ripard 0 siblings, 0 replies; 45+ messages in thread From: Maxime Ripard @ 2019-05-21 14:25 UTC (permalink / raw) To: luca Cc: Mark Rutland, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list, Chen-Yu Tsai, Rob Herring, moderated list:ARM/Allwinner sunXi SoC support [-- Attachment #1.1: Type: text/plain, Size: 2323 bytes --] On Tue, May 21, 2019 at 03:52:47PM +0200, luca@z3ntu.xyz wrote: > On May 21, 2019 3:09:55 PM GMT+02:00, Maxime Ripard <maxime.ripard@bootlin.com> wrote: > >On Tue, May 21, 2019 at 08:43:45AM +0200, luca@z3ntu.xyz wrote: > >> On May 20, 2019 1:07:42 PM GMT+02:00, Maxime Ripard > ><maxime.ripard@bootlin.com> wrote: > >> >On Sat, May 18, 2019 at 07:09:30PM +0200, Luca Weiss wrote: > >> >> Add a node describing the KEYADC on the A64. > >> >> > >> >> Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > >> >> --- > >> >> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 7 +++++++ > >> >> 1 file changed, 7 insertions(+) > >> >> > >> >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > >> >b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > >> >> index 7734f70e1057..dc1bf8c1afb5 100644 > >> >> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > >> >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > >> >> @@ -704,6 +704,13 @@ > >> >> status = "disabled"; > >> >> }; > >> >> > >> >> + lradc: lradc@1c21800 { > >> >> + compatible = "allwinner,sun4i-a10-lradc-keys"; > >> >> + reg = <0x01c21800 0x100>; > >> >> + interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; > >> >> + status = "disabled"; > >> >> + }; > >> >> + > >> > > >> >The controller is pretty different on the A64 compared to the A10. > >The > >> >A10 has two channels for example, while the A64 has only one. > >> > > >> >It looks like the one in the A83t though, so you can use that > >> >compatible instead. > >> > >> Looking at the patch for the A83t, the only difference is that it > >> uses a 3/4 instead of a 2/3 voltage divider, nothing is changed with > >> the channels. > > > >I guess you can reuse the A83t compatible here then, and a more > >specific a64 compatible in case we ever need to fix this. > > > >> But I'm also not sure which one (or a different one) > >> is used from looking at the "A64 User Manual". > > > >I'm sorry, what are you referring to with "one" in that sentence? > > Sorry, I meant I didn't find anything in the A64 user manual whether > a 3/4 or a 2/3 voltage divider (or one with different values) is > used on the A64. Ok :) I guess you can just reuse the A83t compatible then, together with the A64's. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node @ 2019-05-21 14:25 ` Maxime Ripard 0 siblings, 0 replies; 45+ messages in thread From: Maxime Ripard @ 2019-05-21 14:25 UTC (permalink / raw) To: luca Cc: Chen-Yu Tsai, Rob Herring, Mark Rutland, moderated list:ARM/Allwinner sunXi SoC support, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list [-- Attachment #1: Type: text/plain, Size: 2323 bytes --] On Tue, May 21, 2019 at 03:52:47PM +0200, luca@z3ntu.xyz wrote: > On May 21, 2019 3:09:55 PM GMT+02:00, Maxime Ripard <maxime.ripard@bootlin.com> wrote: > >On Tue, May 21, 2019 at 08:43:45AM +0200, luca@z3ntu.xyz wrote: > >> On May 20, 2019 1:07:42 PM GMT+02:00, Maxime Ripard > ><maxime.ripard@bootlin.com> wrote: > >> >On Sat, May 18, 2019 at 07:09:30PM +0200, Luca Weiss wrote: > >> >> Add a node describing the KEYADC on the A64. > >> >> > >> >> Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > >> >> --- > >> >> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 7 +++++++ > >> >> 1 file changed, 7 insertions(+) > >> >> > >> >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > >> >b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > >> >> index 7734f70e1057..dc1bf8c1afb5 100644 > >> >> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > >> >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > >> >> @@ -704,6 +704,13 @@ > >> >> status = "disabled"; > >> >> }; > >> >> > >> >> + lradc: lradc@1c21800 { > >> >> + compatible = "allwinner,sun4i-a10-lradc-keys"; > >> >> + reg = <0x01c21800 0x100>; > >> >> + interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; > >> >> + status = "disabled"; > >> >> + }; > >> >> + > >> > > >> >The controller is pretty different on the A64 compared to the A10. > >The > >> >A10 has two channels for example, while the A64 has only one. > >> > > >> >It looks like the one in the A83t though, so you can use that > >> >compatible instead. > >> > >> Looking at the patch for the A83t, the only difference is that it > >> uses a 3/4 instead of a 2/3 voltage divider, nothing is changed with > >> the channels. > > > >I guess you can reuse the A83t compatible here then, and a more > >specific a64 compatible in case we ever need to fix this. > > > >> But I'm also not sure which one (or a different one) > >> is used from looking at the "A64 User Manual". > > > >I'm sorry, what are you referring to with "one" in that sentence? > > Sorry, I meant I didn't find anything in the A64 user manual whether > a 3/4 or a 2/3 voltage divider (or one with different values) is > used on the A64. Ok :) I guess you can just reuse the A83t compatible then, together with the A64's. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node 2019-05-21 14:25 ` Maxime Ripard (?) @ 2019-05-24 8:35 ` Luca Weiss -1 siblings, 0 replies; 45+ messages in thread From: Luca Weiss @ 2019-05-24 8:35 UTC (permalink / raw) To: Maxime Ripard Cc: Chen-Yu Tsai, Rob Herring, Mark Rutland, moderated list:ARM/Allwinner sunXi SoC support, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list On Dienstag, 21. Mai 2019 16:25:44 CEST Maxime Ripard wrote: > On Tue, May 21, 2019 at 03:52:47PM +0200, luca@z3ntu.xyz wrote: > > On May 21, 2019 3:09:55 PM GMT+02:00, Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > >On Tue, May 21, 2019 at 08:43:45AM +0200, luca@z3ntu.xyz wrote: > > >> On May 20, 2019 1:07:42 PM GMT+02:00, Maxime Ripard > > > > > ><maxime.ripard@bootlin.com> wrote: > > >> >On Sat, May 18, 2019 at 07:09:30PM +0200, Luca Weiss wrote: > > >> >> Add a node describing the KEYADC on the A64. > > >> >> > > >> >> Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > > >> >> --- > > >> >> > > >> >> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 7 +++++++ > > >> >> 1 file changed, 7 insertions(+) > > >> >> > > >> >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > >> > > > >> >b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > >> > > > >> >> index 7734f70e1057..dc1bf8c1afb5 100644 > > >> >> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > >> >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > >> >> @@ -704,6 +704,13 @@ > > >> >> > > >> >> status = "disabled"; > > >> >> > > >> >> }; > > >> >> > > >> >> + lradc: lradc@1c21800 { > > >> >> + compatible = "allwinner,sun4i-a10-lradc- keys"; > > >> >> + reg = <0x01c21800 0x100>; > > >> >> + interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; > > >> >> + status = "disabled"; > > >> >> + }; > > >> >> + > > >> > > > >> >The controller is pretty different on the A64 compared to the A10. > > > > > >The > > > > > >> >A10 has two channels for example, while the A64 has only one. > > >> > > > >> >It looks like the one in the A83t though, so you can use that > > >> >compatible instead. > > >> > > >> Looking at the patch for the A83t, the only difference is that it > > >> uses a 3/4 instead of a 2/3 voltage divider, nothing is changed with > > >> the channels. > > > > > >I guess you can reuse the A83t compatible here then, and a more > > >specific a64 compatible in case we ever need to fix this. > > > > > >> But I'm also not sure which one (or a different one) > > >> is used from looking at the "A64 User Manual". > > > > > >I'm sorry, what are you referring to with "one" in that sentence? > > > > Sorry, I meant I didn't find anything in the A64 user manual whether > > a 3/4 or a 2/3 voltage divider (or one with different values) is > > used on the A64. > > Ok :) > > I guess you can just reuse the A83t compatible then, together with the > A64's. > > Maxime > > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com Hi Maxime, I'd submit a v2 with these changes to v1 then: lradc: lradc@1c21800 { - compatible = "allwinner,sun4i-a10-lradc-keys"; - reg = <0x01c21800 0x100>; + compatible = "allwinner,sun50i-a64-lradc-keys", + "allwinner,sun8i-a83t-r-lradc"; + reg = <0x01c21800 0x400>; interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; status = "disabled"; }; Does that look okay? The reg change is due to me not spotting the address being 0x01C2 1800---0x01C2 1BFF, so the size should be 0x400 and not 0x100. Thanks for the feedback, Luca ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node @ 2019-05-24 8:35 ` Luca Weiss 0 siblings, 0 replies; 45+ messages in thread From: Luca Weiss @ 2019-05-24 8:35 UTC (permalink / raw) To: Maxime Ripard Cc: Mark Rutland, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list, Chen-Yu Tsai, Rob Herring, moderated list:ARM/Allwinner sunXi SoC support On Dienstag, 21. Mai 2019 16:25:44 CEST Maxime Ripard wrote: > On Tue, May 21, 2019 at 03:52:47PM +0200, luca@z3ntu.xyz wrote: > > On May 21, 2019 3:09:55 PM GMT+02:00, Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > >On Tue, May 21, 2019 at 08:43:45AM +0200, luca@z3ntu.xyz wrote: > > >> On May 20, 2019 1:07:42 PM GMT+02:00, Maxime Ripard > > > > > ><maxime.ripard@bootlin.com> wrote: > > >> >On Sat, May 18, 2019 at 07:09:30PM +0200, Luca Weiss wrote: > > >> >> Add a node describing the KEYADC on the A64. > > >> >> > > >> >> Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > > >> >> --- > > >> >> > > >> >> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 7 +++++++ > > >> >> 1 file changed, 7 insertions(+) > > >> >> > > >> >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > >> > > > >> >b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > >> > > > >> >> index 7734f70e1057..dc1bf8c1afb5 100644 > > >> >> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > >> >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > >> >> @@ -704,6 +704,13 @@ > > >> >> > > >> >> status = "disabled"; > > >> >> > > >> >> }; > > >> >> > > >> >> + lradc: lradc@1c21800 { > > >> >> + compatible = "allwinner,sun4i-a10-lradc- keys"; > > >> >> + reg = <0x01c21800 0x100>; > > >> >> + interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; > > >> >> + status = "disabled"; > > >> >> + }; > > >> >> + > > >> > > > >> >The controller is pretty different on the A64 compared to the A10. > > > > > >The > > > > > >> >A10 has two channels for example, while the A64 has only one. > > >> > > > >> >It looks like the one in the A83t though, so you can use that > > >> >compatible instead. > > >> > > >> Looking at the patch for the A83t, the only difference is that it > > >> uses a 3/4 instead of a 2/3 voltage divider, nothing is changed with > > >> the channels. > > > > > >I guess you can reuse the A83t compatible here then, and a more > > >specific a64 compatible in case we ever need to fix this. > > > > > >> But I'm also not sure which one (or a different one) > > >> is used from looking at the "A64 User Manual". > > > > > >I'm sorry, what are you referring to with "one" in that sentence? > > > > Sorry, I meant I didn't find anything in the A64 user manual whether > > a 3/4 or a 2/3 voltage divider (or one with different values) is > > used on the A64. > > Ok :) > > I guess you can just reuse the A83t compatible then, together with the > A64's. > > Maxime > > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com Hi Maxime, I'd submit a v2 with these changes to v1 then: lradc: lradc@1c21800 { - compatible = "allwinner,sun4i-a10-lradc-keys"; - reg = <0x01c21800 0x100>; + compatible = "allwinner,sun50i-a64-lradc-keys", + "allwinner,sun8i-a83t-r-lradc"; + reg = <0x01c21800 0x400>; interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; status = "disabled"; }; Does that look okay? The reg change is due to me not spotting the address being 0x01C2 1800---0x01C2 1BFF, so the size should be 0x400 and not 0x100. Thanks for the feedback, Luca _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node @ 2019-05-24 8:35 ` Luca Weiss 0 siblings, 0 replies; 45+ messages in thread From: Luca Weiss @ 2019-05-24 8:35 UTC (permalink / raw) To: Maxime Ripard Cc: Chen-Yu Tsai, Rob Herring, Mark Rutland, moderated list:ARM/Allwinner sunXi SoC support, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list On Dienstag, 21. Mai 2019 16:25:44 CEST Maxime Ripard wrote: > On Tue, May 21, 2019 at 03:52:47PM +0200, luca@z3ntu.xyz wrote: > > On May 21, 2019 3:09:55 PM GMT+02:00, Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > >On Tue, May 21, 2019 at 08:43:45AM +0200, luca@z3ntu.xyz wrote: > > >> On May 20, 2019 1:07:42 PM GMT+02:00, Maxime Ripard > > > > > ><maxime.ripard@bootlin.com> wrote: > > >> >On Sat, May 18, 2019 at 07:09:30PM +0200, Luca Weiss wrote: > > >> >> Add a node describing the KEYADC on the A64. > > >> >> > > >> >> Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > > >> >> --- > > >> >> > > >> >> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 7 +++++++ > > >> >> 1 file changed, 7 insertions(+) > > >> >> > > >> >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > >> > > > >> >b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > >> > > > >> >> index 7734f70e1057..dc1bf8c1afb5 100644 > > >> >> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > >> >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > >> >> @@ -704,6 +704,13 @@ > > >> >> > > >> >> status = "disabled"; > > >> >> > > >> >> }; > > >> >> > > >> >> + lradc: lradc@1c21800 { > > >> >> + compatible = "allwinner,sun4i-a10-lradc- keys"; > > >> >> + reg = <0x01c21800 0x100>; > > >> >> + interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; > > >> >> + status = "disabled"; > > >> >> + }; > > >> >> + > > >> > > > >> >The controller is pretty different on the A64 compared to the A10. > > > > > >The > > > > > >> >A10 has two channels for example, while the A64 has only one. > > >> > > > >> >It looks like the one in the A83t though, so you can use that > > >> >compatible instead. > > >> > > >> Looking at the patch for the A83t, the only difference is that it > > >> uses a 3/4 instead of a 2/3 voltage divider, nothing is changed with > > >> the channels. > > > > > >I guess you can reuse the A83t compatible here then, and a more > > >specific a64 compatible in case we ever need to fix this. > > > > > >> But I'm also not sure which one (or a different one) > > >> is used from looking at the "A64 User Manual". > > > > > >I'm sorry, what are you referring to with "one" in that sentence? > > > > Sorry, I meant I didn't find anything in the A64 user manual whether > > a 3/4 or a 2/3 voltage divider (or one with different values) is > > used on the A64. > > Ok :) > > I guess you can just reuse the A83t compatible then, together with the > A64's. > > Maxime > > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com Hi Maxime, I'd submit a v2 with these changes to v1 then: lradc: lradc@1c21800 { - compatible = "allwinner,sun4i-a10-lradc-keys"; - reg = <0x01c21800 0x100>; + compatible = "allwinner,sun50i-a64-lradc-keys", + "allwinner,sun8i-a83t-r-lradc"; + reg = <0x01c21800 0x400>; interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; status = "disabled"; }; Does that look okay? The reg change is due to me not spotting the address being 0x01C2 1800---0x01C2 1BFF, so the size should be 0x400 and not 0x100. Thanks for the feedback, Luca ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node 2019-05-24 8:35 ` Luca Weiss (?) @ 2019-05-24 9:20 ` Maxime Ripard -1 siblings, 0 replies; 45+ messages in thread From: Maxime Ripard @ 2019-05-24 9:20 UTC (permalink / raw) To: Luca Weiss Cc: Chen-Yu Tsai, Rob Herring, Mark Rutland, moderated list:ARM/Allwinner sunXi SoC support, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list [-- Attachment #1: Type: text/plain, Size: 3581 bytes --] On Fri, May 24, 2019 at 10:35:36AM +0200, Luca Weiss wrote: > On Dienstag, 21. Mai 2019 16:25:44 CEST Maxime Ripard wrote: > > On Tue, May 21, 2019 at 03:52:47PM +0200, luca@z3ntu.xyz wrote: > > > On May 21, 2019 3:09:55 PM GMT+02:00, Maxime Ripard > <maxime.ripard@bootlin.com> wrote: > > > >On Tue, May 21, 2019 at 08:43:45AM +0200, luca@z3ntu.xyz wrote: > > > >> On May 20, 2019 1:07:42 PM GMT+02:00, Maxime Ripard > > > > > > > ><maxime.ripard@bootlin.com> wrote: > > > >> >On Sat, May 18, 2019 at 07:09:30PM +0200, Luca Weiss wrote: > > > >> >> Add a node describing the KEYADC on the A64. > > > >> >> > > > >> >> Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > > > >> >> --- > > > >> >> > > > >> >> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 7 +++++++ > > > >> >> 1 file changed, 7 insertions(+) > > > >> >> > > > >> >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > > >> > > > > >> >b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > > >> > > > > >> >> index 7734f70e1057..dc1bf8c1afb5 100644 > > > >> >> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > > >> >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > > >> >> @@ -704,6 +704,13 @@ > > > >> >> > > > >> >> status = "disabled"; > > > >> >> > > > >> >> }; > > > >> >> > > > >> >> + lradc: lradc@1c21800 { > > > >> >> + compatible = "allwinner,sun4i-a10-lradc- > keys"; > > > >> >> + reg = <0x01c21800 0x100>; > > > >> >> + interrupts = <GIC_SPI 30 > IRQ_TYPE_LEVEL_HIGH>; > > > >> >> + status = "disabled"; > > > >> >> + }; > > > >> >> + > > > >> > > > > >> >The controller is pretty different on the A64 compared to the A10. > > > > > > > >The > > > > > > > >> >A10 has two channels for example, while the A64 has only one. > > > >> > > > > >> >It looks like the one in the A83t though, so you can use that > > > >> >compatible instead. > > > >> > > > >> Looking at the patch for the A83t, the only difference is that it > > > >> uses a 3/4 instead of a 2/3 voltage divider, nothing is changed with > > > >> the channels. > > > > > > > >I guess you can reuse the A83t compatible here then, and a more > > > >specific a64 compatible in case we ever need to fix this. > > > > > > > >> But I'm also not sure which one (or a different one) > > > >> is used from looking at the "A64 User Manual". > > > > > > > >I'm sorry, what are you referring to with "one" in that sentence? > > > > > > Sorry, I meant I didn't find anything in the A64 user manual whether > > > a 3/4 or a 2/3 voltage divider (or one with different values) is > > > used on the A64. > > > > Ok :) > > > > I guess you can just reuse the A83t compatible then, together with the > > A64's. > > I'd submit a v2 with these changes to v1 then: > lradc: lradc@1c21800 { > - compatible = "allwinner,sun4i-a10-lradc-keys"; > - reg = <0x01c21800 0x100>; > + compatible = "allwinner,sun50i-a64-lradc-keys", > + "allwinner,sun8i-a83t-r-lradc"; > + reg = <0x01c21800 0x400>; > interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; > status = "disabled"; > }; > Does that look okay? > The reg change is due to me not spotting the address being 0x01C2 > 1800---0x01C2 1BFF, so the size should be 0x400 and not 0x100. It would be great to drop the -keys from the compatible, and to document the bindings Looks good otherwise Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node @ 2019-05-24 9:20 ` Maxime Ripard 0 siblings, 0 replies; 45+ messages in thread From: Maxime Ripard @ 2019-05-24 9:20 UTC (permalink / raw) To: Luca Weiss Cc: Mark Rutland, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list, Chen-Yu Tsai, Rob Herring, moderated list:ARM/Allwinner sunXi SoC support [-- Attachment #1.1: Type: text/plain, Size: 3581 bytes --] On Fri, May 24, 2019 at 10:35:36AM +0200, Luca Weiss wrote: > On Dienstag, 21. Mai 2019 16:25:44 CEST Maxime Ripard wrote: > > On Tue, May 21, 2019 at 03:52:47PM +0200, luca@z3ntu.xyz wrote: > > > On May 21, 2019 3:09:55 PM GMT+02:00, Maxime Ripard > <maxime.ripard@bootlin.com> wrote: > > > >On Tue, May 21, 2019 at 08:43:45AM +0200, luca@z3ntu.xyz wrote: > > > >> On May 20, 2019 1:07:42 PM GMT+02:00, Maxime Ripard > > > > > > > ><maxime.ripard@bootlin.com> wrote: > > > >> >On Sat, May 18, 2019 at 07:09:30PM +0200, Luca Weiss wrote: > > > >> >> Add a node describing the KEYADC on the A64. > > > >> >> > > > >> >> Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > > > >> >> --- > > > >> >> > > > >> >> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 7 +++++++ > > > >> >> 1 file changed, 7 insertions(+) > > > >> >> > > > >> >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > > >> > > > > >> >b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > > >> > > > > >> >> index 7734f70e1057..dc1bf8c1afb5 100644 > > > >> >> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > > >> >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > > >> >> @@ -704,6 +704,13 @@ > > > >> >> > > > >> >> status = "disabled"; > > > >> >> > > > >> >> }; > > > >> >> > > > >> >> + lradc: lradc@1c21800 { > > > >> >> + compatible = "allwinner,sun4i-a10-lradc- > keys"; > > > >> >> + reg = <0x01c21800 0x100>; > > > >> >> + interrupts = <GIC_SPI 30 > IRQ_TYPE_LEVEL_HIGH>; > > > >> >> + status = "disabled"; > > > >> >> + }; > > > >> >> + > > > >> > > > > >> >The controller is pretty different on the A64 compared to the A10. > > > > > > > >The > > > > > > > >> >A10 has two channels for example, while the A64 has only one. > > > >> > > > > >> >It looks like the one in the A83t though, so you can use that > > > >> >compatible instead. > > > >> > > > >> Looking at the patch for the A83t, the only difference is that it > > > >> uses a 3/4 instead of a 2/3 voltage divider, nothing is changed with > > > >> the channels. > > > > > > > >I guess you can reuse the A83t compatible here then, and a more > > > >specific a64 compatible in case we ever need to fix this. > > > > > > > >> But I'm also not sure which one (or a different one) > > > >> is used from looking at the "A64 User Manual". > > > > > > > >I'm sorry, what are you referring to with "one" in that sentence? > > > > > > Sorry, I meant I didn't find anything in the A64 user manual whether > > > a 3/4 or a 2/3 voltage divider (or one with different values) is > > > used on the A64. > > > > Ok :) > > > > I guess you can just reuse the A83t compatible then, together with the > > A64's. > > I'd submit a v2 with these changes to v1 then: > lradc: lradc@1c21800 { > - compatible = "allwinner,sun4i-a10-lradc-keys"; > - reg = <0x01c21800 0x100>; > + compatible = "allwinner,sun50i-a64-lradc-keys", > + "allwinner,sun8i-a83t-r-lradc"; > + reg = <0x01c21800 0x400>; > interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; > status = "disabled"; > }; > Does that look okay? > The reg change is due to me not spotting the address being 0x01C2 > 1800---0x01C2 1BFF, so the size should be 0x400 and not 0x100. It would be great to drop the -keys from the compatible, and to document the bindings Looks good otherwise Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node @ 2019-05-24 9:20 ` Maxime Ripard 0 siblings, 0 replies; 45+ messages in thread From: Maxime Ripard @ 2019-05-24 9:20 UTC (permalink / raw) To: Luca Weiss Cc: Chen-Yu Tsai, Rob Herring, Mark Rutland, moderated list:ARM/Allwinner sunXi SoC support, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list [-- Attachment #1: Type: text/plain, Size: 3581 bytes --] On Fri, May 24, 2019 at 10:35:36AM +0200, Luca Weiss wrote: > On Dienstag, 21. Mai 2019 16:25:44 CEST Maxime Ripard wrote: > > On Tue, May 21, 2019 at 03:52:47PM +0200, luca@z3ntu.xyz wrote: > > > On May 21, 2019 3:09:55 PM GMT+02:00, Maxime Ripard > <maxime.ripard@bootlin.com> wrote: > > > >On Tue, May 21, 2019 at 08:43:45AM +0200, luca@z3ntu.xyz wrote: > > > >> On May 20, 2019 1:07:42 PM GMT+02:00, Maxime Ripard > > > > > > > ><maxime.ripard@bootlin.com> wrote: > > > >> >On Sat, May 18, 2019 at 07:09:30PM +0200, Luca Weiss wrote: > > > >> >> Add a node describing the KEYADC on the A64. > > > >> >> > > > >> >> Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > > > >> >> --- > > > >> >> > > > >> >> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 7 +++++++ > > > >> >> 1 file changed, 7 insertions(+) > > > >> >> > > > >> >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > > >> > > > > >> >b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > > >> > > > > >> >> index 7734f70e1057..dc1bf8c1afb5 100644 > > > >> >> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > > >> >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > > >> >> @@ -704,6 +704,13 @@ > > > >> >> > > > >> >> status = "disabled"; > > > >> >> > > > >> >> }; > > > >> >> > > > >> >> + lradc: lradc@1c21800 { > > > >> >> + compatible = "allwinner,sun4i-a10-lradc- > keys"; > > > >> >> + reg = <0x01c21800 0x100>; > > > >> >> + interrupts = <GIC_SPI 30 > IRQ_TYPE_LEVEL_HIGH>; > > > >> >> + status = "disabled"; > > > >> >> + }; > > > >> >> + > > > >> > > > > >> >The controller is pretty different on the A64 compared to the A10. > > > > > > > >The > > > > > > > >> >A10 has two channels for example, while the A64 has only one. > > > >> > > > > >> >It looks like the one in the A83t though, so you can use that > > > >> >compatible instead. > > > >> > > > >> Looking at the patch for the A83t, the only difference is that it > > > >> uses a 3/4 instead of a 2/3 voltage divider, nothing is changed with > > > >> the channels. > > > > > > > >I guess you can reuse the A83t compatible here then, and a more > > > >specific a64 compatible in case we ever need to fix this. > > > > > > > >> But I'm also not sure which one (or a different one) > > > >> is used from looking at the "A64 User Manual". > > > > > > > >I'm sorry, what are you referring to with "one" in that sentence? > > > > > > Sorry, I meant I didn't find anything in the A64 user manual whether > > > a 3/4 or a 2/3 voltage divider (or one with different values) is > > > used on the A64. > > > > Ok :) > > > > I guess you can just reuse the A83t compatible then, together with the > > A64's. > > I'd submit a v2 with these changes to v1 then: > lradc: lradc@1c21800 { > - compatible = "allwinner,sun4i-a10-lradc-keys"; > - reg = <0x01c21800 0x100>; > + compatible = "allwinner,sun50i-a64-lradc-keys", > + "allwinner,sun8i-a83t-r-lradc"; > + reg = <0x01c21800 0x400>; > interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; > status = "disabled"; > }; > Does that look okay? > The reg change is due to me not spotting the address being 0x01C2 > 1800---0x01C2 1BFF, so the size should be 0x400 and not 0x100. It would be great to drop the -keys from the compatible, and to document the bindings Looks good otherwise Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node 2019-05-24 9:20 ` Maxime Ripard (?) @ 2019-05-31 10:27 ` Luca Weiss -1 siblings, 0 replies; 45+ messages in thread From: Luca Weiss @ 2019-05-31 10:27 UTC (permalink / raw) To: Maxime Ripard Cc: Chen-Yu Tsai, Rob Herring, Mark Rutland, moderated list:ARM/Allwinner sunXi SoC support, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list On Freitag, 24. Mai 2019 11:20:01 CEST Maxime Ripard wrote: > > It would be great to drop the -keys from the compatible, and to > document the bindings > > Looks good otherwise > > Maxime Hi again, So I should just document the "allwinner,sun50i-a64-lradc" string in Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt ? Don't I also have to add the compatible to the driver code then? Just adding the a64 compatible to a dts wouldn't work without that. Thanks, Luca ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node @ 2019-05-31 10:27 ` Luca Weiss 0 siblings, 0 replies; 45+ messages in thread From: Luca Weiss @ 2019-05-31 10:27 UTC (permalink / raw) To: Maxime Ripard Cc: Mark Rutland, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list, Chen-Yu Tsai, Rob Herring, moderated list:ARM/Allwinner sunXi SoC support On Freitag, 24. Mai 2019 11:20:01 CEST Maxime Ripard wrote: > > It would be great to drop the -keys from the compatible, and to > document the bindings > > Looks good otherwise > > Maxime Hi again, So I should just document the "allwinner,sun50i-a64-lradc" string in Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt ? Don't I also have to add the compatible to the driver code then? Just adding the a64 compatible to a dts wouldn't work without that. Thanks, Luca _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node @ 2019-05-31 10:27 ` Luca Weiss 0 siblings, 0 replies; 45+ messages in thread From: Luca Weiss @ 2019-05-31 10:27 UTC (permalink / raw) To: Maxime Ripard Cc: Chen-Yu Tsai, Rob Herring, Mark Rutland, moderated list:ARM/Allwinner sunXi SoC support, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list On Freitag, 24. Mai 2019 11:20:01 CEST Maxime Ripard wrote: > > It would be great to drop the -keys from the compatible, and to > document the bindings > > Looks good otherwise > > Maxime Hi again, So I should just document the "allwinner,sun50i-a64-lradc" string in Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt ? Don't I also have to add the compatible to the driver code then? Just adding the a64 compatible to a dts wouldn't work without that. Thanks, Luca ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node 2019-05-31 10:27 ` Luca Weiss (?) @ 2019-06-03 7:42 ` Maxime Ripard -1 siblings, 0 replies; 45+ messages in thread From: Maxime Ripard @ 2019-06-03 7:42 UTC (permalink / raw) To: Luca Weiss Cc: Chen-Yu Tsai, Rob Herring, Mark Rutland, moderated list:ARM/Allwinner sunXi SoC support, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list [-- Attachment #1: Type: text/plain, Size: 969 bytes --] Hi, On Fri, May 31, 2019 at 12:27:55PM +0200, Luca Weiss wrote: > On Freitag, 24. Mai 2019 11:20:01 CEST Maxime Ripard wrote: > > > > It would be great to drop the -keys from the compatible, and to > > document the bindings > > > > Looks good otherwise > > > > Maxime > > So I should just document the "allwinner,sun50i-a64-lradc" string in > Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt ? Don't I also > have to add the compatible to the driver code then? Just adding the a64 > compatible to a dts wouldn't work without that. What I meant was that you needed both, something like: compatible = "allwinner,sun50i-a64-lradc", "allwinner,sun8i-a83t-lradc"; That way, the OS will try to match a driver for the A64 compatible if any, and fallback to the A83's otherwise. And since we don't have any quirk at the moment, there's no change needed to the driver. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node @ 2019-06-03 7:42 ` Maxime Ripard 0 siblings, 0 replies; 45+ messages in thread From: Maxime Ripard @ 2019-06-03 7:42 UTC (permalink / raw) To: Luca Weiss Cc: Mark Rutland, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list, Chen-Yu Tsai, Rob Herring, moderated list:ARM/Allwinner sunXi SoC support [-- Attachment #1.1: Type: text/plain, Size: 969 bytes --] Hi, On Fri, May 31, 2019 at 12:27:55PM +0200, Luca Weiss wrote: > On Freitag, 24. Mai 2019 11:20:01 CEST Maxime Ripard wrote: > > > > It would be great to drop the -keys from the compatible, and to > > document the bindings > > > > Looks good otherwise > > > > Maxime > > So I should just document the "allwinner,sun50i-a64-lradc" string in > Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt ? Don't I also > have to add the compatible to the driver code then? Just adding the a64 > compatible to a dts wouldn't work without that. What I meant was that you needed both, something like: compatible = "allwinner,sun50i-a64-lradc", "allwinner,sun8i-a83t-lradc"; That way, the OS will try to match a driver for the A64 compatible if any, and fallback to the A83's otherwise. And since we don't have any quirk at the moment, there's no change needed to the driver. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node @ 2019-06-03 7:42 ` Maxime Ripard 0 siblings, 0 replies; 45+ messages in thread From: Maxime Ripard @ 2019-06-03 7:42 UTC (permalink / raw) To: Luca Weiss Cc: Chen-Yu Tsai, Rob Herring, Mark Rutland, moderated list:ARM/Allwinner sunXi SoC support, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list [-- Attachment #1: Type: text/plain, Size: 969 bytes --] Hi, On Fri, May 31, 2019 at 12:27:55PM +0200, Luca Weiss wrote: > On Freitag, 24. Mai 2019 11:20:01 CEST Maxime Ripard wrote: > > > > It would be great to drop the -keys from the compatible, and to > > document the bindings > > > > Looks good otherwise > > > > Maxime > > So I should just document the "allwinner,sun50i-a64-lradc" string in > Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt ? Don't I also > have to add the compatible to the driver code then? Just adding the a64 > compatible to a dts wouldn't work without that. What I meant was that you needed both, something like: compatible = "allwinner,sun50i-a64-lradc", "allwinner,sun8i-a83t-lradc"; That way, the OS will try to match a driver for the A64 compatible if any, and fallback to the A83's otherwise. And since we don't have any quirk at the moment, there's no change needed to the driver. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node 2019-06-03 7:42 ` Maxime Ripard (?) @ 2019-06-03 15:20 ` Luca Weiss -1 siblings, 0 replies; 45+ messages in thread From: Luca Weiss @ 2019-06-03 15:20 UTC (permalink / raw) To: Maxime Ripard Cc: Chen-Yu Tsai, Rob Herring, Mark Rutland, moderated list:ARM/Allwinner sunXi SoC support, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list [-- Attachment #1: Type: text/plain, Size: 2020 bytes --] On Montag, 3. Juni 2019 09:42:47 CEST Maxime Ripard wrote: > Hi, > > On Fri, May 31, 2019 at 12:27:55PM +0200, Luca Weiss wrote: > > On Freitag, 24. Mai 2019 11:20:01 CEST Maxime Ripard wrote: > > > It would be great to drop the -keys from the compatible, and to > > > document the bindings > > > > > > Looks good otherwise > > > > > > Maxime > > > > So I should just document the "allwinner,sun50i-a64-lradc" string in > > Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt ? Don't I > > also > > have to add the compatible to the driver code then? Just adding the a64 > > compatible to a dts wouldn't work without that. > > What I meant was that you needed both, something like: > > compatible = "allwinner,sun50i-a64-lradc", "allwinner,sun8i-a83t-lradc"; > > That way, the OS will try to match a driver for the A64 compatible if > any, and fallback to the A83's otherwise. And since we don't have any > quirk at the moment, there's no change needed to the driver. > > Maxime > > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com Hi Maxime, sorry for the long back and forth, I hope I understood you correctly now. Here's what I would submit as v2 then (I'll split the two files into seperate patches as the devicetree documentation suggests) Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt: - compatible: should be one of the following string: "allwinner,sun4i-a10-lradc-keys" "allwinner,sun8i-a83t-r-lradc" + "allwinner,sun50i-a64-lradc", "allwinner,sun8i-a83t-r-lradc" arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi: + lradc: lradc@1c21800 { + compatible = "allwinner,sun50i-a64-lradc", + "allwinner,sun8i-a83t-r-lradc"; + reg = <0x01c21800 0x400>; + interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; + status = "disabled"; + }; + Thanks, Luca [-- Attachment #2: This is a digitally signed message part. --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node @ 2019-06-03 15:20 ` Luca Weiss 0 siblings, 0 replies; 45+ messages in thread From: Luca Weiss @ 2019-06-03 15:20 UTC (permalink / raw) To: Maxime Ripard Cc: Mark Rutland, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list, Chen-Yu Tsai, Rob Herring, moderated list:ARM/Allwinner sunXi SoC support [-- Attachment #1.1: Type: text/plain, Size: 2020 bytes --] On Montag, 3. Juni 2019 09:42:47 CEST Maxime Ripard wrote: > Hi, > > On Fri, May 31, 2019 at 12:27:55PM +0200, Luca Weiss wrote: > > On Freitag, 24. Mai 2019 11:20:01 CEST Maxime Ripard wrote: > > > It would be great to drop the -keys from the compatible, and to > > > document the bindings > > > > > > Looks good otherwise > > > > > > Maxime > > > > So I should just document the "allwinner,sun50i-a64-lradc" string in > > Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt ? Don't I > > also > > have to add the compatible to the driver code then? Just adding the a64 > > compatible to a dts wouldn't work without that. > > What I meant was that you needed both, something like: > > compatible = "allwinner,sun50i-a64-lradc", "allwinner,sun8i-a83t-lradc"; > > That way, the OS will try to match a driver for the A64 compatible if > any, and fallback to the A83's otherwise. And since we don't have any > quirk at the moment, there's no change needed to the driver. > > Maxime > > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com Hi Maxime, sorry for the long back and forth, I hope I understood you correctly now. Here's what I would submit as v2 then (I'll split the two files into seperate patches as the devicetree documentation suggests) Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt: - compatible: should be one of the following string: "allwinner,sun4i-a10-lradc-keys" "allwinner,sun8i-a83t-r-lradc" + "allwinner,sun50i-a64-lradc", "allwinner,sun8i-a83t-r-lradc" arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi: + lradc: lradc@1c21800 { + compatible = "allwinner,sun50i-a64-lradc", + "allwinner,sun8i-a83t-r-lradc"; + reg = <0x01c21800 0x400>; + interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; + status = "disabled"; + }; + Thanks, Luca [-- Attachment #1.2: This is a digitally signed message part. --] [-- Type: application/pgp-signature, Size: 833 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node @ 2019-06-03 15:20 ` Luca Weiss 0 siblings, 0 replies; 45+ messages in thread From: Luca Weiss @ 2019-06-03 15:20 UTC (permalink / raw) To: Maxime Ripard Cc: Chen-Yu Tsai, Rob Herring, Mark Rutland, moderated list:ARM/Allwinner sunXi SoC support, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list [-- Attachment #1: Type: text/plain, Size: 2020 bytes --] On Montag, 3. Juni 2019 09:42:47 CEST Maxime Ripard wrote: > Hi, > > On Fri, May 31, 2019 at 12:27:55PM +0200, Luca Weiss wrote: > > On Freitag, 24. Mai 2019 11:20:01 CEST Maxime Ripard wrote: > > > It would be great to drop the -keys from the compatible, and to > > > document the bindings > > > > > > Looks good otherwise > > > > > > Maxime > > > > So I should just document the "allwinner,sun50i-a64-lradc" string in > > Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt ? Don't I > > also > > have to add the compatible to the driver code then? Just adding the a64 > > compatible to a dts wouldn't work without that. > > What I meant was that you needed both, something like: > > compatible = "allwinner,sun50i-a64-lradc", "allwinner,sun8i-a83t-lradc"; > > That way, the OS will try to match a driver for the A64 compatible if > any, and fallback to the A83's otherwise. And since we don't have any > quirk at the moment, there's no change needed to the driver. > > Maxime > > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com Hi Maxime, sorry for the long back and forth, I hope I understood you correctly now. Here's what I would submit as v2 then (I'll split the two files into seperate patches as the devicetree documentation suggests) Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt: - compatible: should be one of the following string: "allwinner,sun4i-a10-lradc-keys" "allwinner,sun8i-a83t-r-lradc" + "allwinner,sun50i-a64-lradc", "allwinner,sun8i-a83t-r-lradc" arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi: + lradc: lradc@1c21800 { + compatible = "allwinner,sun50i-a64-lradc", + "allwinner,sun8i-a83t-r-lradc"; + reg = <0x01c21800 0x400>; + interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; + status = "disabled"; + }; + Thanks, Luca [-- Attachment #2: This is a digitally signed message part. --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node 2019-06-03 15:20 ` Luca Weiss (?) @ 2019-06-04 8:28 ` Maxime Ripard -1 siblings, 0 replies; 45+ messages in thread From: Maxime Ripard @ 2019-06-04 8:28 UTC (permalink / raw) To: Luca Weiss Cc: Chen-Yu Tsai, Rob Herring, Mark Rutland, moderated list:ARM/Allwinner sunXi SoC support, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list [-- Attachment #1: Type: text/plain, Size: 2163 bytes --] On Mon, Jun 03, 2019 at 05:20:51PM +0200, Luca Weiss wrote: > On Montag, 3. Juni 2019 09:42:47 CEST Maxime Ripard wrote: > > Hi, > > > > On Fri, May 31, 2019 at 12:27:55PM +0200, Luca Weiss wrote: > > > On Freitag, 24. Mai 2019 11:20:01 CEST Maxime Ripard wrote: > > > > It would be great to drop the -keys from the compatible, and to > > > > document the bindings > > > > > > > > Looks good otherwise > > > > > > > > Maxime > > > > > > So I should just document the "allwinner,sun50i-a64-lradc" string in > > > Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt ? Don't I > > > also > > > have to add the compatible to the driver code then? Just adding the a64 > > > compatible to a dts wouldn't work without that. > > > > What I meant was that you needed both, something like: > > > > compatible = "allwinner,sun50i-a64-lradc", "allwinner,sun8i-a83t-lradc"; > > > > That way, the OS will try to match a driver for the A64 compatible if > > any, and fallback to the A83's otherwise. And since we don't have any > > quirk at the moment, there's no change needed to the driver. > > sorry for the long back and forth, I hope I understood you correctly now. > Here's what I would submit as v2 then (I'll split the two files into seperate > patches as the devicetree documentation suggests) > > Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt: > - compatible: should be one of the following string: > "allwinner,sun4i-a10-lradc-keys" > "allwinner,sun8i-a83t-r-lradc" > + "allwinner,sun50i-a64-lradc", "allwinner,sun8i-a83t-r-lradc" > > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi: > + lradc: lradc@1c21800 { > + compatible = "allwinner,sun50i-a64-lradc", > + "allwinner,sun8i-a83t-r-lradc"; > + reg = <0x01c21800 0x400>; > + interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; > + status = "disabled"; > + }; > + > > Thanks, > Luca That looks correct :) Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node @ 2019-06-04 8:28 ` Maxime Ripard 0 siblings, 0 replies; 45+ messages in thread From: Maxime Ripard @ 2019-06-04 8:28 UTC (permalink / raw) To: Luca Weiss Cc: Mark Rutland, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list, Chen-Yu Tsai, Rob Herring, moderated list:ARM/Allwinner sunXi SoC support [-- Attachment #1.1: Type: text/plain, Size: 2163 bytes --] On Mon, Jun 03, 2019 at 05:20:51PM +0200, Luca Weiss wrote: > On Montag, 3. Juni 2019 09:42:47 CEST Maxime Ripard wrote: > > Hi, > > > > On Fri, May 31, 2019 at 12:27:55PM +0200, Luca Weiss wrote: > > > On Freitag, 24. Mai 2019 11:20:01 CEST Maxime Ripard wrote: > > > > It would be great to drop the -keys from the compatible, and to > > > > document the bindings > > > > > > > > Looks good otherwise > > > > > > > > Maxime > > > > > > So I should just document the "allwinner,sun50i-a64-lradc" string in > > > Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt ? Don't I > > > also > > > have to add the compatible to the driver code then? Just adding the a64 > > > compatible to a dts wouldn't work without that. > > > > What I meant was that you needed both, something like: > > > > compatible = "allwinner,sun50i-a64-lradc", "allwinner,sun8i-a83t-lradc"; > > > > That way, the OS will try to match a driver for the A64 compatible if > > any, and fallback to the A83's otherwise. And since we don't have any > > quirk at the moment, there's no change needed to the driver. > > sorry for the long back and forth, I hope I understood you correctly now. > Here's what I would submit as v2 then (I'll split the two files into seperate > patches as the devicetree documentation suggests) > > Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt: > - compatible: should be one of the following string: > "allwinner,sun4i-a10-lradc-keys" > "allwinner,sun8i-a83t-r-lradc" > + "allwinner,sun50i-a64-lradc", "allwinner,sun8i-a83t-r-lradc" > > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi: > + lradc: lradc@1c21800 { > + compatible = "allwinner,sun50i-a64-lradc", > + "allwinner,sun8i-a83t-r-lradc"; > + reg = <0x01c21800 0x400>; > + interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; > + status = "disabled"; > + }; > + > > Thanks, > Luca That looks correct :) Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node @ 2019-06-04 8:28 ` Maxime Ripard 0 siblings, 0 replies; 45+ messages in thread From: Maxime Ripard @ 2019-06-04 8:28 UTC (permalink / raw) To: Luca Weiss Cc: Chen-Yu Tsai, Rob Herring, Mark Rutland, moderated list:ARM/Allwinner sunXi SoC support, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list [-- Attachment #1: Type: text/plain, Size: 2163 bytes --] On Mon, Jun 03, 2019 at 05:20:51PM +0200, Luca Weiss wrote: > On Montag, 3. Juni 2019 09:42:47 CEST Maxime Ripard wrote: > > Hi, > > > > On Fri, May 31, 2019 at 12:27:55PM +0200, Luca Weiss wrote: > > > On Freitag, 24. Mai 2019 11:20:01 CEST Maxime Ripard wrote: > > > > It would be great to drop the -keys from the compatible, and to > > > > document the bindings > > > > > > > > Looks good otherwise > > > > > > > > Maxime > > > > > > So I should just document the "allwinner,sun50i-a64-lradc" string in > > > Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt ? Don't I > > > also > > > have to add the compatible to the driver code then? Just adding the a64 > > > compatible to a dts wouldn't work without that. > > > > What I meant was that you needed both, something like: > > > > compatible = "allwinner,sun50i-a64-lradc", "allwinner,sun8i-a83t-lradc"; > > > > That way, the OS will try to match a driver for the A64 compatible if > > any, and fallback to the A83's otherwise. And since we don't have any > > quirk at the moment, there's no change needed to the driver. > > sorry for the long back and forth, I hope I understood you correctly now. > Here's what I would submit as v2 then (I'll split the two files into seperate > patches as the devicetree documentation suggests) > > Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt: > - compatible: should be one of the following string: > "allwinner,sun4i-a10-lradc-keys" > "allwinner,sun8i-a83t-r-lradc" > + "allwinner,sun50i-a64-lradc", "allwinner,sun8i-a83t-r-lradc" > > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi: > + lradc: lradc@1c21800 { > + compatible = "allwinner,sun50i-a64-lradc", > + "allwinner,sun8i-a83t-r-lradc"; > + reg = <0x01c21800 0x400>; > + interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; > + status = "disabled"; > + }; > + > > Thanks, > Luca That looks correct :) Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 45+ messages in thread
* [PATCH] arm64: dts: allwinner: a64: Add lradc node @ 2019-06-04 14:42 ` Luca Weiss 0 siblings, 0 replies; 45+ messages in thread From: Luca Weiss @ 2019-06-04 14:42 UTC (permalink / raw) Cc: Luca Weiss, Hans de Goede, Dmitry Torokhov, Rob Herring, Mark Rutland, Maxime Ripard, Chen-Yu Tsai, open list:SUN4I LOW RES ADC ATTACHED TABLET KEYS DRIVER, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, moderated list:ARM/Allwinner sunXi SoC support, open list Add a node describing the KEYADC on the A64. Signed-off-by: Luca Weiss <luca@z3ntu.xyz> --- .../devicetree/bindings/input/sun4i-lradc-keys.txt | 1 + arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 8 ++++++++ 2 files changed, 9 insertions(+) diff --git a/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt b/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt index 496125c6bfb7..507b737612ea 100644 --- a/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt +++ b/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt @@ -5,6 +5,7 @@ Required properties: - compatible: should be one of the following string: "allwinner,sun4i-a10-lradc-keys" "allwinner,sun8i-a83t-r-lradc" + "allwinner,sun50i-a64-lradc", "allwinner,sun8i-a83t-r-lradc" - reg: mmio address range of the chip - interrupts: interrupt to which the chip is connected - vref-supply: powersupply for the lradc reference voltage diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi index 7734f70e1057..3a42352b5c9f 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi @@ -704,6 +704,14 @@ status = "disabled"; }; + lradc: lradc@1c21800 { + compatible = "allwinner,sun50i-a64-lradc", + "allwinner,sun8i-a83t-r-lradc"; + reg = <0x01c21800 0x400>; + interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; + status = "disabled"; + }; + i2s0: i2s@1c22000 { #sound-dai-cells = <0>; compatible = "allwinner,sun50i-a64-i2s", -- 2.21.0 ^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PATCH] arm64: dts: allwinner: a64: Add lradc node @ 2019-06-04 14:42 ` Luca Weiss 0 siblings, 0 replies; 45+ messages in thread From: Luca Weiss @ 2019-06-04 14:42 UTC (permalink / raw) Cc: Mark Rutland, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, Maxime Ripard, Dmitry Torokhov, open list, Luca Weiss, Hans de Goede, Chen-Yu Tsai, Rob Herring, open list:SUN4I LOW RES ADC ATTACHED TABLET KEYS DRIVER, moderated list:ARM/Allwinner sunXi SoC support Add a node describing the KEYADC on the A64. Signed-off-by: Luca Weiss <luca@z3ntu.xyz> --- .../devicetree/bindings/input/sun4i-lradc-keys.txt | 1 + arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 8 ++++++++ 2 files changed, 9 insertions(+) diff --git a/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt b/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt index 496125c6bfb7..507b737612ea 100644 --- a/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt +++ b/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt @@ -5,6 +5,7 @@ Required properties: - compatible: should be one of the following string: "allwinner,sun4i-a10-lradc-keys" "allwinner,sun8i-a83t-r-lradc" + "allwinner,sun50i-a64-lradc", "allwinner,sun8i-a83t-r-lradc" - reg: mmio address range of the chip - interrupts: interrupt to which the chip is connected - vref-supply: powersupply for the lradc reference voltage diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi index 7734f70e1057..3a42352b5c9f 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi @@ -704,6 +704,14 @@ status = "disabled"; }; + lradc: lradc@1c21800 { + compatible = "allwinner,sun50i-a64-lradc", + "allwinner,sun8i-a83t-r-lradc"; + reg = <0x01c21800 0x400>; + interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; + status = "disabled"; + }; + i2s0: i2s@1c22000 { #sound-dai-cells = <0>; compatible = "allwinner,sun50i-a64-i2s", -- 2.21.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 45+ messages in thread
* [PATCH] arm64: dts: allwinner: a64: Add lradc node @ 2019-06-04 14:42 ` Luca Weiss 0 siblings, 0 replies; 45+ messages in thread From: Luca Weiss @ 2019-06-04 14:42 UTC (permalink / raw) Cc: Luca Weiss, Hans de Goede, Dmitry Torokhov, Rob Herring, Mark Rutland, Maxime Ripard, Chen-Yu Tsai, open list:SUN4I LOW RES ADC ATTACHED TABLET KEYS DRIVER, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, moderated list:ARM/Allwinner sunXi SoC support, open list Add a node describing the KEYADC on the A64. Signed-off-by: Luca Weiss <luca@z3ntu.xyz> --- .../devicetree/bindings/input/sun4i-lradc-keys.txt | 1 + arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 8 ++++++++ 2 files changed, 9 insertions(+) diff --git a/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt b/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt index 496125c6bfb7..507b737612ea 100644 --- a/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt +++ b/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt @@ -5,6 +5,7 @@ Required properties: - compatible: should be one of the following string: "allwinner,sun4i-a10-lradc-keys" "allwinner,sun8i-a83t-r-lradc" + "allwinner,sun50i-a64-lradc", "allwinner,sun8i-a83t-r-lradc" - reg: mmio address range of the chip - interrupts: interrupt to which the chip is connected - vref-supply: powersupply for the lradc reference voltage diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi index 7734f70e1057..3a42352b5c9f 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi @@ -704,6 +704,14 @@ status = "disabled"; }; + lradc: lradc@1c21800 { + compatible = "allwinner,sun50i-a64-lradc", + "allwinner,sun8i-a83t-r-lradc"; + reg = <0x01c21800 0x400>; + interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; + status = "disabled"; + }; + i2s0: i2s@1c22000 { #sound-dai-cells = <0>; compatible = "allwinner,sun50i-a64-i2s", -- 2.21.0 ^ permalink raw reply related [flat|nested] 45+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node 2019-06-04 14:42 ` Luca Weiss (?) @ 2019-06-04 14:59 ` Maxime Ripard -1 siblings, 0 replies; 45+ messages in thread From: Maxime Ripard @ 2019-06-04 14:59 UTC (permalink / raw) To: Luca Weiss Cc: Hans de Goede, Dmitry Torokhov, Rob Herring, Mark Rutland, Chen-Yu Tsai, open list:SUN4I LOW RES ADC ATTACHED TABLET KEYS DRIVER, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, moderated list:ARM/Allwinner sunXi SoC support, open list [-- Attachment #1: Type: text/plain, Size: 2046 bytes --] Hi Luca, On Tue, Jun 04, 2019 at 04:42:53PM +0200, Luca Weiss wrote: > Add a node describing the KEYADC on the A64. > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> You should have a changelog detailing which changes you made to your patch with the previous version, and why you made those changes (for example because we looked at the a83t datasheet and found the two controllers to be very similar). > --- > .../devicetree/bindings/input/sun4i-lradc-keys.txt | 1 + > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 8 ++++++++ > 2 files changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt b/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt > index 496125c6bfb7..507b737612ea 100644 > --- a/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt > +++ b/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt > @@ -5,6 +5,7 @@ Required properties: > - compatible: should be one of the following string: > "allwinner,sun4i-a10-lradc-keys" > "allwinner,sun8i-a83t-r-lradc" > + "allwinner,sun50i-a64-lradc", "allwinner,sun8i-a83t-r-lradc" > - reg: mmio address range of the chip > - interrupts: interrupt to which the chip is connected > - vref-supply: powersupply for the lradc reference voltage > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > index 7734f70e1057..3a42352b5c9f 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > @@ -704,6 +704,14 @@ > status = "disabled"; > }; > > + lradc: lradc@1c21800 { > + compatible = "allwinner,sun50i-a64-lradc", > + "allwinner,sun8i-a83t-r-lradc"; > + reg = <0x01c21800 0x400>; > + interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; > + status = "disabled"; > + }; > + The bindings and the dt changes should be two different patches as well. Thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node @ 2019-06-04 14:59 ` Maxime Ripard 0 siblings, 0 replies; 45+ messages in thread From: Maxime Ripard @ 2019-06-04 14:59 UTC (permalink / raw) To: Luca Weiss Cc: Mark Rutland, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, Dmitry Torokhov, open list, Hans de Goede, Chen-Yu Tsai, Rob Herring, open list:SUN4I LOW RES ADC ATTACHED TABLET KEYS DRIVER, moderated list:ARM/Allwinner sunXi SoC support [-- Attachment #1.1: Type: text/plain, Size: 2046 bytes --] Hi Luca, On Tue, Jun 04, 2019 at 04:42:53PM +0200, Luca Weiss wrote: > Add a node describing the KEYADC on the A64. > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> You should have a changelog detailing which changes you made to your patch with the previous version, and why you made those changes (for example because we looked at the a83t datasheet and found the two controllers to be very similar). > --- > .../devicetree/bindings/input/sun4i-lradc-keys.txt | 1 + > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 8 ++++++++ > 2 files changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt b/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt > index 496125c6bfb7..507b737612ea 100644 > --- a/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt > +++ b/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt > @@ -5,6 +5,7 @@ Required properties: > - compatible: should be one of the following string: > "allwinner,sun4i-a10-lradc-keys" > "allwinner,sun8i-a83t-r-lradc" > + "allwinner,sun50i-a64-lradc", "allwinner,sun8i-a83t-r-lradc" > - reg: mmio address range of the chip > - interrupts: interrupt to which the chip is connected > - vref-supply: powersupply for the lradc reference voltage > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > index 7734f70e1057..3a42352b5c9f 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > @@ -704,6 +704,14 @@ > status = "disabled"; > }; > > + lradc: lradc@1c21800 { > + compatible = "allwinner,sun50i-a64-lradc", > + "allwinner,sun8i-a83t-r-lradc"; > + reg = <0x01c21800 0x400>; > + interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; > + status = "disabled"; > + }; > + The bindings and the dt changes should be two different patches as well. Thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node @ 2019-06-04 14:59 ` Maxime Ripard 0 siblings, 0 replies; 45+ messages in thread From: Maxime Ripard @ 2019-06-04 14:59 UTC (permalink / raw) To: Luca Weiss Cc: Hans de Goede, Dmitry Torokhov, Rob Herring, Mark Rutland, Chen-Yu Tsai, open list:SUN4I LOW RES ADC ATTACHED TABLET KEYS DRIVER, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, moderated list:ARM/Allwinner sunXi SoC support, open list [-- Attachment #1: Type: text/plain, Size: 2046 bytes --] Hi Luca, On Tue, Jun 04, 2019 at 04:42:53PM +0200, Luca Weiss wrote: > Add a node describing the KEYADC on the A64. > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> You should have a changelog detailing which changes you made to your patch with the previous version, and why you made those changes (for example because we looked at the a83t datasheet and found the two controllers to be very similar). > --- > .../devicetree/bindings/input/sun4i-lradc-keys.txt | 1 + > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 8 ++++++++ > 2 files changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt b/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt > index 496125c6bfb7..507b737612ea 100644 > --- a/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt > +++ b/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt > @@ -5,6 +5,7 @@ Required properties: > - compatible: should be one of the following string: > "allwinner,sun4i-a10-lradc-keys" > "allwinner,sun8i-a83t-r-lradc" > + "allwinner,sun50i-a64-lradc", "allwinner,sun8i-a83t-r-lradc" > - reg: mmio address range of the chip > - interrupts: interrupt to which the chip is connected > - vref-supply: powersupply for the lradc reference voltage > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > index 7734f70e1057..3a42352b5c9f 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > @@ -704,6 +704,14 @@ > status = "disabled"; > }; > > + lradc: lradc@1c21800 { > + compatible = "allwinner,sun50i-a64-lradc", > + "allwinner,sun8i-a83t-r-lradc"; > + reg = <0x01c21800 0x400>; > + interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; > + status = "disabled"; > + }; > + The bindings and the dt changes should be two different patches as well. Thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node 2019-06-04 14:59 ` Maxime Ripard (?) @ 2019-06-04 15:07 ` Luca Weiss -1 siblings, 0 replies; 45+ messages in thread From: Luca Weiss @ 2019-06-04 15:07 UTC (permalink / raw) To: Maxime Ripard Cc: Hans de Goede, Dmitry Torokhov, Rob Herring, Mark Rutland, Chen-Yu Tsai, open list:SUN4I LOW RES ADC ATTACHED TABLET KEYS DRIVER, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, moderated list:ARM/Allwinner sunXi SoC support, open list [-- Attachment #1: Type: text/plain, Size: 2684 bytes --] Hi Maxime, sorry I forgot to mark it as a v2 and add the changelog to v1. I've actually not split the patch into two on purpose as it's a pretty small change and the patch adding support for the A83T didn't split out the device tree changes - and recently in another patch of mine, the extra devicetree patch was squashed into the driver patch by the maintainer while merging. I'll fix this up asap. Luca On Dienstag, 4. Juni 2019 16:59:07 CEST Maxime Ripard wrote: > Hi Luca, > > On Tue, Jun 04, 2019 at 04:42:53PM +0200, Luca Weiss wrote: > > Add a node describing the KEYADC on the A64. > > > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > > You should have a changelog detailing which changes you made to your > patch with the previous version, and why you made those changes (for > example because we looked at the a83t datasheet and found the two > controllers to be very similar). > > > --- > > > > .../devicetree/bindings/input/sun4i-lradc-keys.txt | 1 + > > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 8 ++++++++ > > 2 files changed, 9 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt > > b/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt index > > 496125c6bfb7..507b737612ea 100644 > > --- a/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt > > +++ b/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt > > > > @@ -5,6 +5,7 @@ Required properties: > > - compatible: should be one of the following string: > > "allwinner,sun4i-a10-lradc-keys" > > "allwinner,sun8i-a83t-r-lradc" > > > > + "allwinner,sun50i-a64-lradc", "allwinner,sun8i-a83t-r- lradc" > > > > - reg: mmio address range of the chip > > - interrupts: interrupt to which the chip is connected > > - vref-supply: powersupply for the lradc reference voltage > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi index > > 7734f70e1057..3a42352b5c9f 100644 > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > @@ -704,6 +704,14 @@ > > > > status = "disabled"; > > > > }; > > > > + lradc: lradc@1c21800 { > > + compatible = "allwinner,sun50i-a64-lradc", > > + "allwinner,sun8i-a83t-r- lradc"; > > + reg = <0x01c21800 0x400>; > > + interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; > > + status = "disabled"; > > + }; > > + > > The bindings and the dt changes should be two different patches as > well. > > Thanks! > Maxime > > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com [-- Attachment #2: This is a digitally signed message part. --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node @ 2019-06-04 15:07 ` Luca Weiss 0 siblings, 0 replies; 45+ messages in thread From: Luca Weiss @ 2019-06-04 15:07 UTC (permalink / raw) To: Maxime Ripard Cc: Mark Rutland, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, Dmitry Torokhov, open list, Hans de Goede, Chen-Yu Tsai, Rob Herring, open list:SUN4I LOW RES ADC ATTACHED TABLET KEYS DRIVER, moderated list:ARM/Allwinner sunXi SoC support [-- Attachment #1.1: Type: text/plain, Size: 2684 bytes --] Hi Maxime, sorry I forgot to mark it as a v2 and add the changelog to v1. I've actually not split the patch into two on purpose as it's a pretty small change and the patch adding support for the A83T didn't split out the device tree changes - and recently in another patch of mine, the extra devicetree patch was squashed into the driver patch by the maintainer while merging. I'll fix this up asap. Luca On Dienstag, 4. Juni 2019 16:59:07 CEST Maxime Ripard wrote: > Hi Luca, > > On Tue, Jun 04, 2019 at 04:42:53PM +0200, Luca Weiss wrote: > > Add a node describing the KEYADC on the A64. > > > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > > You should have a changelog detailing which changes you made to your > patch with the previous version, and why you made those changes (for > example because we looked at the a83t datasheet and found the two > controllers to be very similar). > > > --- > > > > .../devicetree/bindings/input/sun4i-lradc-keys.txt | 1 + > > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 8 ++++++++ > > 2 files changed, 9 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt > > b/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt index > > 496125c6bfb7..507b737612ea 100644 > > --- a/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt > > +++ b/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt > > > > @@ -5,6 +5,7 @@ Required properties: > > - compatible: should be one of the following string: > > "allwinner,sun4i-a10-lradc-keys" > > "allwinner,sun8i-a83t-r-lradc" > > > > + "allwinner,sun50i-a64-lradc", "allwinner,sun8i-a83t-r- lradc" > > > > - reg: mmio address range of the chip > > - interrupts: interrupt to which the chip is connected > > - vref-supply: powersupply for the lradc reference voltage > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi index > > 7734f70e1057..3a42352b5c9f 100644 > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > @@ -704,6 +704,14 @@ > > > > status = "disabled"; > > > > }; > > > > + lradc: lradc@1c21800 { > > + compatible = "allwinner,sun50i-a64-lradc", > > + "allwinner,sun8i-a83t-r- lradc"; > > + reg = <0x01c21800 0x400>; > > + interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; > > + status = "disabled"; > > + }; > > + > > The bindings and the dt changes should be two different patches as > well. > > Thanks! > Maxime > > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com [-- Attachment #1.2: This is a digitally signed message part. --] [-- Type: application/pgp-signature, Size: 833 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node @ 2019-06-04 15:07 ` Luca Weiss 0 siblings, 0 replies; 45+ messages in thread From: Luca Weiss @ 2019-06-04 15:07 UTC (permalink / raw) To: Maxime Ripard Cc: Hans de Goede, Dmitry Torokhov, Rob Herring, Mark Rutland, Chen-Yu Tsai, open list:SUN4I LOW RES ADC ATTACHED TABLET KEYS DRIVER, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, moderated list:ARM/Allwinner sunXi SoC support, open list [-- Attachment #1: Type: text/plain, Size: 2684 bytes --] Hi Maxime, sorry I forgot to mark it as a v2 and add the changelog to v1. I've actually not split the patch into two on purpose as it's a pretty small change and the patch adding support for the A83T didn't split out the device tree changes - and recently in another patch of mine, the extra devicetree patch was squashed into the driver patch by the maintainer while merging. I'll fix this up asap. Luca On Dienstag, 4. Juni 2019 16:59:07 CEST Maxime Ripard wrote: > Hi Luca, > > On Tue, Jun 04, 2019 at 04:42:53PM +0200, Luca Weiss wrote: > > Add a node describing the KEYADC on the A64. > > > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > > You should have a changelog detailing which changes you made to your > patch with the previous version, and why you made those changes (for > example because we looked at the a83t datasheet and found the two > controllers to be very similar). > > > --- > > > > .../devicetree/bindings/input/sun4i-lradc-keys.txt | 1 + > > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 8 ++++++++ > > 2 files changed, 9 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt > > b/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt index > > 496125c6bfb7..507b737612ea 100644 > > --- a/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt > > +++ b/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt > > > > @@ -5,6 +5,7 @@ Required properties: > > - compatible: should be one of the following string: > > "allwinner,sun4i-a10-lradc-keys" > > "allwinner,sun8i-a83t-r-lradc" > > > > + "allwinner,sun50i-a64-lradc", "allwinner,sun8i-a83t-r- lradc" > > > > - reg: mmio address range of the chip > > - interrupts: interrupt to which the chip is connected > > - vref-supply: powersupply for the lradc reference voltage > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi index > > 7734f70e1057..3a42352b5c9f 100644 > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > @@ -704,6 +704,14 @@ > > > > status = "disabled"; > > > > }; > > > > + lradc: lradc@1c21800 { > > + compatible = "allwinner,sun50i-a64-lradc", > > + "allwinner,sun8i-a83t-r- lradc"; > > + reg = <0x01c21800 0x400>; > > + interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; > > + status = "disabled"; > > + }; > > + > > The bindings and the dt changes should be two different patches as > well. > > Thanks! > Maxime > > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com [-- Attachment #2: This is a digitally signed message part. --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 45+ messages in thread
end of thread, other threads:[~2019-06-04 15:08 UTC | newest] Thread overview: 45+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-05-18 17:09 [PATCH] arm64: dts: allwinner: a64: Add lradc node Luca Weiss 2019-05-18 17:09 ` Luca Weiss 2019-05-18 17:09 ` Luca Weiss 2019-05-20 11:07 ` Maxime Ripard 2019-05-20 11:07 ` Maxime Ripard 2019-05-20 11:07 ` Maxime Ripard 2019-05-21 6:43 ` luca 2019-05-21 6:43 ` luca 2019-05-21 6:43 ` luca 2019-05-21 13:09 ` Maxime Ripard 2019-05-21 13:09 ` Maxime Ripard 2019-05-21 13:09 ` Maxime Ripard 2019-05-21 13:52 ` luca 2019-05-21 13:52 ` luca 2019-05-21 13:52 ` luca 2019-05-21 14:25 ` Maxime Ripard 2019-05-21 14:25 ` Maxime Ripard 2019-05-21 14:25 ` Maxime Ripard 2019-05-24 8:35 ` Luca Weiss 2019-05-24 8:35 ` Luca Weiss 2019-05-24 8:35 ` Luca Weiss 2019-05-24 9:20 ` Maxime Ripard 2019-05-24 9:20 ` Maxime Ripard 2019-05-24 9:20 ` Maxime Ripard 2019-05-31 10:27 ` Luca Weiss 2019-05-31 10:27 ` Luca Weiss 2019-05-31 10:27 ` Luca Weiss 2019-06-03 7:42 ` Maxime Ripard 2019-06-03 7:42 ` Maxime Ripard 2019-06-03 7:42 ` Maxime Ripard 2019-06-03 15:20 ` Luca Weiss 2019-06-03 15:20 ` Luca Weiss 2019-06-03 15:20 ` Luca Weiss 2019-06-04 8:28 ` Maxime Ripard 2019-06-04 8:28 ` Maxime Ripard 2019-06-04 8:28 ` Maxime Ripard 2019-06-04 14:42 Luca Weiss 2019-06-04 14:42 ` Luca Weiss 2019-06-04 14:42 ` Luca Weiss 2019-06-04 14:59 ` Maxime Ripard 2019-06-04 14:59 ` Maxime Ripard 2019-06-04 14:59 ` Maxime Ripard 2019-06-04 15:07 ` Luca Weiss 2019-06-04 15:07 ` Luca Weiss 2019-06-04 15:07 ` Luca Weiss
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.