All of lore.kernel.org
 help / color / mirror / Atom feed
* Patch "drm/mgag200: Flag all G200 SE A machines as broken wrt <startadd>" has been added to the 5.4-stable tree
@ 2019-12-19 11:37 gregkh
  2019-12-19 18:24 ` BAD -- " John Donnelly
  0 siblings, 1 reply; 3+ messages in thread
From: gregkh @ 2019-12-19 11:37 UTC (permalink / raw)
  To: 20191206081901.9938-1-tzimmermann, airlied, airlied,
	alexander.deucher, allison, andrzej.p, daniel.vetter, dri-devel,
	gregkh, john.p.donnelly, jose.souza, kraxel, maarten.lankhorst,
	mripard, narmstrong, noralf, sam, tglx, tzimmermann, yc_chen
  Cc: stable-commits


This is a note to let you know that I've just added the patch titled

    drm/mgag200: Flag all G200 SE A machines as broken wrt <startadd>

to the 5.4-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     drm-mgag200-flag-all-g200-se-a-machines-as-broken-wrt-startadd.patch
and it can be found in the queue-5.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


From 4adf0b49eea926a55fd956ef7d86750f771435ff Mon Sep 17 00:00:00 2001
From: Thomas Zimmermann <tzimmermann@suse.de>
Date: Fri, 6 Dec 2019 09:19:01 +0100
Subject: drm/mgag200: Flag all G200 SE A machines as broken wrt <startadd>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Thomas Zimmermann <tzimmermann@suse.de>

commit 4adf0b49eea926a55fd956ef7d86750f771435ff upstream.

Several MGA G200 SE machines don't respect the value of the startadd
register field. After more feedback on affected machines, neither PCI
subvendor ID nor the internal ID seem to hint towards the bug. All
affected machines have a PCI ID of 0x0522 (i.e., G200 SE A). It was
decided to flag all G200 SE A machines as broken.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
Fixes: 1591fadf857c ("drm/mgag200: Add workaround for HW that does not support 'startadd'")
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: John Donnelly <john.p.donnelly@oracle.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Dave Airlie <airlied@redhat.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: David Airlie <airlied@linux.ie>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: "Y.C. Chen" <yc_chen@aspeedtech.com>
Cc: Neil Armstrong <narmstrong@baylibre.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: "José Roberto de Souza" <jose.souza@intel.com>
Cc: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
Cc: dri-devel@lists.freedesktop.org
Cc: <stable@vger.kernel.org> # v5.3+
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Allison Randal <allison@lohutok.net>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Noralf Trønnes" <noralf@tronnes.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20191206081901.9938-1-tzimmermann@suse.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/gpu/drm/mgag200/mgag200_drv.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/drivers/gpu/drm/mgag200/mgag200_drv.c
+++ b/drivers/gpu/drm/mgag200/mgag200_drv.c
@@ -30,9 +30,8 @@ module_param_named(modeset, mgag200_mode
 static struct drm_driver driver;
 
 static const struct pci_device_id pciidlist[] = {
-	{ PCI_VENDOR_ID_MATROX, 0x522, PCI_VENDOR_ID_SUN, 0x4852, 0, 0,
+	{ PCI_VENDOR_ID_MATROX, 0x522, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
 		G200_SE_A | MGAG200_FLAG_HW_BUG_NO_STARTADD},
-	{ PCI_VENDOR_ID_MATROX, 0x522, PCI_ANY_ID, PCI_ANY_ID, 0, 0, G200_SE_A },
 	{ PCI_VENDOR_ID_MATROX, 0x524, PCI_ANY_ID, PCI_ANY_ID, 0, 0, G200_SE_B },
 	{ PCI_VENDOR_ID_MATROX, 0x530, PCI_ANY_ID, PCI_ANY_ID, 0, 0, G200_EV },
 	{ PCI_VENDOR_ID_MATROX, 0x532, PCI_ANY_ID, PCI_ANY_ID, 0, 0, G200_WB },


Patches currently in stable-queue which might be from tzimmermann@suse.de are

queue-5.4/drm-mgag200-flag-all-g200-se-a-machines-as-broken-wrt-startadd.patch
queue-5.4/drm-mgag200-store-flags-from-pci-driver-data-in-device-structure.patch
queue-5.4/drm-mgag200-add-workaround-for-hw-that-does-not-support-startadd.patch
queue-5.4/drm-mgag200-extract-device-type-from-flags.patch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re:   BAD --  Patch "drm/mgag200: Flag all G200 SE A machines as broken wrt <startadd>" has been added to the 5.4-stable tree
  2019-12-19 11:37 Patch "drm/mgag200: Flag all G200 SE A machines as broken wrt <startadd>" has been added to the 5.4-stable tree gregkh
@ 2019-12-19 18:24 ` John Donnelly
  2019-12-19 20:17   ` IGNORE " John Donnelly
  0 siblings, 1 reply; 3+ messages in thread
From: John Donnelly @ 2019-12-19 18:24 UTC (permalink / raw)
  To: gregkh
  Cc: narmstrong, airlied, daniel.vetter, dri-devel, andrzej.p,
	20191206081901.9938-1-tzimmermann, jose.souza, tzimmermann,
	stable-commits, alexander.deucher, airlied, tglx, sam, allison,
	kraxel

Hi 

I am having difficulties with this patch on : 5.4.2  variant ;  The system is not booting with these patches applied. 

I had verified a prototype of the patch on 5.4.0-rc8 ;    

 I am currently debugging it ,  but I will be OoO until 1/6/2020 after today .










> On Dec 19, 2019, at 5:37 AM, gregkh@linuxfoundation.org wrote:
> 
> 
> This is a note to let you know that I've just added the patch titled
> 
>    drm/mgag200: Flag all G200 SE A machines as broken wrt <startadd>
> 
> to the 5.4-stable tree which can be found at:
>    https://urldefense.proofpoint.com/v2/url?u=http-3A__www.kernel.org_git_-3Fp-3Dlinux_kernel_git_stable_stable-2Dqueue.git-3Ba-3Dsummary&d=DwIDaQ&c=RoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE&r=t2fPg9D87F7D8jm0_3CG9yoiIKdRg4qc_thBw4bzMhc&m=Nb5EnzCYEqUCU43_FPM930DrN6A-OrVBoIvQhl3A6xo&s=mqHE1ETbyuc9Qg_WHNUzDRBGo073QFCYwTAxpxXEQJU&e= 
> 
> The filename of the patch is:
>     drm-mgag200-flag-all-g200-se-a-machines-as-broken-wrt-startadd.patch
> and it can be found in the queue-5.4 subdirectory.
> 
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable@vger.kernel.org> know about it.
> 
> 
> From 4adf0b49eea926a55fd956ef7d86750f771435ff Mon Sep 17 00:00:00 2001
> From: Thomas Zimmermann <tzimmermann@suse.de>
> Date: Fri, 6 Dec 2019 09:19:01 +0100
> Subject: drm/mgag200: Flag all G200 SE A machines as broken wrt <startadd>
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> From: Thomas Zimmermann <tzimmermann@suse.de>
> 
> commit 4adf0b49eea926a55fd956ef7d86750f771435ff upstream.
> 
> Several MGA G200 SE machines don't respect the value of the startadd
> register field. After more feedback on affected machines, neither PCI
> subvendor ID nor the internal ID seem to hint towards the bug. All
> affected machines have a PCI ID of 0x0522 (i.e., G200 SE A). It was
> decided to flag all G200 SE A machines as broken.
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Acked-by: Gerd Hoffmann <kraxel@redhat.com>
> Fixes: 1591fadf857c ("drm/mgag200: Add workaround for HW that does not support 'startadd'")
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: John Donnelly <john.p.donnelly@oracle.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Dave Airlie <airlied@redhat.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: "Y.C. Chen" <yc_chen@aspeedtech.com>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: "José Roberto de Souza" <jose.souza@intel.com>
> Cc: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: <stable@vger.kernel.org> # v5.3+
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Allison Randal <allison@lohutok.net>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Noralf Trønnes" <noralf@tronnes.org>
> Link: https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.freedesktop.org_patch_msgid_20191206081901.9938-2D1-2Dtzimmermann-40suse.de&d=DwIDaQ&c=RoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE&r=t2fPg9D87F7D8jm0_3CG9yoiIKdRg4qc_thBw4bzMhc&m=Nb5EnzCYEqUCU43_FPM930DrN6A-OrVBoIvQhl3A6xo&s=hkr0WOmd31sveBOYMZnLk8Sb2ujD-JxnYwjeSLBw9cA&e= 
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> ---
> drivers/gpu/drm/mgag200/mgag200_drv.c |    3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
> 
> --- a/drivers/gpu/drm/mgag200/mgag200_drv.c
> +++ b/drivers/gpu/drm/mgag200/mgag200_drv.c
> @@ -30,9 +30,8 @@ module_param_named(modeset, mgag200_mode
> static struct drm_driver driver;
> 
> static const struct pci_device_id pciidlist[] = {
> -	{ PCI_VENDOR_ID_MATROX, 0x522, PCI_VENDOR_ID_SUN, 0x4852, 0, 0,
> +	{ PCI_VENDOR_ID_MATROX, 0x522, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
> 		G200_SE_A | MGAG200_FLAG_HW_BUG_NO_STARTADD},
> -	{ PCI_VENDOR_ID_MATROX, 0x522, PCI_ANY_ID, PCI_ANY_ID, 0, 0, G200_SE_A },
> 	{ PCI_VENDOR_ID_MATROX, 0x524, PCI_ANY_ID, PCI_ANY_ID, 0, 0, G200_SE_B },
> 	{ PCI_VENDOR_ID_MATROX, 0x530, PCI_ANY_ID, PCI_ANY_ID, 0, 0, G200_EV },
> 	{ PCI_VENDOR_ID_MATROX, 0x532, PCI_ANY_ID, PCI_ANY_ID, 0, 0, G200_WB },
> 
> 
> Patches currently in stable-queue which might be from tzimmermann@suse.de are
> 
> queue-5.4/drm-mgag200-flag-all-g200-se-a-machines-as-broken-wrt-startadd.patch
> queue-5.4/drm-mgag200-store-flags-from-pci-driver-data-in-device-structure.patch
> queue-5.4/drm-mgag200-add-workaround-for-hw-that-does-not-support-startadd.patch
> queue-5.4/drm-mgag200-extract-device-type-from-flags.patch

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re:  IGNORE  --  Patch "drm/mgag200: Flag all G200 SE A machines as broken wrt <startadd>" has been added to the 5.4-stable tree
  2019-12-19 18:24 ` BAD -- " John Donnelly
@ 2019-12-19 20:17   ` John Donnelly
  0 siblings, 0 replies; 3+ messages in thread
From: John Donnelly @ 2019-12-19 20:17 UTC (permalink / raw)
  To: gregkh
  Cc: narmstrong, airlied, daniel.vetter, dri-devel, andrzej.p,
	20191206081901.9938-1-tzimmermann, jose.souza, tzimmermann,
	stable-commits, alexander.deucher, airlied, tglx, sam, allison,
	kraxel

I discovered I was missing a commit  when I merged . 


This series is fine .



> On Dec 19, 2019, at 12:24 PM, John Donnelly <john.p.donnelly@oracle.com> wrote:
> 
> Hi 
> 
> I am having difficulties with this patch on : 5.4.2  variant ;  The system is not booting with these patches applied. 
> 
> I had verified a prototype of the patch on 5.4.0-rc8 ;    
> 
> I am currently debugging it ,  but I will be OoO until 1/6/2020 after today .
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
>> On Dec 19, 2019, at 5:37 AM, gregkh@linuxfoundation.org wrote:
>> 
>> 
>> This is a note to let you know that I've just added the patch titled
>> 
>>   drm/mgag200: Flag all G200 SE A machines as broken wrt <startadd>
>> 
>> to the 5.4-stable tree which can be found at:
>>   https://urldefense.proofpoint.com/v2/url?u=http-3A__www.kernel.org_git_-3Fp-3Dlinux_kernel_git_stable_stable-2Dqueue.git-3Ba-3Dsummary&d=DwIDaQ&c=RoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE&r=t2fPg9D87F7D8jm0_3CG9yoiIKdRg4qc_thBw4bzMhc&m=Nb5EnzCYEqUCU43_FPM930DrN6A-OrVBoIvQhl3A6xo&s=mqHE1ETbyuc9Qg_WHNUzDRBGo073QFCYwTAxpxXEQJU&e= 
>> 
>> The filename of the patch is:
>>    drm-mgag200-flag-all-g200-se-a-machines-as-broken-wrt-startadd.patch
>> and it can be found in the queue-5.4 subdirectory.
>> 
>> If you, or anyone else, feels it should not be added to the stable tree,
>> please let <stable@vger.kernel.org> know about it.
>> 
>> 
>> From 4adf0b49eea926a55fd956ef7d86750f771435ff Mon Sep 17 00:00:00 2001
>> From: Thomas Zimmermann <tzimmermann@suse.de>
>> Date: Fri, 6 Dec 2019 09:19:01 +0100
>> Subject: drm/mgag200: Flag all G200 SE A machines as broken wrt <startadd>
>> MIME-Version: 1.0
>> Content-Type: text/plain; charset=UTF-8
>> Content-Transfer-Encoding: 8bit
>> 
>> From: Thomas Zimmermann <tzimmermann@suse.de>
>> 
>> commit 4adf0b49eea926a55fd956ef7d86750f771435ff upstream.
>> 
>> Several MGA G200 SE machines don't respect the value of the startadd
>> register field. After more feedback on affected machines, neither PCI
>> subvendor ID nor the internal ID seem to hint towards the bug. All
>> affected machines have a PCI ID of 0x0522 (i.e., G200 SE A). It was
>> decided to flag all G200 SE A machines as broken.
>> 
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> Acked-by: Gerd Hoffmann <kraxel@redhat.com>
>> Fixes: 1591fadf857c ("drm/mgag200: Add workaround for HW that does not support 'startadd'")
>> Cc: Thomas Zimmermann <tzimmermann@suse.de>
>> Cc: John Donnelly <john.p.donnelly@oracle.com>
>> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
>> Cc: Gerd Hoffmann <kraxel@redhat.com>
>> Cc: Dave Airlie <airlied@redhat.com>
>> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> Cc: Maxime Ripard <mripard@kernel.org>
>> Cc: David Airlie <airlied@linux.ie>
>> Cc: Sam Ravnborg <sam@ravnborg.org>
>> Cc: "Y.C. Chen" <yc_chen@aspeedtech.com>
>> Cc: Neil Armstrong <narmstrong@baylibre.com>
>> Cc: Thomas Gleixner <tglx@linutronix.de>
>> Cc: "José Roberto de Souza" <jose.souza@intel.com>
>> Cc: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
>> Cc: dri-devel@lists.freedesktop.org
>> Cc: <stable@vger.kernel.org> # v5.3+
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Cc: Allison Randal <allison@lohutok.net>
>> Cc: Alex Deucher <alexander.deucher@amd.com>
>> Cc: "Noralf Trønnes" <noralf@tronnes.org>
>> Link: https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.freedesktop.org_patch_msgid_20191206081901.9938-2D1-2Dtzimmermann-40suse.de&d=DwIDaQ&c=RoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE&r=t2fPg9D87F7D8jm0_3CG9yoiIKdRg4qc_thBw4bzMhc&m=Nb5EnzCYEqUCU43_FPM930DrN6A-OrVBoIvQhl3A6xo&s=hkr0WOmd31sveBOYMZnLk8Sb2ujD-JxnYwjeSLBw9cA&e= 
>> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> 
>> ---
>> drivers/gpu/drm/mgag200/mgag200_drv.c |    3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>> 
>> --- a/drivers/gpu/drm/mgag200/mgag200_drv.c
>> +++ b/drivers/gpu/drm/mgag200/mgag200_drv.c
>> @@ -30,9 +30,8 @@ module_param_named(modeset, mgag200_mode
>> static struct drm_driver driver;
>> 
>> static const struct pci_device_id pciidlist[] = {
>> -	{ PCI_VENDOR_ID_MATROX, 0x522, PCI_VENDOR_ID_SUN, 0x4852, 0, 0,
>> +	{ PCI_VENDOR_ID_MATROX, 0x522, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
>> 		G200_SE_A | MGAG200_FLAG_HW_BUG_NO_STARTADD},
>> -	{ PCI_VENDOR_ID_MATROX, 0x522, PCI_ANY_ID, PCI_ANY_ID, 0, 0, G200_SE_A },
>> 	{ PCI_VENDOR_ID_MATROX, 0x524, PCI_ANY_ID, PCI_ANY_ID, 0, 0, G200_SE_B },
>> 	{ PCI_VENDOR_ID_MATROX, 0x530, PCI_ANY_ID, PCI_ANY_ID, 0, 0, G200_EV },
>> 	{ PCI_VENDOR_ID_MATROX, 0x532, PCI_ANY_ID, PCI_ANY_ID, 0, 0, G200_WB },
>> 
>> 
>> Patches currently in stable-queue which might be from tzimmermann@suse.de are
>> 
>> queue-5.4/drm-mgag200-flag-all-g200-se-a-machines-as-broken-wrt-startadd.patch
>> queue-5.4/drm-mgag200-store-flags-from-pci-driver-data-in-device-structure.patch
>> queue-5.4/drm-mgag200-add-workaround-for-hw-that-does-not-support-startadd.patch
>> queue-5.4/drm-mgag200-extract-device-type-from-flags.patch
> 

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-12-23  8:12 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-19 11:37 Patch "drm/mgag200: Flag all G200 SE A machines as broken wrt <startadd>" has been added to the 5.4-stable tree gregkh
2019-12-19 18:24 ` BAD -- " John Donnelly
2019-12-19 20:17   ` IGNORE " John Donnelly

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.