From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Wu, Jingjing" Subject: Re: [PATCH v2 04/17] net/i40e: restore ethertype filter Date: Wed, 28 Dec 2016 02:25:16 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F810CC0063@SHSMSX103.ccr.corp.intel.com> References: <1480679625-4157-1-git-send-email-beilei.xing@intel.com> <1482819984-14120-1-git-send-email-beilei.xing@intel.com> <1482819984-14120-5-git-send-email-beilei.xing@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" To: "Xing, Beilei" , "Zhang, Helin" Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 64961376C for ; Wed, 28 Dec 2016 03:25:20 +0100 (CET) In-Reply-To: <1482819984-14120-5-git-send-email-beilei.xing@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Xing, Beilei > Sent: Tuesday, December 27, 2016 2:26 PM > To: Wu, Jingjing ; Zhang, Helin > Cc: dev@dpdk.org > Subject: [PATCH v2 04/17] net/i40e: restore ethertype filter >=20 > Add support of restoring ethertype filter in case filter dropped accident= ally, as all > filters need to be added and removed by user obviously for generic filter= API. >=20 > Signed-off-by: Beilei Xing > --- > drivers/net/i40e/i40e_ethdev.c | 39 > +++++++++++++++++++++++++++++++++++++++ > 1 file changed, 39 insertions(+) >=20 > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethde= v.c > index 427ebdc..cd7c309 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -484,6 +484,9 @@ static int i40e_sw_tunnel_filter_insert(struct i40e_p= f *pf, > static int i40e_sw_tunnel_filter_del(struct i40e_pf *pf, > struct i40e_tunnel_filter *tunnel_filter); >=20 > +static void i40e_ethertype_filter_restore(struct i40e_pf *pf); static > +void i40e_filter_restore(struct i40e_pf *pf); > + > static const struct rte_pci_id pci_id_i40e_map[] =3D { > { RTE_PCI_DEVICE(I40E_INTEL_VENDOR_ID, I40E_DEV_ID_SFP_XL710) }, > { RTE_PCI_DEVICE(I40E_INTEL_VENDOR_ID, I40E_DEV_ID_QEMU) }, > @@ -1964,6 +1967,8 @@ i40e_dev_start(struct rte_eth_dev *dev) > /* enable uio intr after callback register */ > rte_intr_enable(intr_handle); >=20 > + i40e_filter_restore(pf); > + > return I40E_SUCCESS; >=20 > err_up: > @@ -10066,3 +10071,37 @@ i40e_dev_mtu_set(struct rte_eth_dev *dev, > uint16_t mtu) >=20 > return ret; > } > + > +/* Restore ethertype filter */ > +static void > +i40e_ethertype_filter_restore(struct i40e_pf *pf) { > + struct i40e_hw *hw =3D I40E_PF_TO_HW(pf); > + struct i40e_ethertype_filter_list > + *ethertype_list =3D &pf->ethertype.ethertype_list; > + struct i40e_ethertype_filter *f; > + struct i40e_control_filter_stats stats; > + uint16_t flags; > + > + TAILQ_FOREACH(f, ethertype_list, rules) { > + flags =3D 0; > + if (!(f->flags & RTE_ETHTYPE_FLAGS_MAC)) > + flags |=3D > I40E_AQC_ADD_CONTROL_PACKET_FLAGS_IGNORE_MAC; > + if (f->flags & RTE_ETHTYPE_FLAGS_DROP) > + flags |=3D > I40E_AQC_ADD_CONTROL_PACKET_FLAGS_DROP; > + flags |=3D I40E_AQC_ADD_CONTROL_PACKET_FLAGS_TO_QUEUE; > + > + memset(&stats, 0, sizeof(stats)); > + i40e_aq_add_rem_control_packet_filter(hw, > + f->input.mac_addr.addr_bytes, > + f->input.ether_type, > + flags, pf->main_vsi->seid, > + f->queue, 1, &stats, NULL); > + } How about to lig the stats to show how many filters are restored? Thanks Jingjing