From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Wu, Jingjing" <jingjing.wu@intel.com>
Subject: Re: [PATCH v3 1/4] ethdev: add firmware information get
Date: Wed, 4 Jan 2017 07:48:39 +0000
Message-ID: <9BB6961774997848B5B42BEC655768F810CC2AF1@SHSMSX103.ccr.corp.intel.com>
References: <1481008582-69416-1-git-send-email-qiming.yang@intel.com>
 <20053497.vNKJpYf1IB@xps13>
 <F5DF4F0E3AFEF648ADC1C3C33AD4DBF16EDC9515@SHSMSX101.ccr.corp.intel.com>
 <10603884.vrshqR2O82@xps13>
 <F5DF4F0E3AFEF648ADC1C3C33AD4DBF16EDC973C@SHSMSX101.ccr.corp.intel.com>
 <dd3cff72-0433-bfee-4dfa-9662025e5bee@intel.com>
 <F5DF4F0E3AFEF648ADC1C3C33AD4DBF16EDC998C@SHSMSX101.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Horton, Remy" <remy.horton@intel.com>,
 Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Yang, Qiming" <qiming.yang@intel.com>, "Yigit, Ferruh"
 <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id D75A3F63E
 for <dev@dpdk.org>; Wed,  4 Jan 2017 08:48:42 +0100 (CET)
In-Reply-To: <F5DF4F0E3AFEF648ADC1C3C33AD4DBF16EDC998C@SHSMSX101.ccr.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yang, Qiming
> Sent: Wednesday, January 4, 2017 11:33 AM
> To: Yigit, Ferruh <ferruh.yigit@intel.com>
> Cc: dev@dpdk.org; Horton, Remy <remy.horton@intel.com>; Thomas Monjalon
> <thomas.monjalon@6wind.com>
> Subject: Re: [dpdk-dev] [PATCH v3 1/4] ethdev: add firmware information g=
et
>=20
> Yes, in my opinion it is. And I use this name already exist in the share =
code from
> ND team.
>=20
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Tuesday, January 3, 2017 10:49 PM
> To: Yang, Qiming <qiming.yang@intel.com>
> Cc: dev@dpdk.org; Horton, Remy <remy.horton@intel.com>; Thomas Monjalon
> <thomas.monjalon@6wind.com>
> Subject: Re: [PATCH v3 1/4] ethdev: add firmware information get
>=20
> On 1/3/2017 9:05 AM, Yang, Qiming wrote:
> > Hi, Ferruh
> > Please see the question below. In my opinion, etrack_id is just a name =
used to
> define the ID of one NIC.
> > In kernel version ethtool, it will print this ID in the line of firmwar=
e verison.
> > I know what is etrack_id mean, but I really don't know why this named
> etrack_id.
>=20
> Hi Qiming,
>=20
> I suggested the API based on fields you already used in your patch.
>=20
> So, this API is to get FW version, is etrack_id something that defines (p=
art of)
> firmware version?
>=20
> Thanks,
> ferruh
>=20
>=20
Different HW may have different version format, so it is better to use stri=
ng.

And I prefer the API definition in your v2 patch like

rte_eth_dev_fwver_get(uint8_t port_id, char *fw_version, int fw_length);

Thanks
Jingjing