Re: [dpdk-dev v2 2/3] app: enable HW CRC strip by default

["Wu, Jingjing" <jingjing.wu@intel.com>]

> -----Original Message-----
> From: Guo, Jia
> Sent: Monday, March 20, 2017 5:58 PM
> To: Zhang, Helin <helin.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>
> Cc: dev@dpdk.org; Guo, Jia <jia.guo@intel.com>; stable@dpdk.org
> Subject: [dpdk-dev v2 2/3] app: enable HW CRC strip by default
> 
> Since VF has no ability to disable/enable HW CRC strip for non-DPDK PF drivers,
> and for most case of kernel driver default enable HW CRC strip, if disable HW
> CRC strip in app's rxmode, VF driver will return fail and result the VF launch
> failure. So this patch default to enable HW CRC strip to let VF launch successful.
> 
> Signed-off-by: Jeff Guo <jia.guo@intel.com>
> Cc: stable@dpdk.org
> ---
>  app/test-pmd/testpmd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index
> e04e215..f01522c 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -284,7 +284,7 @@ struct rte_eth_rxmode rx_mode = {
>  	.hw_vlan_strip  = 1, /**< VLAN strip enabled. */
>  	.hw_vlan_extend = 0, /**< Extended VLAN disabled. */
>  	.jumbo_frame    = 0, /**< Jumbo Frame Support disabled. */
> -	.hw_strip_crc   = 0, /**< CRC stripping by hardware disabled. */
> +	.hw_strip_crc   = 1, /**< CRC stripping by hardware disabled. */
>  };
> 
You change the default hw_strip_crc to 1, then the argument "crc-strip" of
testpmd becomes meaningless.
It's better to change it too.