From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Wu, Jingjing" <jingjing.wu@intel.com>
Subject: Re: [dpdk-dev v2 2/3] app: enable HW CRC strip by default
Date: Wed, 22 Mar 2017 12:24:53 +0000
Message-ID: <9BB6961774997848B5B42BEC655768F810CF9869@SHSMSX103.ccr.corp.intel.com>
References: <1490003874-37766-1-git-send-email-jia.guo@intel.com>
 <1490003874-37766-2-git-send-email-jia.guo@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
To: "Guo, Jia" <jia.guo@intel.com>, "Zhang, Helin" <helin.zhang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



> -----Original Message-----
> From: Wu, Jingjing
> Sent: Wednesday, March 22, 2017 8:22 PM
> To: Guo, Jia <jia.guo@intel.com>; Zhang, Helin <helin.zhang@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: RE: [dpdk-dev v2 2/3] app: enable HW CRC strip by default
>=20
>=20
>=20
> > -----Original Message-----
> > From: Guo, Jia
> > Sent: Monday, March 20, 2017 5:58 PM
> > To: Zhang, Helin <helin.zhang@intel.com>; Wu, Jingjing
> > <jingjing.wu@intel.com>
> > Cc: dev@dpdk.org; Guo, Jia <jia.guo@intel.com>; stable@dpdk.org
> > Subject: [dpdk-dev v2 2/3] app: enable HW CRC strip by default
> >
> > Since VF has no ability to disable/enable HW CRC strip for non-DPDK PF
> > drivers, and for most case of kernel driver default enable HW CRC
> > strip, if disable HW CRC strip in app's rxmode, VF driver will return
> > fail and result the VF launch failure. So this patch default to enable =
HW CRC
> strip to let VF launch successful.
> >
> > Signed-off-by: Jeff Guo <jia.guo@intel.com>
> > Cc: stable@dpdk.org
> > ---
> >  app/test-pmd/testpmd.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index
> > e04e215..f01522c 100644
> > --- a/app/test-pmd/testpmd.c
> > +++ b/app/test-pmd/testpmd.c
> > @@ -284,7 +284,7 @@ struct rte_eth_rxmode rx_mode =3D {
> >  	.hw_vlan_strip  =3D 1, /**< VLAN strip enabled. */
> >  	.hw_vlan_extend =3D 0, /**< Extended VLAN disabled. */
> >  	.jumbo_frame    =3D 0, /**< Jumbo Frame Support disabled. */
> > -	.hw_strip_crc   =3D 0, /**< CRC stripping by hardware disabled. */
> > +	.hw_strip_crc   =3D 1, /**< CRC stripping by hardware disabled. */
> >  };
> >
> You change the default hw_strip_crc to 1, then the argument "crc-strip" o=
f
> testpmd becomes meaningless.
> It's better to change it too.

And the comment should be changed to enabled!