From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Wu, Jingjing" <jingjing.wu@intel.com>
Subject: Re: [dpdk-dev v2 3/3] test: enable HW CRC strip by
	default
Date: Wed, 22 Mar 2017 12:26:47 +0000
Message-ID: <9BB6961774997848B5B42BEC655768F810CF987F@SHSMSX103.ccr.corp.intel.com>
References: <1490003874-37766-1-git-send-email-jia.guo@intel.com>
 <1490003874-37766-3-git-send-email-jia.guo@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
To: "Guo, Jia" <jia.guo@intel.com>, "Zhang, Helin" <helin.zhang@intel.com>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <1490003874-37766-3-git-send-email-jia.guo@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



> -----Original Message-----
> From: Guo, Jia
> Sent: Monday, March 20, 2017 5:58 PM
> To: Zhang, Helin <helin.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel=
.com>
> Cc: dev@dpdk.org; Guo, Jia <jia.guo@intel.com>; stable@dpdk.org
> Subject: [dpdk-dev v2 3/3] test: enable HW CRC strip by default
>=20
> Since VF has no ability to disable/enable HW CRC strip for non-DPDK PF dr=
ivers,
> and for most case of kernel driver default enable HW CRC strip, if disabl=
e HW
> CRC strip in test app's rxmode, VF driver will return fail and result the=
 VF launch
> failure. So this patch default to enable HW CRC strip to let VF launch su=
ccessful.
>=20
> Signed-off-by: Jeff Guo <jia.guo@intel.com>
> Cc: stable@dpdk.org
> ---
>  test/test-pipeline/init.c             | 2 +-
>  test/test/test_kni.c                  | 2 +-
>  test/test/test_link_bonding.c         | 4 ++--
>  test/test/test_link_bonding_mode4.c   | 2 +-
>  test/test/test_link_bonding_rssconf.c | 4 ++--
>  test/test/test_pmd_perf.c             | 2 +-
>  6 files changed, 8 insertions(+), 8 deletions(-)
>=20
> diff --git a/test/test-pipeline/init.c b/test/test-pipeline/init.c index
> aef082f..00dbc27 100644
> --- a/test/test-pipeline/init.c
> +++ b/test/test-pipeline/init.c
> @@ -105,7 +105,7 @@ static struct rte_eth_conf port_conf =3D {
>  		.hw_ip_checksum =3D 1, /* IP checksum offload enabled */
>  		.hw_vlan_filter =3D 0, /* VLAN filtering disabled */
>  		.jumbo_frame    =3D 0, /* Jumbo Frame Support disabled */
> -		.hw_strip_crc   =3D 0, /* CRC stripped by hardware */
> +		.hw_strip_crc   =3D 1, /* CRC stripped by hardware */
>  	},
>  	.rx_adv_conf =3D {
>  		.rss_conf =3D {
> diff --git a/test/test/test_kni.c b/test/test/test_kni.c index 309741c..d=
b17fdf
> 100644
> --- a/test/test/test_kni.c
> +++ b/test/test/test_kni.c
> @@ -92,7 +92,7 @@ static const struct rte_eth_conf port_conf =3D {
>  		.hw_ip_checksum =3D 0,
>  		.hw_vlan_filter =3D 0,
>  		.jumbo_frame =3D 0,
> -		.hw_strip_crc =3D 0,
> +		.hw_strip_crc =3D 1,
>  	},
>  	.txmode =3D {
>  		.mq_mode =3D ETH_DCB_NONE,
> diff --git a/test/test/test_link_bonding.c b/test/test/test_link_bonding.=
c index
> 3229660..3a1194c 100644
> --- a/test/test/test_link_bonding.c
> +++ b/test/test/test_link_bonding.c
> @@ -172,7 +172,7 @@ struct rte_eth_rxmode rx_mode =3D {
>  	.hw_vlan_strip  =3D 1, /**< VLAN strip enabled. */
>  	.hw_vlan_extend =3D 0, /**< Extended VLAN disabled. */
>  	.jumbo_frame    =3D 0, /**< Jumbo Frame Support disabled. */
> -	.hw_strip_crc   =3D 0, /**< CRC stripping by hardware disabled. */
> +	.hw_strip_crc   =3D 1, /**< CRC stripping by hardware disabled. */
>  };
Comment "/**< CRC stripping by hardware disabled. */" need to be
Changed too.