From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Wu, Jingjing" <jingjing.wu@intel.com>
Subject: Re: [PATCH v4 4/4] app/testpmd: add isolated mode
 parameter
Date: Thu, 29 Jun 2017 05:52:13 +0000
Message-ID: <9BB6961774997848B5B42BEC655768F810DB5D34@SHSMSX103.ccr.corp.intel.com>
References: <0dca86aa1372d6ff09d0aff01d522c580e0e24ab.1495717153.git.vasilyf@mellanox.com>
 <AM4PR0501MB26896736C1579D254960D25FDBDA0@AM4PR0501MB2689.eurprd05.prod.outlook.com>
 <9BB6961774997848B5B42BEC655768F810DAC7A8@SHSMSX103.ccr.corp.intel.com>
 <3515786.3Gc2XbLCYg@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>, Vasily Philipov <vasilyf@mellanox.com>,
 Adrien Mazarguil <adrien.mazarguil@6wind.com>,
 =?iso-8859-1?Q?N=E9lio_Laranjeiro?= <nelio.laranjeiro@6wind.com>
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 07CF92BE1
 for <dev@dpdk.org>; Thu, 29 Jun 2017 07:52:27 +0200 (CEST)
In-Reply-To: <3515786.3Gc2XbLCYg@xps>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> > > > Should it block the app startup if isolated-mode setting fails?
> > >
> > > if isolated mode cannot be enabled on any port, that port cannot be
> > > initialized and that causes testpmd to quit, at least it won't go
> > > against the user's wishes
> >
> > If so, I prefer the isolated_mode to be port's argument but not global =
one.
> > How about to add a command to configure the isolate mode?
>=20
> There is already a command to configure isolate mode per-port:
> 	http://dpdk.org/patch/25320
> 	http://dpdk.org/doc/guides/testpmd_app_ug/testpmd_funcs.html#flow
> -syntax
>=20
> I think it does not make sense to replicate this per-port command in comm=
and
> line parameters.
> All the other parameters are global:
> 	http://dpdk.org/doc/guides/testpmd_app_ug/run_app.html#testpmd-
> command-line-options
> The idea here is to have a global isolate mode with a general option.

OK. Thanks
Then I'm fine with it.