From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Wu, Jingjing" <jingjing.wu@intel.com>
Subject: Re: [PATCH v7 2/2] app/testpmd: add API for
 configuration of	queue region
Date: Fri, 29 Sep 2017 14:29:21 +0000
Message-ID: <9BB6961774997848B5B42BEC655768F810E83FFC@SHSMSX103.ccr.corp.intel.com>
References: <1506672718-39160-1-git-send-email-wei.zhao1@intel.com>
 <1506676584-41030-1-git-send-email-wei.zhao1@intel.com>
 <1506676584-41030-3-git-send-email-wei.zhao1@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "Zhao1, Wei" <wei.zhao1@intel.com>
To: "Zhao1, Wei" <wei.zhao1@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id CCDFD101B
 for <dev@dpdk.org>; Fri, 29 Sep 2017 16:29:24 +0200 (CEST)
In-Reply-To: <1506676584-41030-3-git-send-email-wei.zhao1@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> +static void
> +cmd_queue_region_parsed(void *parsed_result,
> +			__attribute__((unused)) struct cmdline *cl,
> +			__attribute__((unused)) void *data)
> +{
> +	struct cmd_queue_region_result *res =3D parsed_result;
> +	int ret =3D 0;
> +#ifdef RTE_LIBRTE_I40E_PMD
> +	struct rte_i40e_rss_region_conf region_conf;
> +
> +	memset(&region_conf, 0, sizeof(region_conf));
> +	region_conf.op =3D RTE_PMD_I40E_QUEUE_REGION_SET;
> +	region_conf.region_id =3D res->region_id;
> +	region_conf.queue_num =3D res->queue_num_value;
> +	region_conf.queue_start_index =3D res->queue_id;
> +
> +	ret =3D rte_pmd_i40e_rss_queue_region_conf(res->port_id, &region_conf);
> +#endif
> +
> +	if (ret < 0)
> +		printf("queue region config programming error: (%s)\n",
> +				strerror(-ret));
> +}

If the RTE_LIBRTE_I40E_PMD is not built. The printf info would be incorrect=
.
And you need to check it the port id is valid or not.

Please check all new functions in this patch.

Thanks
Jingjing